ivandasch commented on a change in pull request #9196:
URL: https://github.com/apache/kafka/pull/9196#discussion_r475195929
##########
File path: tests/kafkatest/services/verifiable_consumer.py
##########
@@ -386,33 +386,33 @@ def last_commit(self, tp):
def total_consumed(self):
with self.lock:
- return sum(handler.total_consumed for handler in
self.event_handlers.itervalues())
+ return sum(handler.total_consumed for handler in
self.event_handlers.values())
def num_rebalances(self):
with self.lock:
- return max(handler.assigned_count for handler in
self.event_handlers.itervalues())
+ return max(handler.assigned_count for handler in
self.event_handlers.values())
def num_revokes_for_alive(self, keep_alive=1):
with self.lock:
- return max([handler.revoked_count for handler in
self.event_handlers.itervalues()
+ return max([handler.revoked_count for handler in
self.event_handlers.values()
Review comment:
Please, remove list creation here also
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
