[GitHub] [kafka] vvcephei commented on pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

vvcephei commented on pull request #9098: URL: https://github.com/apache/kafka/pull/9098#issuecomment-673090128 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

vvcephei commented on pull request #9098: URL: https://github.com/apache/kafka/pull/9098#issuecomment-673090192 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] guozhangwang commented on pull request #9170: KAFKA-10391: Overwrite checkpoint in task corruption to remove corrupted partitions

guozhangwang commented on pull request #9170: URL: https://github.com/apache/kafka/pull/9170#issuecomment-673090664 > Do you have any theories as to why this was causing `StreamsUpgradeTest.test_app_upgrade` to be flaky? Do we really get that many TaskCorruptedExceptions in this system tes

[GitHub] [kafka] guozhangwang commented on a change in pull request #9170: KAFKA-10391: Overwrite checkpoint in task corruption to remove corrupted partitions

guozhangwang commented on a change in pull request #9170: URL: https://github.com/apache/kafka/pull/9170#discussion_r469517595 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -193,13 +193,17 @@ private void closeAndRevive

[GitHub] [kafka] guozhangwang commented on a change in pull request #9170: KAFKA-10391: Overwrite checkpoint in task corruption to remove corrupted partitions

guozhangwang commented on a change in pull request #9170: URL: https://github.com/apache/kafka/pull/9170#discussion_r469518409 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -58,6 +58,9 @@ static boolean checkpointN

[GitHub] [kafka] vvcephei removed a comment on pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

vvcephei removed a comment on pull request #9098: URL: https://github.com/apache/kafka/pull/9098#issuecomment-673100824 @cadonna : ``` > Task :streams:checkstyleMain [ant:checkstyle] [ERROR] /home/confluent/kafka/streams/src/generated/java/org/apache/kafka/streams/InteractiveQ

[GitHub] [kafka] vvcephei commented on pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

vvcephei commented on pull request #9098: URL: https://github.com/apache/kafka/pull/9098#issuecomment-673100824 @cadonna : ``` > Task :streams:checkstyleMain [ant:checkstyle] [ERROR] /home/confluent/kafka/streams/src/generated/java/org/apache/kafka/streams/InteractiveQueryPart

[GitHub] [kafka] d8tltanc commented on a change in pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

d8tltanc commented on a change in pull request #8846: URL: https://github.com/apache/kafka/pull/8846#discussion_r468736687 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -721,6 +730,11 @@ protected Node curNode() { r

[GitHub] [kafka] d8tltanc commented on pull request #8846: KAFKA-9800: [KIP-580] Client Exponential Backoff Implementation

d8tltanc commented on pull request #8846: URL: https://github.com/apache/kafka/pull/8846#issuecomment-673114249 @abbccdda Thanks for the review offers! I'll rebase this PR. This is an automated message from the Apache Git Ser

[GitHub] [kafka] rhauch commented on a change in pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

rhauch commented on a change in pull request #9172: URL: https://github.com/apache/kafka/pull/9172#discussion_r469574130 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/TransformationIntegrationTest.java ## @@ -318,4 +323,61 @@ public void test

[GitHub] [kafka] kkonstantine commented on pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

kkonstantine commented on pull request #9172: URL: https://github.com/apache/kafka/pull/9172#issuecomment-673136551 According to https://status.apache.org the jenkins queue has grown too much and the infra team is investigating how to resolve the issues. Thus, the tests haven't run yet.

[GitHub] [kafka] kkonstantine commented on a change in pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

kkonstantine commented on a change in pull request #9172: URL: https://github.com/apache/kafka/pull/9172#discussion_r469577371 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/SourceConnectorConfig.java ## @@ -129,7 +129,8 @@ public SourceConnectorC

[GitHub] [kafka] kkonstantine commented on a change in pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

kkonstantine commented on a change in pull request #9172: URL: https://github.com/apache/kafka/pull/9172#discussion_r469578195 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/TransformationIntegrationTest.java ## @@ -318,4 +323,61 @@ public voi

[GitHub] [kafka] ableegoldman commented on a change in pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

ableegoldman commented on a change in pull request #9094: URL: https://github.com/apache/kafka/pull/9094#discussion_r469582284 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/ProcessorNodeMetrics.java ## @@ -289,6 +294,25 @@ public stat

[GitHub] [kafka] ableegoldman commented on a change in pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

ableegoldman commented on a change in pull request #9094: URL: https://github.com/apache/kafka/pull/9094#discussion_r469582284 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/ProcessorNodeMetrics.java ## @@ -289,6 +294,25 @@ public stat

[GitHub] [kafka] ableegoldman commented on pull request #9173: KAFKA-10122: Consumer should allow heartbeat during rebalance

ableegoldman commented on pull request #9173: URL: https://github.com/apache/kafka/pull/9173#issuecomment-673143739 Closing this since I didn't see the existing PR for this bugfix: https://github.com/apache/kafka/pull/8834 T

[GitHub] [kafka] ableegoldman closed pull request #9173: KAFKA-10122: Consumer should allow heartbeat during rebalance

ableegoldman closed pull request #9173: URL: https://github.com/apache/kafka/pull/9173 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rajinisivaram commented on pull request #9168: MINOR: Ensure same version of scala library is used for compile and at runtime

rajinisivaram commented on pull request #9168: URL: https://github.com/apache/kafka/pull/9168#issuecomment-673144455 @ijuma Thanks for the review, streams test failures not related. Merging to trunk, 2.6, 2,5 and 2.4. This i

[GitHub] [kafka] rajinisivaram merged pull request #9168: MINOR: Ensure same version of scala library is used for compile and at runtime

rajinisivaram merged pull request #9168: URL: https://github.com/apache/kafka/pull/9168 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rhauch commented on a change in pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

rhauch commented on a change in pull request #9172: URL: https://github.com/apache/kafka/pull/9172#discussion_r469586764 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/TransformationIntegrationTest.java ## @@ -318,4 +323,61 @@ public void test

[GitHub] [kafka] svudutala commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

svudutala commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-673145549 @dongjinleekr What is timeline for merging this PR and making this upgrade available? This is an automated mes

[GitHub] [kafka] ableegoldman commented on a change in pull request #8834: MINOR: Do not disable heartbeat during Rebalance

ableegoldman commented on a change in pull request #8834: URL: https://github.com/apache/kafka/pull/8834#discussion_r469587219 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -528,7 +528,6 @@ public void onFailure(

[GitHub] [kafka] rhauch merged pull request #8854: KAFKA-10146, KAFKA-9066: Retain metrics for failed tasks (backport to 2.5)

rhauch merged pull request #8854: URL: https://github.com/apache/kafka/pull/8854 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ableegoldman commented on a change in pull request #8834: MINOR: Do not disable heartbeat during Rebalance

ableegoldman commented on a change in pull request #8834: URL: https://github.com/apache/kafka/pull/8834#discussion_r469593402 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -1069,6 +1069,13 @@ private HeartbeatRe

[GitHub] [kafka] bbejeck commented on a change in pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

bbejeck commented on a change in pull request #9108: URL: https://github.com/apache/kafka/pull/9108#discussion_r469593164 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java ## @@ -123,25 +117,18 @@ public static void

[GitHub] [kafka] bbejeck commented on a change in pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

bbejeck commented on a change in pull request #9108: URL: https://github.com/apache/kafka/pull/9108#discussion_r469593164 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java ## @@ -123,25 +117,18 @@ public static void

[GitHub] [kafka] badaiaqrandista commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

badaiaqrandista commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-673156754 @dajac Can you please re-review the changes I've made? This is an automated message from the Apache Git Se

[GitHub] [kafka] showuon commented on pull request #9104: KAFKA-10266: Update the connector config header.converter

showuon commented on pull request #9104: URL: https://github.com/apache/kafka/pull/9104#issuecomment-673173805 @kkonstantine , could you review this PR? Thanks. This is an automated message from the Apache Git Service. To res

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r469627624 ## File path: core/src/test/scala/unit/kafka/server/DescribeUserScramCredentialsRequestTest.scala ## @@ -0,0 +1,128 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r469637266 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/UserScramCredentialUpsertion.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apach

[GitHub] [kafka] ableegoldman opened a new pull request #9174: KAFKA-10395: relax output topic check in TTD to work with dynamic routing

ableegoldman opened a new pull request #9174: URL: https://github.com/apache/kafka/pull/9174 I went through all 5 stages of grief in thinking about what to do here and decided the best thing was to just relax the check after all. Hopefully users who find their output topic unexpectedly emp

[GitHub] [kafka] ableegoldman commented on pull request #9174: KAFKA-10395: relax output topic check in TTD to work with dynamic routing

ableegoldman commented on pull request #9174: URL: https://github.com/apache/kafka/pull/9174#issuecomment-673189749 @cadonna @guozhangwang This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] hachikuji commented on pull request #9163: KAFKA-10386; Fix flexible version support for `records` type

hachikuji commented on pull request #9163: URL: https://github.com/apache/kafka/pull/9163#issuecomment-673189746 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r469646777 ## File path: core/src/test/scala/unit/kafka/admin/UserScramCredentialsCommandTest.scala ## @@ -0,0 +1,127 @@ +/** + * Licensed to the Apache Software

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r469646777 ## File path: core/src/test/scala/unit/kafka/admin/UserScramCredentialsCommandTest.scala ## @@ -0,0 +1,127 @@ +/** + * Licensed to the Apache Software

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r469650293 ## File path: core/src/test/scala/unit/kafka/admin/UserScramCredentialsCommandTest.scala ## @@ -0,0 +1,127 @@ +/** + * Licensed to the Apache Software

[GitHub] [kafka] chia7712 commented on pull request #9162: MINOR: refactor Log to get rid of "return" in nested anonymous function

chia7712 commented on pull request #9162: URL: https://github.com/apache/kafka/pull/9162#issuecomment-673212958 ```org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest > shouldUpgradeFromEosAlphaToEosBeta[true]``` failed. I test it on my local and it pass. retest this please

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r469680702 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to the

[GitHub] [kafka] guozhangwang merged pull request #9170: KAFKA-10391: Overwrite checkpoint in task corruption to remove corrupted partitions

guozhangwang merged pull request #9170: URL: https://github.com/apache/kafka/pull/9170 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] RamanVerma commented on a change in pull request #9112: KAFKA-10312 Fix error code returned by getPartitionMetadata

RamanVerma commented on a change in pull request #9112: URL: https://github.com/apache/kafka/pull/9112#discussion_r469698016 ## File path: core/src/test/scala/unit/kafka/server/MetadataCacheTest.scala ## @@ -187,49 +191,24 @@ class MetadataCacheTest { new UpdateMetadataB

[GitHub] [kafka] albert02lowis commented on a change in pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

albert02lowis commented on a change in pull request #9108: URL: https://github.com/apache/kafka/pull/9108#discussion_r469704319 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java ## @@ -123,25 +117,18 @@ public static

[GitHub] [kafka] albert02lowis commented on a change in pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

albert02lowis commented on a change in pull request #9108: URL: https://github.com/apache/kafka/pull/9108#discussion_r469704319 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java ## @@ -123,25 +117,18 @@ public static

[GitHub] [kafka] albert02lowis commented on a change in pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

albert02lowis commented on a change in pull request #9108: URL: https://github.com/apache/kafka/pull/9108#discussion_r469707761 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AbstractJoinIntegrationTest.java ## @@ -123,25 +117,18 @@ public static

[GitHub] [kafka] abbccdda commented on a change in pull request #9174: KAFKA-10395: relax output topic check in TTD to work with dynamic routing

abbccdda commented on a change in pull request #9174: URL: https://github.com/apache/kafka/pull/9174#discussion_r469713175 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -805,10 +805,10 @@ public void advanceWallClockTime(

[GitHub] [kafka] JoelWee commented on a change in pull request #8923: KAFKA-6435: KIP-623 Add internal topics option to streamResetter

JoelWee commented on a change in pull request #8923: URL: https://github.com/apache/kafka/pull/8923#discussion_r469722613 ## File path: docs/streams/developer-guide/app-reset-tool.html ## @@ -77,6 +77,7 @@ Step 1: Run the application reset tool

[GitHub] [kafka] JoelWee commented on a change in pull request #8923: KAFKA-6435: KIP-623 Add internal topics option to streamResetter

JoelWee commented on a change in pull request #8923: URL: https://github.com/apache/kafka/pull/8923#discussion_r469725796 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -646,22 +655,68 @@ private boolean isIntermediateTopic(final String topic) {

[GitHub] [kafka] sebadiaz commented on pull request #9161: KAFKA-10385 - Remove no print stat when on detailed stat mode on Consumer Perf

sebadiaz commented on pull request #9161: URL: https://github.com/apache/kafka/pull/9161#issuecomment-673302155 @abbccdda update done This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-673305906 @svudutala > What is timeline for merging this PR and making this upgrade available? It is what exactly I hope to ask the PMC members and committers. It seems li

[GitHub] [kafka] cadonna commented on pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

cadonna commented on pull request #9098: URL: https://github.com/apache/kafka/pull/9098#issuecomment-673328944 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] cadonna commented on pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

cadonna commented on pull request #9098: URL: https://github.com/apache/kafka/pull/9098#issuecomment-673329185 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] cadonna commented on a change in pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

cadonna commented on a change in pull request #9094: URL: https://github.com/apache/kafka/pull/9094#discussion_r469781319 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/ProcessorNodeMetrics.java ## @@ -289,6 +294,25 @@ public static Se

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r469826866 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -3973,25 +3977,38 @@ void handleResponse(AbstractResponse a

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r469835182 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -3732,41 +3734,43 @@ public void testListOffsets() thro

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r469841392 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -584,14 +590,22 @@ public void testFetchProgressWithMi

[GitHub] [kafka] showuon opened a new pull request #9175: KAFKA-10340: Fix the old checkpoint data won't be removed after alter log dir

showuon opened a new pull request #9175: URL: https://github.com/apache/kafka/pull/9175 In [KIP-113](https://cwiki.apache.org/confluence/display/KAFKA/KIP-113%3A+Support+replicas+movement+between+log+directories), we support replicas movement between log directories. But while the director

[GitHub] [kafka] showuon commented on pull request #9175: KAFKA-10340: Fix the old checkpoint data won't be removed after alter log dir

showuon commented on pull request #9175: URL: https://github.com/apache/kafka/pull/9175#issuecomment-673423404 @lindong28 @tombentley , could you help review this PR? Thanks. This is an automated message from the Apache Git S

[GitHub] [kafka] jeqo commented on a change in pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

jeqo commented on a change in pull request #9137: URL: https://github.com/apache/kafka/pull/9137#discussion_r469906366 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/CompositeReadOnlyKeyValueStoreTest.java ## @@ -199,11 +236,44 @@ public void shou

[GitHub] [kafka] carlos-verdes opened a new pull request #9176: Allow replace all for RegexRouter

carlos-verdes opened a new pull request #9176: URL: https://github.com/apache/kafka/pull/9176 ### Context I need to create topics on the fly from database table names (cdc) and I'm replacing all `_` with `-`. With current RegexRouter I can't do this in one call (actually if I don't

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r469964306 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetcherTest.java ## @@ -3546,12 +3594,54 @@ private void testGetOffsetsFor

[GitHub] [kafka] cadonna commented on pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

cadonna commented on pull request #9098: URL: https://github.com/apache/kafka/pull/9098#issuecomment-673493440 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] bbejeck commented on pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

bbejeck commented on pull request #9108: URL: https://github.com/apache/kafka/pull/9108#issuecomment-673506527 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] bbejeck commented on pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

bbejeck commented on pull request #9108: URL: https://github.com/apache/kafka/pull/9108#issuecomment-673507386 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] bbejeck commented on pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

bbejeck commented on pull request #9108: URL: https://github.com/apache/kafka/pull/9108#issuecomment-673507675 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r470008139 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -1221,28 +1226,39 @@ private DeleteGroupsResponse cre

[GitHub] [kafka] mimaison commented on a change in pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

mimaison commented on a change in pull request #8295: URL: https://github.com/apache/kafka/pull/8295#discussion_r470011774 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -892,136 +894,175 @@ class KafkaApis(val requestChannel: RequestChannel, def handle

[GitHub] [kafka] abbccdda commented on pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

abbccdda commented on pull request #9108: URL: https://github.com/apache/kafka/pull/9108#issuecomment-673552014 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r470053173 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -569,8 +575,8 @@ class Partition(val topicPartition: TopicPartition, val oldLead

[GitHub] [kafka] hachikuji commented on pull request #9163: KAFKA-10386; Fix flexible version support for `records` type

hachikuji commented on pull request #9163: URL: https://github.com/apache/kafka/pull/9163#issuecomment-673567576 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r470063833 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -485,13 +490,11 @@ class Partition(val topicPartition: TopicPartition, def makeLeade

[GitHub] [kafka] jeqo commented on pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

jeqo commented on pull request #9137: URL: https://github.com/apache/kafka/pull/9137#issuecomment-673574377 @ableegoldman this should be ready for another review :) This is an automated message from the Apache Git Service. To

[GitHub] [kafka] bbejeck commented on pull request #9108: KAFKA-9273: Extract testShouldAutoShutdownOnIncompleteMetadata from S…

bbejeck commented on pull request #9108: URL: https://github.com/apache/kafka/pull/9108#issuecomment-673577509 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] vvcephei commented on pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

vvcephei commented on pull request #9098: URL: https://github.com/apache/kafka/pull/9098#issuecomment-673582467 \o/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] vvcephei commented on pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

vvcephei commented on pull request #9098: URL: https://github.com/apache/kafka/pull/9098#issuecomment-673582389 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] hachikuji commented on pull request #9163: KAFKA-10386; Fix flexible version support for `records` type

hachikuji commented on pull request #9163: URL: https://github.com/apache/kafka/pull/9163#issuecomment-673583533 Previous builds appear to have succeeded, but I might have jumped the gun on the retest. For example: https://builds.apache.org/job/kafka-pr-jdk11-scala2.13/7820/

[GitHub] [kafka] hachikuji merged pull request #9163: KAFKA-10386; Fix flexible version support for `records` type

hachikuji merged pull request #9163: URL: https://github.com/apache/kafka/pull/9163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r470101599 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to the

[GitHub] [kafka] cadonna commented on pull request #9174: KAFKA-10395: relax output topic check in TTD to work with dynamic routing

cadonna commented on pull request #9174: URL: https://github.com/apache/kafka/pull/9174#issuecomment-673610380 Failure seem related This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] ableegoldman commented on a change in pull request #9174: KAFKA-10395: relax output topic check in TTD to work with dynamic routing

ableegoldman commented on a change in pull request #9174: URL: https://github.com/apache/kafka/pull/9174#discussion_r470134136 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -805,10 +805,10 @@ public void advanceWallClockT

[GitHub] [kafka] ableegoldman commented on a change in pull request #9094: KAFKA-10054: KIP-613, add TRACE-level e2e latency metrics

ableegoldman commented on a change in pull request #9094: URL: https://github.com/apache/kafka/pull/9094#discussion_r470139967 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/ProcessorNodeMetrics.java ## @@ -289,6 +294,25 @@ public stat

[GitHub] [kafka] kkonstantine commented on a change in pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

kkonstantine commented on a change in pull request #9172: URL: https://github.com/apache/kafka/pull/9172#discussion_r470183698 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/TransformationIntegrationTest.java ## @@ -318,4 +323,61 @@ public voi

[GitHub] [kafka] vvcephei commented on pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

vvcephei commented on pull request #9098: URL: https://github.com/apache/kafka/pull/9098#issuecomment-673659166 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] vvcephei commented on pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

vvcephei commented on pull request #9098: URL: https://github.com/apache/kafka/pull/9098#issuecomment-673661633 Looks like the tests never actually ran. I'm running them locally now. This is an automated message from the Apac

[GitHub] [kafka] kkonstantine commented on pull request #9172: KAFKA-10387: Fix inclusion of transformation configs when topic creation is enabled in Connect

kkonstantine commented on pull request #9172: URL: https://github.com/apache/kafka/pull/9172#issuecomment-673664418 Thanks for the comments @rhauch ! The PR should be ready for another pass. Jenkins still has a long queue of jobs. Yesterday 2/3 builds were green. I'm expecting the new jo

[GitHub] [kafka] vvcephei commented on a change in pull request #9174: KAFKA-10395: relax output topic check in TTD to work with dynamic routing

vvcephei commented on a change in pull request #9174: URL: https://github.com/apache/kafka/pull/9174#discussion_r470193578 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -805,10 +805,10 @@ public void advanceWallClockTime(

[GitHub] [kafka] vvcephei commented on pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

vvcephei commented on pull request #9098: URL: https://github.com/apache/kafka/pull/9098#issuecomment-673672230 Build passed: ``` $ test-kafka :streams:testAll ... BUILD SUCCESSFUL in 9m 57s 94 actionable tasks: 94 executed ```

[GitHub] [kafka] vvcephei merged pull request #9098: KAFKA-9924: Prepare RocksDB and metrics for RocksDB properties recording

vvcephei merged pull request #9098: URL: https://github.com/apache/kafka/pull/9098 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] cadonna opened a new pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

cadonna opened a new pull request #9177: URL: https://github.com/apache/kafka/pull/9177 This commit adds the first RocksDB metric that exposes RocksDB property num-entries-active-mem-table. More specifically it introduces - code in StreamsMetricsImpl that is shared by all such metric

[GitHub] [kafka] cadonna commented on pull request #9177: KAFKA-9924: Add RocksDB metric num-entries-active-mem-table

cadonna commented on pull request #9177: URL: https://github.com/apache/kafka/pull/9177#issuecomment-673697329 Call for review: @guozhangwang @vvcephei This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r470339031 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/UserScramCredentialUpsertion.java ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apach

[GitHub] [kafka] rondagostino commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r470339737 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeUserScramCredentialsResult.java ## @@ -0,0 +1,50 @@ +/* + * Licensed to the

[GitHub] [kafka] rondagostino commented on pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

rondagostino commented on pull request #9032: URL: https://github.com/apache/kafka/pull/9032#issuecomment-673778747 @cmccabe Thanks again for the reviews. I think all comments are addressed. Here's where we stand. I will make the indicated KIP changes and announce them in the DISCUSS em

[GitHub] [kafka] showuon closed pull request #9175: KAFKA-8362: Fix the old checkpoint data won't be removed after alter log dir

showuon closed pull request #9175: URL: https://github.com/apache/kafka/pull/9175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] ableegoldman commented on a change in pull request #9137: KAFKA-9929: Support reverse iterator on KeyValueStore

ableegoldman commented on a change in pull request #9137: URL: https://github.com/apache/kafka/pull/9137#discussion_r470311062 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBPrefixIterator.java ## @@ -29,7 +29,7 @@

[GitHub] [kafka] showuon opened a new pull request #9178: KAFKA-8362: fix the old checkpoint won't be removed after alter log dir

showuon opened a new pull request #9178: URL: https://github.com/apache/kafka/pull/9178 In [KIP-113](https://cwiki.apache.org/confluence/display/KAFKA/KIP-113%3A+Support+replicas+movement+between+log+directories), we support replicas movement between log directories. But while the director

[GitHub] [kafka] showuon commented on pull request #9175: KAFKA-8362: Fix the old checkpoint data won't be removed after alter log dir

showuon commented on pull request #9175: URL: https://github.com/apache/kafka/pull/9175#issuecomment-673831587 close this PR since it links to the wrong jira ID. This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] ableegoldman commented on a change in pull request #9174: KAFKA-10395: relax output topic check in TTD to work with dynamic routing

ableegoldman commented on a change in pull request #9174: URL: https://github.com/apache/kafka/pull/9174#discussion_r470374291 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -805,10 +805,10 @@ public void advanceWallClockT

[GitHub] [kafka] tarunrathor-pro commented on pull request #7561: [WIP] KAFKA-7739: Tiered storage

tarunrathor-pro commented on pull request #7561: URL: https://github.com/apache/kafka/pull/7561#issuecomment-673849831 Curious whether this is still actively worked upon? This is an automated message from the Apache Git Servi

[GitHub] [kafka] showuon commented on pull request #9178: KAFKA-8362: fix the old checkpoint won't be removed after alter log dir

showuon commented on pull request #9178: URL: https://github.com/apache/kafka/pull/9178#issuecomment-673851321 @omkreddy @hachikuji , could you review this PR? Thanks. This is an automated message from the Apache Git Service.

[GitHub] [kafka] showuon edited a comment on pull request #9178: KAFKA-8362: fix the old checkpoint won't be removed after alter log dir

showuon edited a comment on pull request #9178: URL: https://github.com/apache/kafka/pull/9178#issuecomment-673851321 @omkreddy @hachikuji @mingaliu , could you review this PR? Thanks. This is an automated message from the Ap

[GitHub] [kafka] showuon opened a new pull request #9179: KAFKA-10390: Remove ignore case option when grep process info to be more specific

showuon opened a new pull request #9179: URL: https://github.com/apache/kafka/pull/9179 Remove ignore case option when grep process info to be more specific since our entry point is definitely `kafka.Kafka`. ### Committer Checklist (excluded from commit message) - [ ] Verify desig

<    7   8   9   10   11   12   13   14   15   16   >