rondagostino commented on pull request #9032: URL: https://github.com/apache/kafka/pull/9032#issuecomment-673778747
@cmccabe Thanks again for the reviews. I think all comments are addressed. Here's where we stand. I will make the indicated KIP changes and announce them in the DISCUSS email thread once we have the full set of KIP changes agreed to/reviewed in this PR. 1. I removed -1 as a valid iterations value in the code. 2. Users who authenticate using delegation tokens are not allowed to alter user SRAM credentials. 3. It is no longer necessary to send Describe requests to the controller 4. I added per-user error information in the Describe response, and kept the top-level error information. The top-level error is non-zero if there is an authorization issue or there is some kind of infrastructure issue. Otherwise, if some users can't de described but others can, the top-level error indicates success and the per-user errors indicate success or failure accordingly. Asking to describe a user that doesn't exist or asking to describe the same user twice results in the corresponding user-level error being set. 5. We've added 3 new errors/exception classes: `RESOURCE_NOT_FOUND/ResourceNotFoundException`, `DUPLICATE_RESOURCE/DuplicateResourceException`, and `UNACCEPTABLE_CREDENTIAL/UnacceptableCredentialException` and we leverage those in the expected places. 6. We leverage the existing `UNSUPPORTED_SASL_MECHANISM/UnsupportedSaslMechanismException` where it would be expected. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
