ableegoldman commented on a change in pull request #9174:
URL: https://github.com/apache/kafka/pull/9174#discussion_r470374291
##########
File path:
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java
##########
@@ -805,10 +805,10 @@ public void advanceWallClockTime(final Duration advance) {
private Queue<ProducerRecord<byte[], byte[]>> getRecordsQueue(final String
topicName) {
final Queue<ProducerRecord<byte[], byte[]>> outputRecords =
outputRecordsByTopic.get(topicName);
- if (outputRecords == null) {
- if (!processorTopology.sinkTopics().contains(topicName)) {
- throw new IllegalArgumentException("Unknown topic: " +
topicName);
- }
+ if (outputRecords == null &&
!processorTopology.sinkTopics().contains(topicName)) {
Review comment:
Yeah, that's a good point. Took a quick look at this and personally I
feel it's not worth it to add even more things for the internal topology to
track. But it wouldn't really add any complexity so if this is a big concern I
can go ahead and add in a flag to watch out for any non-static
TopicNameExtractors
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
