[GitHub] [kafka] abbccdda commented on pull request #8907: MINOR: code cleanup for `VOut` inconsistent naming

2020-07-24 Thread GitBox
abbccdda commented on pull request #8907: URL: https://github.com/apache/kafka/pull/8907#issuecomment-663817294 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-07-24 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-663818439 @junrao I have rebased this PR to include fix of ```group_mode_transactions_test```. Could you run system tests again? Except for ```streams_eos_test``` and transaction t

[GitHub] [kafka] chia7712 edited a comment on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-07-24 Thread GitBox
chia7712 edited a comment on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-663818439 @junrao I have rebased this PR to include fix of ```group_mode_transactions_test```. Could you run system tests again? Except for ```streams_eos_test```, ```stream

[GitHub] [kafka] chia7712 edited a comment on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-07-24 Thread GitBox
chia7712 edited a comment on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-663818439 @junrao I have rebased this PR to include fix of ```group_mode_transactions_test```. Could you run system tests again? Except for ```streams_eos_test```, ```stream

[GitHub] [kafka] AshishRoyJava commented on pull request #9034: KAFKA-10246 : AbstractProcessorContext topic() throws NPE

2020-07-25 Thread GitBox
AshishRoyJava commented on pull request #9034: URL: https://github.com/apache/kafka/pull/9034#issuecomment-663825200 All checks are failing due to some other test case failure. Can anyone look into the logs please? @abbccdda

[GitHub] [kafka] huxihx commented on pull request #9071: KAFKA-10305: Print usage when parsing fails for ConsumerPerformance

2020-07-25 Thread GitBox
huxihx commented on pull request #9071: URL: https://github.com/apache/kafka/pull/9071#issuecomment-663829002 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] chia7712 commented on pull request #9034: KAFKA-10246 : AbstractProcessorContext topic() throws NPE

2020-07-25 Thread GitBox
chia7712 commented on pull request #9034: URL: https://github.com/apache/kafka/pull/9034#issuecomment-663833458 @AshishRoyJava Nice finding and fixing! > AbstractProcessorContext topic() throws NullPointerException when modifying a state store within the DSL from a punctuator

[GitHub] [kafka] rootex- commented on pull request #6700: KAFKA-7817 ConsumerGroupCommand Regex Feature

2020-07-25 Thread GitBox
rootex- commented on pull request #6700: URL: https://github.com/apache/kafka/pull/6700#issuecomment-663834666 @abbccdda Yes, sure This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] Mathieu1124 opened a new pull request #9076: MINOR - fix typo

2020-07-25 Thread GitBox
Mathieu1124 opened a new pull request #9076: URL: https://github.com/apache/kafka/pull/9076 *FIx typo in ProducerConfig* ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

[GitHub] [kafka] huxihx commented on pull request #9071: KAFKA-10305: Print usage when parsing fails for ConsumerPerformance

2020-07-25 Thread GitBox
huxihx commented on pull request #9071: URL: https://github.com/apache/kafka/pull/9071#issuecomment-663842491 @omkreddy Thanks for the review, merging to trunk. This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] huxihx merged pull request #9071: KAFKA-10305: Print usage when parsing fails for ConsumerPerformance

2020-07-25 Thread GitBox
huxihx merged pull request #9071: URL: https://github.com/apache/kafka/pull/9071 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] chia7712 opened a new pull request #9077: MINOR: remove NewTopic#NO_PARTITIONS and NewTopic#NO_REPLICATION_FACT…

2020-07-25 Thread GitBox
chia7712 opened a new pull request #9077: URL: https://github.com/apache/kafka/pull/9077 The constants used to represent no_partition and no_replica are important factor in creating topic. Hence, we should have consistent reference to code base. ### Committer Checklist (excluded fro

[GitHub] [kafka] rgroothuijsen opened a new pull request #9078: KAFKA-10132: Return correct value types for MBean attributes

2020-07-25 Thread GitBox
rgroothuijsen opened a new pull request #9078: URL: https://github.com/apache/kafka/pull/9078 Currently, JMX outputs all metrics as having type `double`, even if they are strings or other types of numbers. This PR gets the type from the metric's value if possible, with `null` as a fallback

[GitHub] [kafka] rgroothuijsen commented on pull request #9078: KAFKA-10132: Return correct value types for MBean attributes

2020-07-25 Thread GitBox
rgroothuijsen commented on pull request #9078: URL: https://github.com/apache/kafka/pull/9078#issuecomment-663854901 I'm not entirely sure about returning raw nulls as a fallback, however, or how permissive it should be about null values in general. Thoughts? -

[GitHub] [kafka] vvcephei commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-25 Thread GitBox
vvcephei commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r460404740 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -275,31 +259,70 @@ private void restore

[GitHub] [kafka] vvcephei commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-25 Thread GitBox
vvcephei commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r460404740 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -275,31 +259,70 @@ private void restore

[GitHub] [kafka] cadonna commented on pull request #9066: KAFKA-10287: Skip unknown offsets when computing sum of changelog offsets

2020-07-25 Thread GitBox
cadonna commented on pull request #9066: URL: https://github.com/apache/kafka/pull/9066#issuecomment-663867610 Java 11 failed with ``` 08:16:38 org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest > shouldUpgradeFromEosAlphaToEosBeta[true] FAILED 08:16:38 java

[GitHub] [kafka] cadonna edited a comment on pull request #9066: KAFKA-10287: Skip unknown offsets when computing sum of changelog offsets

2020-07-25 Thread GitBox
cadonna edited a comment on pull request #9066: URL: https://github.com/apache/kafka/pull/9066#issuecomment-663867610 Java 11 failed with ``` 08:16:38 org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest > shouldUpgradeFromEosAlphaToEosBeta[true] FAILED 08:16:38

[GitHub] [kafka] ijuma commented on a change in pull request #9022: KAFKA-10158: Improve test behavior and resolve flakiness of test...

2020-07-25 Thread GitBox
ijuma commented on a change in pull request #9022: URL: https://github.com/apache/kafka/pull/9022#discussion_r460416614 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -672,11 +677,9 @@ class TopicCommandWithAdminClientTest extend

[GitHub] [kafka] lbradstreet commented on a change in pull request #9022: KAFKA-10158: Improve test behavior and resolve flakiness of test...

2020-07-25 Thread GitBox
lbradstreet commented on a change in pull request #9022: URL: https://github.com/apache/kafka/pull/9022#discussion_r460416611 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -672,11 +677,9 @@ class TopicCommandWithAdminClientTest

[GitHub] [kafka] ijuma commented on a change in pull request #9022: KAFKA-10158: Improve test behavior and resolve flakiness of test...

2020-07-25 Thread GitBox
ijuma commented on a change in pull request #9022: URL: https://github.com/apache/kafka/pull/9022#discussion_r460416797 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -673,10 +678,14 @@ class TopicCommandWithAdminClientTest exten

[GitHub] [kafka] ijuma commented on a change in pull request #9022: KAFKA-10158: Improve test behavior and resolve flakiness of test...

2020-07-25 Thread GitBox
ijuma commented on a change in pull request #9022: URL: https://github.com/apache/kafka/pull/9022#discussion_r460417143 ## File path: core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala ## @@ -673,10 +678,14 @@ class TopicCommandWithAdminClientTest exten

[GitHub] [kafka] abbccdda commented on pull request #9052: MINOR: TopologyTestDriver should not require dummy parameters

2020-07-25 Thread GitBox
abbccdda commented on pull request #9052: URL: https://github.com/apache/kafka/pull/9052#issuecomment-663869941 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] abbccdda commented on pull request #9034: KAFKA-10246 : AbstractProcessorContext topic() throws NPE

2020-07-25 Thread GitBox
abbccdda commented on pull request #9034: URL: https://github.com/apache/kafka/pull/9034#issuecomment-663870109 Test failure should be non related. This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] abbccdda merged pull request #9034: KAFKA-10246 : AbstractProcessorContext topic() throws NPE

2020-07-25 Thread GitBox
abbccdda merged pull request #9034: URL: https://github.com/apache/kafka/pull/9034 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] abbccdda commented on pull request #8907: MINOR: code cleanup for `VOut` inconsistent naming

2020-07-25 Thread GitBox
abbccdda commented on pull request #8907: URL: https://github.com/apache/kafka/pull/8907#issuecomment-663870524 Test failure non related. This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] abbccdda merged pull request #8907: MINOR: code cleanup for `VOut` inconsistent naming

2020-07-25 Thread GitBox
abbccdda merged pull request #8907: URL: https://github.com/apache/kafka/pull/8907 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on pull request #9066: KAFKA-10287: Skip unknown offsets when computing sum of changelog offsets

2020-07-25 Thread GitBox
chia7712 commented on pull request #9066: URL: https://github.com/apache/kafka/pull/9066#issuecomment-663870629 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] ijuma commented on pull request #9022: KAFKA-10158: Improve test behavior and resolve flakiness of test...

2020-07-25 Thread GitBox
ijuma commented on pull request #9022: URL: https://github.com/apache/kafka/pull/9022#issuecomment-663871416 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] chia7712 opened a new pull request #9079: KAFKA-10308 fix flaky core/round_trip_fault_test.py

2020-07-25 Thread GitBox
chia7712 opened a new pull request #9079: URL: https://github.com/apache/kafka/pull/9079 Creating a topic may fail (due to timeout) in running system tests. However, ```RoundTripWorker``` does not ignore ```TopicExistsException``` which makes ```round_trip_fault_test.py``` be a flaky one.

[GitHub] [kafka] ijuma commented on pull request #9022: KAFKA-10158: Improve test behavior and resolve flakiness of test...

2020-07-25 Thread GitBox
ijuma commented on pull request #9022: URL: https://github.com/apache/kafka/pull/9022#issuecomment-663871604 https://builds.apache.org/job/kafka-pr-jdk11-scala2.13/ This is an automated message from the Apache Git Service. To

[GitHub] [kafka] ijuma removed a comment on pull request #9022: KAFKA-10158: Improve test behavior and resolve flakiness of test...

2020-07-25 Thread GitBox
ijuma removed a comment on pull request #9022: URL: https://github.com/apache/kafka/pull/9022#issuecomment-663871604 https://builds.apache.org/job/kafka-pr-jdk11-scala2.13/ This is an automated message from the Apache Git Ser

[GitHub] [kafka] ijuma commented on pull request #9022: KAFKA-10158: Improve test behavior and resolve flakiness of test...

2020-07-25 Thread GitBox
ijuma commented on pull request #9022: URL: https://github.com/apache/kafka/pull/9022#issuecomment-663871642 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] chia7712 closed pull request #5708: Minor: remove WorkerCoordinatorMetrics and instantiate the metrics in the constructor of WorkerCoordinator

2020-07-25 Thread GitBox
chia7712 closed pull request #5708: URL: https://github.com/apache/kafka/pull/5708 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 closed pull request #8137: KAFKA-8967 Flaky test kafka.api.SaslSslAdminIntegrationTest.testCreat…

2020-07-25 Thread GitBox
chia7712 closed pull request #8137: URL: https://github.com/apache/kafka/pull/8137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] mjsax commented on pull request #9075: KAFKA-10306: GlobalThread should fail on InvalidOffsetException

2020-07-25 Thread GitBox
mjsax commented on pull request #9075: URL: https://github.com/apache/kafka/pull/9075#issuecomment-663905239 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #9075: KAFKA-10306: GlobalThread should fail on InvalidOffsetException

2020-07-25 Thread GitBox
mjsax commented on pull request #9075: URL: https://github.com/apache/kafka/pull/9075#issuecomment-663905333 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #9066: KAFKA-10287: Skip unknown offsets when computing sum of changelog offsets

2020-07-25 Thread GitBox
mjsax commented on pull request #9066: URL: https://github.com/apache/kafka/pull/9066#issuecomment-663906774 @chia7712 Only committers can trigger Jenkins builds. This is an automated message from the Apache Git Service. To r

[GitHub] [kafka] mjsax commented on pull request #9066: KAFKA-10287: Skip unknown offsets when computing sum of changelog offsets

2020-07-25 Thread GitBox
mjsax commented on pull request #9066: URL: https://github.com/apache/kafka/pull/9066#issuecomment-663906866 Java 8 passed the tests in question are know to be flaky. Might be good enough? Leave it to @vvcephei to make a call and merge.

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-25 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r460449901 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -275,31 +259,70 @@ private void restoreSta

[GitHub] [kafka] chia7712 commented on pull request #9066: KAFKA-10287: Skip unknown offsets when computing sum of changelog offsets

2020-07-25 Thread GitBox
chia7712 commented on pull request #9066: URL: https://github.com/apache/kafka/pull/9066#issuecomment-663912187 > Only committers can trigger Jenkins builds. It seems I can trigger the jenkins by comment “ Test this please”. Let me test it again. ---

[GitHub] [kafka] chia7712 commented on pull request #9066: KAFKA-10287: Skip unknown offsets when computing sum of changelog offsets

2020-07-25 Thread GitBox
chia7712 commented on pull request #9066: URL: https://github.com/apache/kafka/pull/9066#issuecomment-663912465 Jenkins is running now :( Maybe it does not exclude the committers from other Apache projects. At any rate, I will not trigger Jenkins in the future.

[GitHub] [kafka] ijuma commented on a change in pull request #9049: MINOR: fix scala warnings

2020-07-25 Thread GitBox
ijuma commented on a change in pull request #9049: URL: https://github.com/apache/kafka/pull/9049#discussion_r460453337 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -344,11 +342,14 @@ object ConfigCommand extends Config { val sensitiveEntries

[GitHub] [kafka] ijuma commented on a change in pull request #9049: MINOR: fix scala warnings

2020-07-25 Thread GitBox
ijuma commented on a change in pull request #9049: URL: https://github.com/apache/kafka/pull/9049#discussion_r460453389 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -384,8 +380,8 @@ class AclAuthorizer extends Authorizer with Logging {

[GitHub] [kafka] ijuma commented on pull request #9063: MINOR: Fixed deprecated Gradle build Properties.

2020-07-25 Thread GitBox
ijuma commented on pull request #9063: URL: https://github.com/apache/kafka/pull/9063#issuecomment-663913074 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] ijuma commented on a change in pull request #9063: MINOR: Fixed deprecated Gradle build Properties.

2020-07-25 Thread GitBox
ijuma commented on a change in pull request #9063: URL: https://github.com/apache/kafka/pull/9063#discussion_r460453530 ## File path: build.gradle ## @@ -304,7 +304,7 @@ subprojects { } test { -maxParallelForks = userMaxForks ?: Runtime.runtime.availableProcessors()

[GitHub] [kafka] ijuma commented on pull request #9022: KAFKA-10158: Improve test behavior and resolve flakiness of test...

2020-07-25 Thread GitBox
ijuma commented on pull request #9022: URL: https://github.com/apache/kafka/pull/9022#issuecomment-663913281 https://builds.apache.org/job/kafka-pr-jdk11-scala2.13/ This is an automated message from the Apache Git Service. To

[GitHub] [kafka] ijuma commented on pull request #9079: KAFKA-10308 fix flaky core/round_trip_fault_test.py

2020-07-25 Thread GitBox
ijuma commented on pull request #9079: URL: https://github.com/apache/kafka/pull/9079#issuecomment-663913254 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] ijuma removed a comment on pull request #9022: KAFKA-10158: Improve test behavior and resolve flakiness of test...

2020-07-25 Thread GitBox
ijuma removed a comment on pull request #9022: URL: https://github.com/apache/kafka/pull/9022#issuecomment-663913281 https://builds.apache.org/job/kafka-pr-jdk11-scala2.13/ This is an automated message from the Apache Git Ser

[GitHub] [kafka] ijuma opened a new pull request #9080: MINOR: Recommend Java 11

2020-07-25 Thread GitBox
ijuma opened a new pull request #9080: URL: https://github.com/apache/kafka/pull/9080 Java 11 has been recommended for a while, but the ops section had not been updated. Also tweak the text a bit to read better. ### Committer Checklist (excluded from commit message) - [ ] Verif

[GitHub] [kafka] jsancio commented on a change in pull request #9050: KAFKA-10193: Add preemption for controller events that have callbacks

2020-07-25 Thread GitBox
jsancio commented on a change in pull request #9050: URL: https://github.com/apache/kafka/pull/9050#discussion_r460467261 ## File path: core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala ## @@ -598,6 +603,86 @@ class ControllerIntegrationTest extends Zo

[GitHub] [kafka] mjsax commented on pull request #9066: KAFKA-10287: Skip unknown offsets when computing sum of changelog offsets

2020-07-25 Thread GitBox
mjsax commented on pull request #9066: URL: https://github.com/apache/kafka/pull/9066#issuecomment-663926510 Ah yes. I work for all committers -- it's not project specific. Missed that you are HBase Committer/PMC :) This is

[GitHub] [kafka] jsancio commented on a change in pull request #9050: KAFKA-10193: Add preemption for controller events that have callbacks

2020-07-25 Thread GitBox
jsancio commented on a change in pull request #9050: URL: https://github.com/apache/kafka/pull/9050#discussion_r460468241 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1986,101 +1965,125 @@ private[controller] class ControllerStats extends Kaf

[GitHub] [kafka] jsancio commented on a change in pull request #9050: KAFKA-10193: Add preemption for controller events that have callbacks

2020-07-25 Thread GitBox
jsancio commented on a change in pull request #9050: URL: https://github.com/apache/kafka/pull/9050#discussion_r460468239 ## File path: core/src/main/scala/kafka/controller/ControllerEventManager.scala ## @@ -77,7 +77,7 @@ class ControllerEventManager(controllerId: Int, priv

[GitHub] [kafka] vitojeng commented on pull request #8907: MINOR: code cleanup for `VOut` inconsistent naming

2020-07-25 Thread GitBox
vitojeng commented on pull request #8907: URL: https://github.com/apache/kafka/pull/8907#issuecomment-663928064 Thanks @abbccdda ! This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] showuon edited a comment on pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-26 Thread GitBox
showuon edited a comment on pull request #9029: URL: https://github.com/apache/kafka/pull/9029#issuecomment-663329158 @mimaison , thanks for your comments. I've updated in this commit: https://github.com/apache/kafka/pull/9029/commits/5345c6835ef42da973b794634d9b8d65f27ee80a. What I did ar

[GitHub] [kafka] ijuma commented on pull request #9022: KAFKA-10158: Fix flaky testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress

2020-07-26 Thread GitBox
ijuma commented on pull request #9022: URL: https://github.com/apache/kafka/pull/9022#issuecomment-664002055 Green build, merging to trunk and 2.6. This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [kafka] ijuma merged pull request #9022: KAFKA-10158: Fix flaky testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress

2020-07-26 Thread GitBox
ijuma merged pull request #9022: URL: https://github.com/apache/kafka/pull/9022 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma edited a comment on pull request #9022: KAFKA-10158: Fix flaky testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress

2020-07-26 Thread GitBox
ijuma edited a comment on pull request #9022: URL: https://github.com/apache/kafka/pull/9022#issuecomment-664002055 Green build, merging to trunk, 2.6 and 2.5. This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] sasakitoa opened a new pull request #9081: KAFKA-10309: KafkaProducer's sendOffsetsToTransaction should not block infinitively

2020-07-26 Thread GitBox
sasakitoa opened a new pull request #9081: URL: https://github.com/apache/kafka/pull/9081 This PR will change KafkaProducer#sendOffsetsToTransaction to be affected by max.block.ms to avoid blocking infinitively. This is

[GitHub] [kafka] ijuma opened a new pull request #9082: MINOR: Update dependencies for Kafka 2.7 (part 1)

2020-07-26 Thread GitBox
ijuma opened a new pull request #9082: URL: https://github.com/apache/kafka/pull/9082 I left out updates that could be risky. Preliminary testing indicates we can build (including spotBugs) and run tests with Java 15 with these changes. I will do more thorough testing once Java 15 reac

[GitHub] [kafka] rgroothuijsen removed a comment on pull request #9078: KAFKA-10132: Return correct value types for MBean attributes

2020-07-26 Thread GitBox
rgroothuijsen removed a comment on pull request #9078: URL: https://github.com/apache/kafka/pull/9078#issuecomment-663854901 I'm not entirely sure about returning raw nulls as a fallback, however, or how permissive it should be about null values in general. Thoughts? -

[GitHub] [kafka] mjsax merged pull request #9075: KAFKA-10306: GlobalThread should fail on InvalidOffsetException

2020-07-26 Thread GitBox
mjsax merged pull request #9075: URL: https://github.com/apache/kafka/pull/9075 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] vvcephei commented on a change in pull request #9031: KAFKA-10298: replace abstract Windows with a proper interface

2020-07-26 Thread GitBox
vvcephei commented on a change in pull request #9031: URL: https://github.com/apache/kafka/pull/9031#discussion_r460562257 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/EnumerableWindowDefinition.java ## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache So

[GitHub] [kafka] ijuma merged pull request #9080: MINOR: Recommend Java 11

2020-07-26 Thread GitBox
ijuma merged pull request #9080: URL: https://github.com/apache/kafka/pull/9080 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #9075: KAFKA-10306: GlobalThread should fail on InvalidOffsetException

2020-07-26 Thread GitBox
mjsax commented on pull request #9075: URL: https://github.com/apache/kafka/pull/9075#issuecomment-664031539 Merged to `trunk` and cherry-picked to `2.6` branch. This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-26 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r460449901 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -275,31 +259,70 @@ private void restoreSta

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

2020-07-26 Thread GitBox
mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r460449901 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java ## @@ -275,31 +259,70 @@ private void restoreSta

[GitHub] [kafka] ning2008wisc commented on pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-26 Thread GitBox
ning2008wisc commented on pull request #9029: URL: https://github.com/apache/kafka/pull/9029#issuecomment-664045085 Hi @showuon thanks for your work, a minor thing - do you mind to consolidate / merge the current 4 commits into 1 commit? --

[GitHub] [kafka] guozhangwang merged pull request #9068: MINOR: INFO log4j when request re-join

2020-07-26 Thread GitBox
guozhangwang merged pull request #9068: URL: https://github.com/apache/kafka/pull/9068 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-07-26 Thread GitBox
guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r460588651 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -93,8 +93,8 @@ public boolean isActive() {

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-07-26 Thread GitBox
guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r460590891 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -38,13 +41,39 @@ */ final class StateM

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-07-26 Thread GitBox
guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r460592249 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -454,6 +456,41 @@ public void flush(

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-07-26 Thread GitBox
guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r460599173 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java ## @@ -49,6 +61,31 @@ this.stateDirectory

[GitHub] [kafka] huxihx commented on a change in pull request #9081: KAFKA-10309: KafkaProducer's sendOffsetsToTransaction should not block infinitively

2020-07-26 Thread GitBox
huxihx commented on a change in pull request #9081: URL: https://github.com/apache/kafka/pull/9081#discussion_r460608228 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java ## @@ -687,7 +687,7 @@ public void sendOffsetsToTransaction(Map off

[GitHub] [kafka] huxihx commented on a change in pull request #9081: KAFKA-10309: KafkaProducer's sendOffsetsToTransaction should not block infinitively

2020-07-26 Thread GitBox
huxihx commented on a change in pull request #9081: URL: https://github.com/apache/kafka/pull/9081#discussion_r460609876 ## File path: core/src/test/scala/integration/kafka/api/TransactionsTest.scala ## @@ -406,6 +406,26 @@ class TransactionsTest extends KafkaServerTestHarness

[GitHub] [kafka] Mathieu1124 commented on pull request #9076: MINOR - fix typo

2020-07-26 Thread GitBox
Mathieu1124 commented on pull request #9076: URL: https://github.com/apache/kafka/pull/9076#issuecomment-664081255 > I think it was grammatically correct as it stood before this change. This change, if it were to occur, would have to state `if the leader fails` (the current change says `if

[GitHub] [kafka] Mathieu1124 closed pull request #9076: MINOR - fix typo

2020-07-26 Thread GitBox
Mathieu1124 closed pull request #9076: URL: https://github.com/apache/kafka/pull/9076 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-07-26 Thread GitBox
guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r460621030 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -243,18 +242,24 @@ public void handleAssignmen

[GitHub] [kafka] abbccdda commented on pull request #9077: MINOR: remove NewTopic#NO_PARTITIONS and NewTopic#NO_REPLICATION_FACT…

2020-07-26 Thread GitBox
abbccdda commented on pull request #9077: URL: https://github.com/apache/kafka/pull/9077#issuecomment-664098665 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] abbccdda commented on pull request #9077: MINOR: remove NewTopic#NO_PARTITIONS and NewTopic#NO_REPLICATION_FACT…

2020-07-26 Thread GitBox
abbccdda commented on pull request #9077: URL: https://github.com/apache/kafka/pull/9077#issuecomment-664098712 got 2/3 in previous run This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] abbccdda commented on pull request #9049: MINOR: fix scala warnings

2020-07-26 Thread GitBox
abbccdda commented on pull request #9049: URL: https://github.com/apache/kafka/pull/9049#issuecomment-664102269 Sg, will close the PR @ijuma This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kafka] abbccdda closed pull request #9049: MINOR: fix scala warnings

2020-07-26 Thread GitBox
abbccdda closed pull request #9049: URL: https://github.com/apache/kafka/pull/9049 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on pull request #9077: MINOR: remove NewTopic#NO_PARTITIONS and NewTopic#NO_REPLICATION_FACT…

2020-07-26 Thread GitBox
chia7712 commented on pull request #9077: URL: https://github.com/apache/kafka/pull/9077#issuecomment-664103549 @abbccdda thanks for reviews! This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kafka] guozhangwang opened a new pull request #9083: KAFKA-9450: Follow-up; Forbid process after closed [WIP]

2020-07-26 Thread GitBox
guozhangwang opened a new pull request #9083: URL: https://github.com/apache/kafka/pull/9083 Should be reviewed after https://github.com/apache/kafka/pull/8964 is merged, in which we first commit (flush) then suspend. ### Committer Checklist (excluded from commit message) - [ ] Ve

[GitHub] [kafka] showuon commented on pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-26 Thread GitBox
showuon commented on pull request #9029: URL: https://github.com/apache/kafka/pull/9029#issuecomment-664133647 hi @ning2008wisc , thanks for your suggestion. but I don't think it's good to merge all the 4 commits into 1. I think the commit history is a kind of records to keep why the autho

[GitHub] [kafka] guozhangwang opened a new pull request #9084: MINOR: Preserve Kafka exception from RebalanceListener [Do Not Merge]

2020-07-26 Thread GitBox
guozhangwang opened a new pull request #9084: URL: https://github.com/apache/kafka/pull/9084 Some of the rebalance listener may be implemented by Kafka as well, e.g. Connect and Streams, and if the exception thrown is actually a KafkaException, then we should not wrap it but directly throw

[GitHub] [kafka] showuon edited a comment on pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-26 Thread GitBox
showuon edited a comment on pull request #9029: URL: https://github.com/apache/kafka/pull/9029#issuecomment-664133647 hi @ning2008wisc , thanks for your suggestion. but I don't think it's good to merge all the 4 commits into 1. I think the commit history is a kind of records to keep why th

[GitHub] [kafka] showuon edited a comment on pull request #9029: KAFKA-10255: Fix flaky testOneWayReplicationWithAutoOffsetSync test

2020-07-26 Thread GitBox
showuon edited a comment on pull request #9029: URL: https://github.com/apache/kafka/pull/9029#issuecomment-664133647 hi @ning2008wisc , thanks for your suggestion. but I don't think it's good to merge all the 4 commits into 1. I think the commit history is a kind of records to keep why th

[GitHub] [kafka] abbccdda commented on a change in pull request #9084: MINOR: Preserve Kafka exception from RebalanceListener [Do Not Merge]

2020-07-26 Thread GitBox
abbccdda commented on a change in pull request #9084: URL: https://github.com/apache/kafka/pull/9084#discussion_r460671888 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java ## @@ -728,7 +728,11 @@ protected void onJoinPrep

[GitHub] [kafka] viktorsomogyi commented on pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-07-27 Thread GitBox
viktorsomogyi commented on pull request #4090: URL: https://github.com/apache/kafka/pull/4090#issuecomment-664175913 retest this please This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [kafka] viktorsomogyi commented on pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-07-27 Thread GitBox
viktorsomogyi commented on pull request #8730: URL: https://github.com/apache/kafka/pull/8730#issuecomment-664176258 @ijuma would you please review this or suggest who is the right committer to help with this? This is an aut

[GitHub] [kafka] ijuma commented on pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-07-27 Thread GitBox
ijuma commented on pull request #8730: URL: https://github.com/apache/kafka/pull/8730#issuecomment-664180174 @mimaison, would you be able to review this? This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] ijuma commented on a change in pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-07-27 Thread GitBox
ijuma commented on a change in pull request #4090: URL: https://github.com/apache/kafka/pull/4090#discussion_r460711206 ## File path: core/src/test/scala/unit/kafka/utils/JsonTest.scala ## @@ -41,14 +42,23 @@ class JsonTest { val jnf = JsonNodeFactory.instance asser

[GitHub] [kafka] ijuma commented on a change in pull request #9067: MINOR: Streams integration tests should not call exit

2020-07-27 Thread GitBox
ijuma commented on a change in pull request #9067: URL: https://github.com/apache/kafka/pull/9067#discussion_r460714125 ## File path: checkstyle/suppressions.xml ## @@ -17,8 +17,14 @@ files="(ApiMessageType).java|MessageDataGenerator.java"/> + +

[GitHub] [kafka] ijuma commented on a change in pull request #9067: MINOR: Streams integration tests should not call exit

2020-07-27 Thread GitBox
ijuma commented on a change in pull request #9067: URL: https://github.com/apache/kafka/pull/9067#discussion_r460714547 ## File path: streams/examples/src/main/java/org/apache/kafka/streams/examples/wordcount/WordCountTransformerDemo.java ## @@ -153,8 +154,8 @@ public void run

[GitHub] [kafka] ijuma commented on a change in pull request #9067: MINOR: Streams integration tests should not call exit

2020-07-27 Thread GitBox
ijuma commented on a change in pull request #9067: URL: https://github.com/apache/kafka/pull/9067#discussion_r460714731 ## File path: tools/src/main/java/org/apache/kafka/tools/VerifiableProducer.java ## @@ -241,7 +240,7 @@ public static VerifiableProducer createFromArgs(Argum

[GitHub] [kafka] ijuma commented on a change in pull request #9067: MINOR: Streams integration tests should not call exit

2020-07-27 Thread GitBox
ijuma commented on a change in pull request #9067: URL: https://github.com/apache/kafka/pull/9067#discussion_r460714731 ## File path: tools/src/main/java/org/apache/kafka/tools/VerifiableProducer.java ## @@ -241,7 +240,7 @@ public static VerifiableProducer createFromArgs(Argum

[GitHub] [kafka] ijuma commented on a change in pull request #9067: MINOR: Streams integration tests should not call exit

2020-07-27 Thread GitBox
ijuma commented on a change in pull request #9067: URL: https://github.com/apache/kafka/pull/9067#discussion_r460714731 ## File path: tools/src/main/java/org/apache/kafka/tools/VerifiableProducer.java ## @@ -241,7 +240,7 @@ public static VerifiableProducer createFromArgs(Argum

[GitHub] [kafka] ijuma commented on pull request #8936: KAFKA-10207: Fixed padded timeindex causing premature data deletion

2020-07-27 Thread GitBox
ijuma commented on pull request #8936: URL: https://github.com/apache/kafka/pull/8936#issuecomment-664201898 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

  1   2   3   4   5   6   7   8   9   10   >