ijuma commented on a change in pull request #9067:
URL: https://github.com/apache/kafka/pull/9067#discussion_r460714125
##########
File path: checkstyle/suppressions.xml
##########
@@ -17,8 +17,14 @@
files="(ApiMessageType).java|MessageDataGenerator.java"/>
<suppress checks="MethodLength"
files="MessageDataGenerator.java"/>
+ <suppress checks="Regexp"
+ files="MessageGenerator.java"
+ lines="285,288"/>
<!-- Clients -->
+ <suppress checks="Regexp"
+ files="Exit.java"
+ lines="43"/>
Review comment:
It seems really brittle to have line numbers in the suppression. Could
we:
1. Remove the `lines` part.
2. Give a name to the `Regexp` so that we only exclude the one related to
`System.exit` (not sure if this is possible)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
