vvcephei commented on a change in pull request #9031: URL: https://github.com/apache/kafka/pull/9031#discussion_r460562257
########## File path: streams/src/main/java/org/apache/kafka/streams/kstream/EnumerableWindowDefinition.java ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.streams.kstream; + +import org.apache.kafka.streams.processor.TimestampExtractor; +import org.apache.kafka.streams.state.WindowBytesStoreSupplier; + +import java.time.Duration; +import java.util.Map; + +import static org.apache.kafka.streams.kstream.internals.WindowingDefaults.DEFAULT_RETENTION_MS; + +/** + * The window specification for fixed size windows that is used to define window boundaries and grace period. + * <p> + * Grace period defines how long to wait on out-of-order events. That is, windows will continue to accept new records until {@code stream_time >= window_end + grace_period}. + * Records that arrive after the grace period passed are considered <em>late</em> and will not be processed but are dropped. + * + * @param <W> type of the window instance + */ +public interface EnumerableWindowDefinition<W extends Window> { + + + /** + * List all possible windows that contain the provided timestamp, + * indexed by non-negative window start timestamps. + * + * @param timestamp the timestamp window should get created for + * @return a map of {@code windowStartTimestamp -> Window} entries + */ + Map<Long, W> windowsFor(final long timestamp); + + /** + * Return the size of the specified windows in milliseconds. Review comment: ```suggestion * Return an upper bound on the size of windows in milliseconds. * Used to determine the lower bound on store retention time. ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
