ijuma commented on a change in pull request #9022:
URL: https://github.com/apache/kafka/pull/9022#discussion_r460416614
##########
File path:
core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
##########
@@ -672,11 +677,9 @@ class TopicCommandWithAdminClientTest extends
KafkaServerTestHarness with Loggin
adminClient.createTopics(
Collections.singletonList(new NewTopic(testTopicName, partitions,
replicationFactor).configs(configMap))).all().get()
waitForTopicCreated(testTopicName)
- TestUtils.generateAndProduceMessages(servers, testTopicName, numMessages =
10, acks = -1)
+ TestUtils.generateAndProduceMessages(servers, testTopicName, numMessages =
1000, acks = -1)
Review comment:
The broker only knows about batches, not individual records.
##########
File path:
core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
##########
@@ -672,11 +677,9 @@ class TopicCommandWithAdminClientTest extends
KafkaServerTestHarness with Loggin
adminClient.createTopics(
Collections.singletonList(new NewTopic(testTopicName, partitions,
replicationFactor).configs(configMap))).all().get()
waitForTopicCreated(testTopicName)
- TestUtils.generateAndProduceMessages(servers, testTopicName, numMessages =
10, acks = -1)
+ TestUtils.generateAndProduceMessages(servers, testTopicName, numMessages =
1000, acks = -1)
Review comment:
The broker only works in terms of record batches, not individual records.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
