gharris1727 opened a new pull request, #13185:
URL: https://github.com/apache/kafka/pull/13185
[Jira](https://issues.apache.org/jira/browse/KAFKA-14670)
This is the first part of the above ticket, applied only to SinkConnector
and SourceConnector plugins.
Additional PRs will cover the
guozhangwang commented on PR #12391:
URL: https://github.com/apache/kafka/pull/12391#issuecomment-1412931728
Closing this PR to rebase and create a new PR later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
guozhangwang closed pull request #12391: KAFKA-10199: Add task updater metrics
URL: https://github.com/apache/kafka/pull/12391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
vcrfxia opened a new pull request, #13186:
URL: https://github.com/apache/kafka/pull/13186
Minor changes to the segment value format introduced in
https://github.com/apache/kafka/pull/13126, as a follow-up to the latest PR
review.
* "segment" -> "segment row" in javadocs, where appropria
vcrfxia commented on code in PR #13126:
URL: https://github.com/apache/kafka/pull/13126#discussion_r1093903403
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java:
##
@@ -0,0 +1,554 @@
+/*
+ * Licensed to the Apache S
vcrfxia commented on code in PR #13126:
URL: https://github.com/apache/kafka/pull/13126#discussion_r1093904949
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java:
##
@@ -0,0 +1,554 @@
+/*
+ * Licensed to the Apache S
vcrfxia commented on code in PR #13126:
URL: https://github.com/apache/kafka/pull/13126#discussion_r1093907117
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java:
##
@@ -0,0 +1,554 @@
+/*
+ * Licensed to the Apache S
vcrfxia commented on code in PR #13126:
URL: https://github.com/apache/kafka/pull/13126#discussion_r1093909835
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java:
##
@@ -0,0 +1,518 @@
+/*
+ * Licensed to the Apache S
vcrfxia commented on code in PR #13126:
URL: https://github.com/apache/kafka/pull/13126#discussion_r1093910815
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java:
##
@@ -0,0 +1,518 @@
+/*
+ * Licensed to the Apache S
vcrfxia commented on code in PR #13126:
URL: https://github.com/apache/kafka/pull/13126#discussion_r1093912650
##
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatterTest.java:
##
@@ -0,0 +1,316 @@
+/*
+ * Licensed to the Apac
vcrfxia commented on code in PR #13126:
URL: https://github.com/apache/kafka/pull/13126#discussion_r1093913489
##
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatterTest.java:
##
@@ -0,0 +1,316 @@
+/*
+ * Licensed to the Apac
vcrfxia commented on code in PR #13126:
URL: https://github.com/apache/kafka/pull/13126#discussion_r1093914257
##
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatterTest.java:
##
@@ -0,0 +1,316 @@
+/*
+ * Licensed to the Apac
vcrfxia commented on PR #13126:
URL: https://github.com/apache/kafka/pull/13126#issuecomment-1413015517
Thanks, @mjsax ! Addressed your latest review comments in
https://github.com/apache/kafka/pull/13186 and responded inline here.
> The test cases are really hard to read IMHO, becaus
vcrfxia commented on code in PR #13126:
URL: https://github.com/apache/kafka/pull/13126#discussion_r1093919450
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java:
##
@@ -0,0 +1,554 @@
+/*
+ * Licensed to the Apache S
vcrfxia commented on code in PR #13186:
URL: https://github.com/apache/kafka/pull/13186#discussion_r1093920852
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBVersionedStoreSegmentValueFormatter.java:
##
@@ -146,41 +164,39 @@ interface SegmentValue {
vcrfxia commented on code in PR #13143:
URL: https://github.com/apache/kafka/pull/13143#discussion_r1093924959
##
streams/src/test/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegmentTest.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the Apache Software Foundati
vcrfxia commented on code in PR #13143:
URL: https://github.com/apache/kafka/pull/13143#discussion_r1093929163
##
streams/src/test/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegmentsTest.java:
##
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundat
vcrfxia commented on code in PR #13143:
URL: https://github.com/apache/kafka/pull/13143#discussion_r1094000371
##
streams/src/test/java/org/apache/kafka/streams/state/internals/LogicalKeyValueSegmentTest.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the Apache Software Foundati
lmr3796 opened a new pull request, #13187:
URL: https://github.com/apache/kafka/pull/13187
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
This is for better obse
lmr3796 commented on PR #13187:
URL: https://github.com/apache/kafka/pull/13187#issuecomment-1413356998
Hi @jsancio wondering if you can take a look at this change.
We found it helpful for us to understand such URP issues.
--
This is an automated message from the Apache Git Service.
fvaleri commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1094209610
##
checkstyle/import-control.xml:
##
@@ -351,6 +351,7 @@
+
Review Comment:
Is this related to the above comment? If not please move it above right
fvaleri commented on code in PR #13158:
URL: https://github.com/apache/kafka/pull/13158#discussion_r1094301822
##
server-common/src/main/java/org/apache/kafka/server/util/TopicPartitionFilter.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
clolov commented on code in PR #13177:
URL: https://github.com/apache/kafka/pull/13177#discussion_r1094319881
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/common/metrics/SensorBenchmark.java:
##
@@ -0,0 +1,145 @@
+package org.apache.kafka.jmh.common.metrics;
+
+import or
mimaison merged PR #13136:
URL: https://github.com/apache/kafka/pull/13136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
clolov commented on code in PR #13180:
URL: https://github.com/apache/kafka/pull/13180#discussion_r1094398310
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -415,7 +416,7 @@ public void run() throws Exception {
Hangleton commented on code in PR #13176:
URL: https://github.com/apache/kafka/pull/13176#discussion_r1094408921
##
core/src/main/scala/kafka/migration/MigrationPropagator.scala:
##
@@ -79,6 +81,18 @@ class MigrationPropagator(
_image = image
}
+ /**
+ * A very expe
clolov commented on PR #13184:
URL: https://github.com/apache/kafka/pull/13184#issuecomment-1413610633
To be honest, when I read this code a class which is "kind of" like a
Transformation but throws because some methods are not implemented made more
sense than wrapping Transformations in a
Hangleton commented on code in PR #13183:
URL: https://github.com/apache/kafka/pull/13183#discussion_r1094454976
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -474,6 +472,7 @@ class MetadataChangeEvent extends MigrationEvent {
beardt commented on code in PR #13168:
URL: https://github.com/apache/kafka/pull/13168#discussion_r1093403718
##
clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java:
##
@@ -54,6 +58,12 @@ public void testConfiguredInstances() {
testInvalidInput
clolov commented on PR #12607:
URL: https://github.com/apache/kafka/pull/12607#issuecomment-1413735823
@cadonna I have rebased this on the latest trunk. Is it possible to get a
review? This pull requests is one of the last remaining ones for completing the
Mockito migration for streams.
-
Hangleton commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1094474509
##
storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/LeaderEpochCheckpointFile.java:
##
@@ -0,0 +1,83 @@
+/*
+ * Licensed to the Apache Software Fou
clolov commented on PR #12777:
URL: https://github.com/apache/kafka/pull/12777#issuecomment-1413738931
@cadonna is it possible get a review here as well? @shekhar-rajak, if there
are any comments is it possible for you to address them. I will circle back in
a week's time and if there are st
clolov commented on PR #12739:
URL: https://github.com/apache/kafka/pull/12739#issuecomment-1413740025
@shekhar-rajak, I would quite like to complete the migration for streams, so
I will wait for a response for another week. Afterwards I will open a separate
pull request based on this one i
clolov commented on PR #12524:
URL: https://github.com/apache/kafka/pull/12524#issuecomment-1413742398
Hello @mdedetrich and @cadonna! Is there something still remaining for this
pull request or are we ready to merge it? There are around 4 pull requests
remaining of this migration and I wou
clolov commented on PR #12449:
URL: https://github.com/apache/kafka/pull/12449#issuecomment-1413745195
Hello @dplavcic and @cadonna, how is this pull request fairing? Is there
something outstanding as a review or comments to be addressed?
--
This is an automated message from the Apache Gi
beardt commented on PR #13168:
URL: https://github.com/apache/kafka/pull/13168#issuecomment-1413758244
I went ahead and reintroduced the InterceptorTestConfig as I do not think
it adds anymore complexity than `TestConfig` and `ClassTestConfig` while also
making `testConfiguredInstancesClo
Hangleton commented on code in PR #13177:
URL: https://github.com/apache/kafka/pull/13177#discussion_r1094530705
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/common/metrics/SensorBenchmark.java:
##
@@ -0,0 +1,145 @@
+package org.apache.kafka.jmh.common.metrics;
+
+import
ijuma commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1080718765
##
storage/src/main/java/org/apache/kafka/server/log/internals/LeaderEpochFileCache.java:
##
@@ -0,0 +1,385 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
ijuma commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1094564674
##
storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/LeaderEpochCheckpoint.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation
ijuma commented on code in PR #13046:
URL: https://github.com/apache/kafka/pull/13046#discussion_r1094564674
##
storage/src/main/java/org/apache/kafka/storage/internals/checkpoint/LeaderEpochCheckpoint.java:
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation
mumrah commented on code in PR #13183:
URL: https://github.com/apache/kafka/pull/13183#discussion_r1094614887
##
server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java:
##
@@ -250,7 +250,7 @@ private void handleEvents() throws InterruptedException {
mumrah commented on code in PR #13183:
URL: https://github.com/apache/kafka/pull/13183#discussion_r1094617299
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -474,6 +472,7 @@ class MetadataChangeEvent extends MigrationEvent {
clolov commented on code in PR #13171:
URL: https://github.com/apache/kafka/pull/13171#discussion_r1094628589
##
build.gradle:
##
@@ -1763,6 +1763,7 @@ project(':tools') {
implementation libs.jacksonJDK8Datatypes
implementation libs.slf4jApi
implementation libs.lo
mimaison commented on code in PR #13171:
URL: https://github.com/apache/kafka/pull/13171#discussion_r1094636765
##
build.gradle:
##
@@ -1763,6 +1763,7 @@ project(':tools') {
implementation libs.jacksonJDK8Datatypes
implementation libs.slf4jApi
implementation libs.
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094656127
##
build.gradle:
##
@@ -1763,6 +1763,7 @@ project(':tools') {
implementation libs.jacksonJDK8Datatypes
implementation libs.slf4jApi
implementation libs.lo
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094680573
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094680573
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094680573
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
mumrah commented on code in PR #13180:
URL: https://github.com/apache/kafka/pull/13180#discussion_r1094683166
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -415,7 +416,7 @@ public void run() throws Exception {
mumrah commented on code in PR #13180:
URL: https://github.com/apache/kafka/pull/13180#discussion_r1094684342
##
metadata/src/main/java/org/apache/kafka/metadata/migration/MigrationSummary.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094685504
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094686108
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
C0urante commented on code in PR #12984:
URL: https://github.com/apache/kafka/pull/12984#discussion_r1094686354
##
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##
@@ -711,9 +768,35 @@ KafkaBasedLog
setupAndCreateKafkaBasedLog(Stri
fvaleri commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094601295
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
mumrah commented on PR #13183:
URL: https://github.com/apache/kafka/pull/13183#issuecomment-1413948935
Updates:
* Factored out the CompletableFuture from the MetadataChangeEvent so it's
only used in the unit test
* Removed QueueClosingException, replaced with RejectedExecutionException
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094714174
##
tools/src/test/java/org/apache/kafka/tools/DelegationTokenCommandTest.java:
##
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094720518
##
tools/src/test/java/org/apache/kafka/tools/DelegationTokenCommandTest.java:
##
@@ -0,0 +1,105 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
fvaleri commented on PR #13171:
URL: https://github.com/apache/kafka/pull/13171#issuecomment-1413963412
Rebased. Thanks @clolov and @mimaison.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
C0urante merged PR #12984:
URL: https://github.com/apache/kafka/pull/12984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
gharris1727 commented on PR #13184:
URL: https://github.com/apache/kafka/pull/13184#issuecomment-1414001178
@clolov Perhaps that's where a name change would help. If this was named
`TransformationStage`, with a `TransformationChain` made up of multiple
`TransformationStage`s and a `Transfor
yashmayya commented on PR #12984:
URL: https://github.com/apache/kafka/pull/12984#issuecomment-1414002141
Thanks Greg and Chris for the great reviews on this one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094780253
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094781664
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094781236
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094783703
##
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java:
##
@@ -596,22 +604,89 @@ synchronized public DeleteRecordsResult
deleteRecords(Map future
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094783958
##
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java:
##
@@ -596,22 +604,89 @@ synchronized public DeleteRecordsResult
deleteRecords(Map future
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094784273
##
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java:
##
@@ -94,6 +100,8 @@ public class MockAdminClient extends AdminClient {
private Map
clolov commented on code in PR #13172:
URL: https://github.com/apache/kafka/pull/13172#discussion_r1094788715
##
tools/src/main/java/org/apache/kafka/tools/DelegationTokenCommand.java:
##
@@ -0,0 +1,306 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
mumrah commented on PR #13180:
URL: https://github.com/apache/kafka/pull/13180#issuecomment-1414048688
@cmccabe, here's the new metadata summary format:
> [2023-02-02 11:21:52,175] TRACE Sending RPCs to broker before moving to
dual-write mode. Metadata at offset 122 and epoch 1 in
clolov commented on code in PR #13180:
URL: https://github.com/apache/kafka/pull/13180#discussion_r1094798424
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -415,7 +416,7 @@ public void run() throws Exception {
shekhar-rajak commented on PR #12777:
URL: https://github.com/apache/kafka/pull/12777#issuecomment-1414050155
Hi,
This PR already have one approval and ready to merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
AndrefcBarber commented on PR #6329:
URL: https://github.com/apache/kafka/pull/6329#issuecomment-1414061654
Hi, trying to sell this great product to our company to resolve streaming. I
followed the comments and proposed solutions from Kafka-1194(2016) to present.
@robertbraeutigam & @kobihi
kamalcph commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1590749298
##
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##
@@ -55,7 +57,7 @@ public class TieredStorageTestUtils {
// Log cl
lucasbru commented on code in PR #15852:
URL: https://github.com/apache/kafka/pull/15852#discussion_r1590751522
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateUpdater.java:
##
@@ -103,6 +149,17 @@ public String toString() {
*/
void remove(f
lucasbru commented on code in PR #15852:
URL: https://github.com/apache/kafka/pull/15852#discussion_r1590752878
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -506,16 +506,14 @@ private void addTask(final Task task) {
cadonna commented on code in PR #15852:
URL: https://github.com/apache/kafka/pull/15852#discussion_r1590755586
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/DefaultStateUpdater.java:
##
@@ -506,16 +506,14 @@ private void addTask(final Task task) {
cadonna merged PR #15852:
URL: https://github.com/apache/kafka/pull/15852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
kamalcph commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1590762158
##
storage/src/test/java/org/apache/kafka/tiered/storage/integration/AlterLogDirTest.java:
##
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
kamalcph commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1590764089
##
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##
@@ -55,7 +57,7 @@ public class TieredStorageTestUtils {
// Log cl
cadonna opened a new pull request, #15870:
URL: https://github.com/apache/kafka/pull/15870
Uses the new remove operation of the state updater that returns a future to
remove lost tasks from the state udpater.
### Committer Checklist (excluded from commit message)
- [ ] Verify desig
kamalcph commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1590764089
##
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##
@@ -55,7 +57,7 @@ public class TieredStorageTestUtils {
// Log cl
kamalcph commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1590764089
##
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##
@@ -55,7 +57,7 @@ public class TieredStorageTestUtils {
// Log cl
cadonna opened a new pull request, #15871:
URL: https://github.com/apache/kafka/pull/15871
Uses the new remove operation of the state updater that returns
a future to remove revoked tasks from the state udpater.
### Committer Checklist (excluded from commit message)
- [ ] Verify
cadonna closed pull request #15867: KAFKA-10199: Remove lost tasks in state
updater with new remove
URL: https://github.com/apache/kafka/pull/15867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
chia7712 commented on code in PR #15850:
URL: https://github.com/apache/kafka/pull/15850#discussion_r1590791878
##
core/src/test/java/kafka/admin/ConfigCommandUnitTest.java:
##
@@ -0,0 +1,421 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
chia7712 commented on PR #15868:
URL: https://github.com/apache/kafka/pull/15868#issuecomment-2095618948
@FrankYang0529 please fix the build error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nizhikov commented on code in PR #15850:
URL: https://github.com/apache/kafka/pull/15850#discussion_r1590805333
##
core/src/test/java/kafka/admin/ConfigCommandUnitTest.java:
##
@@ -0,0 +1,421 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contr
FrankYang0529 opened a new pull request, #15872:
URL: https://github.com/apache/kafka/pull/15872
Ref: https://github.com/apache/kafka/pull/15766#discussion_r1585460093
Add ZK mode with classic consumer back to
DeleteOffsetsConsumerGroupCommandIntegrationTest.
### Committer Chec
chia7712 merged PR #15850:
URL: https://github.com/apache/kafka/pull/15850
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
satishd commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1590586656
##
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##
@@ -55,7 +57,7 @@ public class TieredStorageTestUtils {
// Log cle
satishd commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1590586656
##
storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java:
##
@@ -55,7 +57,7 @@ public class TieredStorageTestUtils {
// Log cle
jsto commented on PR #7121:
URL: https://github.com/apache/kafka/pull/7121#issuecomment-2095734292
Hello. We are also being flagged with metrics-core EOL. Do we have any
update on this task?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
chia7712 commented on PR #15872:
URL: https://github.com/apache/kafka/pull/15872#issuecomment-2095735857
Maybe we should merge `DeleteOffsetsConsumerGroupCommandIntegrationTest` and
`DeleteConsumerGroupsTest`. They are used to test delete-related commands.
--
This is an automated message
chia7712 commented on code in PR #15872:
URL: https://github.com/apache/kafka/pull/15872#discussion_r1590841207
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -88,7 +113,7 @@ public void testDeleteOffsets
chia7712 merged PR #15571:
URL: https://github.com/apache/kafka/pull/15571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
nizhikov opened a new pull request, #15873:
URL: https://github.com/apache/kafka/pull/15873
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testin
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1590911279
##
core/src/test/java/kafka/test/ClusterTestExtensionsTest.java:
##
@@ -108,12 +117,12 @@ public void testClusterTests() {
}
@ClusterTests({
-@Clus
dajac merged PR #15854:
URL: https://github.com/apache/kafka/pull/15854
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1590940053
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -83,6 +81,7 @@ private ClusterConfig(Type type, int brokers, int
controllers, int disksPerBroke
johnnychhsu commented on code in PR #15861:
URL: https://github.com/apache/kafka/pull/15861#discussion_r1590943709
##
core/src/test/java/kafka/test/annotation/ClusterTest.java:
##
@@ -44,4 +44,5 @@
String listener() default "";
MetadataVersion metadataVersion() default
401 - 500 of 75379 matches
Mail list logo
