kamalcph commented on code in PR #15690: URL: https://github.com/apache/kafka/pull/15690#discussion_r1590764089
########## storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java: ########## @@ -55,7 +57,7 @@ public class TieredStorageTestUtils { // Log cleanup interval is configured to be 500 ms. We need to wait at least that amount of time before // segments eligible for deletion gets physically removed. - public static final Integer STORAGE_WAIT_TIMEOUT_SEC = 5; + public static final Integer STORAGE_WAIT_TIMEOUT_SEC = 10; Review Comment: The AlterLogDirTest still flaky: ``` Build / JDK 17 and Scala 2.13 / executeTieredStorageTest(String).quorum=kraft – org.apache.kafka.tiered.storage.integration.AlterLogDirTest Error java.lang.AssertionError: [BrokerId=0] The base offset of the first log segment of topicB-0 in the log directory is 2 which is smaller than the expected offset 3. The directory of topicB-0 is made of the following files: 00000000000000000003.timeindex 00000000000000000002.log 00000000000000000002.timeindex leader-epoch-checkpoint 00000000000000000003.snapshot 00000000000000000002.snapshot partition.metadata 00000000000000000003.index 00000000000000000002.index 00000000000000000003.log Stacktrace java.lang.AssertionError: [BrokerId=0] The base offset of the first log segment of topicB-0 in the log directory is 2 which is smaller than the expected offset 3. The directory of topicB-0 is made of the following files: 00000000000000000003.timeindex 00000000000000000002.log 00000000000000000002.timeindex leader-epoch-checkpoint 00000000000000000003.snapshot 00000000000000000002.snapshot partition.metadata 00000000000000000003.index 00000000000000000002.index 00000000000000000003.log at org.apache.kafka.tiered.storage.utils.BrokerLocalStorage.waitForOffset(BrokerLocalStorage.java:129) at org.apache.kafka.tiered.storage.utils.BrokerLocalStorage.waitForEarliestLocalOffset(BrokerLocalStorage.java:86) at org.apache.kafka.tiered.storage.actions.ProduceAction.doExecute(ProduceAction.java:124) at org.apache.kafka.tiered.storage.TieredStorageTestAction.execute(TieredStorageTestAction.java:25) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org