[GitHub] [kafka] mjsax commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

mjsax commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465106657 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -71,11 +75,40 @@ public HostInfo getActiveHost() { * Get the St

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465111665 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedKStreamImpl.java ## @@ -0,0 +1,234 @@ +/* + * Licensed to the A

[GitHub] [kafka] junrao commented on a change in pull request #8936: KAFKA-10207: Fixed padded timeindex causing premature data deletion

junrao commented on a change in pull request #8936: URL: https://github.com/apache/kafka/pull/8936#discussion_r465151900 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -652,6 +653,12 @@ class Log(@volatile private var _dir: File, bytesTruncated } + def s

[GitHub] [kafka] johnthotekat commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

johnthotekat commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465163841 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -71,11 +75,40 @@ public HostInfo getActiveHost() { * Get

[GitHub] [kafka] johnthotekat commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

johnthotekat commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465164586 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -71,11 +75,40 @@ public HostInfo getActiveHost() { * Get

[GitHub] [kafka] johnthotekat commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

johnthotekat commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465164267 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -71,11 +75,40 @@ public HostInfo getActiveHost() { * Get

[GitHub] [kafka] brary commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

brary commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465176121 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, f

[GitHub] [kafka] junrao commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

junrao commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r465179335 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -369,6 +370,32 @@ class GroupCoordinator(val brokerId: Int, }

[GitHub] [kafka] johnthotekat commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

johnthotekat commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465190512 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo active

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465191505 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java ## @@ -459,6 +460,95 @@ public void shouldGro

[GitHub] [kafka] johnthotekat commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

johnthotekat commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465192381 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo active

[GitHub] [kafka] johnthotekat commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

johnthotekat commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465193230 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo active

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465193735 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/SlidingWindowsTest.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] lbradstreet opened a new pull request #9123: MINOR: optimize fetchablePartitions check by performing cheap check first

lbradstreet opened a new pull request #9123: URL: https://github.com/apache/kafka/pull/9123 When the consumer fetches a lot of partitions at once the isAvailable check can become expensive due to a high number of contains check. We might as well perform the isFetchable check first as t

[GitHub] [kafka] johnthotekat commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

johnthotekat commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465190512 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo active

[GitHub] [kafka] lbradstreet commented on pull request #9123: MINOR: optimize fetchablePartitions check by performing cheap check first

lbradstreet commented on pull request #9123: URL: https://github.com/apache/kafka/pull/9123#issuecomment-668711747  From a profile fetching from 2500 partitions. This section o

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465194845 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/SlidingWindowsTest.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] lbradstreet edited a comment on pull request #9123: MINOR: optimize fetchablePartitions check by performing cheap check first

lbradstreet edited a comment on pull request #9123: URL: https://github.com/apache/kafka/pull/9123#issuecomment-668711747  From a profile fetching from 2500 partitions. This se

[GitHub] [kafka] Johnny-Malizia commented on a change in pull request #8936: KAFKA-10207: Fixed padded timeindex causing premature data deletion

Johnny-Malizia commented on a change in pull request #8936: URL: https://github.com/apache/kafka/pull/8936#discussion_r465197854 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -652,6 +653,12 @@ class Log(@volatile private var _dir: File, bytesTruncated }

[GitHub] [kafka] chia7712 commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

chia7712 commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r465200508 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -369,6 +370,32 @@ class GroupCoordinator(val brokerId: Int, }

[GitHub] [kafka] brary commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

brary commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465201600 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, f

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465205088 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStreamThreadTest.java ## @@ -221,7 +221,6 @@ public void shouldTransit

[GitHub] [kafka] chia7712 commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

chia7712 commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r465206257 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -369,6 +370,32 @@ class GroupCoordinator(val brokerId: Int, }

[GitHub] [kafka] mjsax commented on a change in pull request #9047: KAFKA-9274: Remove `retries` for global task

mjsax commented on a change in pull request #9047: URL: https://github.com/apache/kafka/pull/9047#discussion_r465215487 ## File path: docs/streams/developer-guide/config-streams.html ## @@ -326,13 +321,18 @@ bootstrap.serversstate.cleanup.delay.ms Low

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465219522 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java ## @@ -459,6 +460,95 @@ public void shouldGro

[GitHub] [kafka] chia7712 commented on pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

chia7712 commented on pull request #9102: URL: https://github.com/apache/kafka/pull/9102#issuecomment-668732926 ```org.apache.kafka.clients.admin.KafkaAdminClientTest.testMetadataRetries``` is traced by #9091 and ```EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]```

[GitHub] [kafka] hachikuji commented on a change in pull request #9110: MINOR: Ensure a reason is logged for all segment deletion operations

hachikuji commented on a change in pull request #9110: URL: https://github.com/apache/kafka/pull/9110#discussion_r465221060 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2227,14 +2210,17 @@ class Log(@volatile private var _dir: File, * @param segments The log

[GitHub] [kafka] chia7712 commented on a change in pull request #8852: MINOR: code cleanup for Kafka Streams task classes

chia7712 commented on a change in pull request #8852: URL: https://github.com/apache/kafka/pull/8852#discussion_r465229314 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java ## @@ -116,89 +112,100 @@ public boolean isValidTransition(fina

[GitHub] [kafka] ableegoldman commented on pull request #9024: [DO NOT MERGE (yet)] MINOR: bump Streams integration test log level to DEBUG

ableegoldman commented on pull request #9024: URL: https://github.com/apache/kafka/pull/9024#issuecomment-668756679 1 unrelated failure: `SaslPlaintextConsumerTest.testCoordinatorFailover` This is an automated message from th

[GitHub] [kafka] abbccdda commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

abbccdda commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r465243578 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -91,18 +100,20 @@ public InternalTopicMan

[GitHub] [kafka] mjsax merged pull request #9024: MINOR: change Streams integration test log levels

mjsax merged pull request #9024: URL: https://github.com/apache/kafka/pull/9024 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dielhennr commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

dielhennr commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r465257558 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -431,6 +433,26 @@ class AdminManager(val config: KafkaConfig, (na

[GitHub] [kafka] dielhennr commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

dielhennr commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r465257558 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -431,6 +433,26 @@ class AdminManager(val config: KafkaConfig, (na

[GitHub] [kafka] junrao commented on a change in pull request #8936: KAFKA-10207: Fixed padded timeindex causing premature data deletion

junrao commented on a change in pull request #8936: URL: https://github.com/apache/kafka/pull/8936#discussion_r465260977 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -652,6 +653,12 @@ class Log(@volatile private var _dir: File, bytesTruncated } + def s

[GitHub] [kafka] abbccdda opened a new pull request #9124: MINOR: add additional shutdown log info

abbccdda opened a new pull request #9124: URL: https://github.com/apache/kafka/pull/9124 The purpose of this PR is to both enhance the visibility of shutdown progress for Kafka, as well as for the debugging purpose of a delayed process in between socket server close and eventually kafka se

[GitHub] [kafka] dajac closed pull request #9072: KAFKA-10162; Make the rate based quota behave more like a Token Bucket (KIP-599, Part III)

dajac closed pull request #9072: URL: https://github.com/apache/kafka/pull/9072 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] dajac commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig

dajac commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r465272340 ## File path: clients/src/main/resources/common/message/RequestHeader.json ## @@ -37,6 +37,12 @@ // Since the client is sending the ApiVersionsRequest in

[GitHub] [kafka] dajac commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig

dajac commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r465274018 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2599,13 +2664,57 @@ class KafkaApis(val requestChannel: RequestChannel, } }

[GitHub] [kafka] dajac commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig

dajac commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r465273597 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2453,34 +2455,98 @@ class KafkaApis(val requestChannel: RequestChannel, def handleA

[GitHub] [kafka] dajac commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig

dajac commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r465273903 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2599,13 +2664,57 @@ class KafkaApis(val requestChannel: RequestChannel, } }

[GitHub] [kafka] ijuma merged pull request #9058: MINOR: Update jackson to latest 2.10.5

ijuma merged pull request #9058: URL: https://github.com/apache/kafka/pull/9058 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #9058: MINOR: Update jackson to latest 2.10.5

ijuma commented on pull request #9058: URL: https://github.com/apache/kafka/pull/9058#issuecomment-668778840 Merged to trunk. Is there a reason to backport it to older branches? This is an automated message from the Apache Gi

[GitHub] [kafka] dajac commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig

dajac commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r465275440 ## File path: clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java ## @@ -37,11 +37,22 @@ public RequestHeader(Struct struct, short head

[GitHub] [kafka] dhruvilshah3 commented on a change in pull request #9110: MINOR: Ensure a reason is logged for all segment deletion operations

dhruvilshah3 commented on a change in pull request #9110: URL: https://github.com/apache/kafka/pull/9110#discussion_r464100823 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2227,14 +2210,17 @@ class Log(@volatile private var _dir: File, * @param segments The

[GitHub] [kafka] niteshmor commented on pull request #9058: MINOR: Update jackson to latest 2.10.5

niteshmor commented on pull request #9058: URL: https://github.com/apache/kafka/pull/9058#issuecomment-668789671 > Merged to trunk. Is there a reason to backport it to older branches? Thank you. I was under the impression that the older versions are bringing in a vulnerable jackso

[GitHub] [kafka] rhauch commented on pull request #9115: Bump dev version to 2.6.1-SNAPSHOT

rhauch commented on pull request #9115: URL: https://github.com/apache/kafka/pull/9115#issuecomment-668797781 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] hachikuji commented on a change in pull request #9124: MINOR: add additional shutdown log info

hachikuji commented on a change in pull request #9124: URL: https://github.com/apache/kafka/pull/9124#discussion_r465309685 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/Metrics.java ## @@ -673,6 +673,8 @@ public void close() { log.error("

[GitHub] [kafka] mjsax commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

mjsax commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r465324629 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -477,7 +484,7 @@ private boolean checkMe

[GitHub] [kafka] mjsax commented on a change in pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

mjsax commented on a change in pull request #9060: URL: https://github.com/apache/kafka/pull/9060#discussion_r465324629 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -477,7 +484,7 @@ private boolean checkMe

[GitHub] [kafka] dielhennr commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

dielhennr commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r465329379 ## File path: core/src/main/scala/kafka/server/DynamicConfig.scala ## @@ -103,12 +122,25 @@ object DynamicConfig { .define(ProducerByteRateOverride

[GitHub] [kafka] mjsax commented on pull request #9060: KAFKA-9274: Remove `retries` from InternalTopicManager

mjsax commented on pull request #9060: URL: https://github.com/apache/kafka/pull/9060#issuecomment-668826609 @abbccdda I updated the PR. I also realized, that it might be better to throw a `TimeoutException` instead of a `TaskAssignmentException` if we hit the new timeout. Updated the code

[GitHub] [kafka] dielhennr commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

dielhennr commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r465329379 ## File path: core/src/main/scala/kafka/server/DynamicConfig.scala ## @@ -103,12 +122,25 @@ object DynamicConfig { .define(ProducerByteRateOverride

[GitHub] [kafka] dielhennr commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

dielhennr commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r465329379 ## File path: core/src/main/scala/kafka/server/DynamicConfig.scala ## @@ -103,12 +122,25 @@ object DynamicConfig { .define(ProducerByteRateOverride

[GitHub] [kafka] dielhennr commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

dielhennr commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r465329379 ## File path: core/src/main/scala/kafka/server/DynamicConfig.scala ## @@ -103,12 +122,25 @@ object DynamicConfig { .define(ProducerByteRateOverride

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465334577 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/CogroupedKStream.java ## @@ -275,6 +275,15 @@ */ TimeWindowedCogroupedKStrea

[GitHub] [kafka] dielhennr commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

dielhennr commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r465329379 ## File path: core/src/main/scala/kafka/server/DynamicConfig.scala ## @@ -103,12 +122,25 @@ object DynamicConfig { .define(ProducerByteRateOverride

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465336976 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,389 @@ +/* + * Licensed to th

[GitHub] [kafka] dielhennr commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

dielhennr commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r465329379 ## File path: core/src/main/scala/kafka/server/DynamicConfig.scala ## @@ -103,12 +122,25 @@ object DynamicConfig { .define(ProducerByteRateOverride

[GitHub] [kafka] dielhennr commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

dielhennr commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r465329379 ## File path: core/src/main/scala/kafka/server/DynamicConfig.scala ## @@ -103,12 +122,25 @@ object DynamicConfig { .define(ProducerByteRateOverride

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465339322 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,389 @@ +/* + * Licensed to th

[GitHub] [kafka] lct45 commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

lct45 commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465348679 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/SlidingWindowsTest.java ## @@ -0,0 +1,98 @@ +/* + * Licensed to the Apache Software Foun

[GitHub] [kafka] dielhennr commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

dielhennr commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r465351991 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/DynamicConsumerConfig.java ## @@ -0,0 +1,168 @@ +/* + * Licensed to the A

[GitHub] [kafka] dielhennr commented on a change in pull request #9101: KAFKA-10325: KIP-649 implementation

dielhennr commented on a change in pull request #9101: URL: https://github.com/apache/kafka/pull/9101#discussion_r465351991 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/DynamicConsumerConfig.java ## @@ -0,0 +1,168 @@ +/* + * Licensed to the A

[GitHub] [kafka] BackTrak opened a new pull request #9125: KAFKA-10361: Windows batch files that use /bin/windows/kafka-run-class.bat fail with a class path error on fresh installation

BackTrak opened a new pull request #9125: URL: https://github.com/apache/kafka/pull/9125 This contribution is based on public information from https://medium.com/@praveenkumarsingh/confluent-kafka-on-windows-how-to-fix-classpath-is-empty-cf7c31d9c787 I license my version of the wor

[GitHub] [kafka] mjsax opened a new pull request #9126: MINOR: Code cleanup in StreamsResetter

mjsax opened a new pull request #9126: URL: https://github.com/apache/kafka/pull/9126 Call for review @guozhangwang @abbccdda This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] ableegoldman commented on a change in pull request #8976: KIP-617: Allow Kafka Streams State Stores to be iterated backwards

ableegoldman commented on a change in pull request #8976: URL: https://github.com/apache/kafka/pull/8976#discussion_r462687337 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractReadOnlyDecorator.java ## @@ -177,17 +197,36 @@ public V fetc

[GitHub] [kafka] mjsax opened a new pull request #9127: MINOR: fix HTML

mjsax opened a new pull request #9127: URL: https://github.com/apache/kafka/pull/9127 Call for review @abbccdda @guozhangwang This should go to 2.6 and I will also do a PR for kafka-site if necessary This is an automa

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r465367407 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -1214,6 +1215,60 @@ default AlterClientQuotasResult alterClientQuotas(C

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r465369550 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/ScramMechanism.java ## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465369865 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java ## @@ -132,16 +135,19 @@

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465369865 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java ## @@ -132,16 +135,19 @@

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r465370586 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -980,4 +984,137 @@ class AdminManager(val config: KafkaConfig, entry.entity -

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465371635 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/CogroupedKStream.java ## @@ -275,6 +275,15 @@ */ TimeWindowedCogroupe

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465374004 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,389 @@ +/* + * License

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r465374092 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4071,6 +4081,168 @@ void handleFailure(Throwable throwable)

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465374004 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,389 @@ +/* + * License

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r465374713 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4071,6 +4081,168 @@ void handleFailure(Throwable throwable)

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r465377717 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -365,45 +368,90 @@ object ConfigCommand extends Config { adminClient.increm

[GitHub] [kafka] rhauch commented on pull request #9116: KAFKA-10341: Add 2.6.0 to system tests and streams upgrade tests

rhauch commented on pull request #9116: URL: https://github.com/apache/kafka/pull/9116#issuecomment-668868661 The [second run|https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4088] with all of the system tests had [two failures|http://confluent-kafka-branch-builder-system

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r465378122 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -365,45 +368,90 @@ object ConfigCommand extends Config { adminClient.increm

[GitHub] [kafka] rhauch merged pull request #9116: KAFKA-10341: Add 2.6.0 to system tests and streams upgrade tests

rhauch merged pull request #9116: URL: https://github.com/apache/kafka/pull/9116 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] rhauch commented on pull request #9115: Bump dev version to 2.6.1-SNAPSHOT

rhauch commented on pull request #9115: URL: https://github.com/apache/kafka/pull/9115#issuecomment-668869786 The JDK 11 and 14 builds didn't seem to run (IIUC reported on other branches and PRs, too). However, none of these are really impacted by this change of the version number. -

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465379071 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java ## @@ -132,16 +135,19 @@

[GitHub] [kafka] rhauch merged pull request #9115: Bump dev version to 2.6.1-SNAPSHOT

rhauch merged pull request #9115: URL: https://github.com/apache/kafka/pull/9115 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465379566 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregate.java ## @@ -0,0 +1,389 @@ +/* + * License

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465380753 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java ## @@ -459,6 +460,95 @@ public void sh

[GitHub] [kafka] mjsax commented on pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

mjsax commented on pull request #9120: URL: https://github.com/apache/kafka/pull/9120#issuecomment-668872505 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on a change in pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

mjsax commented on a change in pull request #9120: URL: https://github.com/apache/kafka/pull/9120#discussion_r465380798 ## File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java ## @@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, f

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465380753 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java ## @@ -459,6 +460,95 @@ public void sh

[GitHub] [kafka] mjsax commented on pull request #9120: KAFKA-10316: Consider renaming getter method for Interactive Queries

mjsax commented on pull request #9120: URL: https://github.com/apache/kafka/pull/9120#issuecomment-668872593 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] junrao commented on a change in pull request #9114: KAFKA-10162; Use Token Bucket algorithm for controller mutation quota (KIP-599, Part III)

junrao commented on a change in pull request #9114: URL: https://github.com/apache/kafka/pull/9114#discussion_r465310710 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/stats/TokenBucket.java ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Found

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465382189 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/SlidingWindows.java ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] ableegoldman commented on a change in pull request #9039: KAFKA-5636: SlidingWindows (KIP-450)

ableegoldman commented on a change in pull request #9039: URL: https://github.com/apache/kafka/pull/9039#discussion_r465382663 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/SlidingWindows.java ## @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cmccabe commented on a change in pull request #9032: KAFKA-10259: KIP-554 Broker-side SCRAM Config API

cmccabe commented on a change in pull request #9032: URL: https://github.com/apache/kafka/pull/9032#discussion_r465393358 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -980,4 +984,137 @@ class AdminManager(val config: KafkaConfig, entry.entity -

[GitHub] [kafka] ableegoldman commented on a change in pull request #8976: KIP-617: Allow Kafka Streams State Stores to be iterated backwards

ableegoldman commented on a change in pull request #8976: URL: https://github.com/apache/kafka/pull/8976#discussion_r462688575 ## File path: streams/src/main/java/org/apache/kafka/streams/state/ReadOnlyWindowStore.java ## @@ -136,34 +176,65 @@ * * This iterator mu

[GitHub] [kafka] ableegoldman edited a comment on pull request #8976: KIP-617: Allow Kafka Streams State Stores to be iterated backwards

ableegoldman edited a comment on pull request #8976: URL: https://github.com/apache/kafka/pull/8976#issuecomment-668928094 > split this up into three separate PRs, one for each type of store Feel free to start with the WindowStore PR, by the way. I just noticed that was the only stor

[GitHub] [kafka] ableegoldman commented on pull request #8976: KIP-617: Allow Kafka Streams State Stores to be iterated backwards

ableegoldman commented on pull request #8976: URL: https://github.com/apache/kafka/pull/8976#issuecomment-668928094 > split this up into three separate PRs, one for each type of store Feel free to start with the WindowStore PR, by the way. I just noticed that was the only store liste

[GitHub] [kafka] chia7712 commented on pull request #8513: MINOR: jackson 2.10.3

chia7712 commented on pull request #8513: URL: https://github.com/apache/kafka/pull/8513#issuecomment-668948573 Jackson is upgrade to 2.10.5 (see https://github.com/apache/kafka/commit/fcfb71cd500403ddc318a5fec7c48ee23c18f390) --

[GitHub] [kafka] showuon commented on pull request #9121: KAFKA-10351: add tests for IOExceptions for GlobalStateManagerImpl/OffsetCheckpoint

showuon commented on pull request #9121: URL: https://github.com/apache/kafka/pull/9121#issuecomment-668954076 **JDK11: failed with system failure** * What went wrong: 03:15:27 Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed) **JDK14: 2

[GitHub] [kafka] showuon commented on pull request #9062: KAFKA-8098: fix the flaky test by disabling the auto commit to avoid member rejoining

showuon commented on pull request #9062: URL: https://github.com/apache/kafka/pull/9062#issuecomment-668959309 @feyman2016 @huxihx @abbccdda , since you have experience in this test before, could you help review this PR? Thanks. ---

<    1   2   3   4   5   6   7   8   9   10   >