dielhennr commented on a change in pull request #9101:
URL: https://github.com/apache/kafka/pull/9101#discussion_r465329379
##########
File path: core/src/main/scala/kafka/server/DynamicConfig.scala
##########
@@ -103,12 +122,25 @@ object DynamicConfig {
.define(ProducerByteRateOverrideProp, LONG, DefaultProducerOverride,
MEDIUM, ProducerOverrideDoc)
.define(ConsumerByteRateOverrideProp, LONG, DefaultConsumerOverride,
MEDIUM, ConsumerOverrideDoc)
.define(RequestPercentageOverrideProp, DOUBLE, DefaultRequestOverride,
MEDIUM, RequestOverrideDoc)
+ .define(AcksOverrideProp, STRING, DefaultAcksOverride,
ConfigDef.ValidString.in("all", "-1", "0", "1"), HIGH, AcksOverrideDoc)
+ .define(
+ SessionTimeoutOverrideProp,
+ INT,
+ DefaultSessionTimeoutOverride,
+ ConfigDef.Range.between(Defaults.GroupMinSessionTimeoutMs,
Defaults.GroupMaxSessionTimeoutMs),
+ HIGH,
+ SessionTimeoutOverrideDoc)
+ .define(HeartbeatIntervalOverrideProp, INT,
DefaultHeartbeatIntervalOverride, HIGH, HeartbeatIntervalOverrideDoc)
Review comment:
This prevents key-value pairs that the broker knows are invalid from
being persisted to zookeeper e.g. acks=2.
The client will still have to validate them against the user-provided client
configs. For example, if the dynamic config is acks=1 but the user enabled
idempotence the dynamic config should be ignored by the client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
