brary commented on a change in pull request #9120:
URL: https://github.com/apache/kafka/pull/9120#discussion_r465201600
##########
File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java
##########
@@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, final
Set<HostInfo> standbyHo
}
/**
- * Get the Active streams instance for given key
+ * Get the active Kafka Streams instance for given key.
*
* @return active instance's {@link HostInfo}
+ * @deprecated Use {@link #activeHost()} instead.
*/
+ @Deprecated
public HostInfo getActiveHost() {
return activeHost;
}
/**
- * Get the Streams instances that host the key as standbys
+ * Get the Kafka Streams instances that host the key as standbys.
*
* @return set of standby {@link HostInfo} or a empty set, if no standbys
are configured
+ * @deprecated Use {@link #standbyHosts()} instead.
*/
+ @Deprecated
public Set<HostInfo> getStandbyHosts() {
return standbyHosts;
}
/**
- * Get the Store partition corresponding to the key.
+ * Get the store partition corresponding to the key.
*
* @return store partition number
+ * @deprecated Use {@link #partition()} instead.
*/
+ @Deprecated
public int getPartition() {
return partition;
}
+ /**
+ * Get the active Kafka Streams instance for given key.
+ *
+ * @return active instance's {@link HostInfo}
+ */
+ public HostInfo activeHost() {
+ return activeHost;
+ }
+
+ /**
+ * Get the Kafka Streams instances that host the key as standbys.
+ *
+ * @return set of standby {@link HostInfo} or a empty set, if no standbys
are configured
+ */
+ public Set<HostInfo> standbyHosts() {
+ return standbyHosts;
+ }
+
+ /**
+ * Get the store partition corresponding to the key.
+ *
+ * @return store partition number
Review comment:
I wrote the old getters & javadocs but now I feel that key partition
number better conveys the meaning than store partition number.
The class KeyQueryMetadata contains the information for a key being
requested via query. So, the partition number we are returning here is the
partition to which the key belongs, it has no relation to any store yet. You
will of course use this partition information to fetch the data corresponding
to the key from any store but still that doesn't change the fact that this
partition number is related to the key rather than the store.
I am fine either way though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
