brary commented on a change in pull request #9120:
URL: https://github.com/apache/kafka/pull/9120#discussion_r465176121
##########
File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java
##########
@@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, final
Set<HostInfo> standbyHo
}
/**
- * Get the Active streams instance for given key
+ * Get the active Kafka Streams instance for given key.
*
* @return active instance's {@link HostInfo}
+ * @deprecated Use {@link #activeHost()} instead.
*/
+ @Deprecated
public HostInfo getActiveHost() {
return activeHost;
}
/**
- * Get the Streams instances that host the key as standbys
+ * Get the Kafka Streams instances that host the key as standbys.
*
* @return set of standby {@link HostInfo} or a empty set, if no standbys
are configured
+ * @deprecated Use {@link #standbyHosts()} instead.
*/
+ @Deprecated
public Set<HostInfo> getStandbyHosts() {
return standbyHosts;
}
/**
- * Get the Store partition corresponding to the key.
+ * Get the store partition corresponding to the key.
*
* @return store partition number
+ * @deprecated Use {@link #partition()} instead.
*/
+ @Deprecated
public int getPartition() {
return partition;
}
+ /**
+ * Get the active Kafka Streams instance for given key.
+ *
+ * @return active instance's {@link HostInfo}
+ */
+ public HostInfo activeHost() {
+ return activeHost;
+ }
+
+ /**
+ * Get the Kafka Streams instances that host the key as standbys.
+ *
+ * @return set of standby {@link HostInfo} or a empty set, if no standbys
are configured
+ */
+ public Set<HostInfo> standbyHosts() {
+ return standbyHosts;
+ }
+
+ /**
+ * Get the store partition corresponding to the key.
Review comment:
Get the partition number corresponding to the key.
##########
File path: streams/src/main/java/org/apache/kafka/streams/KeyQueryMetadata.java
##########
@@ -50,32 +50,65 @@ public KeyQueryMetadata(final HostInfo activeHost, final
Set<HostInfo> standbyHo
}
/**
- * Get the Active streams instance for given key
+ * Get the active Kafka Streams instance for given key.
*
* @return active instance's {@link HostInfo}
+ * @deprecated Use {@link #activeHost()} instead.
*/
+ @Deprecated
public HostInfo getActiveHost() {
return activeHost;
}
/**
- * Get the Streams instances that host the key as standbys
+ * Get the Kafka Streams instances that host the key as standbys.
*
* @return set of standby {@link HostInfo} or a empty set, if no standbys
are configured
+ * @deprecated Use {@link #standbyHosts()} instead.
*/
+ @Deprecated
public Set<HostInfo> getStandbyHosts() {
return standbyHosts;
}
/**
- * Get the Store partition corresponding to the key.
+ * Get the store partition corresponding to the key.
*
* @return store partition number
+ * @deprecated Use {@link #partition()} instead.
*/
+ @Deprecated
public int getPartition() {
return partition;
}
+ /**
+ * Get the active Kafka Streams instance for given key.
+ *
+ * @return active instance's {@link HostInfo}
+ */
+ public HostInfo activeHost() {
+ return activeHost;
+ }
+
+ /**
+ * Get the Kafka Streams instances that host the key as standbys.
+ *
+ * @return set of standby {@link HostInfo} or a empty set, if no standbys
are configured
+ */
+ public Set<HostInfo> standbyHosts() {
+ return standbyHosts;
+ }
+
+ /**
+ * Get the store partition corresponding to the key.
+ *
+ * @return store partition number
Review comment:
I feel it should be "key partition number" instead of store.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
