[jira] [Commented] (KAFKA-18068) Fixing typo in ProducerConfig

2025-05-08 Thread Ming-Yen Chung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950224#comment-17950224 ] Ming-Yen Chung commented on KAFKA-18068: [~chia7712] I’ve checked the other conf

Re: [PR] KAFKA-19042: [8/N] Move BaseConsumerTest, SaslPlainPlaintextConsumerTest to client-integration-tests module [kafka]

2025-05-08 Thread via GitHub
frankvicky commented on code in PR #19651: URL: https://github.com/apache/kafka/pull/19651#discussion_r2079140399 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/BaseConsumerTest.java: ## @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Softw

[jira] [Assigned] (KAFKA-19229) fix flaky testShareGroupDescribeWithGroupDescribeAndTopicDescribeAcl and testShareGroupDescribeWithoutGroupDescribeAcl

2025-05-08 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal reassigned KAFKA-19229: - Assignee: Shivsundar R (was: Chia-Ping Tsai) > fix flaky testShareGroupDescribeWithGro

Re: [PR] KAFKA-18904: [1/N] Change ListClientMetricsResources API to ListConfigResources [kafka]

2025-05-08 Thread via GitHub
AndrewJSchofield commented on code in PR #19493: URL: https://github.com/apache/kafka/pull/19493#discussion_r2079364838 ## clients/src/main/resources/common/message/ListConfigResourcesResponse.json: ## @@ -16,18 +16,22 @@ { "apiKey": 74, "type": "response", - "name": "Li

[jira] [Assigned] (KAFKA-19251) Resolve the flaky test ShareConsumerTest.testMultipleConsumersInGroupConcurrentConsumption

2025-05-08 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-19251: Assignee: Shivsundar R > Resolve the flaky test > ShareConsumerTest.testMultiple

Re: [PR] KAFKA-19042: [8/N] Move BaseConsumerTest, SaslPlainPlaintextConsumerTest to client-integration-tests module [kafka]

2025-05-08 Thread via GitHub
m1a2st commented on code in PR #19651: URL: https://github.com/apache/kafka/pull/19651#discussion_r2079548501 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/BaseConsumerTest.java: ## @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software

[PR] KAFKA-19253: Improve metadata version handling for share version using feature listeners (1/N) [kafka]

2025-05-08 Thread via GitHub
adixitconfluent opened a new pull request, #19659: URL: https://github.com/apache/kafka/pull/19659 ### About This PR creates a listener for `SharePartitionManager` to listen to any changes in `ShareVersion` feature. In case, there is a toggle, we need to change the attributes in `SharePa

[jira] [Updated] (KAFKA-19253) Improve metadata version handling for share version using feature listeners

2025-05-08 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit updated KAFKA-19253: -- Summary: Improve metadata version handling for share version using feature listeners (was: Im

Re: [PR] KAFKA-18115; Fix for loading big files while performing load tests [kafka]

2025-05-08 Thread via GitHub
manoj-mathivanan commented on code in PR #18391: URL: https://github.com/apache/kafka/pull/18391#discussion_r2079045692 ## tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java: ## @@ -194,9 +195,16 @@ static List readPayloadFile(String payloadFilePath, String pay

Re: [PR] KAFKA-18115; Fix for loading big files while performing load tests [kafka]

2025-05-08 Thread via GitHub
manoj-mathivanan commented on code in PR #18391: URL: https://github.com/apache/kafka/pull/18391#discussion_r2079048431 ## tools/src/test/java/org/apache/kafka/tools/ProducerPerformanceTest.java: ## @@ -104,6 +104,20 @@ public void testReadProps() throws Exception { Uti

Re: [PR] KAFKA-18115; Fix for loading big files while performing load tests [kafka]

2025-05-08 Thread via GitHub
manoj-mathivanan commented on code in PR #18391: URL: https://github.com/apache/kafka/pull/18391#discussion_r2079045692 ## tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java: ## @@ -194,9 +195,16 @@ static List readPayloadFile(String payloadFilePath, String pay

[jira] [Updated] (KAFKA-19253) Improve metadata handling for share version using feature listeners

2025-05-08 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit updated KAFKA-19253: -- Summary: Improve metadata handling for share version using feature listeners (was: Improve me

Re: [PR] KAFKA-19087: Move TransactionState to transaction-coordinator module [kafka]

2025-05-08 Thread via GitHub
chia7712 merged PR #19568: URL: https://github.com/apache/kafka/pull/19568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-19087) Move TransactionState to transaction-coordinator module

2025-05-08 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19087?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-19087. Fix Version/s: 4.1.0 Resolution: Fixed > Move TransactionState to transaction-coord

Re: [PR] MINOR: Simplify OffsetFetchResponse [kafka]

2025-05-08 Thread via GitHub
dajac merged PR #19642: URL: https://github.com/apache/kafka/pull/19642 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-19042: [8/N] Move BaseConsumerTest, SaslPlainPlaintextConsumerTest to client-integration-tests module [kafka]

2025-05-08 Thread via GitHub
FrankYang0529 commented on code in PR #19651: URL: https://github.com/apache/kafka/pull/19651#discussion_r2079722269 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/SaslPlainPlaintextConsumerTest.java: ## @@ -0,0 +1,157 @@ +/* + * Licensed to

Re: [PR] KAFKA-19242: Fix commit bugs caused by race condition during rebalancing. [kafka]

2025-05-08 Thread via GitHub
chickenchickenlove commented on PR #19631: URL: https://github.com/apache/kafka/pull/19631#issuecomment-2862961842 @dajac , @m1a2st gently ping. 🙇‍♂️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-17645: KIP-1052: Enable warmup in producer performance test [kafka]

2025-05-08 Thread via GitHub
matt-welch commented on PR #17340: URL: https://github.com/apache/kafka/pull/17340#issuecomment-2863404217 @chia7712 @kirktrue I think I've addressed the issues raised, but does anyone have any more input on this patch? -- This is an automated message from the Apache Git Service. To res

Re: [PR] KAFKA-17648: AsyncKafkaConsumer#unsubscribe swallow TopicAuthorizationException and GroupAuthorizationException [kafka]

2025-05-08 Thread via GitHub
lianetm commented on code in PR #17516: URL: https://github.com/apache/kafka/pull/17516#discussion_r1824955585 ## core/src/test/scala/integration/kafka/api/GroupAuthorizerIntegrationTest.scala: ## @@ -124,12 +128,56 @@ class GroupAuthorizerIntegrationTest extends BaseRequestTes

[jira] [Commented] (KAFKA-19209) "index.interval.bytes" config doc should also mention time index

2025-05-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950312#comment-17950312 ] ASF GitHub Bot commented on KAFKA-19209: shmily7829 commented on code in PR #686

Re: [PR] KAFKA-18695: Remove quorum=kraft from all integration tests [kafka]

2025-05-08 Thread via GitHub
chia7712 commented on code in PR #19633: URL: https://github.com/apache/kafka/pull/19633#discussion_r2080055283 ## core/src/test/scala/unit/kafka/security/authorizer/AuthorizerTest.scala: ## @@ -204,9 +196,8 @@ class AuthorizerTest extends QuorumTestHarness with BaseAuthorizerT

Re: [PR] KAFKA-19220: Add tests to ensure the internal configs don't return by public APIs by default [kafka]

2025-05-08 Thread via GitHub
chia7712 commented on code in PR #19650: URL: https://github.com/apache/kafka/pull/19650#discussion_r2080071682 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/StaticBrokerConfigTest.java: ## @@ -108,4 +119,68 @@ public void testTopicConfigsGet

Re: [PR] KAFKA-19229: Ignore background errors while closing share consumers. (Fix flaky test) [kafka]

2025-05-08 Thread via GitHub
ShivsundarR commented on code in PR #19647: URL: https://github.com/apache/kafka/pull/19647#discussion_r2080076709 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -1017,8 +1017,12 @@ private void maybeThrowInvalidGroupIdExceptio

Re: [PR] KAFKA-19229: Ignore background errors while closing share consumers. (Fix flaky test) [kafka]

2025-05-08 Thread via GitHub
AndrewJSchofield commented on code in PR #19647: URL: https://github.com/apache/kafka/pull/19647#discussion_r2080085111 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImplTest.java: ## @@ -672,6 +673,33 @@ public void testEnsurePollEventSentOnC

[PR] MINOR; Remove cast for Records' slice [kafka]

2025-05-08 Thread via GitHub
jsancio opened a new pull request, #19661: URL: https://github.com/apache/kafka/pull/19661 In Java return types are covariant. This means that method override can override the return type with a subclass. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] KAFKA-18695: Remove quorum=kraft from all integration tests [kafka]

2025-05-08 Thread via GitHub
chia7712 commented on code in PR #19633: URL: https://github.com/apache/kafka/pull/19633#discussion_r2080061056 ## core/src/test/scala/unit/kafka/server/AddPartitionsToTxnRequestServerTest.scala: ## @@ -32,9 +32,9 @@ import org.apache.kafka.common.requests.FindCoordinatorReques

[PR] MINOR: Move TxnTransitMetadata to transaction-coordinator [kafka]

2025-05-08 Thread via GitHub
yunchipang opened a new pull request, #19662: URL: https://github.com/apache/kafka/pull/19662 Migrates the `TxnTransitMetadata` class from scala to java, moving it from to the `transaction-coordinator` module. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-18836 Make ConsumerGroupMetadata an interface [kafka]

2025-05-08 Thread via GitHub
pszymczyk commented on PR #18977: URL: https://github.com/apache/kafka/pull/18977#issuecomment-2863730801 @mjsax can we merge this and release in 4.1.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-19229: Ignore background errors while closing share consumers. (Fix flaky test) [kafka]

2025-05-08 Thread via GitHub
ShivsundarR commented on code in PR #19647: URL: https://github.com/apache/kafka/pull/19647#discussion_r2080104203 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImplTest.java: ## @@ -672,6 +673,33 @@ public void testEnsurePollEventSentOnConsum

Re: [PR] KAFKA-19145: Move LeaderEndPoint to Server module [kafka]

2025-05-08 Thread via GitHub
chia7712 commented on code in PR #19630: URL: https://github.com/apache/kafka/pull/19630#discussion_r2080096579 ## core/src/main/scala/kafka/server/LocalLeaderEndPoint.scala: ## @@ -134,8 +135,9 @@ class LocalLeaderEndPoint(sourceBroker: BrokerEndPoint, new OffsetAndEpoch(l

Re: [PR] KAFKA-19234: broker should return UNAUTHORIZATION error for non-existing topic in produce request [kafka]

2025-05-08 Thread via GitHub
FrankYang0529 commented on code in PR #19635: URL: https://github.com/apache/kafka/pull/19635#discussion_r2079614303 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -411,10 +411,8 @@ class KafkaApis(val requestChannel: RequestChannel, } val topicPa

Re: [PR] KAFKA-18115; Fix for loading big files while performing load tests [kafka]

2025-05-08 Thread via GitHub
manoj-mathivanan commented on code in PR #18391: URL: https://github.com/apache/kafka/pull/18391#discussion_r2079247045 ## tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java: ## @@ -194,9 +195,16 @@ static List readPayloadFile(String payloadFilePath, String pay

Re: [PR] KAFKA-19229: Ignore background errors while closing share consumers. (Fix flaky test) [kafka]

2025-05-08 Thread via GitHub
lianetm commented on code in PR #19647: URL: https://github.com/apache/kafka/pull/19647#discussion_r2079983666 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -1017,8 +1017,12 @@ private void maybeThrowInvalidGroupIdException()

Re: [PR] KAFKA-19182: Move SchedulerTest to server module [kafka]

2025-05-08 Thread via GitHub
chia7712 commented on PR #19608: URL: https://github.com/apache/kafka/pull/19608#issuecomment-2863571986 @UladzislauBlok thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-19182: Move SchedulerTest to server module [kafka]

2025-05-08 Thread via GitHub
chia7712 merged PR #19608: URL: https://github.com/apache/kafka/pull/19608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-17897: Deprecate Admin.listConsumerGroups [2/N] [kafka]

2025-05-08 Thread via GitHub
chia7712 commented on code in PR #19508: URL: https://github.com/apache/kafka/pull/19508#discussion_r2080185161 ## clients/src/main/java/org/apache/kafka/common/requests/ListGroupsRequest.java: ## @@ -50,8 +53,19 @@ public ListGroupsRequest build(short version) {

Re: [PR] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-05-08 Thread via GitHub
JimmyWang6 commented on code in PR #18929: URL: https://github.com/apache/kafka/pull/18929#discussion_r2080200800 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3620,7 +3620,50 @@ class KafkaApis(val requestChannel: RequestChannel, def handleAlterShareGroupOffs

Re: [PR] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-05-08 Thread via GitHub
JimmyWang6 commented on code in PR #18929: URL: https://github.com/apache/kafka/pull/18929#discussion_r2080201451 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -662,6 +665,34 @@ public void run() { )); }

Re: [PR] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-05-08 Thread via GitHub
JimmyWang6 commented on code in PR #18929: URL: https://github.com/apache/kafka/pull/18929#discussion_r2080201974 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1172,6 +1203,37 @@ public CompletableFuture> shareGroupDe

Re: [PR] MINOR: remove xijiu from asf.yaml in order to resend invitation [kafka]

2025-05-08 Thread via GitHub
chia7712 commented on PR #19660: URL: https://github.com/apache/kafka/pull/19660#issuecomment-2863861001 the failed test is traced by https://issues.apache.org/jira/browse/KAFKA-19217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] MINOR: remove xijiu from asf.yaml in order to resend invitation [kafka]

2025-05-08 Thread via GitHub
chia7712 merged PR #19660: URL: https://github.com/apache/kafka/pull/19660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-05-08 Thread via GitHub
JimmyWang6 commented on code in PR #18929: URL: https://github.com/apache/kafka/pull/18929#discussion_r2080211861 ## clients/src/main/java/org/apache/kafka/common/requests/AlterShareGroupOffsetsResponse.java: ## @@ -63,4 +66,44 @@ public static AlterShareGroupOffsetsResponse par

Re: [PR] KAFKA-19234: broker should return UNAUTHORIZATION error for non-existing topic in produce request [kafka]

2025-05-08 Thread via GitHub
junrao commented on code in PR #19635: URL: https://github.com/apache/kafka/pull/19635#discussion_r2080213276 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -838,11 +838,11 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerIntegra

[jira] [Updated] (KAFKA-18666) Controller-side monitoring for broker shutdown and startup

2025-05-08 Thread Kevin Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Wu updated KAFKA-18666: - Fix Version/s: 4.1.0 > Controller-side monitoring for broker shutdown and startup >

[jira] [Updated] (KAFKA-19254) Add generic feature level metric

2025-05-08 Thread Kevin Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Wu updated KAFKA-19254: - Fix Version/s: 4.1.0 > Add generic feature level metric > > >

[jira] [Updated] (KAFKA-19255) KRaft request manager should support one in-flight request per request type

2025-05-08 Thread Kevin Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19255?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Wu updated KAFKA-19255: - Fix Version/s: 4.1.0 > KRaft request manager should support one in-flight request per request type > ---

[jira] [Assigned] (KAFKA-18536) Flaky ReplicationQuotasTest.shouldBootstrapTwoBrokersWithFollowerThrottle

2025-05-08 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uladzislau Blok reassigned KAFKA-18536: --- Assignee: Uladzislau Blok > Flaky ReplicationQuotasTest.shouldBootstrapTwoBrokersWi

[jira] [Assigned] (KAFKA-18535) Flaky PlaintextConsumerPollTest.testMaxPollIntervalMsDelayInRevocation

2025-05-08 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uladzislau Blok reassigned KAFKA-18535: --- Assignee: Uladzislau Blok > Flaky PlaintextConsumerPollTest.testMaxPollIntervalMsDe

[jira] [Created] (KAFKA-19255) KRaft request manager should support one in-flight request per request type

2025-05-08 Thread Kevin Wu (Jira)
Kevin Wu created KAFKA-19255: Summary: KRaft request manager should support one in-flight request per request type Key: KAFKA-19255 URL: https://issues.apache.org/jira/browse/KAFKA-19255 Project: Kafka

Re: [PR] KAFKA-19091: Fix race condition in DelayedFutureTest [kafka]

2025-05-08 Thread via GitHub
UladzislauBlok commented on PR #19553: URL: https://github.com/apache/kafka/pull/19553#issuecomment-2864026084 @FrankYang0529 Hey. Can we merge it if all are good? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-05-08 Thread via GitHub
JimmyWang6 commented on code in PR #18929: URL: https://github.com/apache/kafka/pull/18929#discussion_r2080231131 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorShard.java: ## @@ -785,6 +787,38 @@ public CoordinatorResult );

Re: [PR] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-05-08 Thread via GitHub
JimmyWang6 commented on code in PR #18929: URL: https://github.com/apache/kafka/pull/18929#discussion_r2080230356 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -662,6 +665,34 @@ public void run() { )); }

Re: [PR] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-05-08 Thread via GitHub
JimmyWang6 commented on code in PR #18929: URL: https://github.com/apache/kafka/pull/18929#discussion_r2080211861 ## clients/src/main/java/org/apache/kafka/common/requests/AlterShareGroupOffsetsResponse.java: ## @@ -63,4 +66,44 @@ public static AlterShareGroupOffsetsResponse par

Re: [PR] MINOR; Remove cast for Records' slice [kafka]

2025-05-08 Thread via GitHub
chia7712 commented on PR #19661: URL: https://github.com/apache/kafka/pull/19661#issuecomment-2863943453 @jsancio there is a discussion before - see https://github.com/apache/kafka/pull/19581#discussion_r2063755306 -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] KAFKA-18847: Refactor OAuth layer to improve reusability 1/N [kafka]

2025-05-08 Thread via GitHub
omkreddy commented on code in PR #19622: URL: https://github.com/apache/kafka/pull/19622#discussion_r2080166544 ## clients/src/main/java/org/apache/kafka/common/security/oauthbearer/OAuthBearerLoginCallbackHandler.java: ## @@ -179,28 +180,34 @@ public class OAuthBearerLoginCallb

Re: [PR] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-05-08 Thread via GitHub
JimmyWang6 commented on PR #18929: URL: https://github.com/apache/kafka/pull/18929#issuecomment-2863806958 @smjn Thanks for your comments. I will start to handle the test these days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] KAFKA-19042: [8/N] Move BaseConsumerTest, SaslPlainPlaintextConsumerTest to client-integration-tests module [kafka]

2025-05-08 Thread via GitHub
frankvicky commented on code in PR #19651: URL: https://github.com/apache/kafka/pull/19651#discussion_r2080199141 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/BaseConsumerTest.java: ## @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Softw

Re: [PR] MINOR: add xijiu from asf.yaml in order to resend invitation [kafka]

2025-05-08 Thread via GitHub
chia7712 commented on PR #19663: URL: https://github.com/apache/kafka/pull/19663#issuecomment-2863871553 related to #19508 19660 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[jira] [Assigned] (KAFKA-18475) Flaky PlaintextProducerSendTest testCloseWithZeroTimeoutFromCallerThread

2025-05-08 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uladzislau Blok reassigned KAFKA-18475: --- Assignee: Uladzislau Blok > Flaky PlaintextProducerSendTest testCloseWithZeroTimeou

Re: [PR] KAFKA-19209: Clarify index.interval.bytes impact on offset and time index [kafka]

2025-05-08 Thread via GitHub
showuon merged PR #19657: URL: https://github.com/apache/kafka/pull/19657 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-19042: [8/N] Move BaseConsumerTest, SaslPlainPlaintextConsumerTest to client-integration-tests module [kafka]

2025-05-08 Thread via GitHub
frankvicky commented on code in PR #19651: URL: https://github.com/apache/kafka/pull/19651#discussion_r2080748529 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/BaseConsumerTest.java: ## @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Softw

Re: [PR] KAFKA-19145: Move LeaderEndPoint to Server module [kafka]

2025-05-08 Thread via GitHub
YutaLin commented on code in PR #19630: URL: https://github.com/apache/kafka/pull/19630#discussion_r2080751252 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -151,14 +158,17 @@ abstract class AbstractFetcherThread(name: String, partitionStates.part

[jira] [Resolved] (KAFKA-19209) "index.interval.bytes" config doc should also mention time index

2025-05-08 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-19209. --- Fix Version/s: 4.1.0 Resolution: Fixed > "index.interval.bytes" config doc should also mentio

Re: [PR] KAFKA-19145: Move LeaderEndPoint to Server module [kafka]

2025-05-08 Thread via GitHub
YutaLin commented on code in PR #19630: URL: https://github.com/apache/kafka/pull/19630#discussion_r2080869119 ## core/src/main/scala/kafka/server/LocalLeaderEndPoint.scala: ## @@ -134,8 +135,9 @@ class LocalLeaderEndPoint(sourceBroker: BrokerEndPoint, new OffsetAndEpoch(lo

Re: [PR] KAFKA-19145: Move LeaderEndPoint to Server module [kafka]

2025-05-08 Thread via GitHub
YutaLin commented on code in PR #19630: URL: https://github.com/apache/kafka/pull/19630#discussion_r2080868631 ## core/src/main/scala/kafka/server/LocalLeaderEndPoint.scala: ## @@ -156,48 +158,50 @@ class LocalLeaderEndPoint(sourceBroker: BrokerEndPoint, .setPartiti

Re: [PR] KAFKA-19042: [8/N] Move BaseConsumerTest, SaslPlainPlaintextConsumerTest to client-integration-tests module [kafka]

2025-05-08 Thread via GitHub
m1a2st commented on code in PR #19651: URL: https://github.com/apache/kafka/pull/19651#discussion_r2080919129 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/BaseConsumerTest.java: ## @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-17897: Deprecate Admin.listConsumerGroups [2/N] [kafka]

2025-05-08 Thread via GitHub
AndrewJSchofield commented on code in PR #19508: URL: https://github.com/apache/kafka/pull/19508#discussion_r2080499100 ## clients/src/main/java/org/apache/kafka/common/requests/ListGroupsRequest.java: ## @@ -50,8 +53,19 @@ public ListGroupsRequest build(short version) {

Re: [PR] KAFKA-19145: Move LeaderEndPoint to Server module [kafka]

2025-05-08 Thread via GitHub
YutaLin commented on code in PR #19630: URL: https://github.com/apache/kafka/pull/19630#discussion_r2080656237 ## core/src/main/scala/kafka/server/RemoteLeaderEndPoint.scala: ## @@ -126,14 +128,15 @@ class RemoteLeaderEndPoint(logPrefix: String, } } - override def fet

Re: [PR] KAFKA-19220: Add tests to ensure the internal configs don't return by public APIs by default [kafka]

2025-05-08 Thread via GitHub
TaiJuWu commented on code in PR #19650: URL: https://github.com/apache/kafka/pull/19650#discussion_r2080977162 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/StaticBrokerConfigTest.java: ## @@ -108,4 +119,80 @@ public void testTopicConfigsGetI

Re: [PR] KAFKA-19220: Add tests to ensure the internal configs don't return by public APIs by default [kafka]

2025-05-08 Thread via GitHub
TaiJuWu commented on code in PR #19650: URL: https://github.com/apache/kafka/pull/19650#discussion_r2080977162 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/StaticBrokerConfigTest.java: ## @@ -108,4 +119,80 @@ public void testTopicConfigsGetI

Re: [PR] KAFKA-16717 [2/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-05-08 Thread via GitHub
JimmyWang6 commented on code in PR #18929: URL: https://github.com/apache/kafka/pull/18929#discussion_r2080201974 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1172,6 +1203,37 @@ public CompletableFuture> shareGroupDe

[jira] [Updated] (KAFKA-19078) Implement automatic controller addition to cluster metadata partition

2025-05-08 Thread Kevin Wu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Wu updated KAFKA-19078: - Fix Version/s: 4.1.0 > Implement automatic controller addition to cluster metadata partition > -

[jira] [Created] (KAFKA-19256) Only send IQ information on assignment changes

2025-05-08 Thread Bill Bejeck (Jira)
Bill Bejeck created KAFKA-19256: --- Summary: Only send IQ information on assignment changes Key: KAFKA-19256 URL: https://issues.apache.org/jira/browse/KAFKA-19256 Project: Kafka Issue Type: Sub-

Re: [PR] MINOR; Remove cast for Records' slice [kafka]

2025-05-08 Thread via GitHub
jsancio commented on PR #19661: URL: https://github.com/apache/kafka/pull/19661#issuecomment-2864168205 > @jsancio : Thanks for the PR. Since this usage of covariant is idiomatic in java, the change looks good to me. Could you revert some of the other unnecessary casting introduced in [7eb

Re: [PR] MINOR; Remove cast for Records' slice [kafka]

2025-05-08 Thread via GitHub
jsancio commented on PR #19661: URL: https://github.com/apache/kafka/pull/19661#issuecomment-2864183725 > @jsancio there is a discussion before - see [#19581 (comment)](https://github.com/apache/kafka/pull/19581#discussion_r2063755306) Thanks. I looked at that discussion. It is always

[PR] [KAFKA-18681] Created GetReplicaLogInfo* RPCs [kafka]

2025-05-08 Thread via GitHub
josefk31 opened a new pull request, #19664: URL: https://github.com/apache/kafka/pull/19664 Creates GetReplicaLogInfoRequest and GetReplicaLogInfoResponse RPCs Information returned by these brokers will be used to aid unclean-recovery by selecting longest logs. RPCs are cluster actio

Re: [PR] KAFKA-19042: [8/N] Move BaseConsumerTest, SaslPlainPlaintextConsumerTest to client-integration-tests module [kafka]

2025-05-08 Thread via GitHub
frankvicky commented on code in PR #19651: URL: https://github.com/apache/kafka/pull/19651#discussion_r2080971393 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/BaseConsumerTest.java: ## @@ -0,0 +1,247 @@ +/* + * Licensed to the Apache Softw

Re: [PR] KAFKA-19220: Add tests to ensure the internal configs don't return by public APIs by default [kafka]

2025-05-08 Thread via GitHub
xijiu commented on PR #19650: URL: https://github.com/apache/kafka/pull/19650#issuecomment-2864978282 @chia7712 Yeah, I have fixed them, PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-19145: Move LeaderEndPoint to Server module [kafka]

2025-05-08 Thread via GitHub
YutaLin commented on code in PR #19630: URL: https://github.com/apache/kafka/pull/19630#discussion_r2080817433 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -218,16 +244,25 @@ abstract class AbstractFetcherThread(name: String, curPartitionState

[jira] [Updated] (KAFKA-18115) Issue loading big files for performance testing

2025-05-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-18115: --- Fix Version/s: 4.1.0 > Issue loading big files for performance testi

Re: [PR] KAFKA-18115; Fix for loading big files while performing load tests [kafka]

2025-05-08 Thread via GitHub
jsancio merged PR #18391: URL: https://github.com/apache/kafka/pull/18391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] (WIP) MINOR: Move logDirs config out of KafkaConfig [kafka]

2025-05-08 Thread via GitHub
Yunyung commented on code in PR #19579: URL: https://github.com/apache/kafka/pull/19579#discussion_r2080810066 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1237,7 +1237,7 @@ class ReplicaManager(val config: KafkaConfig, def describeLogDirs(partitions: Set[

Re: [PR] (WIP) MINOR: Move logDirs config out of KafkaConfig [kafka]

2025-05-08 Thread via GitHub
Yunyung commented on code in PR #19579: URL: https://github.com/apache/kafka/pull/19579#discussion_r2080661082 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -709,7 +709,7 @@ class BrokerServer( None } - val rlm = new RemoteLogManager(config

Re: [PR] KAFKA-19145: Move LeaderEndPoint to Server module [kafka]

2025-05-08 Thread via GitHub
YutaLin commented on code in PR #19630: URL: https://github.com/apache/kafka/pull/19630#discussion_r2080817081 ## core/src/main/scala/kafka/server/AbstractFetcherThread.scala: ## @@ -204,11 +214,27 @@ abstract class AbstractFetcherThread(name: String, * occur during truncati

Re: [PR] MINOR; Remove cast for Records' slice [kafka]

2025-05-08 Thread via GitHub
chia7712 commented on code in PR #19661: URL: https://github.com/apache/kafka/pull/19661#discussion_r2080825212 ## clients/src/main/java/org/apache/kafka/common/record/FileRecords.java: ## @@ -121,10 +122,14 @@ public void readInto(ByteBuffer buffer, int position) throws IOExce

Re: [PR] MINOR; Remove cast for Records' slice [kafka]

2025-05-08 Thread via GitHub
junrao commented on code in PR #19661: URL: https://github.com/apache/kafka/pull/19661#discussion_r2080526231 ## clients/src/main/java/org/apache/kafka/common/record/FileRecords.java: ## @@ -121,10 +122,14 @@ public void readInto(ByteBuffer buffer, int position) throws IOExcept

[jira] [Commented] (KAFKA-13555) Consider number if input topic partitions for task assignment

2025-05-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950376#comment-17950376 ] Matthias J. Sax commented on KAFKA-13555: - Good questions... Would be good to al

[jira] [Commented] (KAFKA-17019) Producer TimeoutException should include root cause

2025-05-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950377#comment-17950377 ] Matthias J. Sax commented on KAFKA-17019: - Just changed your permissions – you s

[jira] [Updated] (KAFKA-19256) Only send IQ information on assignment changes

2025-05-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19256: Component/s: streams > Only send IQ information on assignment changes > --

[jira] [Resolved] (KAFKA-18115) Issue loading big files for performance testing

2025-05-08 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio resolved KAFKA-18115. Resolution: Fixed > Issue loading big files for performance testin

Re: [PR] [KAFKA-18345] Prevent deadlocked elections [kafka]

2025-05-08 Thread via GitHub
TaiJuWu commented on code in PR #19658: URL: https://github.com/apache/kafka/pull/19658#discussion_r2080885590 ## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ## @@ -1048,14 +1053,18 @@ private void maybeHandleElectionLoss(NomineeState state, long currentTimeM

Re: [PR] KAFKA-19145: Move LeaderEndPoint to Server module [kafka]

2025-05-08 Thread via GitHub
YutaLin commented on code in PR #19630: URL: https://github.com/apache/kafka/pull/19630#discussion_r2080663207 ## core/src/main/java/kafka/server/TierStateMachine.java: ## @@ -136,12 +136,13 @@ private OffsetForLeaderEpochResponseData.EpochEndOffset fetchEarlierEpochEndOffs

Re: [PR] KAFKA-18666: Controller-side monitoring for broker shutdown and startup [kafka]

2025-05-08 Thread via GitHub
cmccabe commented on code in PR #19586: URL: https://github.com/apache/kafka/pull/19586#discussion_r2080615754 ## metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetrics.java: ## @@ -157,6 +215,46 @@ public void addToActiveBrokerCount(int brokerCount

Re: [PR] KAFKA-18666: Controller-side monitoring for broker shutdown and startup [kafka]

2025-05-08 Thread via GitHub
cmccabe commented on code in PR #19586: URL: https://github.com/apache/kafka/pull/19586#discussion_r2080615298 ## metadata/src/main/java/org/apache/kafka/controller/metrics/ControllerMetadataMetrics.java: ## @@ -39,10 +44,33 @@ * {@link org.apache.kafka.controller.metrics.Quor

Re: [PR] KAFKA-18836 Make ConsumerGroupMetadata an interface [kafka]

2025-05-08 Thread via GitHub
mjsax commented on PR #18977: URL: https://github.com/apache/kafka/pull/18977#issuecomment-2864552489 @pszymczyk -- we first need to complete the KIP, ie, the KIP must be voted and must be accepted. To do this, you would start a new email thread with subject `[VOTE] KIP-1136: ` a

Re: [PR] MINOR: Move TxnTransitMetadata to transaction-coordinator [kafka]

2025-05-08 Thread via GitHub
Rancho-7 commented on PR #19662: URL: https://github.com/apache/kafka/pull/19662#issuecomment-2864710357 Hi @yunchipang , thanks for the patch. Could you please use `./gradlew checkstyleMain checkstyleTest spotlessCheck` to fix the build error? -- This is an automated message from the Apa

Re: [PR] KAFKA-19234: broker should return UNAUTHORIZATION error for non-existing topic in produce request [kafka]

2025-05-08 Thread via GitHub
chia7712 commented on code in PR #19635: URL: https://github.com/apache/kafka/pull/19635#discussion_r2080768388 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -411,10 +411,9 @@ class KafkaApis(val requestChannel: RequestChannel, } val topicPartiti

Re: [PR] KAFKA-17897: Deprecate Admin.listConsumerGroups [2/N] [kafka]

2025-05-08 Thread via GitHub
chia7712 commented on code in PR #19508: URL: https://github.com/apache/kafka/pull/19508#discussion_r2080773834 ## clients/src/main/java/org/apache/kafka/common/requests/ListGroupsRequest.java: ## @@ -50,8 +53,19 @@ public ListGroupsRequest build(short version) {