chia7712 commented on code in PR #19633: URL: https://github.com/apache/kafka/pull/19633#discussion_r2080055283
########## core/src/test/scala/unit/kafka/security/authorizer/AuthorizerTest.scala: ########## @@ -204,9 +196,8 @@ class AuthorizerTest extends QuorumTestHarness with BaseAuthorizerTest { assertFalse(authorize(authorizer1, host1Context, READ, resource), "User1 should not have READ access from host1 due to denyAcl") } - @ParameterizedTest - @ValueSource(strings = Array(KRAFT)) - def testDenyTakesPrecedence(quorum: String): Unit = { + @Test Review Comment: please fix the indent ########## core/src/test/scala/integration/kafka/api/SaslClientsWithInvalidCredentialsTest.scala: ########## @@ -111,9 +111,8 @@ class SaslClientsWithInvalidCredentialsTest extends AbstractSaslTest { verifyWithRetry(sendOneRecord(producer2))() Review Comment: please remove `quorum=kraft` from line#94 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org