AndrewJSchofield commented on code in PR #19647:
URL: https://github.com/apache/kafka/pull/19647#discussion_r2080085111
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImplTest.java:
##########
@@ -672,6 +673,33 @@ public void testEnsurePollEventSentOnConsumerPoll() {
verify(applicationEventHandler).addAndGet(any(ShareAcknowledgeOnCloseEvent.class));
}
+ @Test
Review Comment:
I'd prefer to see a parameterised test so it runs 3 times, once per
exception class. That makes it much easier to add more exceptions to the list
if we want later on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
