JimmyWang6 commented on code in PR #18929:
URL: https://github.com/apache/kafka/pull/18929#discussion_r2080201974
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##########
@@ -1172,6 +1203,37 @@ public CompletableFuture<List<DescribedGroup>>
shareGroupDescribe(
return FutureUtils.combineFutures(futures, ArrayList::new,
List::addAll);
}
+ /**
+ * See {@link
GroupCoordinator#alterShareGroupOffsets(AuthorizableRequestContext, String,
AlterShareGroupOffsetsRequestData)}.
+ */
+ @Override
+ public CompletableFuture<AlterShareGroupOffsetsResponseData>
alterShareGroupOffsets(AuthorizableRequestContext context, String groupId,
AlterShareGroupOffsetsRequestData request) {
+ if (!isActive.get() || metadataImage == null) {
+ return CompletableFuture.completedFuture(
+
AlterShareGroupOffsetsRequest.getErrorAlterShareGroupResponseData(Errors.COORDINATOR_NOT_AVAILABLE));
+ }
+
+ if (groupId == null) {
+ return CompletableFuture.completedFuture(
+
AlterShareGroupOffsetsRequest.getErrorAlterShareGroupResponseData(Errors.GROUP_ID_NOT_FOUND));
+ }
+
+ return runtime.scheduleWriteOperation(
+ "share-group-alter",
Review Comment:
Right. Good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
