jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2050789803
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -3621,7 +3646,35 @@ public long logEndOffset() {
@Override
public KRaftVersion kraft
jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2051797068
##
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##
@@ -97,11 +106,30 @@ public FeatureControlManager build() {
[
https://issues.apache.org/jira/browse/KAFKA-17156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio resolved KAFKA-17156.
Resolution: Won't Fix
> Metadata controller to provide the KafkaRa
[
https://issues.apache.org/jira/browse/KAFKA-18865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-18865:
---
Parent: KAFKA-17241
Issue Type: Sub-task (was: Improvement)
[
https://issues.apache.org/jira/browse/KAFKA-18865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
José Armando García Sancio updated KAFKA-18865:
---
Description:
Handling of kraft.version is a bit tricky.
The kraft.v
jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2051800562
##
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##
@@ -3621,7 +3646,35 @@ public long logEndOffset() {
@Override
public KRaftVersion kraft
wernerdv commented on PR #19446:
URL: https://github.com/apache/kafka/pull/19446#issuecomment-2817293293
@chia7712 @frankvicky Could you please take a look at this when you get a
chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/KAFKA-19176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kaushik Raina updated KAFKA-19176:
--
Summary: Update Transactional producer to translate retriable into
abortable exceptions (was
k-raina opened a new pull request, #19522:
URL: https://github.com/apache/kafka/pull/19522
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
chirag-wadhwa5 commented on code in PR #19500:
URL: https://github.com/apache/kafka/pull/19500#discussion_r2051974700
##
server/src/main/java/org/apache/kafka/server/share/session/ShareSessionCache.java:
##
@@ -122,15 +113,9 @@ public synchronized ShareSession remove(ShareSessio
github-actions[bot] commented on PR #19456:
URL: https://github.com/apache/kafka/pull/19456#issuecomment-2817551650
A label of 'needs-attention' was automatically added to this PR in order to
raise the
attention of the committers. Once this issue has been triaged, the `triage`
label
s
m1a2st commented on code in PR #19371:
URL: https://github.com/apache/kafka/pull/19371#discussion_r2051911610
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -583,35 +584,72 @@ object KafkaMetadataLog extends Logging {
scheduler: Scheduler,
config: Meta
github-actions[bot] commented on PR #18596:
URL: https://github.com/apache/kafka/pull/18596#issuecomment-2817567834
This PR is being marked as stale since it has not had any activity in 90
days. If you
would like to keep this PR alive, please leave a comment asking for a
review. If the P
FrankYang0529 opened a new pull request, #19523:
URL: https://github.com/apache/kafka/pull/19523
* Add `guava` to dependencies.
* Add `computeTopicHash` and `computeGroupHash` functions to `Group` class.
* Add related unit test.
--
This is an automated message from the Apache Git Ser
[
https://issues.apache.org/jira/browse/KAFKA-19178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Guo reassigned KAFKA-19178:
Assignee: Nick Guo (was: Chia-Ping Tsai)
> Replace Vector by ArrayList for PluginClassLoader#get
[
https://issues.apache.org/jira/browse/KAFKA-19178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17946050#comment-17946050
]
Nick Guo commented on KAFKA-19178:
--
Hi [~chia7712] ,I would like to take this,Thanks!
Chia-Ping Tsai created KAFKA-19178:
--
Summary: Replace Vector by ArrayList for
PluginClassLoader#getResources
Key: KAFKA-19178
URL: https://issues.apache.org/jira/browse/KAFKA-19178
Project: Kafka
chia7712 commented on code in PR #14626:
URL: https://github.com/apache/kafka/pull/14626#discussion_r2052014562
##
streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java:
##
@@ -335,6 +345,28 @@ private static QueryResult
runWindowRangeQuery(final
showuon merged PR #19512:
URL: https://github.com/apache/kafka/pull/19512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
chia7712 commented on code in PR #19387:
URL: https://github.com/apache/kafka/pull/19387#discussion_r2052025917
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogCleaner.java:
##
@@ -0,0 +1,650 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
Chia-Ping Tsai created KAFKA-19179:
--
Summary: remove the dot from thread_dump_url
Key: KAFKA-19179
URL: https://issues.apache.org/jira/browse/KAFKA-19179
Project: Kafka
Issue Type: Improveme
[
https://issues.apache.org/jira/browse/KAFKA-19176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kaushik Raina reassigned KAFKA-19176:
-
Assignee: Kaushik Raina
> Update Transactional producer to never return retriable excep
Kaushik Raina created KAFKA-19176:
-
Summary: Update Transactional producer to never return retriable
exceptions
Key: KAFKA-19176
URL: https://issues.apache.org/jira/browse/KAFKA-19176
Project: Kafka
Kaushik Raina created KAFKA-19177:
-
Summary: Return InvalidTxnStateException as Abortable for
Transaction producer API
Key: KAFKA-19177
URL: https://issues.apache.org/jira/browse/KAFKA-19177
Project:
m1a2st commented on code in PR #19520:
URL: https://github.com/apache/kafka/pull/19520#discussion_r2051763711
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerFetchTest.java:
##
@@ -0,0 +1,489 @@
+/*
+ * Licensed to the Apache
jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2051808839
##
raft/src/main/java/org/apache/kafka/raft/internals/Pair.java:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * cont
jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2051808769
##
metadata/src/main/java/org/apache/kafka/controller/KRaftVersionAccessor.java:
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2051808958
##
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##
@@ -225,6 +272,32 @@ private ApiError updateFeature(
if (featureName.equal
jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2051809216
##
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##
@@ -225,6 +272,32 @@ private ApiError updateFeature(
if (featureName.equal
sjhajharia commented on PR #19510:
URL: https://github.com/apache/kafka/pull/19510#issuecomment-2817013444
Thanks @frankvicky
Adding in the changes in a subsequent commit. Pls review when possible!
--
This is an automated message from the Apache Git Service.
To respond to the message,
m1a2st opened a new pull request, #19520:
URL: https://github.com/apache/kafka/pull/19520
Use Java to rewrite `PlaintextConsumerFetchTest` by new test infra and move
it to client-integration-tests module.
--
This is an automated message from the Apache Git Service.
To respond to the m
Rancho-7 commented on code in PR #19346:
URL: https://github.com/apache/kafka/pull/19346#discussion_r2051717695
##
raft/src/main/java/org/apache/kafka/raft/ControlRecord.java:
##
@@ -23,54 +23,51 @@
import org.apache.kafka.common.message.VotersRecord;
import org.apache.kafka.c
FrankYang0529 commented on code in PR #19346:
URL: https://github.com/apache/kafka/pull/19346#discussion_r2051678587
##
raft/src/main/java/org/apache/kafka/raft/internals/RecordsIterator.java:
##
@@ -346,29 +343,12 @@ private T decodeDataRecord(Optional key,
Optional value)
chia7712 commented on code in PR #19346:
URL: https://github.com/apache/kafka/pull/19346#discussion_r2051733779
##
raft/src/main/java/org/apache/kafka/raft/internals/RecordsIterator.java:
##
@@ -346,29 +343,12 @@ private T decodeDataRecord(Optional key,
Optional value)
}
chia7712 commented on PR #19191:
URL: https://github.com/apache/kafka/pull/19191#issuecomment-2817188285
@FrankYang0529 please fix the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
chia7712 commented on code in PR #19508:
URL: https://github.com/apache/kafka/pull/19508#discussion_r2051739551
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -3524,44 +3524,62 @@ void handleResponse(AbstractResponse abstractResponse) {
chia7712 commented on code in PR #19516:
URL: https://github.com/apache/kafka/pull/19516#discussion_r2051729958
##
clients/src/test/java/org/apache/kafka/common/utils/annotation/ApiKeyVersionsProvider.java:
##
@@ -23,16 +23,40 @@
import org.junit.jupiter.params.provider.Argumen
chia7712 commented on code in PR #19440:
URL: https://github.com/apache/kafka/pull/19440#discussion_r2051733277
##
clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java:
##
@@ -3799,10 +3799,11 @@ MAX_REQUEST_SIZE, ACKS_ALL, MAX_RETRIES, n
apalan60 opened a new pull request, #19521:
URL: https://github.com/apache/kafka/pull/19521
This patch addresses issue #19516 and corrects a typo in
`ApiKeyVersionsProvider.java`: when `toVersion` exceeds `latestVersion`, the
`IllegalArgumentException` message was erroneously formatted with
apalan60 commented on code in PR #19516:
URL: https://github.com/apache/kafka/pull/19516#discussion_r2051734950
##
clients/src/test/java/org/apache/kafka/common/utils/annotation/ApiKeyVersionsProvider.java:
##
@@ -23,16 +23,40 @@
import org.junit.jupiter.params.provider.Argumen
chia7712 commented on code in PR #19520:
URL: https://github.com/apache/kafka/pull/19520#discussion_r2051749603
##
clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/PlaintextConsumerFetchTest.java:
##
@@ -0,0 +1,489 @@
+/*
+ * Licensed to the Apac
chia7712 commented on PR #19393:
URL: https://github.com/apache/kafka/pull/19393#issuecomment-2817223866
@m1a2st could you please update docs for `offsetsForTimes` as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
chia7712 merged PR #19487:
URL: https://github.com/apache/kafka/pull/19487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
frankvicky commented on PR #19518:
URL: https://github.com/apache/kafka/pull/19518#issuecomment-2817031470
Hi @mumrah
I have cherry-picked this patch to my local branch and tried to run a new RC.
It appears that the patch introduces a merge operation during the push of a
tag, which vi
44 matches
Mail list logo
