jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2051797068
##########
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##########
@@ -97,11 +106,30 @@ public FeatureControlManager build() {
MetadataVersion.latestProduction().featureLevel()));
quorumFeatures = new QuorumFeatures(0, localSupportedFeatures,
List.of(0));
}
+ if (kraftVersionAccessor == null) {
+ kraftVersionAccessor = new KRaftVersionAccessor() {
+ private KRaftVersion version =
KRaftVersion.LATEST_PRODUCTION;
Review Comment:
> any reason we don't just throw if the accessor is not assigned - is it
just for ease of testing?
To make it easier to test this type. Builders in the metadata module tend to
set the fields to a value that is valid for most tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
