jsancio commented on code in PR #19416:
URL: https://github.com/apache/kafka/pull/19416#discussion_r2050789803
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -3621,7 +3646,35 @@ public long logEndOffset() {
@Override
public KRaftVersion kraftVersion() {
- return partitionState.lastKraftVersion();
+ if (!isInitialized()) {
+ throw new IllegalStateException("Cannot read the kraft version
before the replica has been initialized");
+ }
+
+ return quorum
+ .maybeLeaderState()
+ .flatMap(LeaderState::requestedKRaftVersion)
Review Comment:
Yes. We need to do that because the active controller operates on possibly
uncommitted state and we want to fence any new registration that doesn't
support the new finalized kraft version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
