chia7712 commented on code in PR #14626: URL: https://github.com/apache/kafka/pull/14626#discussion_r2052014562
########## streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java: ########## @@ -335,6 +345,28 @@ private static <R> QueryResult<R> runWindowRangeQuery(final Query<R> query, } } + @SuppressWarnings("unchecked") + private static <R> QueryResult<R> runMultiVersionedKeyQuery(final Query<R> query, + final PositionBound positionBound, + final QueryConfig config, + final StateStore store) { + if (store instanceof VersionedKeyValueStore) { Review Comment: Sorry for making noise on this old PR, but I have a small question: why to check `VersionedKeyValueStore` rather than `RocksDBVersionedStore` if we plan to cast `store` to `RocksDBVersionedStore`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org