[jira] [Resolved] (KAFKA-19147) ConsumerGroupHeartbeat API leaks topic id and partition count of unauthorized topics

2025-04-16 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-19147. Fix Version/s: 4.1.0 Reviewer: David Jacot Resolution: Fixed > ConsumerGro

Re: [PR] KAFKA-18891: KIP-877 add support for RemoteLogMetadataManager and RemoteStorageManager [kafka]

2025-04-16 Thread via GitHub
TaiJuWu commented on code in PR #19286: URL: https://github.com/apache/kafka/pull/19286#discussion_r2046367913 ## server/src/test/java/org/apache/kafka/server/MonitorablePluginsIntegrationTest.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

[PR] KAFKA-19112:cleanup.policy shouldn't be empty [kafka]

2025-04-16 Thread via GitHub
Itry1992 opened a new pull request, #19486: URL: https://github.com/apache/kafka/pull/19486 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] KAFKA-19002: Rewrite ListOffsetsIntegrationTest and move it to clients-integration-test [kafka]

2025-04-16 Thread via GitHub
TaiJuWu commented on code in PR #19460: URL: https://github.com/apache/kafka/pull/19460#discussion_r2046231461 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/ListOffsetsIntegrationTest.java: ## @@ -0,0 +1,292 @@ +/* + * Licensed to the Apache S

Re: [PR] KAFKA-19002: Rewrite ListOffsetsIntegrationTest and move it to clients-integration-test [kafka]

2025-04-16 Thread via GitHub
TaiJuWu commented on code in PR #19460: URL: https://github.com/apache/kafka/pull/19460#discussion_r2046233193 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/ListOffsetsIntegrationTest.java: ## @@ -0,0 +1,292 @@ +/* + * Licensed to the Apache S

Re: [PR] KAFKA-19002: Rewrite ListOffsetsIntegrationTest and move it to clients-integration-test [kafka]

2025-04-16 Thread via GitHub
TaiJuWu commented on PR #19460: URL: https://github.com/apache/kafka/pull/19460#issuecomment-2808612902 > @TaiJuWu please fix the conflicts Thanks for reminding me. Resolve it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] KAFKA-18854:Move DynamicConfig to server module [kafka]

2025-04-16 Thread via GitHub
chia7712 commented on PR #19487: URL: https://github.com/apache/kafka/pull/19487#issuecomment-2809055110 @gongxuanzhang please revise the title :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-17747: Trigger rebalance on rack topology changes [kafka]

2025-04-16 Thread via GitHub
squah-confluent commented on code in PR #17444: URL: https://github.com/apache/kafka/pull/17444#discussion_r2046569906 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/ModernGroup.java: ## @@ -348,54 +376,58 @@ public Map targetAssignment() { }

[jira] [Assigned] (KAFKA-19158) Add a new error code for “share session limit reached”

2025-04-16 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-19158: Assignee: Andrew Schofield (was: Chirag Wadhwa) Summary: Add a new error cod

[jira] [Assigned] (KAFKA-19162) Topology description sent to broker contains non-determinstically ordered topic configs

2025-04-16 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-19162: -- Assignee: Lucas Brutschy > Topology description sent to broker contains non-determins

Re: [PR] KAFKA-19162: Topology metadata contains non-deterministically ordered topic configs [kafka]

2025-04-16 Thread via GitHub
lucasbru commented on PR #19491: URL: https://github.com/apache/kafka/pull/19491#issuecomment-2809449043 PTAL @aliehsaeedii -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] KAFKA-19162: Topology metadata contains non-deterministically ordered topic configs [kafka]

2025-04-16 Thread via GitHub
lucasbru opened a new pull request, #19491: URL: https://github.com/apache/kafka/pull/19491 Topology description sent to broker in KIP-1071 contains non-deterministically ordered topic configs. Since the topology is compared to the groups topology upon joining, it should be completel

Re: [PR] KAFKA-19054: StreamThread exception handling with SHUTDOWN_APPLICATION may trigger a tight loop with MANY logs [kafka]

2025-04-16 Thread via GitHub
apalan60 commented on code in PR #19394: URL: https://github.com/apache/kafka/pull/19394#discussion_r2047947955 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java: ## @@ -336,16 +339,20 @@ private v

Re: [PR] KAFKA-19054: StreamThread exception handling with SHUTDOWN_APPLICATION may trigger a tight loop with MANY logs [kafka]

2025-04-16 Thread via GitHub
apalan60 commented on code in PR #19394: URL: https://github.com/apache/kafka/pull/19394#discussion_r2047945194 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -869,8 +870,10 @@ public void setStreamsUncaughtExceptionHandler(final

Re: [PR] KAFKA-19054: StreamThread exception handling with SHUTDOWN_APPLICATION may trigger a tight loop with MANY logs [kafka]

2025-04-16 Thread via GitHub
apalan60 commented on PR #19394: URL: https://github.com/apache/kafka/pull/19394#issuecomment-2811252138 @mjsax Thanks for your review, I've addressed all feedback. PTAL, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-16 Thread via GitHub
junrao commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2047838466 ## core/src/test/scala/integration/kafka/api/ProducerSendWhileDeletionTest.scala: ## @@ -85,4 +85,80 @@ class ProducerSendWhileDeletionTest extends IntegrationTestHarne

[jira] [Updated] (KAFKA-19166) Release tags are orphaned

2025-04-16 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-19166: - Affects Version/s: 3.9.0 4.0.0 > Release tags are orphaned >

[PR] MINOR: Supress stdout when checking Log4j 1.x configuration compatibility mode [kafka]

2025-04-16 Thread via GitHub
omkreddy opened a new pull request, #19502: URL: https://github.com/apache/kafka/pull/19502 when you using log41 config, we are printing addtional line like below. This change is to fix that For example, cmd ` KAFKA_CLUSTER_ID="$(bin/kafka-storage.sh random-uuid)"s` gives

[jira] [Assigned] (KAFKA-16869) Rewrite HighAvailabilityTaskAssignor to implement the new TaskAssignor interface

2025-04-16 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorcan reassigned KAFKA-16869: -- Assignee: (was: Lorcan) > Rewrite HighAvailabilityTaskAssignor to implement the new TaskAssignor

Re: [PR] KAFKA-18752: Fix the warning of no-operation caused by slf4j in building kafka [kafka]

2025-04-16 Thread via GitHub
frankvicky commented on PR #19501: URL: https://github.com/apache/kafka/pull/19501#issuecomment-2811891358 Build output: ![image](https://github.com/user-attachments/assets/bf726391-dc4d-44a6-8a68-0ceffe3da54c) -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-10789: Streamlining Tests in ChangeLoggingKeyValueBytesStoreTest [kafka]

2025-04-16 Thread via GitHub
mjsax commented on code in PR #18816: URL: https://github.com/apache/kafka/pull/18816#discussion_r2040351003 ## streams/src/test/java/org/apache/kafka/streams/state/internals/ChangeLoggingKeyValueBytesStoreTest.java: ## @@ -89,8 +95,81 @@ public class ChangeLoggingKeyValueBytesS

[PR] KAFKA-19158: Add SHARE_SESSION_LIMIT_REACHED error code [kafka]

2025-04-16 Thread via GitHub
AndrewJSchofield opened a new pull request, #19492: URL: https://github.com/apache/kafka/pull/19492 Add the new `SHARE_SESSION_LIMIT_REACHED` error code which is used when an attempt is made to open a new share session when the share session limit of the broker has already been reached. Sup

Re: [PR] KAFKA-18894: Add KIP-877 support for ConfigProvider [kafka]

2025-04-16 Thread via GitHub
Yunyung commented on code in PR #19397: URL: https://github.com/apache/kafka/pull/19397#discussion_r2046923569 ## clients/src/main/java/org/apache/kafka/common/config/provider/ConfigProvider.java: ## @@ -29,6 +29,10 @@ * Kafka Connect discovers implementations of this interfac

Re: [PR] KAFKA-18894: Add KIP-877 support for ConfigProvider [kafka]

2025-04-16 Thread via GitHub
Yunyung commented on code in PR #19397: URL: https://github.com/apache/kafka/pull/19397#discussion_r2034036959 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -620,21 +621,22 @@ private Map instantiateConfigProviders( } }

Re: [PR] KAFKA-18894: Add KIP-877 support for ConfigProvider [kafka]

2025-04-16 Thread via GitHub
Yunyung commented on code in PR #19397: URL: https://github.com/apache/kafka/pull/19397#discussion_r2046927417 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java: ## @@ -269,18 +270,19 @@ List configProviders() { Map transform(Map props)

Re: [PR] KAFKA-18894: Add KIP-877 support for ConfigProvider [kafka]

2025-04-16 Thread via GitHub
Yunyung commented on code in PR #19397: URL: https://github.com/apache/kafka/pull/19397#discussion_r2046928161 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -620,21 +621,22 @@ private Map instantiateConfigProviders( } }

[PR] KAFKA-18904: Change ListClientMetricsResources API to ListConfigResources (wip) [kafka]

2025-04-16 Thread via GitHub
FrankYang0529 opened a new pull request, #19493: URL: https://github.com/apache/kafka/pull/19493 * Change `ListClientMetricsResourcesRequest.json` to `ListConfigResourcesRequest.json`. * Change `ListClientMetricsResourcesResponse.json` to `ListConfigResourcesResponse.json`. * Change `

[jira] [Updated] (KAFKA-19157) Add group.share.max.share.sessions config

2025-04-16 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield updated KAFKA-19157: - Description: As described in the updated KIP-932. Summary: Add group.share.max.sh

Re: [PR] Added the ShareGroupStatePartitionMetadata record during deletion of share group offsets [kafka]

2025-04-16 Thread via GitHub
smjn commented on code in PR #19478: URL: https://github.com/apache/kafka/pull/19478#discussion_r2046247231 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1257,38 +1257,103 @@ private CompletableFuture> persisterDelete

Re: [PR] Added the ShareGroupStatePartitionMetadata record during deletion of share group offsets [kafka]

2025-04-16 Thread via GitHub
smjn commented on code in PR #19478: URL: https://github.com/apache/kafka/pull/19478#discussion_r2046245448 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1257,38 +1257,103 @@ private CompletableFuture> persisterDelete

Re: [PR] Added the ShareGroupStatePartitionMetadata record during deletion of share group offsets [kafka]

2025-04-16 Thread via GitHub
smjn commented on code in PR #19478: URL: https://github.com/apache/kafka/pull/19478#discussion_r2046248551 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1257,38 +1257,103 @@ private CompletableFuture> persisterDelete

Re: [PR] Added the ShareGroupStatePartitionMetadata record during deletion of share group offsets [kafka]

2025-04-16 Thread via GitHub
smjn commented on code in PR #19478: URL: https://github.com/apache/kafka/pull/19478#discussion_r2046248961 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1257,38 +1257,103 @@ private CompletableFuture> persisterDelete

Re: [PR] Added the ShareGroupStatePartitionMetadata record during deletion of share group offsets [kafka]

2025-04-16 Thread via GitHub
smjn commented on code in PR #19478: URL: https://github.com/apache/kafka/pull/19478#discussion_r2046254058 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -8200,50 +8200,119 @@ public Optional shareGroupBuildPartitionDelet

Re: [PR] Added the ShareGroupStatePartitionMetadata record during deletion of share group offsets [kafka]

2025-04-16 Thread via GitHub
smjn commented on code in PR #19478: URL: https://github.com/apache/kafka/pull/19478#discussion_r2046256836 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -8200,50 +8200,119 @@ public Optional shareGroupBuildPartitionDelet

Re: [PR] Added the ShareGroupStatePartitionMetadata record during deletion of share group offsets [kafka]

2025-04-16 Thread via GitHub
smjn commented on code in PR #19478: URL: https://github.com/apache/kafka/pull/19478#discussion_r2046256836 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -8200,50 +8200,119 @@ public Optional shareGroupBuildPartitionDelet

[jira] [Commented] (KAFKA-19161) Diskless Topics

2025-04-16 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945052#comment-17945052 ] Stanislav Kozlovski commented on KAFKA-19161: - this is AWESOME > Diskless T

[jira] [Created] (KAFKA-19162) Topology description sent to broker contains non-determinstically ordered topic configs

2025-04-16 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-19162: -- Summary: Topology description sent to broker contains non-determinstically ordered topic configs Key: KAFKA-19162 URL: https://issues.apache.org/jira/browse/KAFKA-19162

Re: [PR] KAFKA-18170: Add scheduled job to snapshot cold share partitions. [kafka]

2025-04-16 Thread via GitHub
smjn commented on code in PR #19443: URL: https://github.com/apache/kafka/pull/19443#discussion_r2047117734 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java: ## @@ -574,6 +575,46 @@ public CoordinatorResult(List.of(record), respon

Re: [PR] KAFKA-14690; Add TopicId to OffsetCommit API [kafka]

2025-04-16 Thread via GitHub
lianetm commented on code in PR #19461: URL: https://github.com/apache/kafka/pull/19461#discussion_r2045463288 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java: ## @@ -45,20 +45,24 @@ public static class Builder extends AbstractRequest.Builder

Re: [PR] KAFKA-14690; Add TopicId to OffsetCommit API [kafka]

2025-04-16 Thread via GitHub
dajac commented on code in PR #19461: URL: https://github.com/apache/kafka/pull/19461#discussion_r2047364604 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java: ## @@ -1308,6 +1308,75 @@ public void testConsumerGroupOffsetCommit(

Re: [PR] KAFKA-19158: Add SHARE_SESSION_LIMIT_REACHED error code [kafka]

2025-04-16 Thread via GitHub
AndrewJSchofield merged PR #19492: URL: https://github.com/apache/kafka/pull/19492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] KAFKA-17747: Trigger rebalance on rack topology changes [kafka]

2025-04-16 Thread via GitHub
dajac commented on code in PR #17444: URL: https://github.com/apache/kafka/pull/17444#discussion_r2047369968 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/ModernGroup.java: ## @@ -348,54 +376,58 @@ public Map targetAssignment() { } /**

Re: [PR] KAFKA-19151: docs: clarify that flush.ms requires log.flush.scheduler.interval.ms config [kafka]

2025-04-16 Thread via GitHub
yunchipang commented on code in PR #19479: URL: https://github.com/apache/kafka/pull/19479#discussion_r2047369883 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -58,8 +58,8 @@ public class TopicConfig { public static final String FLUSH_MS_CO

Re: [PR] KAFKA-17747: Trigger rebalance on rack topology changes [kafka]

2025-04-16 Thread via GitHub
dajac commented on PR #17444: URL: https://github.com/apache/kafka/pull/17444#issuecomment-2810200638 @FrankYang0529 When you update the PR, I wonder whether we could split it into smaller chunks. That would ease the reviews. Would it be possible? -- This is an automated message from the

[jira] [Resolved] (KAFKA-19158) Add a new error code for “share session limit reached”

2025-04-16 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-19158. -- Fix Version/s: 4.1.0 Resolution: Fixed > Add a new error code for “share sessio

[jira] [Created] (KAFKA-19163) New group coordinator can incorrectly delete groups with pending transactional offsets

2025-04-16 Thread Sean Quah (Jira)
Sean Quah created KAFKA-19163: - Summary: New group coordinator can incorrectly delete groups with pending transactional offsets Key: KAFKA-19163 URL: https://issues.apache.org/jira/browse/KAFKA-19163 Proj

Re: [PR] MINOR: Update GroupCoordinator interface to use AuthorizableRequestContext instead of RequestContext [kafka]

2025-04-16 Thread via GitHub
dajac merged PR #19485: URL: https://github.com/apache/kafka/pull/19485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[PR] HOTFIX add SuppressWarnings in TieredStorageTestUtils [kafka]

2025-04-16 Thread via GitHub
m1a2st opened a new pull request, #19494: URL: https://github.com/apache/kafka/pull/19494 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] HOTFIX add SuppressWarnings in TieredStorageTestUtils [kafka]

2025-04-16 Thread via GitHub
chia7712 commented on code in PR #19494: URL: https://github.com/apache/kafka/pull/19494#discussion_r2047334846 ## storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java: ## @@ -53,7 +54,6 @@ import static org.apache.kafka.server.log.remote.sto

Re: [PR] KAFKA-13610: Deprecate log.cleaner.enable configuration [kafka]

2025-04-16 Thread via GitHub
m1a2st commented on PR #19472: URL: https://github.com/apache/kafka/pull/19472#issuecomment-2810141568 I addressed https://github.com/apache/kafka/pull/19494 th fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] HOTFIX add SuppressWarnings in TieredStorageTestUtils [kafka]

2025-04-16 Thread via GitHub
m1a2st commented on code in PR #19494: URL: https://github.com/apache/kafka/pull/19494#discussion_r2047337475 ## storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java: ## @@ -53,7 +54,6 @@ import static org.apache.kafka.server.log.remote.stora

Re: [PR] KAFKA-18760: Deprecate Optional and return String from public Endpoint#listener [kafka]

2025-04-16 Thread via GitHub
chia7712 commented on code in PR #19191: URL: https://github.com/apache/kafka/pull/19191#discussion_r2047340719 ## clients/src/main/java/org/apache/kafka/common/Endpoint.java: ## @@ -16,35 +16,51 @@ */ package org.apache.kafka.common; -import org.apache.kafka.common.annotat

Re: [PR] HOTFIX add SuppressWarnings in TieredStorageTestUtils [kafka]

2025-04-16 Thread via GitHub
chia7712 commented on code in PR #19494: URL: https://github.com/apache/kafka/pull/19494#discussion_r2047338914 ## storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java: ## @@ -53,7 +54,6 @@ import static org.apache.kafka.server.log.remote.sto

Re: [PR] KAFKA-14690; Add TopicId to OffsetCommit API [kafka]

2025-04-16 Thread via GitHub
dajac commented on code in PR #19461: URL: https://github.com/apache/kafka/pull/19461#discussion_r2047353585 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -271,40 +271,62 @@ class KafkaApis(val requestChannel: RequestChannel, ): CompletableFuture[Unit] = { v

Re: [PR] KAFKA-14690; Add TopicId to OffsetCommit API [kafka]

2025-04-16 Thread via GitHub
dajac commented on code in PR #19461: URL: https://github.com/apache/kafka/pull/19461#discussion_r2047354258 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java: ## @@ -190,12 +203,85 @@ public Builder merge( }

Re: [PR] KAFKA-14690; Add TopicId to OffsetCommit API [kafka]

2025-04-16 Thread via GitHub
dajac commented on code in PR #19461: URL: https://github.com/apache/kafka/pull/19461#discussion_r2047358176 ## clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitRequest.java: ## @@ -45,20 +45,24 @@ public static class Builder extends AbstractRequest.Builder

Re: [PR] KAFKA-14690; Add TopicId to OffsetCommit API [kafka]

2025-04-16 Thread via GitHub
dajac commented on code in PR #19461: URL: https://github.com/apache/kafka/pull/19461#discussion_r2047360656 ## clients/src/main/resources/common/message/OffsetCommitResponse.json: ## @@ -34,7 +34,9 @@ // Version 9 is the first version that can be used with the new consumer

Re: [PR] KAFKA-14690; Add TopicId to OffsetCommit API [kafka]

2025-04-16 Thread via GitHub
dajac commented on code in PR #19461: URL: https://github.com/apache/kafka/pull/19461#discussion_r2047359577 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -271,40 +271,62 @@ class KafkaApis(val requestChannel: RequestChannel, ): CompletableFuture[Unit] = { v

Re: [PR] KAFKA-14690; Add TopicId to OffsetCommit API [kafka]

2025-04-16 Thread via GitHub
dajac commented on code in PR #19461: URL: https://github.com/apache/kafka/pull/19461#discussion_r2047359577 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -271,40 +271,62 @@ class KafkaApis(val requestChannel: RequestChannel, ): CompletableFuture[Unit] = { v

Re: [PR] KAFKA-19151: docs: clarify that flush.ms requires log.flush.scheduler.interval.ms config [kafka]

2025-04-16 Thread via GitHub
chia7712 commented on code in PR #19479: URL: https://github.com/apache/kafka/pull/19479#discussion_r2047338225 ## clients/src/main/java/org/apache/kafka/common/config/TopicConfig.java: ## @@ -58,8 +58,8 @@ public class TopicConfig { public static final String FLUSH_MS_CONF

Re: [PR] KAFKA-18854: Move `DynamicConfig User` and `DynamicConfig Client` to server module [kafka]

2025-04-16 Thread via GitHub
gongxuanzhang commented on code in PR #19487: URL: https://github.com/apache/kafka/pull/19487#discussion_r2046991460 ## server/src/main/java/org/apache/kafka/server/config/DynamicConfig.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-18854: Move `DynamicConfig User` and `DynamicConfig Client` to server module [kafka]

2025-04-16 Thread via GitHub
FrankYang0529 commented on code in PR #19487: URL: https://github.com/apache/kafka/pull/19487#discussion_r2046985960 ## server/src/main/java/org/apache/kafka/server/config/DynamicConfig.java: ## @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] KAFKA-17897: Deprecate Admin.listConsumerGroups [kafka]

2025-04-16 Thread via GitHub
chia7712 commented on code in PR #19477: URL: https://github.com/apache/kafka/pull/19477#discussion_r2047281878 ## clients/src/main/java/org/apache/kafka/clients/admin/ListGroupsOptions.java: ## @@ -45,6 +57,11 @@ public ListGroupsOptions inGroupStates(Set groupStates) {

Re: [PR] KAFKA-13610: Deprecate log.cleaner.enable configuration [kafka]

2025-04-16 Thread via GitHub
chia7712 commented on PR #19472: URL: https://github.com/apache/kafka/pull/19472#issuecomment-2810125777 @frankvicky could you please fix the following warning? ``` > Task :storage:compileTestJava /home/chia7712/project/kafka/storage/src/test/java/org/apache/kafka/tiered/storage/uti

Re: [PR] KAFKA-18170: Add scheduled job to snapshot cold share partitions. [kafka]

2025-04-16 Thread via GitHub
AndrewJSchofield commented on code in PR #19443: URL: https://github.com/apache/kafka/pull/19443#discussion_r2047031680 ## share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java: ## @@ -574,6 +575,46 @@ public CoordinatorResult(List.of(rec

Re: [PR] MINOR: improve (De)Serializer JavaDocs [kafka]

2025-04-16 Thread via GitHub
kirktrue commented on code in PR #19467: URL: https://github.com/apache/kafka/pull/19467#discussion_r2047085428 ## clients/src/main/java/org/apache/kafka/common/serialization/Serializer.java: ## @@ -23,20 +23,25 @@ /** * An interface for converting objects to bytes. - * *

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-04-16 Thread via GitHub
OmniaGM commented on code in PR #15968: URL: https://github.com/apache/kafka/pull/15968#discussion_r2047099316 ## core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala: ## @@ -94,9 +94,14 @@ class AuthorizerIntegrationTest extends AbstractAuthorizerIntegrati

Re: [PR] MINOR: remove unused DelayedElectLeader [kafka]

2025-04-16 Thread via GitHub
chia7712 merged PR #19490: URL: https://github.com/apache/kafka/pull/19490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-19163) New group coordinator can incorrectly delete groups with pending transactional offsets

2025-04-16 Thread Sean Quah (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Quah updated KAFKA-19163: -- Description: When a group has pending transactional offsets and no committed offsets, the group coord

Re: [PR] MINOR: Remove Kafka release section from root README [kafka]

2025-04-16 Thread via GitHub
ijuma commented on PR #19483: URL: https://github.com/apache/kafka/pull/19483#issuecomment-2810083718 Thanks for the quick update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Updated] (KAFKA-19163) New group coordinator can incorrectly delete groups with pending transactional offsets

2025-04-16 Thread Sean Quah (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Quah updated KAFKA-19163: -- Description: When a group has pending transactional offsets and no committed offsets, the group coord

Re: [PR] MINOR: improve (De)Serializer JavaDocs [kafka]

2025-04-16 Thread via GitHub
mjsax commented on PR #19467: URL: https://github.com/apache/kafka/pull/19467#issuecomment-2810269706 > Are the line breaking changes for the @param JavaDoc a new style guideline, or one used in Streams? I haven't seen that elsewhere in the project. I don't think there is any official

[jira] [Created] (KAFKA-19164) New group coordinator won't delete groups with previously pending transactional offsets that were deleted

2025-04-16 Thread Sean Quah (Jira)
Sean Quah created KAFKA-19164: - Summary: New group coordinator won't delete groups with previously pending transactional offsets that were deleted Key: KAFKA-19164 URL: https://issues.apache.org/jira/browse/KAFKA-1916

Re: [PR] KAFKA-17897: Deprecate Admin.listConsumerGroups [kafka]

2025-04-16 Thread via GitHub
AndrewJSchofield commented on code in PR #19477: URL: https://github.com/apache/kafka/pull/19477#discussion_r2047639023 ## clients/src/main/java/org/apache/kafka/clients/admin/ListGroupsOptions.java: ## @@ -61,6 +78,13 @@ public Set groupStates() { return groupStates;

Re: [PR] KAFKA-19162: Topology metadata contains non-deterministically ordered topic configs [kafka]

2025-04-16 Thread via GitHub
lucasbru commented on PR #19491: URL: https://github.com/apache/kafka/pull/19491#issuecomment-2810818905 Thanks for the comments. Ready for re-review @mjsax -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-19162: Topology metadata contains non-deterministically ordered topic configs [kafka]

2025-04-16 Thread via GitHub
lucasbru commented on code in PR #19491: URL: https://github.com/apache/kafka/pull/19491#discussion_r2047774189 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -237,6 +237,7 @@ private static List getRepartiti

Re: [PR] KAFKA-19162: Topology metadata contains non-deterministically ordered topic configs [kafka]

2025-04-16 Thread via GitHub
lucasbru commented on code in PR #19491: URL: https://github.com/apache/kafka/pull/19491#discussion_r2047774920 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -490,8 +492,12 @@ private NetworkClientDelegate.Un

[jira] [Created] (KAFKA-19165) PartitionLeaderStrategy has very high error rate during topic initialization

2025-04-16 Thread Steven Schlansker (Jira)
Steven Schlansker created KAFKA-19165: - Summary: PartitionLeaderStrategy has very high error rate during topic initialization Key: KAFKA-19165 URL: https://issues.apache.org/jira/browse/KAFKA-19165

Re: [PR] KAFKA-19136: Move metadata-related configs from KRaftConfigs to MetadataLogConfig [kafka]

2025-04-16 Thread via GitHub
chia7712 commented on code in PR #19465: URL: https://github.com/apache/kafka/pull/19465#discussion_r2047326389 ## raft/src/main/java/org/apache/kafka/raft/MetadataLogConfig.java: ## @@ -16,25 +16,161 @@ */ package org.apache.kafka.raft; -/** - * Configuration for the metad

Re: [PR] KAFKA-19164: Keep track of groups when deleting transactional offsets [kafka]

2025-04-16 Thread via GitHub
squah-confluent commented on code in PR #19495: URL: https://github.com/apache/kafka/pull/19495#discussion_r2047494613 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -256,7 +263,7 @@ private OffsetAndMetadata remove(

Re: [PR] KAFKA-19163: Avoid deleting groups with pending transactional offsets [kafka]

2025-04-16 Thread via GitHub
squah-confluent commented on PR #19496: URL: https://github.com/apache/kafka/pull/19496#issuecomment-2810400896 Marking this as a draft until #19495 is completed, since there is a merge conflict. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[PR] KAFKA-19160: Improve performance of fetching stable offsets [kafka]

2025-04-16 Thread via GitHub
squah-confluent opened a new pull request, #19497: URL: https://github.com/apache/kafka/pull/19497 When fetching stable offsets in the group coordinator, we iterate over all requested partitions. For each partition, we iterate over the group's ongoing transactions to check if there is a

Re: [PR] KAFKA-19164: Keep track of groups when deleting transactional offsets [kafka]

2025-04-16 Thread via GitHub
jolshan commented on code in PR #19495: URL: https://github.com/apache/kafka/pull/19495#discussion_r2047758771 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -256,7 +263,7 @@ private OffsetAndMetadata remove(

Re: [PR] MINOR: fix docs/ops.html ZK migration docs [kafka]

2025-04-16 Thread via GitHub
cmccabe commented on PR #19499: URL: https://github.com/apache/kafka/pull/19499#issuecomment-2810806228 oh, now that I think about it, it won’t claim controllership until all brokers are changed to be migration enabled. Let me think about this more. -- This is an automated message from th

Re: [PR] MINOR: fix docs/ops.html ZK migration docs [kafka]

2025-04-16 Thread via GitHub
cmccabe closed pull request #19499: MINOR: fix docs/ops.html ZK migration docs URL: https://github.com/apache/kafka/pull/19499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] KAFKA-19160: Improve performance of fetching stable offsets [kafka]

2025-04-16 Thread via GitHub
shaan150 commented on code in PR #19497: URL: https://github.com/apache/kafka/pull/19497#discussion_r2047739805 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -650,24 +658,18 @@ public int deleteAllOffsets( // Del

[jira] [Commented] (KAFKA-18713) Kafka Streams Left-Join not always emitting the last value

2025-04-16 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945205#comment-17945205 ] Matthias J. Sax commented on KAFKA-18713: - It's very unlikely that 3.8.2 will ac

[jira] [Resolved] (KAFKA-19024) Enhance the client behaviour when it tries to exceed the `group.share.max.groups`

2025-04-16 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lan Ding resolved KAFKA-19024. -- Resolution: Fixed > Enhance the client behaviour when it tries to exceed the > `group.share.max.group

Re: [PR] MINOR: Remove unused fields in KafkaConfig [kafka]

2025-04-16 Thread via GitHub
chia7712 merged PR #19481: URL: https://github.com/apache/kafka/pull/19481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-19157) Add group.share.max.share.sessions config

2025-04-16 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945210#comment-17945210 ] Lan Ding commented on KAFKA-19157: -- Hi [~cwadhwa] , If this ticket is still open, may I

Re: [PR] HOTFIX: add SuppressWarnings in TieredStorageTestUtils [kafka]

2025-04-16 Thread via GitHub
chia7712 merged PR #19494: URL: https://github.com/apache/kafka/pull/19494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-6629: parameterise SegmentedCacheFunctionTest for session key schemas [kafka]

2025-04-16 Thread via GitHub
mjsax commented on PR #19404: URL: https://github.com/apache/kafka/pull/19404#issuecomment-2811620083 @lorcanj Thanks for the PR -- we are currently quite backlogged and it might take some more time until we get to your PR. Thanks for your understanding. -- This is an automated message fr

Re: [PR] MINOR: fix docs references to missing features that are no longer missing [kafka]

2025-04-16 Thread via GitHub
chia7712 commented on code in PR #19498: URL: https://github.com/apache/kafka/pull/19498#discussion_r2048130537 ## docs/ops.html: ## @@ -3967,15 +3964,6 @@ The Kafka controllers store all the metadata for the cluster in memory and on disk. We believe that for a typical Kafka cl

Re: [PR] KAFKA-7025: Some Android compatibility for kafka-client [kafka]

2025-04-16 Thread via GitHub
github-actions[bot] closed pull request #17950: KAFKA-7025: Some Android compatibility for kafka-client URL: https://github.com/apache/kafka/pull/17950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] KAFKA-19019: Add support for remote storage fetch for share groups [kafka]

2025-04-16 Thread via GitHub
adixitconfluent commented on code in PR #19437: URL: https://github.com/apache/kafka/pull/19437#discussion_r2048256117 ## core/src/test/java/kafka/server/share/DelayedShareFetchTest.java: ## @@ -1155,6 +1170,537 @@ public void testOnCompleteExecutionOnTimeout() { assert

[jira] [Updated] (KAFKA-19166) Release tags are orphaned

2025-04-16 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-19166: - Fix Version/s: 4.0.1 > Release tags are orphaned > - > >

Re: [PR] KAFKA-19024 Enhance the client behaviour when it tries to exceed the `group.share.max.groups` [kafka]

2025-04-16 Thread via GitHub
DL1231 closed pull request #19313: KAFKA-19024 Enhance the client behaviour when it tries to exceed the `group.share.max.groups` URL: https://github.com/apache/kafka/pull/19313 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Created] (KAFKA-19167) Move RemoteLogManagerConfig out of KafkaConfig

2025-04-16 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19167: -- Summary: Move RemoteLogManagerConfig out of KafkaConfig Key: KAFKA-19167 URL: https://issues.apache.org/jira/browse/KAFKA-19167 Project: Kafka Issue Type

[jira] [Updated] (KAFKA-19054) StreamThread exception handling with SHUTDOWN_APPLICATION may trigger a tight loop with MANY logs

2025-04-16 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19054: Affects Version/s: 2.8.0 (was: 3.7.1) > StreamThread exception

[jira] [Commented] (KAFKA-19156) Remove group.share.max.groups config

2025-04-16 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17945211#comment-17945211 ] Lan Ding commented on KAFKA-19156: -- Hi [~cwadhwa] , If this ticket is still open, may I

  1   2   >