dajac commented on code in PR #19461:
URL: https://github.com/apache/kafka/pull/19461#discussion_r2047354258
##########
clients/src/main/java/org/apache/kafka/common/requests/OffsetCommitResponse.java:
##########
@@ -190,12 +203,85 @@ public Builder merge(
}
});
}
-
return this;
}
public OffsetCommitResponse build() {
return new OffsetCommitResponse(data);
}
}
+
+ public static class TopicIdBuilder extends Builder {
+ private final HashMap<Uuid, OffsetCommitResponseTopic> byTopicId = new
HashMap<>();
+
+ @Override
+ protected void add(OffsetCommitResponseTopic topic) {
+ throwIfTopicIdIsNull(topic.topicId());
+ data.topics().add(topic);
+ byTopicId.put(topic.topicId(), topic);
+ }
+
+ @Override
+ protected OffsetCommitResponseTopic get(Uuid topicId, String
topicName) {
+ throwIfTopicIdIsNull(topicId);
+ return byTopicId.get(topicId);
+ }
+
+ @Override
+ protected OffsetCommitResponseTopic getOrCreate(Uuid topicId, String
topicName) {
+ throwIfTopicIdIsNull(topicId);
+ OffsetCommitResponseTopic topic = byTopicId.get(topicId);
+ if (topic == null) {
+ topic = new OffsetCommitResponseTopic()
+ .setName(topicName)
+ .setTopicId(topicId);
+ data.topics().add(topic);
+ byTopicId.put(topicId, topic);
+ }
+ return topic;
+ }
+
+ private static void throwIfTopicIdIsNull(Uuid topicId) {
Review Comment:
You're right. It may not be needed but being defensive does not hurt, I
guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
