Yunyung commented on code in PR #19397:
URL: https://github.com/apache/kafka/pull/19397#discussion_r2046927417
##########
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java:
##########
@@ -269,18 +270,19 @@ List<String> configProviders() {
Map<String, String> transform(Map<String, String> props) {
// transform worker config according to config.providers
List<String> providerNames = configProviders();
- Map<String, ConfigProvider> providers = new HashMap<>();
+ Map<String, Plugin<ConfigProvider>> providerPlugins = new HashMap<>();
for (String name : providerNames) {
- ConfigProvider configProvider = plugins.newConfigProvider(
+ Plugin<ConfigProvider> configProviderPlugin =
plugins.newConfigProvider(
this,
- CONFIG_PROVIDERS_CONFIG + "." + name,
- Plugins.ClassLoaderUsage.PLUGINS
+ name,
Review Comment:
Yes, I improved the newConfigProvider API in order to reuse `name`
(providerName) in the method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
