jolshan commented on code in PR #19495:
URL: https://github.com/apache/kafka/pull/19495#discussion_r2047758771
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -256,7 +263,7 @@ private OffsetAndMetadata remove(
if (partitionOffsets.isEmpty())
topicOffsets.remove(topic);
- if (topicOffsets.isEmpty())
+ if (!preserveGroups && topicOffsets.isEmpty())
offsetsByGroup.remove(groupId);
Review Comment:
I guess we could also just remove from the openTransactionsByGroup here as
well? Not a strong opinion either way. If we do it this way we should also
clean it up when we remove from openTransactionByGroup? I don't think we want
to preserve it forever?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
