[PR] MINOR: remove unused parameter from KafkaMetadataLog [kafka]

2025-04-13 Thread via GitHub
shmily7829 opened a new pull request, #19458: URL: https://github.com/apache/kafka/pull/19458 remove unused parameter from KafkaMetadataLog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] KAFKA-18888: Add KIP-877 support to Authorizer [kafka]

2025-04-13 Thread via GitHub
mimaison commented on code in PR #19050: URL: https://github.com/apache/kafka/pull/19050#discussion_r2041136887 ## clients/src/main/java/org/apache/kafka/common/internals/Plugin.java: ## @@ -40,14 +47,46 @@ private Plugin(T instance, PluginMetricsImpl pluginMetrics) {

Re: [PR] KAFKA-18888: Add KIP-877 support to Authorizer [kafka]

2025-04-13 Thread via GitHub
mimaison commented on code in PR #19050: URL: https://github.com/apache/kafka/pull/19050#discussion_r2041137300 ## clients/src/main/java/org/apache/kafka/common/internals/Plugin.java: ## @@ -60,6 +99,13 @@ private static Map tags(String key, T instance) { return tags;

Re: [PR] KAFKA-18888: Add KIP-877 support to Authorizer [kafka]

2025-04-13 Thread via GitHub
m1a2st commented on code in PR #19050: URL: https://github.com/apache/kafka/pull/19050#discussion_r2041132665 ## clients/src/main/java/org/apache/kafka/common/internals/Plugin.java: ## @@ -40,14 +47,46 @@ private Plugin(T instance, PluginMetricsImpl pluginMetrics) { th

Re: [PR] KAFKA-18888: Add KIP-877 support to Authorizer [kafka]

2025-04-13 Thread via GitHub
m1a2st commented on code in PR #19050: URL: https://github.com/apache/kafka/pull/19050#discussion_r2041132013 ## clients/src/main/java/org/apache/kafka/common/internals/Plugin.java: ## @@ -40,14 +47,46 @@ private Plugin(T instance, PluginMetricsImpl pluginMetrics) { th

Re: [PR] KAFKA-18888: Add KIP-877 support to Authorizer [kafka]

2025-04-13 Thread via GitHub
mimaison commented on code in PR #19050: URL: https://github.com/apache/kafka/pull/19050#discussion_r2041137804 ## clients/src/main/java/org/apache/kafka/common/internals/Plugin.java: ## @@ -40,14 +47,46 @@ private Plugin(T instance, PluginMetricsImpl pluginMetrics) {

Re: [PR] KAFKA-19121: Move AddPartitionsToTxnConfig and TransactionStateManagerConfig out of KafkaConfig [kafka]

2025-04-13 Thread via GitHub
FrankYang0529 commented on code in PR #19439: URL: https://github.com/apache/kafka/pull/19439#discussion_r2041137473 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -204,11 +203,6 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) private va

Re: [PR] KAFKA-18888: Add KIP-877 support to Authorizer [kafka]

2025-04-13 Thread via GitHub
m1a2st commented on code in PR #19050: URL: https://github.com/apache/kafka/pull/19050#discussion_r2041145949 ## clients/src/main/java/org/apache/kafka/common/internals/Plugin.java: ## @@ -40,14 +47,46 @@ private Plugin(T instance, PluginMetricsImpl pluginMetrics) { th

Re: [PR] Support keystore with multiple alias entries [kafka]

2025-04-13 Thread via GitHub
mimaison commented on PR #17560: URL: https://github.com/apache/kafka/pull/17560#issuecomment-2799977197 Usually when people address reviews and make updates to their KIP, they also reply to the DISCUSS thread, you know to keep the discussion going. -- This is an automated message from th

[jira] [Updated] (KAFKA-19135) Add IQ Support - move from feature branch

2025-04-13 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck updated KAFKA-19135: Parent: KAFKA-17125 Issue Type: Sub-task (was: Task) > Add IQ Support - move from feature

[jira] [Created] (KAFKA-19135) Add IQ Support - move from feature branch

2025-04-13 Thread Bill Bejeck (Jira)
Bill Bejeck created KAFKA-19135: --- Summary: Add IQ Support - move from feature branch Key: KAFKA-19135 URL: https://issues.apache.org/jira/browse/KAFKA-19135 Project: Kafka Issue Type: Task

Re: [PR] MINOR: remove unused parameter from KafkaMetadataLog [kafka]

2025-04-13 Thread via GitHub
frankvicky commented on code in PR #19458: URL: https://github.com/apache/kafka/pull/19458#discussion_r2041152696 ## core/src/main/scala/kafka/raft/KafkaMetadataLog.scala: ## @@ -698,9 +698,7 @@ object KafkaMetadataLog extends Logging { private def deleteSnapshotFiles(

[PR] KAFKA-19117: Client Throttling Log messages should be of log level - WARN (Java client) [kafka]

2025-04-13 Thread via GitHub
siddharthaDevineni opened a new pull request, #19456: URL: https://github.com/apache/kafka/pull/19456 We experienced an outage in our application due to a built up Kafka lag, which we eventually discovered to be the problem with Kafka Clients being throttled. Even when using the conf

[PR] KAFKA-19110: Add missing unit test for Streams-consumer integration (wip) [kafka]

2025-04-13 Thread via GitHub
FrankYang0529 opened a new pull request, #19457: URL: https://github.com/apache/kafka/pull/19457 - Construct `AsyncKafkaConsumer` constructor and verify that the `RequestManagers.supplier()` contains Streams-specific data structures. - Verify that `RequestManagers` constructs the Streams

[jira] [Assigned] (KAFKA-19092) Flaky test QuorumControllerTest#testBalancePartitionLeaders

2025-04-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-19092: -- Assignee: Divya > Flaky test QuorumControllerTest#testBalancePartitionLeaders > -

[jira] [Commented] (KAFKA-19092) Flaky test QuorumControllerTest#testBalancePartitionLeaders

2025-04-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943913#comment-17943913 ] Chia-Ping Tsai commented on KAFKA-19092: [~divya2890]  I have assigned this Jira

[jira] [Comment Edited] (KAFKA-19117) Client Throttling Log messages should be of log level - WARN (Java client)

2025-04-13 Thread Siddhartha Devineni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943842#comment-17943842 ] Siddhartha Devineni edited comment on KAFKA-19117 at 4/13/25 1:45 PM:

Re: [PR] MINOR: Simplify PartitionStates update logic by removing unnecessary grouping [kafka]

2025-04-13 Thread via GitHub
zt52875287 commented on code in PR #19442: URL: https://github.com/apache/kafka/pull/19442#discussion_r2041284312 ## clients/src/main/java/org/apache/kafka/common/internals/PartitionStates.java: ## @@ -138,17 +138,7 @@ private void updateSize() { } private void updat

[jira] [Commented] (KAFKA-19052) Document how to query versioned stores/KTables

2025-04-13 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943998#comment-17943998 ] PoAn Yang commented on KAFKA-19052: --- [~atusharm], reassign to you. > Document how to

Re: [PR] KAFKA-15371: MetadataShell is stuck when bootstrapping [kafka]

2025-04-13 Thread via GitHub
gongxuanzhang commented on PR #19419: URL: https://github.com/apache/kafka/pull/19419#issuecomment-2800267756 @chia7712 PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Assigned] (KAFKA-19052) Document how to query versioned stores/KTables

2025-04-13 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-19052: - Assignee: Atul Sharma (was: PoAn Yang) > Document how to query versioned stores/KTables >

Re: [PR] KAFKA-19102 Enhance the docs of group.coordinator.append.linger.ms [kafka]

2025-04-13 Thread via GitHub
frankvicky commented on code in PR #19451: URL: https://github.com/apache/kafka/pull/19451#discussion_r2041485690 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -66,7 +66,9 @@ public class GroupCoordinatorConfig {

[jira] [Updated] (KAFKA-19136) Move metadata-related configs from KRaftConfigs to MetadataLogConfig

2025-04-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19136: --- Summary: Move metadata-related configs from KRaftConfigs to MetadataLogConfig (was: Merge M

[jira] [Commented] (KAFKA-19136) Merge MetadataLogConfig into KRaftConfigs

2025-04-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944154#comment-17944154 ] Chia-Ping Tsai commented on KAFKA-19136: [~ijuma] thanks for quick response. you

Re: [PR] KAFKA-19121: Move AddPartitionsToTxnConfig and TransactionStateManagerConfig out of KafkaConfig [kafka]

2025-04-13 Thread via GitHub
chia7712 commented on code in PR #19439: URL: https://github.com/apache/kafka/pull/19439#discussion_r2041505982 ## core/src/main/scala/kafka/server/KafkaConfig.scala: ## @@ -204,11 +203,6 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) private val _sh

[jira] [Commented] (KAFKA-19052) Document how to query versioned stores/KTables

2025-04-13 Thread Atul Sharma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943933#comment-17943933 ] Atul Sharma commented on KAFKA-19052: - Hi [~yangpoan].. if you are not looking into

[jira] [Assigned] (KAFKA-19091) Flaky test DelayedFutureTest#testDelayedFuture

2025-04-13 Thread Uladzislau Blok (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uladzislau Blok reassigned KAFKA-19091: --- Assignee: Uladzislau Blok > Flaky test DelayedFutureTest#testDelayedFuture > --

Re: [PR] KAFKA-18888: Add KIP-877 support to Authorizer [kafka]

2025-04-13 Thread via GitHub
mimaison commented on code in PR #19050: URL: https://github.com/apache/kafka/pull/19050#discussion_r2041168550 ## clients/src/main/java/org/apache/kafka/common/internals/Plugin.java: ## @@ -40,14 +47,46 @@ private Plugin(T instance, PluginMetricsImpl pluginMetrics) {

Re: [PR] MINOR: Cleanups in connect:runtime [kafka]

2025-04-13 Thread via GitHub
frankvicky commented on code in PR #19452: URL: https://github.com/apache/kafka/pull/19452#discussion_r2041156088 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/RestartRequest.java: ## @@ -25,14 +25,12 @@ * A request to restart a connector and/or task instan

Re: [PR] MINOR: Cleanups in connect:runtime [kafka]

2025-04-13 Thread via GitHub
mimaison commented on code in PR #19452: URL: https://github.com/apache/kafka/pull/19452#discussion_r2041168391 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/RestartRequest.java: ## @@ -25,14 +25,12 @@ * A request to restart a connector and/or task instance

[jira] [Commented] (KAFKA-17939) Kafka Streams API exposes org.apache.kafka.common.utils.Bytes which is not part of the public API

2025-04-13 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943937#comment-17943937 ] Mickael Maison commented on KAFKA-17939: I found that some of the KafkaStreams c

[jira] [Commented] (KAFKA-19136) Merge MetadataLogConfig into KRaftConfigs

2025-04-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944102#comment-17944102 ] Ismael Juma commented on KAFKA-19136: - Hmm, there are two separate things: # Server

Re: [PR] KAFKA-15371: MetadataShell is stuck when bootstrapping [kafka]

2025-04-13 Thread via GitHub
chia7712 merged PR #19419: URL: https://github.com/apache/kafka/pull/19419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-15371) MetadataShell is stuck when bootstrapping

2025-04-13 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-15371. Fix Version/s: 4.1.0 Resolution: Fixed > MetadataShell is stuck when bootstrapping

Re: [PR] KAFKA-19015: Remove share session from cache on share consumer connection drop [kafka]

2025-04-13 Thread via GitHub
apoorvmittal10 commented on code in PR #19329: URL: https://github.com/apache/kafka/pull/19329#discussion_r2041222325 ## server/src/main/java/org/apache/kafka/server/share/session/ShareSessionCache.java: ## @@ -140,50 +124,46 @@ public synchronized void touch(ShareSession sessio

[jira] [Assigned] (KAFKA-19039) The refresh_collaborators.py script messes .asf.yaml

2025-04-13 Thread Siyang He (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyang He reassigned KAFKA-19039: - Assignee: Siyang He > The refresh_collaborators.py script messes .asf.yaml > --

[jira] [Commented] (KAFKA-17939) Kafka Streams API exposes org.apache.kafka.common.utils.Bytes which is not part of the public API

2025-04-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943946#comment-17943946 ] Ismael Juma commented on KAFKA-17939: - I think we need to use one of the existing to

[jira] [Commented] (KAFKA-18731) KStream-GlobalKTabel ValueJoinerWithKey passed incorrect key

2025-04-13 Thread Siddhartha Devineni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943954#comment-17943954 ] Siddhartha Devineni commented on KAFKA-18731: - Hello [~mjsax], Could I take

[jira] [Resolved] (KAFKA-19043) Move DelayedRemoteListOffsets to the storage module

2025-04-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-19043. - Fix Version/s: 4.1.0 Resolution: Fixed Looks like this was done via https://github.com/ap

Re: [PR] KAFKA-14523: Decouple RemoteLogManager and Partition [kafka]

2025-04-13 Thread via GitHub
ijuma commented on PR #19391: URL: https://github.com/apache/kafka/pull/19391#issuecomment-2800171113 > RemoteLogManager depends on it and it is in the server module and depends on LogConfig in the storage module so we can't just move it to server-common. Looks like all it needs is ac

[jira] [Commented] (KAFKA-17861) Serialize with ByteBuffer instead of byte[]

2025-04-13 Thread Siddhartha Devineni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943953#comment-17943953 ] Siddhartha Devineni commented on KAFKA-17861: - Hello [~shennenkamp], Is the

[PR] KAFKA-19039: The refresh_collaborators.py script messes .asf.yaml [kafka]

2025-04-13 Thread via GitHub
decaf12 opened a new pull request, #19459: URL: https://github.com/apache/kafka/pull/19459 `update_local_yaml_content` in `refresh_collaborators.py` instantiates a YAML object with no arguments. As such, the YAML object defaults to using a `RoundTripRepresenter` under the hood, which serial

Re: [PR] KAFKA-18039: Test all versions of quorum responses in RequestResponseTest [kafka]

2025-04-13 Thread via GitHub
github-actions[bot] commented on PR #17873: URL: https://github.com/apache/kafka/pull/17873#issuecomment-2800395118 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-17444: fix high memory allocation rate for FetchSession.update [kafka]

2025-04-13 Thread via GitHub
lifepuzzlefun commented on PR #17052: URL: https://github.com/apache/kafka/pull/17052#issuecomment-2800323695 ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] KAFKA-19071: Fix doc for remote.storage.enable [kafka]

2025-04-13 Thread via GitHub
showuon commented on code in PR #19345: URL: https://github.com/apache/kafka/pull/19345#discussion_r2041319621 ## core/src/test/scala/integration/kafka/admin/RemoteTopicCrudTest.scala: ## @@ -441,7 +441,36 @@ class RemoteTopicCrudTest extends IntegrationTestHarness {

Re: [PR] KAFKA-19071: Fix doc for remote.storage.enable [kafka]

2025-04-13 Thread via GitHub
showuon commented on PR #19345: URL: https://github.com/apache/kafka/pull/19345#issuecomment-2800330421 @m1a2st , do you have any other comments on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-14523) Move RemoteLogManager to the storage module

2025-04-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17943984#comment-17943984 ] Ismael Juma commented on KAFKA-14523: - [~mimaison] Looks like you're working on this

Re: [PR] MINOR: Cleanups in connect:runtime [kafka]

2025-04-13 Thread via GitHub
frankvicky commented on code in PR #19452: URL: https://github.com/apache/kafka/pull/19452#discussion_r2041315836 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/RestartRequest.java: ## @@ -25,33 +25,26 @@ * A request to restart a connector and/or task instan

Re: [PR] KAFKA-19071: Fix doc for remote.storage.enable [kafka]

2025-04-13 Thread via GitHub
showuon commented on PR #19345: URL: https://github.com/apache/kafka/pull/19345#issuecomment-2800366299 Thanks for the fix @azhar2407 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] KAFKA-19071: Fix doc for remote.storage.enable [kafka]

2025-04-13 Thread via GitHub
showuon merged PR #19345: URL: https://github.com/apache/kafka/pull/19345 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Resolved] (KAFKA-19071) Incorrect documentation for remote.storage.enable

2025-04-13 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-19071. --- Fix Version/s: 4.1.0 3.9.1 4.0.1 Resolution: Fixed > In

Re: [PR] KAFKA-18877: Add an mechanism to find cases where we accessed variables from the wrong thread. [kafka]

2025-04-13 Thread via GitHub
github-actions[bot] commented on PR #19231: URL: https://github.com/apache/kafka/pull/19231#issuecomment-2800376515 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-04-13 Thread via GitHub
github-actions[bot] commented on PR #19236: URL: https://github.com/apache/kafka/pull/19236#issuecomment-2800376480 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[jira] [Commented] (KAFKA-19026) AlterConfigPolicy incompatibility between ZK mode and KRaft mode when using AlterConfigOp.OpType.SUBTRACT/APPEND

2025-04-13 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944012#comment-17944012 ] Luke Chen commented on KAFKA-19026: --- [~ecomar] , could I know what impact is this issu

Re: [PR] KAFKA-15767: Refactor TransactionManager to avoid use of ThreadLocal [kafka]

2025-04-13 Thread via GitHub
chia7712 commented on code in PR #19440: URL: https://github.com/apache/kafka/pull/19440#discussion_r2041523678 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -171,7 +171,25 @@ public class TransactionManager { * *