[ 
https://issues.apache.org/jira/browse/KAFKA-19136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17944154#comment-17944154
 ] 

Chia-Ping Tsai commented on KAFKA-19136:
----------------------------------------

[~ijuma] thanks for quick response. you are right that KRaftConfigs has some 
server-related configs, so merging them is not good idea. We should extract the 
metadata-related configs from KRaftConfigs to MetadataLogConfig.  Also, we can 
move node.id from MetadataLogConfig to KafkaMetadataLog's constructor. With 
this approach, we will have a smaller KafkaConfig and a MetadataLogConfig 
having metadata-related configs and variables. In the follow-up, we can do a 
refactor for KRaftConfig's' by moving getters from KafkaConfig to KRaftConfig.

> Merge MetadataLogConfig into KRaftConfigs
> -----------------------------------------
>
>                 Key: KAFKA-19136
>                 URL: https://issues.apache.org/jira/browse/KAFKA-19136
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Chia-Ping Tsai
>            Assignee: Logan Zhu
>            Priority: Minor
>
> Most config class consists of definition and POJO, so we should merge 
> MetadataLogConfig with KRaftConfigs



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to