chia7712 commented on code in PR #19439: URL: https://github.com/apache/kafka/pull/19439#discussion_r2041505982
########## core/src/main/scala/kafka/server/KafkaConfig.scala: ########## @@ -204,11 +203,6 @@ class KafkaConfig private(doLog: Boolean, val props: util.Map[_, _]) private val _shareCoordinatorConfig = new ShareCoordinatorConfig(this) def shareCoordinatorConfig: ShareCoordinatorConfig = _shareCoordinatorConfig - private val _transactionStateManagerConfig = new TransactionStateManagerConfig(this) - private val _addPartitionsToTxnConfig = new AddPartitionsToTxnConfig(this) - def transactionStateManagerConfig: TransactionStateManagerConfig = _transactionStateManagerConfig Review Comment: @FrankYang0529 sorry for my unclear comment. My point was `TransactionLogConfig` should not hold `KafkaConfig` anymore. I will file a jira for it. `TransactionStateManagerConfig` and `AddPartitionsToTxnConfig` constructor should take `AbstractConfig` as input for consistency. Sorry for my unclear comment again. Could you please revert the changes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
