frankvicky commented on code in PR #19458:
URL: https://github.com/apache/kafka/pull/19458#discussion_r2041152696
##########
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##########
@@ -698,9 +698,7 @@ object KafkaMetadataLog extends Logging {
private def deleteSnapshotFiles(
logDir: Path,
- expiredSnapshots: mutable.TreeMap[OffsetAndEpoch,
Option[FileRawSnapshotReader]],
- logging: Logging
- ): Unit = {
+ expiredSnapshots: mutable.TreeMap[OffsetAndEpoch,
Option[FileRawSnapshotReader]]): Unit = {
expiredSnapshots.foreach { case (snapshotId, snapshotReader) =>
snapshotReader.foreach { reader =>
Utils.closeQuietly(reader, "reader")
Review Comment:
The second argument is for logging purposes.
Should we use a more meaningful name instead of "reader"?
To me, "reader" doesn't provide too much value for troubleshooting.
For example: "FileRawSnapshotReader"
cc @chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
