[jira] [Updated] (KAFKA-19047) Broker registrations are slow if previously fenced or shutdown

2025-03-27 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-19047: --- Issue Type: Bug (was: Improvement) > Broker registrations are slow

[PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2025-03-27 Thread via GitHub
AyoubOm opened a new pull request, #19303: URL: https://github.com/apache/kafka/pull/19303 This fixes both KAFKA-16407 and KAFKA-16434. Summary of existing issues: - We are ignoring new left record when its **previous** FK value is null - We do not unset foreign key join resu

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
ShivsundarR commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016129362 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if

[jira] [Updated] (KAFKA-7699) Improve wall-clock time punctuations

2025-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-7699: --- Description: KIP-1146: [https://cwiki.apache.org/confluence/display/KAFKA/KIP-1146%3A+Anchor

Re: [PR] MINOR: Move inner test classes out of CoordinatorRuntimeTest [kafka]

2025-03-27 Thread via GitHub
squah-confluent commented on code in PR #19258: URL: https://github.com/apache/kafka/pull/19258#discussion_r2007416635 ## coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/MockCoordinatorShard.java: ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache S

[jira] [Commented] (KAFKA-7952) Consider to switch to in-memory stores in test whenever possible

2025-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939094#comment-17939094 ] Matthias J. Sax commented on KAFKA-7952: [~lorcanj] Thanks for the PR. I'll try t

Re: [PR] KAFKA-17662: config.providers configuration missing from the docs [kafka]

2025-03-27 Thread via GitHub
gharris1727 commented on code in PR #18930: URL: https://github.com/apache/kafka/pull/18930#discussion_r2017574587 ## clients/src/main/java/org/apache/kafka/clients/admin/AdminClientConfig.java: ## @@ -289,6 +295,13 @@ protected Map postProcessParsedConfig(final Map Co

[jira] [Updated] (KAFKA-6840) support windowing in ktable API

2025-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-6840: --- Priority: Major (was: Blocker) > support windowing in ktable API > -

[jira] [Comment Edited] (KAFKA-19047) Broker registrations are slow if previously fenced or shutdown

2025-03-27 Thread Gunnar Morling (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939055#comment-17939055 ] Gunnar Morling edited comment on KAFKA-19047 at 3/27/25 7:42 PM: -

Re: [PR] MINOR: Refactor GroupCoordinator write path [kafka]

2025-03-27 Thread via GitHub
jeffkbkim commented on code in PR #19290: URL: https://github.com/apache/kafka/pull/19290#discussion_r2016876236 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -661,16 +705,18 @@ class ReplicaManager(val config: KafkaConfig, return } -val sTime

Re: [PR] MINOR: Refactor GroupCoordinator write path [kafka]

2025-03-27 Thread via GitHub
dajac commented on code in PR #19290: URL: https://github.com/apache/kafka/pull/19290#discussion_r2016912371 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -661,16 +705,18 @@ class ReplicaManager(val config: KafkaConfig, return } -val sTime = t

Re: [PR] MINOR: Refactor GroupCoordinator write path [kafka]

2025-03-27 Thread via GitHub
dajac merged PR #19290: URL: https://github.com/apache/kafka/pull/19290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[PR] KAFKA-14487: Move LogManager static methods/fields to storage module [kafka]

2025-03-27 Thread via GitHub
mimaison opened a new pull request, #19302: URL: https://github.com/apache/kafka/pull/19302 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[jira] [Commented] (KAFKA-19047) Broker registrations are slow if previously fenced or shutdown

2025-03-27 Thread Gunnar Morling (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939055#comment-17939055 ] Gunnar Morling commented on KAFKA-19047: For reference, here are the logs I've o

Re: [PR] KAFKA-10409: Refactor Kakfa Streams RocksDB Iterators [kafka]

2025-03-27 Thread via GitHub
fonsdant commented on code in PR #18610: URL: https://github.com/apache/kafka/pull/18610#discussion_r2017792607 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java: ## @@ -277,197 +275,361 @@ public void close() { } } -

[jira] [Updated] (KAFKA-18797) Flaky testLargeAssignmentAndGroupWithUniformSubscription

2025-03-27 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-18797: -- Attachment: testLargeAssignmentAndGroupWithUniformSubscription.jfr > Flaky testLargeAssignmentAndGroup

[jira] [Updated] (KAFKA-19050) kafka-streams-integration-tests artifact is empty

2025-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19050: Priority: Blocker (was: Major) > kafka-streams-integration-tests artifact is empty >

[jira] [Updated] (KAFKA-19050) kafka-streams-integration-tests artifact is empty

2025-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19050: Fix Version/s: 4.1.0 4.0.1 > kafka-streams-integration-tests artifact i

Re: [PR] KAFKA-10844: groupBy without shuffling [kafka]

2025-03-27 Thread via GitHub
fonsdant commented on PR #18811: URL: https://github.com/apache/kafka/pull/18811#issuecomment-2759887172 @mjsax, I would like to suggest that we adopt "skip repartition" instead of "mark as partitioned". It seems to me to be more consistent with the rest of the KStream API methods and its f

[jira] [Updated] (KAFKA-19050) kafka-streams-integration-tests artifact is empty

2025-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19050: Component/s: streams > kafka-streams-integration-tests artifact is empty > ---

Re: [PR] KAFKA-18980: OffsetMetadataManager#cleanupExpiredOffsets should record the number of records rather than topic partitions [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19207: URL: https://github.com/apache/kafka/pull/19207#discussion_r2006072232 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -875,7 +872,7 @@ public boolean cleanupExpiredOffsets(String gr

Re: [PR] KAFKA-10409: Refactor Kakfa Streams RocksDB Iterators [kafka]

2025-03-27 Thread via GitHub
fonsdant commented on code in PR #18610: URL: https://github.com/apache/kafka/pull/18610#discussion_r2017792885 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java: ## @@ -277,197 +275,361 @@ public void close() { } } -

Re: [PR] KAFKA-10409: Refactor Kakfa Streams RocksDB Iterators [kafka]

2025-03-27 Thread via GitHub
fonsdant commented on code in PR #18610: URL: https://github.com/apache/kafka/pull/18610#discussion_r2017793076 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java: ## @@ -277,197 +275,361 @@ public void close() { } } -

Re: [PR] MINOR: Add 4.0.0 to streams system tests [kafka]

2025-03-27 Thread via GitHub
dajac merged PR #19239: URL: https://github.com/apache/kafka/pull/19239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-19004:Move DelayedDeleteRecords to server-common module [kafka]

2025-03-27 Thread via GitHub
gongxuanzhang commented on code in PR #19226: URL: https://github.com/apache/kafka/pull/19226#discussion_r2017802756 ## server-common/src/main/java/org/apache/kafka/server/common/DelayedDeleteRecords.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] MINOR UnifiedLog topic-partition as attribute as it is stable [kafka]

2025-03-27 Thread via GitHub
github-actions[bot] commented on PR #19253: URL: https://github.com/apache/kafka/pull/19253#issuecomment-2760076574 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18877: Add an mechanism to find cases where we accessed variables from the wrong thread. [kafka]

2025-03-27 Thread via GitHub
github-actions[bot] commented on PR #19231: URL: https://github.com/apache/kafka/pull/19231#issuecomment-2760076628 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18068: Fixing typo in ProducerConfig [kafka]

2025-03-27 Thread via GitHub
github-actions[bot] commented on PR #17908: URL: https://github.com/apache/kafka/pull/17908#issuecomment-2760101395 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-7516: Attempt to dynamically load ManagementFactory class [kafka]

2025-03-27 Thread via GitHub
github-actions[bot] commented on PR #17969: URL: https://github.com/apache/kafka/pull/17969#issuecomment-2760101431 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-7516: Attempt to dynamically load ManagementFactory class [kafka]

2025-03-27 Thread via GitHub
github-actions[bot] closed pull request #17969: KAFKA-7516: Attempt to dynamically load ManagementFactory class URL: https://github.com/apache/kafka/pull/17969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-18068: Fixing typo in ProducerConfig [kafka]

2025-03-27 Thread via GitHub
github-actions[bot] closed pull request #17908: KAFKA-18068: Fixing typo in ProducerConfig URL: https://github.com/apache/kafka/pull/17908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] KAFKA-17423 Trie implementation [kafka]

2025-03-27 Thread via GitHub
github-actions[bot] commented on PR #17087: URL: https://github.com/apache/kafka/pull/17087#issuecomment-2760101352 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

[jira] [Commented] (KAFKA-3370) Add options to auto.offset.reset to reset offsets upon initialization only

2025-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939097#comment-17939097 ] Matthias J. Sax commented on KAFKA-3370: Nobody is currently working on this AFAI

[jira] [Commented] (KAFKA-19050) kafka-streams-integration-tests artifact is empty

2025-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939098#comment-17939098 ] Matthias J. Sax commented on KAFKA-19050: - There was always a desire for some pu

Re: [PR] KAFKA-10409: Refactor Kakfa Streams RocksDB Iterators [kafka]

2025-03-27 Thread via GitHub
fonsdant commented on PR #18610: URL: https://github.com/apache/kafka/pull/18610#issuecomment-2759949221 @agavra, thanks for reviewing! I have push some commits :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-17078: Add SecurityManagerCompatibility shim (#16522) [kafka]

2025-03-27 Thread via GitHub
showuon commented on PR #19221: URL: https://github.com/apache/kafka/pull/19221#issuecomment-2760036097 Let's wait until we have consensus in the community. I've replied in this thread: https://lists.apache.org/thread/6k942pphowd28dh9gn6xbnngk6nxs3n0 . @gharris1727 , it'd be good if you cou

[jira] [Commented] (KAFKA-19024) Enhance the client behaviour when it tries to exceed the `group.share.max.groups`

2025-03-27 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939117#comment-17939117 ] Lan Ding commented on KAFKA-19024: -- In the current implementation, the `group.share.max

[jira] [Assigned] (KAFKA-17541) Improve handling of delivery count

2025-03-27 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lan Ding reassigned KAFKA-17541: Assignee: Lan Ding (was: Andrew Schofield) > Improve handling of delivery count > --

[jira] [Updated] (KAFKA-19048) Minimal Movement Replica Balancing algorithm

2025-03-27 Thread Jialun Peng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jialun Peng updated KAFKA-19048: Description: h2. Motivation Kafka clusters typically require rebalancing of topic replicas after

Re: [PR] KAFKA-18991: FetcherThread should match leader epochs between fetch request and fetch state [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on PR #19223: URL: https://github.com/apache/kafka/pull/19223#issuecomment-2752123826 I try to cherry-pick https://github.com/apache/kafka/commit/4a8a0637e07734779b40ba9785842311144f922c to 4.0, but there are some conflicts. @jsancio do you have free cycle to file PR to

[jira] [Assigned] (KAFKA-9904) Use ThreadLocalConcurrent to Replace Random

2025-03-27 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorcan reassigned KAFKA-9904: - Assignee: Lorcan > Use ThreadLocalConcurrent to Replace Random > ---

[jira] [Commented] (KAFKA-14485) Move LogCleaner to storage module

2025-03-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938848#comment-17938848 ] Chia-Ping Tsai commented on KAFKA-14485: [~javakillah] that is a good question.

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016068726 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if (cu

Re: [PR] KAFKA-19036: Rewrite LogAppendTimeTest and move it to storage module [kafka]

2025-03-27 Thread via GitHub
FrankYang0529 commented on PR #19282: URL: https://github.com/apache/kafka/pull/19282#issuecomment-2757324418 @chia7712 Thanks for the review. I addressed all comments and CI passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] KAFKA-19004:Move DelayedDeleteRecords to server-common module [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19226: URL: https://github.com/apache/kafka/pull/19226#discussion_r2016093160 ## server-common/src/main/java/org/apache/kafka/server/common/DelayedDeleteRecords.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-19032: Remove TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames [kafka]

2025-03-27 Thread via GitHub
FrankYang0529 commented on PR #19270: URL: https://github.com/apache/kafka/pull/19270#issuecomment-2757323381 @chia7712 Thanks for the reminder. I fix conflicts and CI passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Assigned] (KAFKA-18902) Implement ShareConsumer option to throw on poll if there are unacked records

2025-03-27 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-18902: Assignee: Andrew Schofield (was: Shivsundar R) > Implement ShareConsumer option

Re: [PR] KAFKA-19049: Remove the `@ExtendWith(ClusterTestExtensions.class)` from code base [kafka]

2025-03-27 Thread via GitHub
Rancho-7 commented on PR #19299: URL: https://github.com/apache/kafka/pull/19299#issuecomment-2757438387 > @Rancho-7 please cleanup `SaslApiVersionsRequestTest` and `StaticBrokerConfigTest` too Thanks for pointing out! Will fix it soon. -- This is an automated message from the Apac

Re: [PR] MINOR: migrate BrokerCompressionTest to storage module [kafka]

2025-03-27 Thread via GitHub
TaiJuWu commented on code in PR #19277: URL: https://github.com/apache/kafka/pull/19277#discussion_r2016120749 ## storage/src/test/java/org/apache/kafka/storage/internals/log/BrokerCompressionTest.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
ShivsundarR commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016129362 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
ShivsundarR commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016129362 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
ShivsundarR commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016129362 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if

Re: [PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-03-27 Thread via GitHub
dajac commented on PR #19281: URL: https://github.com/apache/kafka/pull/19281#issuecomment-2757464241 > nit: It appears `ShareGroupHeartbeatRequestTest` also requires cleanup. However, it's acceptable to leave it as is - or we can fix it in the follow-up Removed it and few others rela

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
ShivsundarR commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016129362 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
ShivsundarR commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016129362 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if

Re: [PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-03-27 Thread via GitHub
dajac commented on code in PR #19281: URL: https://github.com/apache/kafka/pull/19281#discussion_r2015985621 ## core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestTest.scala: ## @@ -37,15 +37,17 @@ import java.lang.{Byte => JByte} import java.util.Collections im

Re: [PR] KAFKA-19042: [4/N] Move PlaintextConsumerCallbackTest to client-integration-tests module [kafka]

2025-03-27 Thread via GitHub
frankvicky commented on code in PR #19298: URL: https://github.com/apache/kafka/pull/19298#discussion_r2015873494 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/callback/PlaintextConsumerCallbackTest.java: ## @@ -0,0 +1,382 @@ +/* + * Licensed to the

Re: [PR] MINOR: migrate BrokerCompressionTest to storage module [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19277: URL: https://github.com/apache/kafka/pull/19277#discussion_r2015807142 ## storage/src/test/java/org/apache/kafka/storage/internals/log/BrokerCompressionTest.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-03-27 Thread via GitHub
dajac commented on code in PR #19281: URL: https://github.com/apache/kafka/pull/19281#discussion_r2015820533 ## core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestTest.scala: ## @@ -37,15 +37,17 @@ import java.lang.{Byte => JByte} import java.util.Collections im

[jira] [Created] (KAFKA-19049) Remove the `@ExtendWith(ClusterTestExtensions.class)` from code base

2025-03-27 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19049: -- Summary: Remove the `@ExtendWith(ClusterTestExtensions.class)` from code base Key: KAFKA-19049 URL: https://issues.apache.org/jira/browse/KAFKA-19049 Project: Kaf

Re: [PR] KAFKA-19036: Rewrite LogAppendTimeTest and move it to storage module [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19282: URL: https://github.com/apache/kafka/pull/19282#discussion_r2015816441 ## storage/src/test/java/org/apache/kafka/server/log/LogAppendTimeTest.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-27 Thread via GitHub
wernerdv commented on PR #19216: URL: https://github.com/apache/kafka/pull/19216#issuecomment-2756859134 @chia7712 @junrao @mimaison @frankvicky Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19281: URL: https://github.com/apache/kafka/pull/19281#discussion_r2015826951 ## core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestTest.scala: ## @@ -37,15 +37,17 @@ import java.lang.{Byte => JByte} import java.util.Collections

[jira] [Assigned] (KAFKA-19049) Remove the `@ExtendWith(ClusterTestExtensions.class)` from code base

2025-03-27 Thread Nick Guo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Guo reassigned KAFKA-19049: Assignee: Nick Guo (was: Chia-Ping Tsai) > Remove the `@ExtendWith(ClusterTestExtensions.class)`

[jira] [Commented] (KAFKA-19049) Remove the `@ExtendWith(ClusterTestExtensions.class)` from code base

2025-03-27 Thread Nick Guo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938828#comment-17938828 ] Nick Guo commented on KAFKA-19049: -- Hi [~chia7712] ,I would like to take this issue.Tha

Re: [PR] KAFKA-18067: Add a flag to disable producer reset during active task creator shutting down [kafka]

2025-03-27 Thread via GitHub
frankvicky commented on PR #19269: URL: https://github.com/apache/kafka/pull/19269#issuecomment-2757028923 Hi @ableegoldman, > can you look into adding a test to make sure that the producer does still get reset/recreated properly if the producer is reset (eg transaction hits a timeou

[PR] KAFKA-19049: Remove the `@ExtendWith(ClusterTestExtensions.class)` from code base [kafka]

2025-03-27 Thread via GitHub
Rancho-7 opened a new pull request, #19299: URL: https://github.com/apache/kafka/pull/19299 jira: https://issues.apache.org/jira/browse/KAFKA-19049 [KAFKA-18671](https://issues.apache.org/jira/browse/KAFKA-18671) introduced the mechanism to inject the cluster test at runtime, so the i

Re: [PR] MINOR: Revert migrate LogFetchInfo, Assignment and RequestAndCompletionHandler to java record [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19177: URL: https://github.com/apache/kafka/pull/19177#discussion_r2016096742 ## server/src/main/java/org/apache/kafka/server/Assignment.java: ## @@ -24,25 +24,62 @@ import org.apache.kafka.metadata.Replicas; import org.apache.kafka.server.com

[jira] [Resolved] (KAFKA-17830) Cover unit tests for TBRLMM init failure scenarios

2025-03-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17830. Fix Version/s: 4.1.0 Assignee: PoAn Yang (was: Anshul Goyal) Resolution: F

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
ShivsundarR commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016129362 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if

Re: [PR] KAFKA-19036: Rewrite LogAppendTimeTest and move it to storage module [kafka]

2025-03-27 Thread via GitHub
FrankYang0529 commented on code in PR #19282: URL: https://github.com/apache/kafka/pull/19282#discussion_r2016935923 ## storage/src/test/java/org/apache/kafka/server/log/LogAppendTimeTest.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] KAFKA-18390: Use LinkedHashMap instead of Map in creating MetricName and SensorBuilder (1/N) [kafka]

2025-03-27 Thread via GitHub
dajac commented on PR #19300: URL: https://github.com/apache/kafka/pull/19300#issuecomment-2757903933 @TaiJuWu Thanks for the patch. Out of curiosity, have we checked that jmx metric names are not altered by this change? I think that they are generated based on the order in the data structu

Re: [PR] KAFKA-19032: Remove TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on PR #19270: URL: https://github.com/apache/kafka/pull/19270#issuecomment-2757016872 @FrankYang0529 could you please fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-18826: Add global thread metrics [kafka]

2025-03-27 Thread via GitHub
bbejeck commented on PR #18953: URL: https://github.com/apache/kafka/pull/18953#issuecomment-2758977759 @mjsax comments addressed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Assigned] (KAFKA-19024) Enhance the client behaviour when it tries to exceed the `group.share.max.groups`

2025-03-27 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-19024: Assignee: Lan Ding (was: Andrew Schofield) By all means. Here you go. > Enhance

[jira] [Commented] (KAFKA-18971) Update AK system tests for AK 4.0

2025-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939041#comment-17939041 ] Matthias J. Sax commented on KAFKA-18971: - Seems this is already done: [https://

[jira] [Commented] (KAFKA-17541) Improve handling of delivery count

2025-03-27 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939043#comment-17939043 ] Andrew Schofield commented on KAFKA-17541: -- Sure, if the description is clear.

[jira] [Assigned] (KAFKA-19047) Broker registrations are slow if previously fenced or shutdown

2025-03-27 Thread Alyssa Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alyssa Huang reassigned KAFKA-19047: Assignee: Alyssa Huang > Broker registrations are slow if previously fenced or shutdown >

[jira] [Updated] (KAFKA-19048) Minimal Movement Replica Balancing algorithm

2025-03-27 Thread Jialun Peng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jialun Peng updated KAFKA-19048: Labels: pull-request-available (was: ) > Minimal Movement Replica Balancing algorithm > -

Re: [PR] KAFKA-18935: Ensure brokers do not return null records in FetchResponse [kafka]

2025-03-27 Thread via GitHub
frankvicky commented on code in PR #19167: URL: https://github.com/apache/kafka/pull/19167#discussion_r2016857591 ## clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java: ## @@ -89,7 +89,7 @@ public FetchResponseData data() { */ public FetchRespon

Re: [PR] MINOR: add log4j2.yaml to clients-integration-tests module [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19252: URL: https://github.com/apache/kafka/pull/19252#discussion_r2006232652 ## clients/clients-integration-tests/src/test/resources/log4j2.yaml: ## @@ -0,0 +1,32 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contr

Re: [PR] KAFKA-18826: Add global thread metrics [kafka]

2025-03-27 Thread via GitHub
bbejeck commented on code in PR #18953: URL: https://github.com/apache/kafka/pull/18953#discussion_r2017246779 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java: ## @@ -496,16 +483,20 @@ private void addGlob

Re: [PR] KAFKA-18826: Add global thread metrics [kafka]

2025-03-27 Thread via GitHub
bbejeck commented on code in PR #18953: URL: https://github.com/apache/kafka/pull/18953#discussion_r2017220549 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java: ## @@ -496,16 +483,20 @@ private void addGlob

Re: [PR] KAFKA-18826: Add global thread metrics [kafka]

2025-03-27 Thread via GitHub
bbejeck commented on code in PR #18953: URL: https://github.com/apache/kafka/pull/18953#discussion_r2017246779 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KafkaStreamsTelemetryIntegrationTest.java: ## @@ -496,16 +483,20 @@ private void addGlob

[jira] [Updated] (KAFKA-19047) Broker registrations are slow if previously fenced or shutdown

2025-03-27 Thread Alyssa Huang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alyssa Huang updated KAFKA-19047: - Affects Version/s: 4.0.0 > Broker registrations are slow if previously fenced or shutdown >

[jira] [Commented] (KAFKA-9904) Use ThreadLocalConcurrent to Replace Random

2025-03-27 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939012#comment-17939012 ] Lorcan commented on KAFKA-9904: --- Hi [~belugabehr], is this something that you'd advise shou

Re: [PR] KAFKA-19047: Broker registrations are slow if previously fenced or shutdown [kafka]

2025-03-27 Thread via GitHub
splett2 commented on code in PR #19296: URL: https://github.com/apache/kafka/pull/19296#discussion_r2017080238 ## metadata/src/test/java/org/apache/kafka/controller/ClusterControlManagerTest.java: ## @@ -978,6 +980,129 @@ public void testBrokerContactTimesAreUpdatedOnClusterCon

Re: [PR] KIP-991 Add deletedConnector flag when stopping tasks [kafka]

2025-03-27 Thread via GitHub
hgeraldino closed pull request #13146: KIP-991 Add deletedConnector flag when stopping tasks URL: https://github.com/apache/kafka/pull/13146 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] KAFKA-16368: segment.bytes constraints to min 1MB [kafka]

2025-03-27 Thread via GitHub
junrao commented on PR #18140: URL: https://github.com/apache/kafka/pull/18140#issuecomment-2758776560 @jayteej : Thanks for the PR and sorry for chiming in late. The KIP https://cwiki.apache.org/confluence/display/KAFKA/KIP-1030%3A+Change+constraints+and+default+values+for+various+configura

[jira] [Updated] (KAFKA-19051) Fix implicit acknowledgement cannot be overriden when RecordDeserializationException occurs

2025-03-27 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frédérik ROULEAU updated KAFKA-19051: - Summary: Fix implicit acknowledgement cannot be overriden when RecordDeserializationExce

[jira] [Updated] (KAFKA-19051) Fix implicit acknowledgement cannot be overridden when RecordDeserializationException occurs

2025-03-27 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Frédérik ROULEAU updated KAFKA-19051: - Summary: Fix implicit acknowledgement cannot be overridden when RecordDeserializationExc

[jira] [Updated] (KAFKA-19047) Broker registrations are slow if previously fenced or shutdown

2025-03-27 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-19047: --- Fix Version/s: 4.1.0 4.0.1 > Broker registrations

[jira] [Updated] (KAFKA-19047) Broker registrations are slow if previously fenced or shutdown

2025-03-27 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-19047: --- Component/s: controller > Broker registrations are slow if previousl

[PR] KAFKA-15873: Filter topics before sorting [kafka]

2025-03-27 Thread via GitHub
lorcanj opened a new pull request, #19304: URL: https://github.com/apache/kafka/pull/19304 Partially addresses: [KAFKA-15873](https://issues.apache.org/jira/browse/KAFKA-15873) When filtering and sorting, we should be applying the filter before the sort of topics. Order that u

Re: [PR] KAFKA-19049: Remove the `@ExtendWith(ClusterTestExtensions.class)` from code base [kafka]

2025-03-27 Thread via GitHub
FrankYang0529 commented on PR #19299: URL: https://github.com/apache/kafka/pull/19299#issuecomment-2760354933 @Rancho-7 Can we also this line in Java doc? Thanks. https://github.com/apache/kafka/blob/28de78bcbad605a3e906d085d2e59b441ae35212/test-common/test-common-runtime/src/main/jav

Re: [PR] KAFKA-18390: Use LinkedHashMap instead of Map in creating MetricName and SensorBuilder (1/N) [kafka]

2025-03-27 Thread via GitHub
TaiJuWu commented on PR #19300: URL: https://github.com/apache/kafka/pull/19300#issuecomment-2760216868 > @TaiJuWu Thanks for the patch. Out of curiosity, have we checked that jmx metric names are not altered by this change? I think that they are generated based on the order in the data str

Re: [PR] KAFKA-16729: Support isolation level for share consumer [kafka]

2025-03-27 Thread via GitHub
adixitconfluent commented on code in PR #19261: URL: https://github.com/apache/kafka/pull/19261#discussion_r2017977111 ## server-common/src/main/java/org/apache/kafka/server/storage/log/FetchIsolation.java: ## @@ -25,11 +25,11 @@ public enum FetchIsolation { TXN_COMMITTED;

[jira] [Commented] (KAFKA-19024) Enhance the client behaviour when it tries to exceed the `group.share.max.groups`

2025-03-27 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939153#comment-17939153 ] Lan Ding commented on KAFKA-19024: -- Thanks for your reply. Whether reusing the GROUP_MA

Re: [PR] KAFKA-16580: Enable dynamic quorum reconfiguration for raft simulation tests [kafka]

2025-03-27 Thread via GitHub
kevin-wu24 commented on code in PR #18987: URL: https://github.com/apache/kafka/pull/18987#discussion_r2003724311 ## raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java: ## @@ -1127,14 +1331,75 @@ private MajorityReachedHighWatermark(Cluster cluster) {

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2025-03-27 Thread via GitHub
AyoubOm commented on PR #19303: URL: https://github.com/apache/kafka/pull/19303#issuecomment-2759697061 @mjsax FYI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

  1   2   >