Re: [PR] KAFKA-18390: Use LinkedHashMap instead of Map in creating MetricName and SensorBuilder (1/N) [kafka]

2025-03-27 Thread via GitHub
TaiJuWu commented on PR #19300: URL: https://github.com/apache/kafka/pull/19300#issuecomment-2760243119 ``` #!/bin/bash # set Kafka JMX port(need to set by manual) JMX_PORT= JMXTERM_JAR="jmxterm.jar" if [ ! -f "$JMXTERM_JAR" ]; then echo "🔍 jmxterm.jar is not

[jira] [Commented] (KAFKA-19024) Enhance the client behaviour when it tries to exceed the `group.share.max.groups`

2025-03-27 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939146#comment-17939146 ] Andrew Schofield commented on KAFKA-19024: -- There are two cases to consider for

Re: [PR] KAFKA-18962: Fix onBatchRestored call in GlobalStateManagerImpl [kafka]

2025-03-27 Thread via GitHub
mjsax commented on code in PR #19188: URL: https://github.com/apache/kafka/pull/19188#discussion_r2015184978 ## clients/src/main/java/org/apache/kafka/clients/consumer/MockConsumer.java: ## @@ -274,13 +276,23 @@ public synchronized ConsumerRecords poll(final Duration timeout) {

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
AndrewJSchofield commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016245476 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack

Re: [PR] MINOR: Remove stray printStackTrace from RequestConvertToJsonTest [kafka]

2025-03-27 Thread via GitHub
mimaison merged PR #19287: URL: https://github.com/apache/kafka/pull/19287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16394: Fix null propagation in foreign key join result [kafka]

2025-03-27 Thread via GitHub
AyoubOm commented on PR #15607: URL: https://github.com/apache/kafka/pull/15607#issuecomment-2757816904 @mjsax rebase done. Ready to review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016187929 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if (cu

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
ShivsundarR commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016349699 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2025-03-27 Thread via GitHub
AyoubOm commented on PR #15615: URL: https://github.com/apache/kafka/pull/15615#issuecomment-2757859000 @mjsax branch successfully rebased -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[jira] [Comment Edited] (KAFKA-14485) Move LogCleaner to storage module

2025-03-27 Thread Dmitry Werner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938829#comment-17938829 ] Dmitry Werner edited comment on KAFKA-14485 at 3/27/25 7:31 AM: --

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
ShivsundarR commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016349699 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if

[jira] [Updated] (KAFKA-19049) Remove the `@ExtendWith(ClusterTestExtensions.class)` from code base

2025-03-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-19049: --- Description: KAFKA-18617 introduced the mechanism to inject the cluster test at runtime, so

[jira] [Comment Edited] (KAFKA-19050) kafka-streams-integration-tests artifact is empty

2025-03-27 Thread Utku Aydin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938906#comment-17938906 ] Utku Aydin edited comment on KAFKA-19050 at 3/27/25 11:32 AM:

[jira] [Commented] (KAFKA-19050) kafka-streams-integration-tests artifact is empty

2025-03-27 Thread Utku Aydin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938906#comment-17938906 ] Utku Aydin commented on KAFKA-19050: [~chia7712] I'm not saying it should be moved t

[jira] [Comment Edited] (KAFKA-19050) kafka-streams-integration-tests artifact is empty

2025-03-27 Thread Utku Aydin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938906#comment-17938906 ] Utku Aydin edited comment on KAFKA-19050 at 3/27/25 11:34 AM:

Re: [PR] KAFKA-19036: Rewrite LogAppendTimeTest and move it to storage module [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19282: URL: https://github.com/apache/kafka/pull/19282#discussion_r2016321714 ## storage/src/test/java/org/apache/kafka/server/log/LogAppendTimeTest.java: ## @@ -0,0 +1,104 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[jira] [Comment Edited] (KAFKA-19050) kafka-streams-integration-tests artifact is empty

2025-03-27 Thread Utku Aydin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938906#comment-17938906 ] Utku Aydin edited comment on KAFKA-19050 at 3/27/25 11:33 AM:

[jira] [Created] (KAFKA-19050) kafka-streams-integration-tests artifact is empty

2025-03-27 Thread Utku Aydin (Jira)
Utku Aydin created KAFKA-19050: -- Summary: kafka-streams-integration-tests artifact is empty Key: KAFKA-19050 URL: https://issues.apache.org/jira/browse/KAFKA-19050 Project: Kafka Issue Type: Imp

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
ShivsundarR commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016129362 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if

[PR] MINOR: migrate SaslClientsWithInvalidCredentialsTest to use ClusterTestExtensions [kafka]

2025-03-27 Thread via GitHub
FrankYang0529 opened a new pull request, #16225: URL: https://github.com/apache/kafka/pull/16225 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of t

Re: [PR] KAFKA-18959: increase the num_workers from 9 to 12 [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on PR #19274: URL: https://github.com/apache/kafka/pull/19274#issuecomment-2757759125 @apalan60 maybe we should align the number with docker-based e2e? https://github.com/apache/kafka/blob/b9d5597b445741330bf561b096c25e28224988eb/tests/docker/run_tests.sh#L19

Re: [PR] KAFKA-19049: Remove the `@ExtendWith(ClusterTestExtensions.class)` from code base [kafka]

2025-03-27 Thread via GitHub
Yunyung commented on PR #19299: URL: https://github.com/apache/kafka/pull/19299#issuecomment-2757781684 It looks like [KAFKA-18671](https://issues.apache.org/jira/browse/KAFKA-18671) in the description is an incorrect reference. The correct Jira should be [KAFKA-17587](https://issue

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016537417 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if (cu

Re: [PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-03-27 Thread via GitHub
dajac merged PR #19281: URL: https://github.com/apache/kafka/pull/19281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] MINOR: Specify 2.1 as the minimum broker version for clients [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19250: URL: https://github.com/apache/kafka/pull/19250#discussion_r2016352250 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -61,9 +61,9 @@ * The consumer is not thread-safe. See Multi-threaded Processing

Re: [PR] KAFKA-19049: Remove the `@ExtendWith(ClusterTestExtensions.class)` from code base [kafka]

2025-03-27 Thread via GitHub
Rancho-7 commented on PR #19299: URL: https://github.com/apache/kafka/pull/19299#issuecomment-2758021532 > It looks like [KAFKA-18671](https://issues.apache.org/jira/browse/KAFKA-18671) in the description is an incorrect reference. > > The correct Jira should be [KAFKA-17587](https:

Re: [PR] MINOR: Mark streams RPCs as unstable [kafka]

2025-03-27 Thread via GitHub
lucasbru merged PR #19292: URL: https://github.com/apache/kafka/pull/19292 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19049: Remove the `@ExtendWith(ClusterTestExtensions.class)` from code base [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on PR #19299: URL: https://github.com/apache/kafka/pull/19299#issuecomment-2758040624 > However, shouldn't the correct jira be [KAFKA-18617](https://issues.apache.org/jira/browse/KAFKA-18617)? yes, that is the correct jira -- This is an automated message from the

[PR] MINOR: Remove DeleteSegmentsByRetentionTimeTest#executeTieredStorageTest flaky anootation [kafka]

2025-03-27 Thread via GitHub
m1a2st opened a new pull request, #19301: URL: https://github.com/apache/kafka/pull/19301 This test was fixed by [this commit](https://github.com/apache/kafka/commit/f50a17fa8d2dbecc69891e2310763d64fe97175b) and hasn't failed for about two weeks. Therefore, we can remove the `@Flaky` annot

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016581868 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if (cu

Re: [PR] KAFKA-19042: [1/N] Move ConsumerTopicCreationTest to client-integration-tests module [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19283: URL: https://github.com/apache/kafka/pull/19283#discussion_r2016204135 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/consumer/ConsumerTopicCreationTest.java: ## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apach

Re: [PR] KAFKA-17830: Cover unit tests for TBRLMM init failure scenarios [kafka]

2025-03-27 Thread via GitHub
chia7712 merged PR #19076: URL: https://github.com/apache/kafka/pull/19076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-17694) Migrate SaslClientsWithInvalidCredentialsTest to new test infra

2025-03-27 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938902#comment-17938902 ] PoAn Yang commented on KAFKA-17694: --- I found that I already have a PR for this. May I

[jira] [Commented] (KAFKA-14485) Move LogCleaner to storage module

2025-03-27 Thread Dmitry Werner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938829#comment-17938829 ] Dmitry Werner commented on KAFKA-14485: --- [~chia7712] [~mimaison]  The current Log

[jira] [Updated] (KAFKA-19048) Minimal Movement Replica Balancing algorithm

2025-03-27 Thread Jialun Peng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jialun Peng updated KAFKA-19048: Description: h2. Motivation Kafka clusters typically require rebalancing of topic replicas after

[jira] [Updated] (KAFKA-19048) Minimal Movement Replica Balancing algorithm

2025-03-27 Thread Jialun Peng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jialun Peng updated KAFKA-19048: Description: h2. Motivation Kafka clusters typically require rebalancing of topic replicas after

[jira] [Updated] (KAFKA-19048) Minimal Movement Replica Balancing algorithm

2025-03-27 Thread Jialun Peng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jialun Peng updated KAFKA-19048: Description: h2. Motivation Kafka clusters typically require rebalancing of topic replicas after

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
ShivsundarR commented on PR #19295: URL: https://github.com/apache/kafka/pull/19295#issuecomment-2758130014 @AndrewJSchofield as @chia7712 mentioned if the case arises where successive `ShareFetchResponses` have only control records (eg. 2 abort markers received in read_commited mode),

Re: [PR] KAFKA-18959: increase the num_workers from 9 to 12 [kafka]

2025-03-27 Thread via GitHub
apalan60 commented on PR #19274: URL: https://github.com/apache/kafka/pull/19274#issuecomment-2758138154 > @apalan60 maybe we should align the number with docker-based e2e? > > https://github.com/apache/kafka/blob/b9d5597b445741330bf561b096c25e28224988eb/tests/docker/run_tests.sh#L19

Re: [PR] MINOR: Refactor configs in GroupMetadataManager [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #17982: URL: https://github.com/apache/kafka/pull/17982#discussion_r2007782255 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -5252,7 +5066,7 @@ private CoordinatorResult tryCompleteInitial

[jira] [Updated] (KAFKA-19048) Minimal Movement Replica Balancing algorithm

2025-03-27 Thread Jialun Peng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jialun Peng updated KAFKA-19048: Description: h2. Motivation Kafka clusters typically require rebalancing of topic replicas after

[jira] [Updated] (KAFKA-19048) Minimal Movement Replica Balancing algorithm

2025-03-27 Thread Jialun Peng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jialun Peng updated KAFKA-19048: Description: h2. Motivation Kafka clusters typically require rebalancing of topic replicas after

[jira] [Updated] (KAFKA-19048) Minimal Movement Replica Balancing algorithm

2025-03-27 Thread Jialun Peng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jialun Peng updated KAFKA-19048: Description: h2. Motivation Kafka clusters typically require rebalancing of topic replicas after

Re: [PR] KAFKA-14487: Move LogManager static methods/fields to storage module [kafka]

2025-03-27 Thread via GitHub
mimaison commented on PR #19302: URL: https://github.com/apache/kafka/pull/19302#issuecomment-2758271468 We can't quite move the whole `LogManager` class yet as it still depends on `KafkaConfig`. Still it's useful to move its static methods/fields as these are used in `RaftManager` and `Bro

[jira] [Updated] (KAFKA-19047) Broker registrations are slow if previously fenced or shutdown

2025-03-27 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-19047: --- Issue Type: Bug (was: Improvement) > Broker registrations are slow

[PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2025-03-27 Thread via GitHub
AyoubOm opened a new pull request, #19303: URL: https://github.com/apache/kafka/pull/19303 This fixes both KAFKA-16407 and KAFKA-16434. Summary of existing issues: - We are ignoring new left record when its **previous** FK value is null - We do not unset foreign key join resu

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
ShivsundarR commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016129362 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if

[jira] [Updated] (KAFKA-7699) Improve wall-clock time punctuations

2025-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-7699: --- Description: KIP-1146: [https://cwiki.apache.org/confluence/display/KAFKA/KIP-1146%3A+Anchor

Re: [PR] MINOR: Move inner test classes out of CoordinatorRuntimeTest [kafka]

2025-03-27 Thread via GitHub
squah-confluent commented on code in PR #19258: URL: https://github.com/apache/kafka/pull/19258#discussion_r2007416635 ## coordinator-common/src/test/java/org/apache/kafka/coordinator/common/runtime/MockCoordinatorShard.java: ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache S

[jira] [Commented] (KAFKA-7952) Consider to switch to in-memory stores in test whenever possible

2025-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939094#comment-17939094 ] Matthias J. Sax commented on KAFKA-7952: [~lorcanj] Thanks for the PR. I'll try t

Re: [PR] KAFKA-17662: config.providers configuration missing from the docs [kafka]

2025-03-27 Thread via GitHub
gharris1727 commented on code in PR #18930: URL: https://github.com/apache/kafka/pull/18930#discussion_r2017574587 ## clients/src/main/java/org/apache/kafka/clients/admin/AdminClientConfig.java: ## @@ -289,6 +295,13 @@ protected Map postProcessParsedConfig(final Map Co

[jira] [Updated] (KAFKA-6840) support windowing in ktable API

2025-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-6840: --- Priority: Major (was: Blocker) > support windowing in ktable API > -

[jira] [Comment Edited] (KAFKA-19047) Broker registrations are slow if previously fenced or shutdown

2025-03-27 Thread Gunnar Morling (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939055#comment-17939055 ] Gunnar Morling edited comment on KAFKA-19047 at 3/27/25 7:42 PM: -

Re: [PR] MINOR: Refactor GroupCoordinator write path [kafka]

2025-03-27 Thread via GitHub
jeffkbkim commented on code in PR #19290: URL: https://github.com/apache/kafka/pull/19290#discussion_r2016876236 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -661,16 +705,18 @@ class ReplicaManager(val config: KafkaConfig, return } -val sTime

Re: [PR] MINOR: Refactor GroupCoordinator write path [kafka]

2025-03-27 Thread via GitHub
dajac commented on code in PR #19290: URL: https://github.com/apache/kafka/pull/19290#discussion_r2016912371 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -661,16 +705,18 @@ class ReplicaManager(val config: KafkaConfig, return } -val sTime = t

Re: [PR] MINOR: Refactor GroupCoordinator write path [kafka]

2025-03-27 Thread via GitHub
dajac merged PR #19290: URL: https://github.com/apache/kafka/pull/19290 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[PR] KAFKA-14487: Move LogManager static methods/fields to storage module [kafka]

2025-03-27 Thread via GitHub
mimaison opened a new pull request, #19302: URL: https://github.com/apache/kafka/pull/19302 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[jira] [Commented] (KAFKA-19047) Broker registrations are slow if previously fenced or shutdown

2025-03-27 Thread Gunnar Morling (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939055#comment-17939055 ] Gunnar Morling commented on KAFKA-19047: For reference, here are the logs I've o

Re: [PR] KAFKA-10409: Refactor Kakfa Streams RocksDB Iterators [kafka]

2025-03-27 Thread via GitHub
fonsdant commented on code in PR #18610: URL: https://github.com/apache/kafka/pull/18610#discussion_r2017792607 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java: ## @@ -277,197 +275,361 @@ public void close() { } } -

[jira] [Updated] (KAFKA-18797) Flaky testLargeAssignmentAndGroupWithUniformSubscription

2025-03-27 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang updated KAFKA-18797: -- Attachment: testLargeAssignmentAndGroupWithUniformSubscription.jfr > Flaky testLargeAssignmentAndGroup

[jira] [Updated] (KAFKA-19050) kafka-streams-integration-tests artifact is empty

2025-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19050: Priority: Blocker (was: Major) > kafka-streams-integration-tests artifact is empty >

[jira] [Updated] (KAFKA-19050) kafka-streams-integration-tests artifact is empty

2025-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19050: Fix Version/s: 4.1.0 4.0.1 > kafka-streams-integration-tests artifact i

Re: [PR] KAFKA-10844: groupBy without shuffling [kafka]

2025-03-27 Thread via GitHub
fonsdant commented on PR #18811: URL: https://github.com/apache/kafka/pull/18811#issuecomment-2759887172 @mjsax, I would like to suggest that we adopt "skip repartition" instead of "mark as partitioned". It seems to me to be more consistent with the rest of the KStream API methods and its f

[jira] [Updated] (KAFKA-19050) kafka-streams-integration-tests artifact is empty

2025-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-19050: Component/s: streams > kafka-streams-integration-tests artifact is empty > ---

Re: [PR] KAFKA-18980: OffsetMetadataManager#cleanupExpiredOffsets should record the number of records rather than topic partitions [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19207: URL: https://github.com/apache/kafka/pull/19207#discussion_r2006072232 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -875,7 +872,7 @@ public boolean cleanupExpiredOffsets(String gr

Re: [PR] KAFKA-10409: Refactor Kakfa Streams RocksDB Iterators [kafka]

2025-03-27 Thread via GitHub
fonsdant commented on code in PR #18610: URL: https://github.com/apache/kafka/pull/18610#discussion_r2017792885 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java: ## @@ -277,197 +275,361 @@ public void close() { } } -

Re: [PR] KAFKA-10409: Refactor Kakfa Streams RocksDB Iterators [kafka]

2025-03-27 Thread via GitHub
fonsdant commented on code in PR #18610: URL: https://github.com/apache/kafka/pull/18610#discussion_r2017793076 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java: ## @@ -277,197 +275,361 @@ public void close() { } } -

Re: [PR] MINOR: Add 4.0.0 to streams system tests [kafka]

2025-03-27 Thread via GitHub
dajac merged PR #19239: URL: https://github.com/apache/kafka/pull/19239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-19004:Move DelayedDeleteRecords to server-common module [kafka]

2025-03-27 Thread via GitHub
gongxuanzhang commented on code in PR #19226: URL: https://github.com/apache/kafka/pull/19226#discussion_r2017802756 ## server-common/src/main/java/org/apache/kafka/server/common/DelayedDeleteRecords.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (

Re: [PR] MINOR UnifiedLog topic-partition as attribute as it is stable [kafka]

2025-03-27 Thread via GitHub
github-actions[bot] commented on PR #19253: URL: https://github.com/apache/kafka/pull/19253#issuecomment-2760076574 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18877: Add an mechanism to find cases where we accessed variables from the wrong thread. [kafka]

2025-03-27 Thread via GitHub
github-actions[bot] commented on PR #19231: URL: https://github.com/apache/kafka/pull/19231#issuecomment-2760076628 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18068: Fixing typo in ProducerConfig [kafka]

2025-03-27 Thread via GitHub
github-actions[bot] commented on PR #17908: URL: https://github.com/apache/kafka/pull/17908#issuecomment-2760101395 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-7516: Attempt to dynamically load ManagementFactory class [kafka]

2025-03-27 Thread via GitHub
github-actions[bot] commented on PR #17969: URL: https://github.com/apache/kafka/pull/17969#issuecomment-2760101431 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-7516: Attempt to dynamically load ManagementFactory class [kafka]

2025-03-27 Thread via GitHub
github-actions[bot] closed pull request #17969: KAFKA-7516: Attempt to dynamically load ManagementFactory class URL: https://github.com/apache/kafka/pull/17969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-18068: Fixing typo in ProducerConfig [kafka]

2025-03-27 Thread via GitHub
github-actions[bot] closed pull request #17908: KAFKA-18068: Fixing typo in ProducerConfig URL: https://github.com/apache/kafka/pull/17908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] KAFKA-17423 Trie implementation [kafka]

2025-03-27 Thread via GitHub
github-actions[bot] commented on PR #17087: URL: https://github.com/apache/kafka/pull/17087#issuecomment-2760101352 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

[jira] [Commented] (KAFKA-3370) Add options to auto.offset.reset to reset offsets upon initialization only

2025-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939097#comment-17939097 ] Matthias J. Sax commented on KAFKA-3370: Nobody is currently working on this AFAI

[jira] [Commented] (KAFKA-19050) kafka-streams-integration-tests artifact is empty

2025-03-27 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939098#comment-17939098 ] Matthias J. Sax commented on KAFKA-19050: - There was always a desire for some pu

Re: [PR] KAFKA-10409: Refactor Kakfa Streams RocksDB Iterators [kafka]

2025-03-27 Thread via GitHub
fonsdant commented on PR #18610: URL: https://github.com/apache/kafka/pull/18610#issuecomment-2759949221 @agavra, thanks for reviewing! I have push some commits :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-17078: Add SecurityManagerCompatibility shim (#16522) [kafka]

2025-03-27 Thread via GitHub
showuon commented on PR #19221: URL: https://github.com/apache/kafka/pull/19221#issuecomment-2760036097 Let's wait until we have consensus in the community. I've replied in this thread: https://lists.apache.org/thread/6k942pphowd28dh9gn6xbnngk6nxs3n0 . @gharris1727 , it'd be good if you cou

[jira] [Commented] (KAFKA-19024) Enhance the client behaviour when it tries to exceed the `group.share.max.groups`

2025-03-27 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17939117#comment-17939117 ] Lan Ding commented on KAFKA-19024: -- In the current implementation, the `group.share.max

[jira] [Assigned] (KAFKA-17541) Improve handling of delivery count

2025-03-27 Thread Lan Ding (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lan Ding reassigned KAFKA-17541: Assignee: Lan Ding (was: Andrew Schofield) > Improve handling of delivery count > --

[jira] [Updated] (KAFKA-19048) Minimal Movement Replica Balancing algorithm

2025-03-27 Thread Jialun Peng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jialun Peng updated KAFKA-19048: Description: h2. Motivation Kafka clusters typically require rebalancing of topic replicas after

Re: [PR] KAFKA-18991: FetcherThread should match leader epochs between fetch request and fetch state [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on PR #19223: URL: https://github.com/apache/kafka/pull/19223#issuecomment-2752123826 I try to cherry-pick https://github.com/apache/kafka/commit/4a8a0637e07734779b40ba9785842311144f922c to 4.0, but there are some conflicts. @jsancio do you have free cycle to file PR to

[jira] [Assigned] (KAFKA-9904) Use ThreadLocalConcurrent to Replace Random

2025-03-27 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lorcan reassigned KAFKA-9904: - Assignee: Lorcan > Use ThreadLocalConcurrent to Replace Random > ---

[jira] [Commented] (KAFKA-14485) Move LogCleaner to storage module

2025-03-27 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17938848#comment-17938848 ] Chia-Ping Tsai commented on KAFKA-14485: [~javakillah] that is a good question.

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016068726 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if (cu

Re: [PR] KAFKA-19036: Rewrite LogAppendTimeTest and move it to storage module [kafka]

2025-03-27 Thread via GitHub
FrankYang0529 commented on PR #19282: URL: https://github.com/apache/kafka/pull/19282#issuecomment-2757324418 @chia7712 Thanks for the review. I addressed all comments and CI passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] KAFKA-19004:Move DelayedDeleteRecords to server-common module [kafka]

2025-03-27 Thread via GitHub
chia7712 commented on code in PR #19226: URL: https://github.com/apache/kafka/pull/19226#discussion_r2016093160 ## server-common/src/main/java/org/apache/kafka/server/common/DelayedDeleteRecords.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-19032: Remove TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames [kafka]

2025-03-27 Thread via GitHub
FrankYang0529 commented on PR #19270: URL: https://github.com/apache/kafka/pull/19270#issuecomment-2757323381 @chia7712 Thanks for the reminder. I fix conflicts and CI passes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[jira] [Assigned] (KAFKA-18902) Implement ShareConsumer option to throw on poll if there are unacked records

2025-03-27 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-18902: Assignee: Andrew Schofield (was: Shivsundar R) > Implement ShareConsumer option

Re: [PR] KAFKA-19049: Remove the `@ExtendWith(ClusterTestExtensions.class)` from code base [kafka]

2025-03-27 Thread via GitHub
Rancho-7 commented on PR #19299: URL: https://github.com/apache/kafka/pull/19299#issuecomment-2757438387 > @Rancho-7 please cleanup `SaslApiVersionsRequestTest` and `StaticBrokerConfigTest` too Thanks for pointing out! Will fix it soon. -- This is an automated message from the Apac

Re: [PR] MINOR: migrate BrokerCompressionTest to storage module [kafka]

2025-03-27 Thread via GitHub
TaiJuWu commented on code in PR #19277: URL: https://github.com/apache/kafka/pull/19277#discussion_r2016120749 ## storage/src/test/java/org/apache/kafka/storage/internals/log/BrokerCompressionTest.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
ShivsundarR commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016129362 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
ShivsundarR commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016129362 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
ShivsundarR commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016129362 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if

Re: [PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-03-27 Thread via GitHub
dajac commented on PR #19281: URL: https://github.com/apache/kafka/pull/19281#issuecomment-2757464241 > nit: It appears `ShareGroupHeartbeatRequestTest` also requires cleanup. However, it's acceptable to leave it as is - or we can fix it in the follow-up Removed it and few others rela

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
ShivsundarR commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016129362 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if

Re: [PR] MINOR: Add check in ShareConsumerImpl to send acknowledgements of control records when ShareFetch is empty. [kafka]

2025-03-27 Thread via GitHub
ShivsundarR commented on code in PR #19295: URL: https://github.com/apache/kafka/pull/19295#discussion_r2016129362 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java: ## @@ -644,8 +645,12 @@ private ShareFetch collect(Map ack if

Re: [PR] MINOR: Some cleanups in group coordinator's intergration tests [kafka]

2025-03-27 Thread via GitHub
dajac commented on code in PR #19281: URL: https://github.com/apache/kafka/pull/19281#discussion_r2015985621 ## core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestTest.scala: ## @@ -37,15 +37,17 @@ import java.lang.{Byte => JByte} import java.util.Collections im

  1   2   >