jeffkbkim commented on code in PR #19290:
URL: https://github.com/apache/kafka/pull/19290#discussion_r2016876236
##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -661,16 +705,18 @@ class ReplicaManager(val config: KafkaConfig,
return
}
- val sTime = time.milliseconds
- val localProduceResultsWithTopicId =
appendToLocalLog(internalTopicsAllowed = internalTopicsAllowed,
- origin, entriesPerPartition, requiredAcks, requestLocal,
verificationGuards.toMap)
- debug("Produce to local log in %d ms".format(time.milliseconds - sTime))
- val localProduceResults : Map[TopicPartition, LogAppendResult] =
localProduceResultsWithTopicId.map {
- case(k, v) => (k.topicPartition, v)}
+ val localProduceResults = appendRecordsToLeader(
+ requiredAcks,
+ internalTopicsAllowed,
+ origin,
+ entriesPerPartition,
+ requestLocal,
+ actionQueue,
+ verificationGuards
+ )
val produceStatus = buildProducePartitionStatus(localProduceResults)
- addCompletePurgatoryAction(actionQueue, localProduceResultsWithTopicId)
recordValidationStatsCallback(localProduceResults.map { case (k, v) =>
k -> v.info.recordValidationStats
})
Review Comment:
(can't write a comment below this) to confirm, maybeAddDelayedProduce below
can be asynchronous which it isn't if acks=1 today but it may change in the
future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
