chia7712 commented on code in PR #19207:
URL: https://github.com/apache/kafka/pull/19207#discussion_r2006072232
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##########
@@ -875,7 +872,7 @@ public boolean cleanupExpiredOffsets(String groupId,
List<CoordinatorRecord> rec
// We don't expire the offset yet if there is a pending
transactional offset for the partition.
if (condition.isOffsetExpired(offsetAndMetadata,
currentTimestampMs, config.offsetsRetentionMs()) &&
!hasPendingTransactionalOffsets(groupId, topic,
partition)) {
-
expiredPartitions.add(appendOffsetCommitTombstone(groupId, topic, partition,
records).toString());
+ appendOffsetCommitTombstone(groupId, topic, partition,
records);
Review Comment:
my point was `appendOffsetCommitTombstone` can remove the returned value.
for example:
```java
private void appendOffsetCommitTombstone(
String groupId,
String topic,
int partition,
List<CoordinatorRecord> records
) {
records.add(GroupCoordinatorRecordHelpers.newOffsetCommitTombstoneRecord(groupId,
topic, partition));
TopicPartition tp = new TopicPartition(topic, partition);
log.trace("[GroupId {}] Removing expired offset and metadata for
{}", groupId, tp);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
