gharris1727 commented on code in PR #18930:
URL: https://github.com/apache/kafka/pull/18930#discussion_r2017574587


##########
clients/src/main/java/org/apache/kafka/clients/admin/AdminClientConfig.java:
##########
@@ -289,6 +295,13 @@ protected Map<String, Object> 
postProcessParsedConfig(final Map<String, Object>
         CommonClientConfigs.warnDisablingExponentialBackoff(this);
         return CommonClientConfigs.postProcessReconnectBackoffConfigs(this, 
parsedValues);
     }
+    
+    @Override
+    public Map<String, Object> originals() {

Review Comment:
   The WorkerConfig is a connect-specific class, and it removes 
config.providers to avoid false-positive errors related to a recent CVE: 
https://www.cve.org/CVERecord?id=CVE-2024-31141
   
   Admin (and Producer and Consumer) clients don't have the same concerns that 
WorkerConfig does, or at least i'm not aware of them.
   
   Also, the title of this PR makes it sound like a documentation change, and 
this appears to be a functional change. If it needs to be addressed, can it be 
addressed separately?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to