Re: [PR] KAFKA-18984: Reset interval.ms By Using kafka-client-metrics.sh [kafka]

2025-03-17 Thread via GitHub
Parkerhiphop commented on PR #19213: URL: https://github.com/apache/kafka/pull/19213#issuecomment-2728550547 Local testing screenshot: ![image](https://github.com/user-attachments/assets/537dd9b6-0f63-48ad-90d8-0b77d41a6bae) For valid and invalid string ![CleanShot 2025-03-1

[jira] [Commented] (KAFKA-18760) Deprecate Optional and return String from public EndPoint#Listener

2025-03-17 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936126#comment-17936126 ] PoAn Yang commented on KAFKA-18760: --- KIP: [https://cwiki.apache.org/confluence/pages/

Re: [PR] KAFKA-18989 Optimize FileRecord#searchForOffsetWithSize [kafka]

2025-03-17 Thread via GitHub
m1a2st commented on PR #19214: URL: https://github.com/apache/kafka/pull/19214#issuecomment-2729022427 Hello @frankvicky, I don’t think we need to update the Javadoc. We are still finding "the file position of the message batch whose last offset is greater than or equal to the target offset

[jira] [Created] (KAFKA-19000) Flaky test report should use absolute time for links

2025-03-17 Thread David Arthur (Jira)
David Arthur created KAFKA-19000: Summary: Flaky test report should use absolute time for links Key: KAFKA-19000 URL: https://issues.apache.org/jira/browse/KAFKA-19000 Project: Kafka Issue Ty

Re: [PR] MINOR Fixup develocity report [kafka]

2025-03-17 Thread via GitHub
mumrah commented on PR #19179: URL: https://github.com/apache/kafka/pull/19179#issuecomment-2729690621 We should probably make the links in the report use absolute time instead of the "last 7 days" filter. Filed https://issues.apache.org/jira/browse/KAFKA-19000 to fix this -- This is an

[jira] [Commented] (KAFKA-18999) Remove BrokerMetadata

2025-03-17 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936206#comment-17936206 ] Ismael Juma commented on KAFKA-18999: - That makes sense. > Remove BrokerMetadata >

Re: [PR] KAFKA-18984: Reset interval.ms By Using kafka-client-metrics.sh [kafka]

2025-03-17 Thread via GitHub
chia7712 commented on code in PR #19213: URL: https://github.com/apache/kafka/pull/19213#discussion_r1998755108 ## tools/src/main/java/org/apache/kafka/tools/ClientMetricsCommand.java: ## @@ -241,7 +241,7 @@ public ClientMetricsCommandOptions(String[] args) { interv

Re: [PR] KAFKA-18989 Optimize FileRecord#searchForOffsetWithSize [kafka]

2025-03-17 Thread via GitHub
mumrah commented on code in PR #19214: URL: https://github.com/apache/kafka/pull/19214#discussion_r1998877164 ## clients/src/main/java/org/apache/kafka/common/record/FileRecords.java: ## @@ -464,6 +481,12 @@ public static class LogOffsetPosition { public final int posit

[jira] [Commented] (KAFKA-14579) Move DumpLogSegments to tools

2025-03-17 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936261#comment-17936261 ] TaiJuWu commented on KAFKA-14579: - Hi [~adupriez] , are you still working on this? If no

[jira] [Resolved] (KAFKA-18808) add test to ensure the name= is not equal to default quota

2025-03-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18808. Resolution: Fixed > add test to ensure the name= is not equal to default quota > -

Re: [PR] KAFKA-17171: Add test cases for `STATIC_BROKER_CONFIG`in kraft mode [kafka]

2025-03-17 Thread via GitHub
chia7712 commented on code in PR #18463: URL: https://github.com/apache/kafka/pull/18463#discussion_r1998752540 ## core/src/test/java/kafka/server/BootstrapControllersIntegrationTest.java: ## @@ -342,4 +343,22 @@ private void testAcls(ClusterInstance clusterInstance, boolean us

Re: [PR] KAFKA-16505: Fix lost source raw key and value in store caches and buffers [kafka]

2025-03-17 Thread via GitHub
sebastienviale commented on PR #18739: URL: https://github.com/apache/kafka/pull/18739#issuecomment-2729806425 As @loicgreffier said, it is mentioned in the KIP that the raw record value: "If available, contains the value of the input message that triggered the sub-topology, null if trigger

[jira] [Created] (KAFKA-19001) Use streams group-level configurations in heartbeat

2025-03-17 Thread Lucas Brutschy (Jira)
Lucas Brutschy created KAFKA-19001: -- Summary: Use streams group-level configurations in heartbeat Key: KAFKA-19001 URL: https://issues.apache.org/jira/browse/KAFKA-19001 Project: Kafka Issue

[jira] [Assigned] (KAFKA-19001) Use streams group-level configurations in heartbeat

2025-03-17 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-19001: -- Assignee: Lucas Brutschy > Use streams group-level configurations in heartbeat >

Re: [PR] KAFKA-17431: Support invalid static configs for KRaft so long as dynamic configs are valid [kafka]

2025-03-17 Thread via GitHub
cmccabe commented on code in PR #18949: URL: https://github.com/apache/kafka/pull/18949#discussion_r1999661209 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -194,6 +194,7 @@ class BrokerServer( val clientMetricsReceiverPlugin = new ClientMetricsReceiverP

Re: [PR] KAFKA-17431: Support invalid static configs for KRaft so long as dynamic configs are valid [kafka]

2025-03-17 Thread via GitHub
cmccabe commented on code in PR #18949: URL: https://github.com/apache/kafka/pull/18949#discussion_r1999661209 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -194,6 +194,7 @@ class BrokerServer( val clientMetricsReceiverPlugin = new ClientMetricsReceiverP

Re: [PR] KAFKA-18955: Fix infinite loop and standardize options in MetadataSchemaCheckerTool [kafka]

2025-03-17 Thread via GitHub
cmccabe merged PR #19165: URL: https://github.com/apache/kafka/pull/19165 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

Re: [PR] KAFKA-17431: Support invalid static configs for KRaft so long as dynamic configs are valid [kafka]

2025-03-17 Thread via GitHub
cmccabe commented on code in PR #18949: URL: https://github.com/apache/kafka/pull/18949#discussion_r1999664781 ## core/src/main/scala/kafka/server/DynamicBrokerConfig.scala: ## @@ -192,6 +197,37 @@ object DynamicBrokerConfig { } props } + + private[server] def read

Re: [PR] KAFKA-18955: Fix infinite loop and standardize options in MetadataSchemaCheckerTool [kafka]

2025-03-17 Thread via GitHub
cmccabe commented on PR #19165: URL: https://github.com/apache/kafka/pull/19165#issuecomment-2730918434 Thanks @ahuang98 . Committed. @mannoopj , you may want to configure your email better. It's showing up as `139923522+manno...@users.noreply.github.com` which I don't think is what y

Re: [PR] KAFKA-18954: Add ELR election rate metric [kafka]

2025-03-17 Thread via GitHub
CalvinConfluent commented on PR #19180: URL: https://github.com/apache/kafka/pull/19180#issuecomment-2730933066 @cmccabe Updated the name from `electionWithElr` to `electionFromElr` The KIP has been updated with this metric. I have emailed the change in the KIP-966 discussion thread and n

Re: [PR] KAFKA-17431: Support invalid static configs for KRaft so long as dynamic configs are valid [kafka]

2025-03-17 Thread via GitHub
kevin-wu24 commented on code in PR #18949: URL: https://github.com/apache/kafka/pull/18949#discussion_r1999696908 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -194,6 +194,7 @@ class BrokerServer( val clientMetricsReceiverPlugin = new ClientMetricsReceiv

Re: [PR] KAFKA-18754: Allow `PlainSaslServer` to pass client info through the negotiated properties. [kafka]

2025-03-17 Thread via GitHub
bachmanity1 commented on PR #18828: URL: https://github.com/apache/kafka/pull/18828#issuecomment-2731387765 Hi @cmccabe @chia7712 @ijuma, could you take a look, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] KAFKA-10863: Convert ControRecordType schema to use auto-generated protocol [kafka]

2025-03-17 Thread via GitHub
dengziming commented on PR #19110: URL: https://github.com/apache/kafka/pull/19110#issuecomment-2731431118 @chia7712 Thank your for reviewing this, I changed the naming methodology, the build is green, PATL. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] KAFKA-7061: KIP-280 Enhanced log compaction [kafka]

2025-03-17 Thread via GitHub
chad-wheeler-sp commented on PR #8103: URL: https://github.com/apache/kafka/pull/8103#issuecomment-2730982287 @senthilm-ms senthilm-ms] Why did this feature die? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-18975: Move clients-integration-test out of core module [kafka]

2025-03-17 Thread via GitHub
kirktrue commented on code in PR #19217: URL: https://github.com/apache/kafka/pull/19217#discussion_r1999895425 ## clients/clients-integration-tests/src/test/java/org/apache/kafka/clients/admin/DescribeAuthorizedOperationsTest.java: ## @@ -154,7 +147,7 @@ public void testConsum

Re: [PR] KAFKA-18969: Rewrite ShareConsumerTest#setup and move to clients-integration-tests module [kafka]

2025-03-17 Thread via GitHub
chia7712 merged PR #19202: URL: https://github.com/apache/kafka/pull/19202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18969) Rewrite ShareConsumerTest#setup by beforeEach and move ShareConsumerTest to clients-integration-tests module

2025-03-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18969. Fix Version/s: 4.1.0 Resolution: Fixed > Rewrite ShareConsumerTest#setup by beforeE

Re: [PR] KAFKA-18980: OffsetMetadataManager#cleanupExpiredOffsets should record the number of records rather than topic partitions [kafka]

2025-03-17 Thread via GitHub
chia7712 commented on code in PR #19207: URL: https://github.com/apache/kafka/pull/19207#discussion_r2000323926 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -875,7 +872,7 @@ public boolean cleanupExpiredOffsets(String gr

Re: [PR] MINOR Capture heap dump after OOM on CI [kafka]

2025-03-17 Thread via GitHub
mumrah commented on PR #19031: URL: https://github.com/apache/kafka/pull/19031#issuecomment-2730836657 @chia7712 thanks for investigating. The metric creation inside a loop sounds like the likely culprit. -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] KAFKA-18953: [1/N] Add broker side handling for 2 PC (KIP-939) [kafka]

2025-03-17 Thread via GitHub
jolshan commented on code in PR #19193: URL: https://github.com/apache/kafka/pull/19193#discussion_r1999826677 ## core/src/test/scala/unit/kafka/coordinator/transaction/TransactionCoordinatorTest.scala: ## @@ -1070,26 +1146,47 @@ class TransactionCoordinatorTest { })

[jira] [Created] (KAFKA-19003) Add force-terminate command to kafka-transactions CLI

2025-03-17 Thread Ritika Reddy (Jira)
Ritika Reddy created KAFKA-19003: Summary: Add force-terminate command to kafka-transactions CLI Key: KAFKA-19003 URL: https://issues.apache.org/jira/browse/KAFKA-19003 Project: Kafka Issue

Re: [PR] KAFKA-16524: Metrics for KIP-853 [kafka]

2025-03-17 Thread via GitHub
kevin-wu24 commented on PR #18304: URL: https://github.com/apache/kafka/pull/18304#issuecomment-2731172907 > > Moved DefaultExternalKRaftMetrics to /core/src/main/scala/kafka/raft to avoid circular dependency and avoid BrokerServerMetrics and ControllerMetadataMetrics needing to implement a

Re: [PR] [MINOR] Cleanup Server Common Module [kafka]

2025-03-17 Thread via GitHub
github-actions[bot] commented on PR #19085: URL: https://github.com/apache/kafka/pull/19085#issuecomment-2731500245 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-17727: swallow exceptions on segment flush [kafka]

2025-03-17 Thread via GitHub
github-actions[bot] closed pull request #17425: KAFKA-17727: swallow exceptions on segment flush URL: https://github.com/apache/kafka/pull/17425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] MINOR: Documentation improvements for dynamic quorums [kafka]

2025-03-17 Thread via GitHub
github-actions[bot] closed pull request #17810: MINOR: Documentation improvements for dynamic quorums URL: https://github.com/apache/kafka/pull/17810 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-7025: Some Android compatibility for kafka-client [kafka]

2025-03-17 Thread via GitHub
github-actions[bot] commented on PR #17950: URL: https://github.com/apache/kafka/pull/17950#issuecomment-2731529602 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the P

Re: [PR] KAFKA-17727: swallow exceptions on segment flush [kafka]

2025-03-17 Thread via GitHub
github-actions[bot] commented on PR #17425: URL: https://github.com/apache/kafka/pull/17425#issuecomment-2731529431 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-18989 Optimize FileRecord#searchForOffsetWithSize [kafka]

2025-03-17 Thread via GitHub
kirktrue commented on code in PR #19214: URL: https://github.com/apache/kafka/pull/19214#discussion_r103645 ## clients/src/main/java/org/apache/kafka/common/record/FileRecords.java: ## @@ -298,11 +298,28 @@ public int writeTo(TransferableChannel destChannel, int offset, int

Re: [PR] KAFKA-17431: Support invalid static configs for KRaft so long as dynamic configs are valid [kafka]

2025-03-17 Thread via GitHub
cmccabe commented on code in PR #18949: URL: https://github.com/apache/kafka/pull/18949#discussion_r1999661209 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -194,6 +194,7 @@ class BrokerServer( val clientMetricsReceiverPlugin = new ClientMetricsReceiverP

[jira] [Updated] (KAFKA-19002) Rewrite ListOffsetsIntegrationTest and move it to clients-integration-test

2025-03-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-19002: -- Component/s: clients > Rewrite ListOffsetsIntegrationTest and move it to clients-integration-test > --

[jira] [Commented] (KAFKA-18986) Properly handle configured topology soft-state using KIP-1101

2025-03-17 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936104#comment-17936104 ] Lucas Brutschy commented on KAFKA-18986: We first need KIP-1101 implemented befo

Re: [PR] KAFKA-18332: fix ClassDataAbstractionCoupling problem in KafkaRaftClientTest(1/2) [kafka]

2025-03-17 Thread via GitHub
leaf-soba commented on code in PR #18926: URL: https://github.com/apache/kafka/pull/18926#discussion_r1998286042 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -920,10 +917,10 @@ public void testInitializeAsUnattachedAndBecomeLeader(boolean withKip8

Re: [PR] KAFKA-18935: Ensure brokers do not return null records in FetchResponse [kafka]

2025-03-17 Thread via GitHub
github-actions[bot] commented on PR #19167: URL: https://github.com/apache/kafka/pull/19167#issuecomment-2727943789 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18984: Reset interval.ms By Using kafka-client-metrics.sh [kafka]

2025-03-17 Thread via GitHub
m1a2st commented on code in PR #19213: URL: https://github.com/apache/kafka/pull/19213#discussion_r1998620696 ## tools/src/main/java/org/apache/kafka/tools/ClientMetricsCommand.java: ## @@ -241,7 +241,7 @@ public ClientMetricsCommandOptions(String[] args) { interval

Re: [PR] KAFKA-10551: Add topic id support to produce request and response [kafka]

2025-03-17 Thread via GitHub
OmniaGM commented on PR #15968: URL: https://github.com/apache/kafka/pull/15968#issuecomment-2728359297 > @OmniaGM any updates here? Thanks for your patience and work so far! Hi, Sorry for this very late reply. I have been busy with too many things lately and haven't had time to look

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-17 Thread via GitHub
lucasbru commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r1998207274 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -3338,9 +3342,9 @@ private boolean hasMemberSubscriptionChanged(

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-17 Thread via GitHub
lucasbru commented on PR #19114: URL: https://github.com/apache/kafka/pull/19114#issuecomment-2728632732 @bbejeck Thanks for the comments! Ready for re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] KAFKA-16505: Fix lost source raw key and value in store caches and buffers [kafka]

2025-03-17 Thread via GitHub
loicgreffier commented on PR #18739: URL: https://github.com/apache/kafka/pull/18739#issuecomment-2729270055 @cadonna KIP-1034 suggests that the input record should be the one that triggers the sub-topology: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1034%3A+Dead+letter+queue+in+

Re: [PR] KAFKA-18332: fix ClassDataAbstractionCoupling problem in KafkaRaftClientTest(1/2) [kafka]

2025-03-17 Thread via GitHub
leaf-soba commented on code in PR #18926: URL: https://github.com/apache/kafka/pull/18926#discussion_r1998298448 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java: ## @@ -4030,24 +4027,17 @@ public void testMetrics(boolean withKip853Rpc) throws Exception {

Re: [PR] KAFKA-14486: Move LogCleanerManager to storage module [kafka]

2025-03-17 Thread via GitHub
wernerdv commented on PR #19216: URL: https://github.com/apache/kafka/pull/19216#issuecomment-2728401472 @mimaison @chia7712 Hello, please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] KAFKA-18982: Allow ClusterTests to ignore specific thread leaks [kafka]

2025-03-17 Thread via GitHub
edoardocomar commented on PR #19206: URL: https://github.com/apache/kafka/pull/19206#issuecomment-2729369615 for information only - related mini PR in a different repo https://github.com/prometheus/client_java/pull/1307 -- This is an automated message from the Apache Git Service. To respo

[jira] [Commented] (KAFKA-7952) Consider to switch to in-memory stores in test whenever possible

2025-03-17 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936180#comment-17936180 ] Lorcan commented on KAFKA-7952: --- Hi [~mjsax] I have created a PR below with an approach tha

[jira] [Commented] (KAFKA-18999) Remove BrokerMetadata

2025-03-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936182#comment-17936182 ] Chia-Ping Tsai commented on KAFKA-18999: [~ijuma] you are right that using `entr

[jira] [Commented] (KAFKA-15370) Support Participation in 2PC (KIP-939)

2025-03-17 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936199#comment-17936199 ] Stanislav Kozlovski commented on KAFKA-15370: - What is the target Fix versio

Re: [PR] MINOR: Rewrite unchecked operations in Mock API [kafka]

2025-03-17 Thread via GitHub
chia7712 merged PR #19071: URL: https://github.com/apache/kafka/pull/19071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18975: Move clients-integration-test out of core module [kafka]

2025-03-17 Thread via GitHub
chia7712 commented on PR #19217: URL: https://github.com/apache/kafka/pull/19217#issuecomment-2730214171 @FrankYang0529 please fix the conflicts and move the RackAwareAutoTopicCreationTest -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Created] (KAFKA-19002) Rewrite ListOffsetsIntegrationTest and move it to clients-integration-test

2025-03-17 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-19002: -- Summary: Rewrite ListOffsetsIntegrationTest and move it to clients-integration-test Key: KAFKA-19002 URL: https://issues.apache.org/jira/browse/KAFKA-19002 Projec

[jira] [Commented] (KAFKA-19002) Rewrite ListOffsetsIntegrationTest and move it to clients-integration-test

2025-03-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936262#comment-17936262 ] Chia-Ping Tsai commented on KAFKA-19002: [~javakillah] sorry that [~taijuwu] is

[jira] [Assigned] (KAFKA-19002) Rewrite ListOffsetsIntegrationTest and move it to clients-integration-test

2025-03-17 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TaiJuWu reassigned KAFKA-19002: --- Assignee: TaiJuWu (was: Chia-Ping Tsai) > Rewrite ListOffsetsIntegrationTest and move it to client

Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

2025-03-17 Thread via GitHub
fvaleri commented on code in PR #19198: URL: https://github.com/apache/kafka/pull/19198#discussion_r1999330309 ## docs/upgrade.html: ## @@ -72,10 +72,8 @@ Upgrading Servers to 4.0.0 from brokers will be running the latest version and you can verify that the cluster's

[jira] [Commented] (KAFKA-19002) Rewrite ListOffsetsIntegrationTest and move it to clients-integration-test

2025-03-17 Thread Dmitry Werner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936264#comment-17936264 ] Dmitry Werner commented on KAFKA-19002: --- no problem :) > Rewrite ListOffsetsInteg

Re: [PR] KAFKA-16524: Metrics for KIP-853 [kafka]

2025-03-17 Thread via GitHub
chia7712 commented on PR #18304: URL: https://github.com/apache/kafka/pull/18304#issuecomment-2730334817 > Moved DefaultExternalKRaftMetrics to /core/src/main/scala/kafka/raft to avoid circular dependency and avoid BrokerServerMetrics and ControllerMetadataMetrics needing to implement anoth

[PR] KAFKA-18679: KafkaRaftMetrics metrics are exposing doubles instead of integers [kafka]

2025-03-17 Thread via GitHub
TaiJuWu opened a new pull request, #19220: URL: https://github.com/apache/kafka/pull/19220 JIRA: https://issues.apache.org/jira/browse/KAFKA-18679 The following metrics are being exposed as floating point doubles instead of ints/longs: - log-end-offset - log-end-epoch - n

Re: [PR] KAFKA-17171: Add test cases for `STATIC_BROKER_CONFIG`in kraft mode [kafka]

2025-03-17 Thread via GitHub
chia7712 merged PR #18463: URL: https://github.com/apache/kafka/pull/18463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-17171) Add test cases for `STATIC_BROKER_CONFIG`in kraft mode

2025-03-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17171. Fix Version/s: 4.1.0 Resolution: Fixed > Add test cases for `STATIC_BROKER_CONFIG`i

[jira] [Updated] (KAFKA-18992) kafka-features.sh wronly output `upgraded kraft.version to 1`

2025-03-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-18992: --- Component/s: controller kraft > kafka-features.sh w

[jira] [Comment Edited] (KAFKA-18992) kafka-features.sh wronly output `upgraded kraft.version to 1`

2025-03-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936228#comment-17936228 ] José Armando García Sancio edited comment on KAFKA-18992 at 3/17/25 4:03 PM: -

Re: [PR] KAFKA-17565: Move MetadataCache interface to metadata module [kafka]

2025-03-17 Thread via GitHub
chia7712 merged PR #18801: URL: https://github.com/apache/kafka/pull/18801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Commented] (KAFKA-18992) kafka-features.sh wronly output `upgraded kraft.version to 1`

2025-03-17 Thread TengYao Chi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936231#comment-17936231 ] TengYao Chi commented on KAFKA-18992: - Hi [~jsancio]  Thanks for the explanation :)

[jira] [Resolved] (KAFKA-17565) Move MetadataCache interface to metadata module

2025-03-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17565. Resolution: Fixed > Move MetadataCache interface to metadata module >

Re: [PR] KAFKA-18989 Optimize FileRecord#searchForOffsetWithSize [kafka]

2025-03-17 Thread via GitHub
m1a2st commented on code in PR #19214: URL: https://github.com/apache/kafka/pull/19214#discussion_r1999093157 ## clients/src/main/java/org/apache/kafka/common/record/FileRecords.java: ## @@ -298,11 +298,28 @@ public int writeTo(TransferableChannel destChannel, int offset, int l

Re: [PR] KAFKA-18984: Reset interval.ms By Using kafka-client-metrics.sh [kafka]

2025-03-17 Thread via GitHub
chia7712 commented on code in PR #19213: URL: https://github.com/apache/kafka/pull/19213#discussion_r1999098658 ## tools/src/test/java/org/apache/kafka/tools/ClientMetricsCommandTest.java: ## @@ -156,6 +166,27 @@ public void testAlterGenerateName() { assertTrue(captured

Re: [PR] KAFKA-18989 Optimize FileRecord#searchForOffsetWithSize [kafka]

2025-03-17 Thread via GitHub
m1a2st commented on PR #19214: URL: https://github.com/apache/kafka/pull/19214#issuecomment-2730090896 > Also, how about the case where a target offset lies between batches (which I think is possible due to compaction In the previous logic, it would point to the next batch. For exampl

Re: [PR] KAFKA-18966: Change controller_num_nodes_override to override_num_isolated_controllers [kafka]

2025-03-17 Thread via GitHub
CalvinConfluent commented on code in PR #19194: URL: https://github.com/apache/kafka/pull/19194#discussion_r1999125992 ## tests/kafkatest/services/kafka/kafka.py: ## @@ -330,7 +327,7 @@ def __init__(self, context, num_nodes, zk, security_protocol=SecurityConfig.PLAI

Re: [PR] MINOR Fixup develocity report [kafka]

2025-03-17 Thread via GitHub
mumrah commented on PR #19179: URL: https://github.com/apache/kafka/pull/19179#issuecomment-2729676268 The report was generated on March 10th, if you look at the 7 days prior to that, you'll see a lot more failures https://github.com/user-attachments/assets/91569321-47a9-4536-9d60-95

[PR] (WIP) KAFKA-18390: Use LinkedHashMap instead of Map in creating MetricName and SensorBuilder [kafka]

2025-03-17 Thread via GitHub
TaiJuWu opened a new pull request, #19222: URL: https://github.com/apache/kafka/pull/19222 Delete this text and replace it with a detailed description of your change. The PR title and body will become the squashed commit message. If you would like to tag individuals, add some comm

Re: [PR] KAFKA-18989 Optimize FileRecord#searchForOffsetWithSize [kafka]

2025-03-17 Thread via GitHub
junrao commented on code in PR #19214: URL: https://github.com/apache/kafka/pull/19214#discussion_r1999287436 ## clients/src/test/java/org/apache/kafka/common/record/FileRecordsTest.java: ## @@ -518,6 +523,176 @@ public void testBytesLengthOfWriteTo() throws IOException {

[jira] [Assigned] (KAFKA-19000) Flaky test report should use absolute time for links

2025-03-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-19000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 黃竣陽 reassigned KAFKA-19000: --- Assignee: 黃竣陽 > Flaky test report should use absolute time for links >

[PR] KAFKA-19001: Use streams group-level configurations in heartbeat [kafka]

2025-03-17 Thread via GitHub
lucasbru opened a new pull request, #19219: URL: https://github.com/apache/kafka/pull/19219 Implements the use of session timeout, standby tasks and heartbeat interval configurations in the streams group heartbeat. Piggy-backed is another test that streams groups react to changes

[jira] [Updated] (KAFKA-18992) kafka-features.sh wronly output `upgraded kraft.version to 1`

2025-03-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-18992: --- Affects Version/s: 4.0.0 > kafka-features.sh wronly output `upgraded

[jira] [Updated] (KAFKA-18992) kafka-features.sh wronly output `upgraded kraft.version to 1`

2025-03-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio updated KAFKA-18992: --- Fix Version/s: 4.1.0 > kafka-features.sh wronly output `upgraded kra

[jira] [Commented] (KAFKA-18992) kafka-features.sh wronly output `upgraded kraft.version to 1`

2025-03-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936228#comment-17936228 ] José Armando García Sancio commented on KAFKA-18992: [~frankvicky] T

[jira] [Assigned] (KAFKA-18992) kafka-features.sh wronly output `upgraded kraft.version to 1`

2025-03-17 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-18992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] José Armando García Sancio reassigned KAFKA-18992: -- Assignee: José Armando García Sancio (was: TengYao Chi) > ka

Re: [PR] KAFKA-18984: Reset interval.ms By Using kafka-client-metrics.sh [kafka]

2025-03-17 Thread via GitHub
Parkerhiphop commented on code in PR #19213: URL: https://github.com/apache/kafka/pull/19213#discussion_r1998990551 ## tools/src/main/java/org/apache/kafka/tools/ClientMetricsCommand.java: ## @@ -241,7 +241,7 @@ public ClientMetricsCommandOptions(String[] args) { in

[PR] KAFKA-17078: Add SecurityManagerCompatibility shim (#16522) [kafka]

2025-03-17 Thread via GitHub
srdo opened a new pull request, #19221: URL: https://github.com/apache/kafka/pull/19221 Backport for 3.9 for https://github.com/apache/kafka/pull/16522 The reason to do this is that this is necessary in order for 3.9 to support Java 24. Please see https://lists.apache.org/threa

Re: [PR] KAFKA-18946: Move BrokerReconfigurable and DynamicProducerStateManagerConfig to server module [kafka]

2025-03-17 Thread via GitHub
chia7712 commented on code in PR #19174: URL: https://github.com/apache/kafka/pull/19174#discussion_r1999272304 ## server/src/main/java/org/apache/kafka/server/config/BrokerReconfigurable.java: ## @@ -0,0 +1,25 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

Re: [PR] KAFKA-17755 AbstractPartitionAssignor can not enable RackAwareAssignm… [kafka]

2025-03-17 Thread via GitHub
github-actions[bot] commented on PR #17571: URL: https://github.com/apache/kafka/pull/17571#issuecomment-2728031146 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] KAFKA-18989 Optimize FileRecord#searchForOffsetWithSize [kafka]

2025-03-17 Thread via GitHub
chia7712 commented on code in PR #19214: URL: https://github.com/apache/kafka/pull/19214#discussion_r1999448126 ## clients/src/test/java/org/apache/kafka/common/record/FileRecordsTest.java: ## @@ -518,6 +523,176 @@ public void testBytesLengthOfWriteTo() throws IOException {

[jira] [Commented] (KAFKA-19002) Rewrite ListOffsetsIntegrationTest and move it to clients-integration-test

2025-03-17 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936263#comment-17936263 ] TaiJuWu commented on KAFKA-19002: - Sorry [~javakillah] , I would like to pick it up afte

Re: [PR] KAFKA-18989 Optimize FileRecord#searchForOffsetWithSize [kafka]

2025-03-17 Thread via GitHub
chia7712 commented on code in PR #19214: URL: https://github.com/apache/kafka/pull/19214#discussion_r1999450816 ## clients/src/main/java/org/apache/kafka/common/record/FileRecords.java: ## @@ -298,11 +298,28 @@ public int writeTo(TransferableChannel destChannel, int offset, int

[jira] [Commented] (KAFKA-18818) Significant delay in Metadata Update After Admin Client Operations in KRaft Mode

2025-03-17 Thread Ritvik Gupta (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17936271#comment-17936271 ] Ritvik Gupta commented on KAFKA-18818: -- Hi, Just have a few follow up queries base

Re: [PR] KAFKA-18808: add test to ensure the name= is not equal to default quota [kafka]

2025-03-17 Thread via GitHub
chia7712 merged PR #18966: URL: https://github.com/apache/kafka/pull/18966 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18613: Improve test coverage for missing topics [kafka]

2025-03-17 Thread via GitHub
lucasbru commented on code in PR #19189: URL: https://github.com/apache/kafka/pull/19189#discussion_r1991580254 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2246,25 +2246,27 @@ private StreamsTopology maybeUpdateTopology