kevin-wu24 commented on code in PR #18949:
URL: https://github.com/apache/kafka/pull/18949#discussion_r1999696908
##########
core/src/main/scala/kafka/server/BrokerServer.scala:
##########
@@ -194,6 +194,7 @@ class BrokerServer(
val clientMetricsReceiverPlugin = new ClientMetricsReceiverPlugin()
config.dynamicConfig.initialize(Some(clientMetricsReceiverPlugin))
+ DynamicBrokerConfig.readDynamicBrokerConfigsFromSnapshot(raftManager,
config, quotaManagers)
Review Comment:
> If you are confident that this will handle the case that originally
motivated this JIRA then I'm OK with doing this for now. As you recall, the
case was the broker SSL keystore file being statically set to a path that no
longer existed.
The test I wrote shows that the implementation changes address this case,
since it does the following:
- updating the dynamic configs with the current valid static configs, which
includes the keystore file
- making sure the broker's most recent snapshot has that config update
- shutdown the broker
- setting the static keystore location config to an invalid file path
- verify we can start the broker again (with my change this test passes, and
without it the test throws a NoSuchFileException for the invalid file path)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
