kevin-wu24 commented on PR #18304: URL: https://github.com/apache/kafka/pull/18304#issuecomment-2731172907
> > Moved DefaultExternalKRaftMetrics to /core/src/main/scala/kafka/raft to avoid circular dependency and avoid BrokerServerMetrics and ControllerMetadataMetrics needing to implement another interface. > > Out of curiosity, considering the eventual removal of the 'core' module, what is the planned strategy for resolving the circular dependency in the future? We'll probably have to do something like what's mentioned here: https://github.com/apache/kafka/pull/18304#discussion_r1902242222, where `ExternalKRaftMetrics` lives in `raft/internals`, along with the interface that `BrokerServerMetrics` and `ControllerMetadataMetrics` implement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
