[jira] [Commented] (KAFKA-18925) Add streams groups support in Admin.listGroups.

2025-03-07 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933300#comment-17933300 ] Lucas Brutschy commented on KAFKA-18925: [~isding_l] Thanks for offering your he

[jira] [Updated] (KAFKA-18925) Add streams groups support in Admin.listGroups.

2025-03-07 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-18925: --- Description: Needs extension of `GroupState`, `GroupType` and some tests.   This is impleme

[jira] [Updated] (KAFKA-18925) Add streams groups support in Admin.listGroups

2025-03-07 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-18925: --- Summary: Add streams groups support in Admin.listGroups (was: Add streams groups support in

Re: [PR] KAFKA-18736: Decide when a heartbeat should be sent [kafka]

2025-03-07 Thread via GitHub
cadonna commented on code in PR #19121: URL: https://github.com/apache/kafka/pull/19121#discussion_r1985038155 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java: ## @@ -254,34 +284,131 @@ public StreamsGroupHeartbeatReq

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-07 Thread via GitHub
adixitconfluent commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1985037801 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3139,15 +3135,15 @@ class KafkaApis(val requestChannel: RequestChannel, val erroneous = mutable

[jira] [Assigned] (KAFKA-18913) Consider removing state-updater feature flag

2025-03-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-18913: --- Assignee: Janindu Pathirana > Consider removing state-updater feature flag > --

[jira] [Commented] (KAFKA-15143) MockFixedKeyProcessorContext is missing from test-utils

2025-03-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933364#comment-17933364 ] Matthias J. Sax commented on KAFKA-15143: - The only workaround might be, to use

[PR] KAFKA-18925: Add streams groups support to Admin.listGroups [kafka]

2025-03-07 Thread via GitHub
lucasbru opened a new pull request, #19155: URL: https://github.com/apache/kafka/pull/19155 Add support so that Admin.listGroups can represent streams groups and their states. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-18925: Add streams groups support to Admin.listGroups [kafka]

2025-03-07 Thread via GitHub
lucasbru commented on PR #19155: URL: https://github.com/apache/kafka/pull/19155#issuecomment-2706876088 @bbejeck Could you have a look at this small PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-07 Thread via GitHub
cadonna commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r1983382584 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1348,6 +1381,34 @@ private void throwIfEmptyString( }

Re: [PR] KAFKA-17431: Support invalid static configs for KRaft so long as dynamic configs are valid [kafka]

2025-03-07 Thread via GitHub
kevin-wu24 commented on code in PR #18949: URL: https://github.com/apache/kafka/pull/18949#discussion_r1984227562 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -194,6 +194,7 @@ class BrokerServer( val clientMetricsReceiverPlugin = new ClientMetricsReceiv

Re: [PR] MINOR: Adjust ToC of zk2kraft and fix wrong section number of docker [kafka]

2025-03-07 Thread via GitHub
frankvicky commented on PR #19146: URL: https://github.com/apache/kafka/pull/19146#issuecomment-2706891667 Preview: ![Screenshot from 2025-03-08 00-28-38](https://github.com/user-attachments/assets/612b7104-7e2b-4a19-93fd-ac307f2d9ccc) -- This is an automated message from the Apach

Re: [PR] MINOR: Wrapping exceptions in usage for groups and metrics utility [kafka]

2025-03-07 Thread via GitHub
AndrewJSchofield merged PR #19151: URL: https://github.com/apache/kafka/pull/19151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

2025-03-07 Thread via GitHub
artemlivshits commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r1985871102 ## clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java: ## @@ -122,8 +124,8 @@ public final ByteBuffer serializeWithHeader(RequestHeader

Re: [PR] KAFKA-15931: Reopen TransactionIndex if channel is closed [kafka]

2025-03-07 Thread via GitHub
ijuma commented on code in PR #15241: URL: https://github.com/apache/kafka/pull/15241#discussion_r1985844349 ## storage/src/main/java/org/apache/kafka/storage/internals/log/TransactionIndex.java: ## @@ -238,35 +207,137 @@ private Iterable iterable(Supplier allocate)

Re: [PR] MINOR: Using Java records for SnapshotPath [kafka]

2025-03-07 Thread via GitHub
m1a2st commented on PR #19161: URL: https://github.com/apache/kafka/pull/19161#issuecomment-2707865455 Hello @CaoManhDat, thanks for your PR. However, it appears to be a duplicate of https://github.com/apache/kafka/pull/19062. Please feel free to close this PR. Thanks! -- This is an auto

Re: [PR] MINOR: Use readable interface to parse requests [kafka]

2025-03-07 Thread via GitHub
soondenana commented on code in PR #19163: URL: https://github.com/apache/kafka/pull/19163#discussion_r1985891433 ## clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java: ## @@ -122,8 +124,8 @@ public final ByteBuffer serializeWithHeader(RequestHeader hea

[jira] [Comment Edited] (KAFKA-17184) Remote index cache noisy logging

2025-03-07 Thread Azhar Ahmed (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933490#comment-17933490 ] Azhar Ahmed edited comment on KAFKA-17184 at 3/8/25 2:03 AM: -

[jira] [Commented] (KAFKA-17184) Remote index cache noisy logging

2025-03-07 Thread Azhar Ahmed (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933490#comment-17933490 ] Azhar Ahmed commented on KAFKA-17184: - I am assigning this to myself. > Remote inde

[jira] [Assigned] (KAFKA-17184) Remote index cache noisy logging

2025-03-07 Thread Azhar Ahmed (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Azhar Ahmed reassigned KAFKA-17184: --- Assignee: Azhar Ahmed > Remote index cache noisy logging >

[PR] Fix infinite loop and standardize options in MetadataSchemaCheckerTool [kafka]

2025-03-07 Thread via GitHub
ahuang98 opened a new pull request, #19165: URL: https://github.com/apache/kafka/pull/19165 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] KAFKA-18602: Incorrect FinalizedVersionLevel reported for dynamic KRaft quorum [kafka]

2025-03-07 Thread via GitHub
ijuma commented on code in PR #18685: URL: https://github.com/apache/kafka/pull/18685#discussion_r1985518686 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -522,10 +522,14 @@ class KRaftMetadataCache( if (kraftVersionLevel > 0) { finaliz

Re: [PR] HOTFIX: Do not use highest version when version is valid [kafka]

2025-03-07 Thread via GitHub
ijuma commented on PR #19109: URL: https://github.com/apache/kafka/pull/19109#issuecomment-2707255402 Thanks for checking this @dengziming. Given what you described, I am ok if we don't add a new test. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-18602: Incorrect FinalizedVersionLevel reported for dynamic KRaft quorum [kafka]

2025-03-07 Thread via GitHub
junrao commented on code in PR #18685: URL: https://github.com/apache/kafka/pull/18685#discussion_r1985613298 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -522,10 +522,14 @@ class KRaftMetadataCache( if (kraftVersionLevel > 0) { finali

[PR] MINOR: Using Java records for SnapshotPath [kafka]

2025-03-07 Thread via GitHub
CaoManhDat opened a new pull request, #19161: URL: https://github.com/apache/kafka/pull/19161 As title minor change to make the SnapshotPath class shorter and cleaner -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-18927: Remove LATEST_0_11, LATEST_1_0, LATEST_1_1, LATEST_2_0 [kafka]

2025-03-07 Thread via GitHub
mjsax commented on PR #19134: URL: https://github.com/apache/kafka/pull/19134#issuecomment-2707094168 Will also trigger a re-run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] KAFKA-18602: Incorrect FinalizedVersionLevel reported for dynamic KRaft quorum [kafka]

2025-03-07 Thread via GitHub
cmccabe commented on PR #18685: URL: https://github.com/apache/kafka/pull/18685#issuecomment-2707182871 @ijuma @junrao @chia7712 @FrankYang0529 if you want a minimal change that fixes this, with a test, there is my PR: https://github.com/apache/kafka/pull/19127 Since this a bl

[PR] MINOR Improve PR linter output [kafka]

2025-03-07 Thread via GitHub
mumrah opened a new pull request, #19159: URL: https://github.com/apache/kafka/pull/19159 Add a step summary for the PR linter which shows all the errors in a more readable format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] HOTFIX: Do not use highest version when version is valid [kafka]

2025-03-07 Thread via GitHub
chia7712 commented on PR #19109: URL: https://github.com/apache/kafka/pull/19109#issuecomment-2707189281 @dengziming maybe we can leverage `Mockito.mockConstruction` to ensure the version passed to `EndTxnMarker` is less or equal to `EndTxnMarker.HIGHEST_SUPPORTED_VERSION`? -- This is an

[jira] [Created] (KAFKA-18943) Kafka Streams incorrectly commits TX during task revokation

2025-03-07 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-18943: --- Summary: Kafka Streams incorrectly commits TX during task revokation Key: KAFKA-18943 URL: https://issues.apache.org/jira/browse/KAFKA-18943 Project: Kafka

[jira] [Assigned] (KAFKA-18943) Kafka Streams incorrectly commits TX during task revokation

2025-03-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-18943: --- Assignee: Matthias J. Sax > Kafka Streams incorrectly commits TX during task revoka

[jira] [Updated] (KAFKA-18943) Kafka Streams incorrectly commits TX during task revokation

2025-03-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18943: Description: We found a very rare edge case in Kafka Streams commit logic, that may lead t

[jira] [Updated] (KAFKA-18943) Kafka Streams incorrectly commits TX during task revokation

2025-03-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18943: Description: We found a very rare edge case in Kafka Streams commit logic, that may lead t

Re: [PR] MINOR: fix: add missing @Test lost while rebasing [kafka]

2025-03-07 Thread via GitHub
ijuma commented on PR #19149: URL: https://github.com/apache/kafka/pull/19149#issuecomment-2707709399 > Minor issue while rebasing merged https://github.com/apache/kafka/pull/15241 Disabling tests is actually a major issue. Thanks for catching it! -- This is an automated message fr

[jira] [Updated] (KAFKA-18943) Kafka Streams incorrectly commits TX during task revokation

2025-03-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18943: Description: We found a very rare edge case in Kafka Streams commit logic, that may lead t

Re: [PR] MINOR KIP link change to use immutable link [kafka]

2025-03-07 Thread via GitHub
m1a2st commented on code in PR #19153: URL: https://github.com/apache/kafka/pull/19153#discussion_r1985992116 ## docs/streams/upgrade-guide.html: ## @@ -849,13 +849,13 @@ Streams API KeyQueryMetadata was introduced in Kafka Streams 2.5 release with getter methods havin

Re: [PR] KAFKA-18074: Add kafka client compatibility matrix [kafka]

2025-03-07 Thread via GitHub
mjsax commented on code in PR #18091: URL: https://github.com/apache/kafka/pull/18091#discussion_r1984211009 ## docs/compatibility.html: ## @@ -0,0 +1,225 @@ + + + + + + +Compatibility +With the release of Kafka 4.0, significant changes have been introduced

[PR] KAFKA-18943: Kafka Streams incorrectly commits TX during task revokation [kafka]

2025-03-07 Thread via GitHub
mjsax opened a new pull request, #19164: URL: https://github.com/apache/kafka/pull/19164 Fixes two issues: - only commit TX if no revoked tasks need to be committed - commit revoked tasks after punctuation triggered -- This is an automated message from the Apache Git Service. To re

Re: [PR] MINOR: Using Java records for SnapshotPath [kafka]

2025-03-07 Thread via GitHub
CaoManhDat closed pull request #19161: MINOR: Using Java records for SnapshotPath URL: https://github.com/apache/kafka/pull/19161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] KAFKA-18285: Add describeStreamsGroup to Admin API [kafka]

2025-03-07 Thread via GitHub
lucasbru merged PR #19116: URL: https://github.com/apache/kafka/pull/19116 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-18602: Incorrect FinalizedVersionLevel reported for dynamic KRaft quorum [kafka]

2025-03-07 Thread via GitHub
junrao commented on code in PR #18685: URL: https://github.com/apache/kafka/pull/18685#discussion_r1985471978 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -522,10 +522,14 @@ class KRaftMetadataCache( if (kraftVersionLevel > 0) { finali

Re: [PR] KAFKA-18933 Add client integration tests module [kafka]

2025-03-07 Thread via GitHub
mumrah commented on code in PR #19144: URL: https://github.com/apache/kafka/pull/19144#discussion_r1985588765 ## build.gradle: ## @@ -1960,6 +1960,29 @@ project(':clients') { } } +project(':clients:integration-tests') { + base { +archivesName = "kafka-clients-integrat

Re: [PR] KAFKA-18933 Add client integration tests module [kafka]

2025-03-07 Thread via GitHub
chia7712 commented on code in PR #19144: URL: https://github.com/apache/kafka/pull/19144#discussion_r1985569125 ## build.gradle: ## @@ -1960,6 +1960,29 @@ project(':clients') { } } +project(':clients:integration-tests') { + base { +archivesName = "kafka-clients-integr

Re: [PR] KAFKA-18933 Add client integration tests module [kafka]

2025-03-07 Thread via GitHub
mumrah commented on code in PR #19144: URL: https://github.com/apache/kafka/pull/19144#discussion_r1985586776 ## settings.gradle: ## @@ -64,6 +64,7 @@ buildCache { } include 'clients', +'clients:integration-tests', Review Comment: yes, good call 👍 -- This is an

Re: [PR] KAFKA-18940: fix electionWasClean [kafka]

2025-03-07 Thread via GitHub
junrao merged PR #19156: URL: https://github.com/apache/kafka/pull/19156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[jira] [Commented] (KAFKA-18942) Add reviewers to PR body with committer-tools

2025-03-07 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933465#comment-17933465 ] Ismael Juma commented on KAFKA-18942: - It will be awesome to have this. > Add revie

Re: [PR] KAFKA-15931: Reopen TransactionIndex if channel is closed [kafka]

2025-03-07 Thread via GitHub
junrao commented on code in PR #15241: URL: https://github.com/apache/kafka/pull/15241#discussion_r1985806237 ## storage/src/main/java/org/apache/kafka/storage/internals/log/TransactionIndex.java: ## @@ -238,35 +207,137 @@ private Iterable iterable(Supplier allocate)

[jira] [Created] (KAFKA-18933) Extract an interface from ClusterInstance for Java 11 modules

2025-03-07 Thread David Arthur (Jira)
David Arthur created KAFKA-18933: Summary: Extract an interface from ClusterInstance for Java 11 modules Key: KAFKA-18933 URL: https://issues.apache.org/jira/browse/KAFKA-18933 Project: Kafka

Re: [PR] MINOR: zk2kraft: add more information about kafka-configs.sh [kafka]

2025-03-07 Thread via GitHub
chia7712 commented on PR #19100: URL: https://github.com/apache/kafka/pull/19100#issuecomment-2705435256 check the web-site and run the example commands, all works. will merge this PR ![螢幕快照 2025-03-07 11-26-02](https://github.com/user-attachments/assets/33f5e6d1-78b8-461b-976f-dcf4eddca

[jira] [Commented] (KAFKA-18938) Kraft version and metadata version wrongly showing

2025-03-07 Thread Rameshkanna N (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933493#comment-17933493 ] Rameshkanna N commented on KAFKA-18938: --- [~yangpoan] In controller.properties what

[jira] [Updated] (KAFKA-18920) The kcontrollers do not set kraft.version in ApiVersionsResponse

2025-03-07 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-18920: Fix Version/s: 4.0.0 (was: 4.0.1) > The kcontrollers do not set kraft.versi

[jira] [Commented] (KAFKA-18920) The kcontrollers do not set kraft.version in ApiVersionsResponse

2025-03-07 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933505#comment-17933505 ] David Jacot commented on KAFKA-18920: - [~cmccabe] [~jsancio] I need to close the tic

[jira] [Resolved] (KAFKA-18920) The kcontrollers do not set kraft.version in ApiVersionsResponse

2025-03-07 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-18920. - Fix Version/s: (was: 3.9.1) Assignee: Colin McCabe (was: José Armando García Sancio

[jira] [Updated] (KAFKA-18938) Kraft version and metadata version wrongly showing

2025-03-07 Thread Rameshkanna N (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rameshkanna N updated KAFKA-18938: -- Description: I am using Kafka {*}3.9.0{*}. When starting a {*}KRaft controller{*}, it shows {

Re: [PR] KAFKA-18613: Add describeStreamsGroup to Admin API [kafka]

2025-03-07 Thread via GitHub
lucasbru commented on code in PR #19116: URL: https://github.com/apache/kafka/pull/19116#discussion_r1984784869 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -5762,6 +5764,347 @@ public void testDeleteStreamsGroupOffsetsFindCoordinator

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-03-07 Thread via GitHub
chia7712 commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1984872155 ## docs/toc.html: ## @@ -27,7 +27,8 @@ 1.3 Quick Start 1.4 Ecosystem 1.5 Upgrading -1.6 Docker +

Re: [PR] KAFKA-17607: Add CI step to verify LICENSE-binary [kafka]

2025-03-07 Thread via GitHub
mumrah merged PR #18299: URL: https://github.com/apache/kafka/pull/18299 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[jira] [Updated] (KAFKA-18939) kafka-site preview does not use the correct rewrite rules

2025-03-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18939: --- Description: the preview should use the same rewrite rule as production. otherwise, it is h

[jira] [Updated] (KAFKA-18939) kafka-site preview does not use the correct rewrite rules

2025-03-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18939: --- Priority: Blocker (was: Major) > kafka-site preview does not use the correct rewrite rules

Re: [PR] [WIP] MINOR: Adjust ToC of zk2kraft and fix wrong section number of docker [kafka]

2025-03-07 Thread via GitHub
chia7712 commented on PR #19146: URL: https://github.com/apache/kafka/pull/19146#issuecomment-2706162986 we should review this PR after fixing https://issues.apache.org/jira/browse/KAFKA-18939 - otherwise, we can't use the correct way to "review" the site -- This is an automated message

[jira] [Updated] (KAFKA-18939) kafka-site preview does not use the correct rewrite rules

2025-03-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-18939: --- Issue Type: Bug (was: Improvement) > kafka-site preview does not use the correct rewrite ru

[jira] [Created] (KAFKA-18939) kafka-site preview does not use the correct rewrite rules

2025-03-07 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18939: -- Summary: kafka-site preview does not use the correct rewrite rules Key: KAFKA-18939 URL: https://issues.apache.org/jira/browse/KAFKA-18939 Project: Kafka

[jira] [Updated] (KAFKA-18288) Add support kafka-streams-groups.sh --describe

2025-03-07 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-18288: --- Description: Implement --describe and its options: (--state, --offset, --members and the co

[jira] [Updated] (KAFKA-18287) Add support for kafka-streams-groups.sh --list

2025-03-07 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-18287: --- Description: Implement kafka-streams-group.sh --list. This is already present on the kip107

[jira] [Commented] (KAFKA-15143) MockFixedKeyProcessorContext is missing from test-utils

2025-03-07 Thread Javad Saljooghi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933282#comment-17933282 ] Javad Saljooghi commented on KAFKA-15143: - I tried to find a workaround until a

[jira] [Assigned] (KAFKA-16729) Support for read-committed isolation level

2025-03-07 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield reassigned KAFKA-16729: Assignee: Abhinav Dixit (was: Andrew Schofield) > Support for read-committed iso

[jira] [Updated] (KAFKA-18932) Remove partition max bytes usage from brokers for share fetch requests

2025-03-07 Thread Abhinav Dixit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhinav Dixit updated KAFKA-18932: -- Summary: Remove partition max bytes usage from brokers for share fetch requests (was: Remove

[PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-07 Thread via GitHub
adixitconfluent opened a new pull request, #19148: URL: https://github.com/apache/kafka/pull/19148 ### What This PR aims to remove the usage of partition max bytes from share fetch requests on the broker. Partition Max Bytes is being defined by `PartitionMaxBytesStrategy` which was added

[jira] [Commented] (KAFKA-18939) kafka-site preview does not use the correct rewrite rules

2025-03-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933278#comment-17933278 ] Chia-Ping Tsai commented on KAFKA-18939: we must fix this issue. otherwise, we c

[jira] [Updated] (KAFKA-18285) Add Admin.describeStreamsGroups

2025-03-07 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-18285: --- Description: Implement > Add Admin.describeStreamsGroups > --- >

[jira] [Updated] (KAFKA-18285) Add Admin.describeStreamsGroups

2025-03-07 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy updated KAFKA-18285: --- Description: Adds {{describeStreamsGroup}} to Admin API. This exposes the result of the {{D

Re: [PR] MINOR: Improve grammar and clarity in upgrade.html [kafka]

2025-03-07 Thread via GitHub
MahsaSeifikar commented on code in PR #19141: URL: https://github.com/apache/kafka/pull/19141#discussion_r1985254581 ## docs/upgrade.html: ## @@ -74,24 +74,24 @@ Notable changes in 4 The Next Generation of the Consumer Rebalance Protocol (https://cwiki.apa

Re: [PR] KAFKA-18901: [1/N] Improved homogeneous SimpleAssignor [kafka]

2025-03-07 Thread via GitHub
AndrewJSchofield commented on code in PR #19142: URL: https://github.com/apache/kafka/pull/19142#discussion_r1984855066 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -135,56 +148,68 @@ private GroupAssignment newAssignm

Re: [PR] KAFKA-15143: Adding in MockFixedKeyProcessorContext and Test [kafka]

2025-03-07 Thread via GitHub
javad87 commented on PR #14605: URL: https://github.com/apache/kafka/pull/14605#issuecomment-2706297226 @s7pandey Will this mock added to test-utils in comming monthes? I tried to find a workaround until a mock for FixedKeyProcessor is added to test-utils. However, I need to create a

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-07 Thread via GitHub
apoorvmittal10 commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1984986626 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3139,15 +3135,15 @@ class KafkaApis(val requestChannel: RequestChannel, val erroneous = mutable.

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-07 Thread via GitHub
apoorvmittal10 commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1985008350 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3139,15 +3135,15 @@ class KafkaApis(val requestChannel: RequestChannel, val erroneous = mutable.

Re: [PR] KAFKA-18932: Removed usage of partition max bytes from share fetch requests on the broker [kafka]

2025-03-07 Thread via GitHub
adixitconfluent commented on code in PR #19148: URL: https://github.com/apache/kafka/pull/19148#discussion_r1984992039 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -3139,15 +3135,15 @@ class KafkaApis(val requestChannel: RequestChannel, val erroneous = mutable

[jira] [Commented] (KAFKA-18939) kafka-site preview does not use the correct rewrite rules

2025-03-07 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933291#comment-17933291 ] ASF GitHub Bot commented on KAFKA-18939: chia7712 commented on code in PR #665:

Re: [PR] KAFKA-18613: Add StreamsGroupHeartbeat handler in the group coordinator [kafka]

2025-03-07 Thread via GitHub
lucasbru commented on code in PR #19114: URL: https://github.com/apache/kafka/pull/19114#discussion_r1985368229 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/TasksTuple.java: ## @@ -30,11 +34,11 @@ * An immutable tuple containing active, standby

Re: [PR] MINOR: Disallow unused local variables [kafka]

2025-03-07 Thread via GitHub
lucasbru commented on PR #18963: URL: https://github.com/apache/kafka/pull/18963#issuecomment-270647 @mumrah I have addressed all comments. Should we just go forward with this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] MINOR: Allow for scheduling delay for periodic tasks to be configurable when ControllerResult.response = true [kafka]

2025-03-07 Thread via GitHub
mumrah merged PR #19143: URL: https://github.com/apache/kafka/pull/19143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

[PR] MINOR: fix electionWasClean [kafka]

2025-03-07 Thread via GitHub
CalvinConfluent opened a new pull request, #19156: URL: https://github.com/apache/kafka/pull/19156 The electionWasClean should also consider if the election is done through ELR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] KAFKA-18572: Update Kafka Streams metric documenation [kafka]

2025-03-07 Thread via GitHub
bbejeck commented on PR #18673: URL: https://github.com/apache/kafka/pull/18673#issuecomment-2706918769 > hey @bbejeck yes i am still able to work on it Great! if you can address the comments here, we should be able to merge this soon. -- This is an automated message from the Apach

Re: [PR] MINOR: Improve grammar and clarity in upgrade.html [kafka]

2025-03-07 Thread via GitHub
MahsaSeifikar commented on PR #19141: URL: https://github.com/apache/kafka/pull/19141#issuecomment-2706719071 > LGTM > > https://github.com/apache/kafka/pull/19096/files#diff-439593088d083e21a92c1a0d89e4f299147740d123283a62cc7a303c2b5a7e0fL34 > > I noticed a previous PR and was

[PR] KAFKA-18788 Fix the inconsistent lastest supported version in StorageTool.scala and FutureCommand [kafka]

2025-03-07 Thread via GitHub
m1a2st opened a new pull request, #19157: URL: https://github.com/apache/kafka/pull/19157 JIra: https://issues.apache.org/jira/browse/KAFKA-18778 To maintain code consistency, `MetadataVersion#fromVersionString` uses `latestTesting()` as the latest version. Therefore, in the tools, we

Re: [PR] KAFKA-18901: [1/N] Improved homogeneous SimpleAssignor [kafka]

2025-03-07 Thread via GitHub
AndrewJSchofield commented on code in PR #19142: URL: https://github.com/apache/kafka/pull/19142#discussion_r1985365027 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -135,56 +148,71 @@ private GroupAssignment newAssignm

[jira] [Updated] (KAFKA-18940) Fix uncleanLeaderElection metric due to ELR election

2025-03-07 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu updated KAFKA-18940: --- Priority: Blocker (was: Major) > Fix uncleanLeaderElection metric due to ELR election > ---

Re: [PR] MINOR: Adjust ToC of zk2kraft and fix wrong section number of docker [kafka]

2025-03-07 Thread via GitHub
frankvicky commented on PR #19146: URL: https://github.com/apache/kafka/pull/19146#issuecomment-2706935738 ![Screenshot from 2025-03-08 00-48-39](https://github.com/user-attachments/assets/57516573-8cda-4960-b93e-9e696176c243) -- This is an automated message from the Apache Git Servic

Re: [PR] KAFKA-18572: Update Kafka Streams metric documenation [kafka]

2025-03-07 Thread via GitHub
ukpagrace commented on code in PR #18673: URL: https://github.com/apache/kafka/pull/18673#discussion_r1985387479 ## docs/ops.html: ## @@ -2888,6 +2898,21 @@

[jira] [Updated] (KAFKA-18940) Fix uncleanLeaderElection metric due to ELR election

2025-03-07 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu updated KAFKA-18940: --- Affects Version/s: 4.0.1 > Fix uncleanLeaderElection metric due to ELR election > --

[jira] [Updated] (KAFKA-18940) Fix uncleanLeaderElection metric due to ELR election

2025-03-07 Thread Calvin Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Calvin Liu updated KAFKA-18940: --- Fix Version/s: 4.0.0 > Fix uncleanLeaderElection metric due to ELR election > --

Re: [PR] KAFKA-18572: Update Kafka Streams metric documenation [kafka]

2025-03-07 Thread via GitHub
ukpagrace commented on PR #18673: URL: https://github.com/apache/kafka/pull/18673#issuecomment-2706937831 > > hey @bbejeck yes i am still able to work on it > > Great! if you can address the comments here, we should be able to merge this soon. Alright I will make the changes

Re: [PR] KAFKA-18461: Fix potential NPE in setDelta after map is erased [kafka]

2025-03-07 Thread via GitHub
mumrah merged PR #18684: URL: https://github.com/apache/kafka/pull/18684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

Re: [PR] KAFKA-18901: [1/N] Improved homogeneous SimpleAssignor [kafka]

2025-03-07 Thread via GitHub
adixitconfluent commented on code in PR #19142: URL: https://github.com/apache/kafka/pull/19142#discussion_r1985134315 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -135,56 +148,71 @@ private GroupAssignment newAssignme

Re: [PR] KAFKA-15931: Reopen TransactionIndex if channel is closed [kafka]

2025-03-07 Thread via GitHub
ijuma commented on code in PR #15241: URL: https://github.com/apache/kafka/pull/15241#discussion_r1985206261 ## storage/src/main/java/org/apache/kafka/storage/internals/log/TransactionIndex.java: ## @@ -238,35 +207,137 @@ private Iterable iterable(Supplier allocate)

[PR] Kafka-18914 Migrate ConsumerRebootstrapTest to use new test infra [kafka]

2025-03-07 Thread via GitHub
clarkwtc opened a new pull request, #19154: URL: https://github.com/apache/kafka/pull/19154 Migrate ConsumerRebootstrapTest to the new test infra and remove the old Scala test. I still had some issues with getting `RejectedExecutionException` error, and the broker was shut down. h

Re: [PR] KAFKA-18924 Running the storage module tests produces a storage/storage.log file [kafka]

2025-03-07 Thread via GitHub
m1a2st commented on PR #19147: URL: https://github.com/apache/kafka/pull/19147#issuecomment-2706695598 use `./gradlew clean :storage:test` on my local machine ![image](https://github.com/user-attachments/assets/0d79a26c-6f55-4c7a-babb-e267c931a3ca) -- This is an automated message f

Re: [PR] KAFKA-18142 switch Kafka's Gradle build shadow plugin to `com.gradleup.shadow` (and upgrade plugin version) [kafka]

2025-03-07 Thread via GitHub
dejan2609 commented on PR #18018: URL: https://github.com/apache/kafka/pull/18018#issuecomment-2706733670 Thank you for a merge @mumrah, it seems that tests are fine. Could you spare some time to perform a review ? -- This is an automated message from the Apache Git Service. To respond

Re: [PR] MINOR: Improve grammar and clarity in upgrade.html [kafka]

2025-03-07 Thread via GitHub
MahsaSeifikar commented on code in PR #19141: URL: https://github.com/apache/kafka/pull/19141#discussion_r1985262195 ## docs/upgrade.html: ## @@ -74,24 +74,24 @@ Notable changes in 4 The Next Generation of the Consumer Rebalance Protocol (https://cwiki.apa

Re: [PR] KAFKA-15931: Reopen TransactionIndex if channel is closed [kafka]

2025-03-07 Thread via GitHub
jeqo commented on PR #15241: URL: https://github.com/apache/kafka/pull/15241#issuecomment-2706210945 @showuon thanks! build looks good after rebase 👍🏽 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

  1   2   >