mjsax commented on code in PR #18091:
URL: https://github.com/apache/kafka/pull/18091#discussion_r1984211009


##########
docs/compatibility.html:
##########
@@ -0,0 +1,225 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements.  See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License.  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<!--#include virtual="../includes/_header.htm" -->
+<!--#include virtual="../includes/_top.htm" -->
+<div class="content">
+    <div class="p-compatibility">
+        <h1>Compatibility</h1>
+        With the release of Kafka 4.0, significant changes have been 
introduced that impact compatibility across various
+        components. To assist users in planning upgrades and ensuring seamless 
interoperability, a comprehensive
+        compatibility matrix has been prepared.
+        <h2 class="anchor-heading">JDK Compatibility Across Kafka Versions</h2>
+        <table>
+            <tr>
+                <th>Module</th>
+                <th>Kafka Version</th>
+                <th>Java 11</th>
+                <th>Java 17</th>
+                <th>Java 23</th>
+            </tr>
+            <tr>
+                <td>Clients</td>
+                <td>4.0.0</td>
+                <td>✅</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>Streams</td>
+                <td>4.0.0</td>
+                <td>✅</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>Connect</td>
+                <td>4.0.0</td>
+                <td>❌</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>Server</td>
+                <td>4.0.0</td>
+                <td>❌</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+        </table>
+        <p><strong>Note: Java 8 is deprecated in Kafka 4.0 and is no longer 
supported.</strong></p>

Review Comment:
   Is "deprecated" the right term? Usually is means, something is still 
supported, but will be removed in the future.
   
   We did drop/remove Java8, so it seems deprecated could be misleading?



##########
docs/compatibility.html:
##########
@@ -0,0 +1,225 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements.  See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License.  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<!--#include virtual="../includes/_header.htm" -->
+<!--#include virtual="../includes/_top.htm" -->
+<div class="content">
+    <div class="p-compatibility">
+        <h1>Compatibility</h1>
+        With the release of Kafka 4.0, significant changes have been 
introduced that impact compatibility across various
+        components. To assist users in planning upgrades and ensuring seamless 
interoperability, a comprehensive
+        compatibility matrix has been prepared.
+        <h2 class="anchor-heading">JDK Compatibility Across Kafka Versions</h2>
+        <table>
+            <tr>
+                <th>Module</th>
+                <th>Kafka Version</th>
+                <th>Java 11</th>
+                <th>Java 17</th>
+                <th>Java 23</th>
+            </tr>
+            <tr>
+                <td>Clients</td>
+                <td>4.0.0</td>
+                <td>✅</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>Streams</td>
+                <td>4.0.0</td>
+                <td>✅</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>Connect</td>
+                <td>4.0.0</td>
+                <td>❌</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>Server</td>
+                <td>4.0.0</td>
+                <td>❌</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+        </table>
+        <p><strong>Note: Java 8 is deprecated in Kafka 4.0 and is no longer 
supported.</strong></p>
+
+        <h2 class="anchor-heading">Server Compatibility</h2>
+        <table>
+            <tr>
+                <th>KRaft Cluster Version</th>
+                <th>Compatibility 4.0 Server (dynamic voter)</th>
+                <th>Compatibility 4.0 Server (static voter)</th>
+            </tr>
+            <tr>
+                <td>before 3.2.x</td>
+                <td>❌</td>
+                <td>❌</td>
+            </tr>
+            <tr>
+                <td>3.3.x</td>
+                <td>❌</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>3.4.x</td>
+                <td>❌</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>3.5.x</td>
+                <td>❌</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>3.6.x</td>
+                <td>❌</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>3.7.x</td>
+                <td>❌</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>3.8.x</td>
+                <td>❌</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>3.9.x</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>4.0.x</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+        </table>
+        <p><strong>Note: Can’t upgrade server from static voter to dynamic
+            voter, see <a 
href="https://issues.apache.org/jira/browse/KAFKA-16538";>KAFKA-16538</a>.</strong></p>
+
+        <h4>Client/Broker Forward Compatibility</h4>
+        <table>
+            <tr>
+                <th>Kafka Version</th>
+                <th>Module</th>
+                <th>Compatibility with Kafka 4.0</th>
+                <th>Key Differences/Limitations</th>
+            </tr>
+            <tr>
+                <td rowspan="3">0.x</td>
+                <td>Client</td>
+                <td>❌ Not Compatible</td>
+                <td>Pre-0.10.x protocols are fully removed in Kafka 4.0 (<a
+                        
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-896";>KIP-896</a>).
+                </td>
+            </tr>
+            <tr>
+                <td>Streams</td>
+                <td>❌ Not Compatible</td>
+                <td>Kafka Streams introduced in Kafka 0.10.x.</td>
+            </tr>
+            <tr>
+                <td>Connect</td>
+                <td>❌ Not Compatible</td>
+                <td>Pre-0.10.x protocols are fully removed in Kafka 4.0 (<a
+                        
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-896";>KIP-896</a>).
+                </td>
+            </tr>
+            <tr>
+                <td rowspan="3">1.x</td>
+                <td>Client</td>
+                <td>⚠️ Limited Compatibility</td>
+                <td>Does not support newer features like idempotent producer 
or transactional API.</td>
+            </tr>
+            <tr>
+                <td>Streams</td>
+                <td>⚠️ Limited Compatibility</td>
+                <td>Basic Streams features available. EOSv1 and eager 
rebalancing unavailable in Kafka 4.0.</td>
+            </tr>
+            <tr>
+                <td>Connect</td>
+                <td>⚠️ Limited Compatibility</td>
+                <td>IncrementalAlterConfigs not supported before Kafka 
2.3.x.</td>
+            </tr>
+            <tr>
+                <td rowspan="3">2.x</td>
+                <td>Client</td>
+                <td>⚠️ Partially Compatible</td>
+                <td>
+                    Multiple Admin API methods removed/renamed: alterConfigs → 
incrementalAlterConfigs<br>
+                    UniformStickyPartitioner removed
+                </td>
+            </tr>
+            <tr>
+                <td>Streams</td>
+                <td>⚠️ Limited Compatibility</td>
+                <td>
+                    EOSv1 and eager rebalancing unavailable in Kafka 4.0.<br>

Review Comment:
   Both EOSv1 and eager rebalancing, are _KS_ features and they have nothing to 
do with 4.0 brokers. So this statements is confusing to me. I though this table 
is about compatibility of client/KS/connect version X to broker 4.0?
   
   Similar question for the other row. Or maybe I misunderstand something?



##########
docs/compatibility.html:
##########
@@ -0,0 +1,225 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements.  See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License.  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<!--#include virtual="../includes/_header.htm" -->
+<!--#include virtual="../includes/_top.htm" -->
+<div class="content">
+    <div class="p-compatibility">
+        <h1>Compatibility</h1>
+        With the release of Kafka 4.0, significant changes have been 
introduced that impact compatibility across various
+        components. To assist users in planning upgrades and ensuring seamless 
interoperability, a comprehensive
+        compatibility matrix has been prepared.
+        <h2 class="anchor-heading">JDK Compatibility Across Kafka Versions</h2>
+        <table>
+            <tr>
+                <th>Module</th>
+                <th>Kafka Version</th>
+                <th>Java 11</th>
+                <th>Java 17</th>
+                <th>Java 23</th>
+            </tr>
+            <tr>
+                <td>Clients</td>
+                <td>4.0.0</td>
+                <td>✅</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>Streams</td>
+                <td>4.0.0</td>
+                <td>✅</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>Connect</td>
+                <td>4.0.0</td>
+                <td>❌</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>Server</td>
+                <td>4.0.0</td>
+                <td>❌</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+        </table>
+        <p><strong>Note: Java 8 is deprecated in Kafka 4.0 and is no longer 
supported.</strong></p>
+
+        <h2 class="anchor-heading">Server Compatibility</h2>
+        <table>
+            <tr>
+                <th>KRaft Cluster Version</th>
+                <th>Compatibility 4.0 Server (dynamic voter)</th>
+                <th>Compatibility 4.0 Server (static voter)</th>
+            </tr>
+            <tr>
+                <td>before 3.2.x</td>
+                <td>❌</td>
+                <td>❌</td>
+            </tr>
+            <tr>
+                <td>3.3.x</td>
+                <td>❌</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>3.4.x</td>
+                <td>❌</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>3.5.x</td>
+                <td>❌</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>3.6.x</td>
+                <td>❌</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>3.7.x</td>
+                <td>❌</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>3.8.x</td>
+                <td>❌</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>3.9.x</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>4.0.x</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+        </table>
+        <p><strong>Note: Can’t upgrade server from static voter to dynamic
+            voter, see <a 
href="https://issues.apache.org/jira/browse/KAFKA-16538";>KAFKA-16538</a>.</strong></p>
+
+        <h4>Client/Broker Forward Compatibility</h4>
+        <table>
+            <tr>
+                <th>Kafka Version</th>
+                <th>Module</th>
+                <th>Compatibility with Kafka 4.0</th>
+                <th>Key Differences/Limitations</th>
+            </tr>
+            <tr>
+                <td rowspan="3">0.x</td>
+                <td>Client</td>
+                <td>❌ Not Compatible</td>
+                <td>Pre-0.10.x protocols are fully removed in Kafka 4.0 (<a
+                        
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-896";>KIP-896</a>).
+                </td>
+            </tr>
+            <tr>
+                <td>Streams</td>
+                <td>❌ Not Compatible</td>
+                <td>Kafka Streams introduced in Kafka 0.10.x.</td>

Review Comment:
   Should we add
   ```
   Pre-0.10.x protocols are fully removed in Kafka 4.0 (<a 
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-896";>KIP-896</a>).
   ```
   here too? In the end, it also applies to KS? -- Overall, the same thing 
applies to all three components. Should we merge these three cells into a 
single one?



##########
docs/compatibility.html:
##########
@@ -0,0 +1,225 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements.  See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License.  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+
+<!--#include virtual="../includes/_header.htm" -->
+<!--#include virtual="../includes/_top.htm" -->
+<div class="content">
+    <div class="p-compatibility">
+        <h1>Compatibility</h1>
+        With the release of Kafka 4.0, significant changes have been 
introduced that impact compatibility across various
+        components. To assist users in planning upgrades and ensuring seamless 
interoperability, a comprehensive
+        compatibility matrix has been prepared.
+        <h2 class="anchor-heading">JDK Compatibility Across Kafka Versions</h2>
+        <table>
+            <tr>
+                <th>Module</th>
+                <th>Kafka Version</th>
+                <th>Java 11</th>
+                <th>Java 17</th>
+                <th>Java 23</th>
+            </tr>
+            <tr>
+                <td>Clients</td>
+                <td>4.0.0</td>
+                <td>✅</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>Streams</td>
+                <td>4.0.0</td>
+                <td>✅</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>Connect</td>
+                <td>4.0.0</td>
+                <td>❌</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>Server</td>
+                <td>4.0.0</td>
+                <td>❌</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+        </table>
+        <p><strong>Note: Java 8 is deprecated in Kafka 4.0 and is no longer 
supported.</strong></p>
+
+        <h2 class="anchor-heading">Server Compatibility</h2>
+        <table>
+            <tr>
+                <th>KRaft Cluster Version</th>
+                <th>Compatibility 4.0 Server (dynamic voter)</th>
+                <th>Compatibility 4.0 Server (static voter)</th>
+            </tr>
+            <tr>
+                <td>before 3.2.x</td>
+                <td>❌</td>
+                <td>❌</td>
+            </tr>
+            <tr>
+                <td>3.3.x</td>
+                <td>❌</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>3.4.x</td>
+                <td>❌</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>3.5.x</td>
+                <td>❌</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>3.6.x</td>
+                <td>❌</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>3.7.x</td>
+                <td>❌</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>3.8.x</td>
+                <td>❌</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>3.9.x</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+            <tr>
+                <td>4.0.x</td>
+                <td>✅</td>
+                <td>✅</td>
+            </tr>
+        </table>
+        <p><strong>Note: Can’t upgrade server from static voter to dynamic
+            voter, see <a 
href="https://issues.apache.org/jira/browse/KAFKA-16538";>KAFKA-16538</a>.</strong></p>
+
+        <h4>Client/Broker Forward Compatibility</h4>
+        <table>
+            <tr>
+                <th>Kafka Version</th>
+                <th>Module</th>
+                <th>Compatibility with Kafka 4.0</th>
+                <th>Key Differences/Limitations</th>
+            </tr>
+            <tr>
+                <td rowspan="3">0.x</td>
+                <td>Client</td>
+                <td>❌ Not Compatible</td>
+                <td>Pre-0.10.x protocols are fully removed in Kafka 4.0 (<a
+                        
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-896";>KIP-896</a>).
+                </td>
+            </tr>
+            <tr>
+                <td>Streams</td>
+                <td>❌ Not Compatible</td>
+                <td>Kafka Streams introduced in Kafka 0.10.x.</td>
+            </tr>
+            <tr>
+                <td>Connect</td>
+                <td>❌ Not Compatible</td>
+                <td>Pre-0.10.x protocols are fully removed in Kafka 4.0 (<a
+                        
href="https://cwiki.apache.org/confluence/display/KAFKA/KIP-896";>KIP-896</a>).
+                </td>
+            </tr>
+            <tr>
+                <td rowspan="3">1.x</td>

Review Comment:
   Not sure about these rows? Given that 2.1 is the base version, it seems we 
should put `0.x`, `1.x`, and `2.0` into a single block, and say none of these 
old versions are compatibility to 4.0 brokers?
   
   Cf KIP-1124.
   
   Or do I miss something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to