[
https://issues.apache.org/jira/browse/KAFKA-18939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17933291#comment-17933291
]
ASF GitHub Bot commented on KAFKA-18939:
----------------------------------------
chia7712 commented on code in PR #665:
URL: https://github.com/apache/kafka-site/pull/665#discussion_r1984962603
##########
Dockerfile:
##########
@@ -9,14 +9,14 @@ RUN sed -i \
AddType text/html .html\n\
AddHandler server-parsed .html\n\
Redirect 301 /design.html /documentation#design\n\
- RewriteRule ^/?(\d+)/generated/ - [S=4]\n\
- RewriteRule ^/?(\d+)/documentation(\.html)? - [S=3]\n\
- RewriteRule ^/?(\d+)/javadoc - [S=2]\n\
- RewriteRule ^/?(\d+)/images/ - [S=1]\n\
+ RewriteRule ^/?(\\\d+)/generated/ - [S=4]\n\
+ RewriteRule ^/?(\\\d+)/documentation(\\.html)? - [S=3]\n\
+ RewriteRule ^/?(\\\d+)/javadoc - [S=2]\n\
+ RewriteRule ^/?(\\\d+)/images/ - [S=1]\n\
RewriteCond $2 !=protocol\n\
- RewriteRule ^/?(\d+)/([a-z]+)(\.html)? /$1/documentation#$2
[R=302,L,NE]\n\
+ RewriteRule ^/?(\\\d+)/([a-z]+)(\\.html)? /$1/documentation#$2
[R=302,L,NE]\n\
RewriteCond %{REQUEST_FILENAME}.html -f\n\
Review Comment:
Please remove this condition to match the production.
> kafka-site preview does not use the correct rewrite rules
> ---------------------------------------------------------
>
> Key: KAFKA-18939
> URL: https://issues.apache.org/jira/browse/KAFKA-18939
> Project: Kafka
> Issue Type: Bug
> Reporter: Chia-Ping Tsai
> Assignee: Chia-Ping Tsai
> Priority: Blocker
>
> the preview should use the same rewrite rule as production. otherwise, it is
> hard to debug before deploying. However, we never apply the valid regex ...
> see [https://github.com/apache/kafka-site/blob/asf-site/Dockerfile#L12]
> / -> //
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
