chia7712 commented on code in PR #18961:
URL: https://github.com/apache/kafka/pull/18961#discussion_r1984872155


##########
docs/toc.html:
##########
@@ -27,7 +27,8 @@
                 <li><a href="#quickstart">1.3 Quick Start</a>
                 <li><a href="#ecosystem">1.4 Ecosystem</a>
                 <li><a href="#upgrade">1.5 Upgrading</a>
-                <li><a href="#docker">1.6 Docker</a>
+                <li><a href="/{{version}}/zk2kraft">1.6 Differences Between 
KRaft mode and ZooKeeper mode</a>

Review Comment:
   > In https://kafka.apache.org/40/documentation/, the link from the index 
page on the left points to the beginning of the doc page, not the zk2kraft page.
   
   That is caused by our rewrite rule. see 
https://github.com/apache/kafka-site/blob/asf-site/.htaccess#L12
   
   Also, we don't observe it in preview because our preview does not use 
correct rewrite rule. I have opened 
https://issues.apache.org/jira/browse/KAFKA-18939 to fix it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to