Re: [PR] KAFKA-18089: RemoteIndexCacheTest fails with caffeine > 3.1.1 [kafka]

2025-02-18 Thread via GitHub
TaiJuWu commented on code in PR #18004: URL: https://github.com/apache/kafka/pull/18004#discussion_r1960679875 ## gradle/dependencies.gradle: ## @@ -54,10 +54,7 @@ versions += [ apacheds: "2.0.0-M24", argparse4j: "0.7.0", bcpkix: "1.78.1", - // Version >=3.1.2 includes

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1960696997 ## metadata/src/test/java/org/apache/kafka/controller/ClusterControlManagerTest.java: ## @@ -718,30 +710,14 @@ public void testRegistrationWithUnsupportedMetadataVers

Re: [PR] KAFKA-18723; Better handle invalid records during replication [kafka]

2025-02-18 Thread via GitHub
jsancio commented on code in PR #18852: URL: https://github.com/apache/kafka/pull/18852#discussion_r1960722608 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1086,63 +1088,79 @@ class UnifiedLog(@volatile var logStartOffset: Long, var shallowOffsetOfMaxTimestamp

[PR] KAFKA-18733: Implemented fetch ratio and partition acquire time metrics (3/N) [kafka]

2025-02-18 Thread via GitHub
apoorvmittal10 opened a new pull request, #18959: URL: https://github.com/apache/kafka/pull/18959 PR implements the final set of ShareGroupMetrics, RequestTopicPartitionsFetchRatio and TopicPartitionsAcquireTimeMs, as defined in KIP-1103: https://cwiki.apache.org/confluence/display/KAFKA/K

[PR] Minor: Fix error when upgrade ELR [kafka]

2025-02-18 Thread via GitHub
CalvinConfluent opened a new pull request, #18958: URL: https://github.com/apache/kafka/pull/18958 Fix a null ptr problem when upgrading ELR. It does not affect the UTs because the update is actually successful but it confuses the admin client. ``` Could not upgrade eligible.leader.rep

Re: [PR] MINOR: cleanup top level class JavaDocs for main interfaces of Kafka Streams DSL (3/N) [kafka]

2025-02-18 Thread via GitHub
mjsax commented on code in PR #18883: URL: https://github.com/apache/kafka/pull/18883#discussion_r1960770603 ## streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedKStream.java: ## @@ -18,38 +18,46 @@ import org.apache.kafka.common.utils.Bytes; import org.apac

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-18 Thread via GitHub
ijuma commented on PR #18845: URL: https://github.com/apache/kafka/pull/18845#issuecomment-2667217579 @chia7712 I addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] MINOR: cleanup top level class JavaDocs for main interfaces of Kafka Streams DSL (4/N) [kafka]

2025-02-18 Thread via GitHub
mjsax merged PR #18884: URL: https://github.com/apache/kafka/pull/18884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[PR] Update asf.yaml [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah opened a new pull request, #54: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/54 Testing out https://github.com/apache/kafka/pull/18955/files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] MINOR: verify that internal StreamsConfig members are not public [kafka]

2025-02-18 Thread via GitHub
mjsax merged PR #18840: URL: https://github.com/apache/kafka/pull/18840 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] [WIP] KAFKA-10844: groupBy without shuffling [kafka]

2025-02-18 Thread via GitHub
github-actions[bot] commented on PR #18811: URL: https://github.com/apache/kafka/pull/18811#issuecomment-2667405773 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18647: Clarify Windows support in Quick Start Guide [kafka]

2025-02-18 Thread via GitHub
github-actions[bot] commented on PR #18715: URL: https://github.com/apache/kafka/pull/18715#issuecomment-2667405822 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18379: Enforce resigned cannot transition to any other state in same epoch [kafka]

2025-02-18 Thread via GitHub
github-actions[bot] commented on PR #18789: URL: https://github.com/apache/kafka/pull/18789#issuecomment-2667405797 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18754: Allow `PlainSaslServer` to pass client info through the negotiated properties. [kafka]

2025-02-18 Thread via GitHub
github-actions[bot] commented on PR #18828: URL: https://github.com/apache/kafka/pull/18828#issuecomment-2667405748 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18576: Convert ConfigType to Enum [kafka]

2025-02-18 Thread via GitHub
github-actions[bot] commented on PR #18711: URL: https://github.com/apache/kafka/pull/18711#issuecomment-2667405849 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-18606: Flaky test DeleteSegmentsByRetentionTimeTest#executeTieredStorageTest [kafka]

2025-02-18 Thread via GitHub
github-actions[bot] commented on PR #18861: URL: https://github.com/apache/kafka/pull/18861#issuecomment-2667405716 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

[PR] MINOR: Update upgrade notes [kafka]

2025-02-18 Thread via GitHub
ijuma opened a new pull request, #18960: URL: https://github.com/apache/kafka/pull/18960 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

Re: [PR] Support for base64 encode string keystore [kafka]

2025-02-18 Thread via GitHub
github-actions[bot] commented on PR #17561: URL: https://github.com/apache/kafka/pull/17561#issuecomment-2667432037 This PR has been closed since it has not had any activity in 120 days. If you feel like this was a mistake, or you would like to continue working on it, please feel free to

Re: [PR] Support for base64 encode string keystore [kafka]

2025-02-18 Thread via GitHub
github-actions[bot] closed pull request #17561: Support for base64 encode string keystore URL: https://github.com/apache/kafka/pull/17561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-18799: Remove `AdminUtils` [kafka]

2025-02-18 Thread via GitHub
chia7712 merged PR #18946: URL: https://github.com/apache/kafka/pull/18946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-18799) Remove AdminUtils

2025-02-18 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-18799. Fix Version/s: 4.1.0 Resolution: Fixed > Remove AdminUtils > - > >

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-18 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1960678323 ## metadata/src/test/java/org/apache/kafka/image/writer/ImageWriterOptionsTest.java: ## @@ -48,40 +48,33 @@ public class ImageWriterOptionsTest { @Test public

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-18 Thread via GitHub
frankvicky commented on PR #18844: URL: https://github.com/apache/kafka/pull/18844#issuecomment-2667179189 Run the native container with the latest commit: ![Screenshot from 2025-02-19 07-48-47](https://github.com/user-attachments/assets/03175a9c-c931-409c-b018-2a696a9d382e) -- Thi

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-18 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1960688656 ## metadata/src/test/java/org/apache/kafka/controller/ClusterControlManagerTest.java: ## @@ -718,30 +710,14 @@ public void testRegistrationWithUnsupportedMetadataVersion

[PR] MINOR: Fix Some Exceptions in MetaPropertiesEnsemble and MetadataQuorumCommand [kafka]

2025-02-18 Thread via GitHub
nihyxx opened a new pull request, #18957: URL: https://github.com/apache/kafka/pull/18957 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

Re: [PR] KAFKA-16918: TestUtils#assertFutureThrows should use future.get with timeout [kafka]

2025-02-18 Thread via GitHub
m1a2st commented on PR #18891: URL: https://github.com/apache/kafka/pull/18891#issuecomment-2667203885 Thanks for @Parkerhiphop reminder :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[jira] [Commented] (KAFKA-4650) Improve test coverage org.apache.kafka.streams.kstream.internals

2025-02-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928224#comment-17928224 ] Matthias J. Sax commented on KAFKA-4650: Thanks Lorcan. I'll take a look (might t

[jira] [Assigned] (KAFKA-4650) Improve test coverage org.apache.kafka.streams.kstream.internals

2025-02-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-4650: -- Assignee: Lorcan > Improve test coverage org.apache.kafka.streams.kstream.internals >

Re: [PR] MINOR: Move the ELR default version to 4.1 [kafka]

2025-02-18 Thread via GitHub
CalvinConfluent commented on code in PR #18954: URL: https://github.com/apache/kafka/pull/18954#discussion_r1960765911 ## server-common/src/main/java/org/apache/kafka/server/common/EligibleLeaderReplicasVersion.java: ## @@ -25,7 +25,7 @@ public enum EligibleLeaderReplicasVersion

[jira] [Updated] (KAFKA-18826) Add Global Thread Metrics

2025-02-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-18826: Component/s: streams > Add Global Thread Metrics > - > >

Re: [PR] Touch asf yaml [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah merged PR #57: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

[PR] Another default commit message test [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah opened a new pull request, #58: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/58 Hopefully this becomes the git body. Reviewers: David Arthur -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] KAFKA-18754: Allow `PlainSaslServer` to pass client info through the negotiated properties. [kafka]

2025-02-18 Thread via GitHub
bachmanity1 commented on PR #18828: URL: https://github.com/apache/kafka/pull/18828#issuecomment-2667501190 @chia7712 can you have a look please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] KAFKA-18757: Create full-function SimpleAssignor to match KIP-932 description [kafka]

2025-02-18 Thread via GitHub
adixitconfluent commented on code in PR #18864: URL: https://github.com/apache/kafka/pull/18864#discussion_r1960968611 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -111,12 +258,26 @@ private Map> computeTargetPartition

Re: [PR] KAFKA-18757: Create full-function SimpleAssignor to match KIP-932 description [kafka]

2025-02-18 Thread via GitHub
adixitconfluent commented on code in PR #18864: URL: https://github.com/apache/kafka/pull/18864#discussion_r1960969024 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -111,12 +258,26 @@ private Map> computeTargetPartition

[PR] KAFKA-18828: Update share group metrics per new init and call mechanism. [kafka]

2025-02-18 Thread via GitHub
smjn opened a new pull request, #18962: URL: https://github.com/apache/kafka/pull/18962 * Due to recent changes in the group count metrics are initialized and updated, the current share group count code has become obsolete as well as non-functional. * The update method for the share-grou

Re: [PR] Add TransactionAbortableException and Timeout Exception handling instruction in docs [kafka]

2025-02-18 Thread via GitHub
k-raina commented on PR #18942: URL: https://github.com/apache/kafka/pull/18942#issuecomment-2667686271 @jolshan Yes, i will raise PR for 4.0 as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-18 Thread via GitHub
frankvicky opened a new pull request, #18961: URL: https://github.com/apache/kafka/pull/18961 Reference: https://github.com/apache/kafka/pull/18365/files#r1960092384 The content of `upgrade.html` has become too large. This patch moves the embedded `zk2kraft` content into a separate page

Re: [PR] KAFKA-18757: Create full-function SimpleAssignor to match KIP-932 description [kafka]

2025-02-18 Thread via GitHub
adixitconfluent commented on code in PR #18864: URL: https://github.com/apache/kafka/pull/18864#discussion_r1960965421 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -111,12 +258,26 @@ private Map> computeTargetPartition

Re: [PR] KAFKA-18757: Create full-function SimpleAssignor to match KIP-932 description [kafka]

2025-02-18 Thread via GitHub
adixitconfluent commented on code in PR #18864: URL: https://github.com/apache/kafka/pull/18864#discussion_r1960964532 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java: ## @@ -72,36 +77,178 @@ private GroupAssignment assignHomoge

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-18 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1960998479 ## docs/upgrade.html: ## @@ -48,7 +48,6 @@ Notable changes in 4 Before updating your Kafka cluster which build on Zookeeper to Kafka 4.0, you must unders

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-18 Thread via GitHub
mingdaoy commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961009420 ## docs/zk2kraft.html: ## @@ -15,14 +15,13 @@ limitations under the License. --> - + + - + -Significant Cha

[jira] [Created] (KAFKA-18827) Initialize share group state impl

2025-02-18 Thread Sushant Mahajan (Jira)
Sushant Mahajan created KAFKA-18827: --- Summary: Initialize share group state impl Key: KAFKA-18827 URL: https://issues.apache.org/jira/browse/KAFKA-18827 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-18828) Update share group metrics code in group coordinator

2025-02-18 Thread Sushant Mahajan (Jira)
Sushant Mahajan created KAFKA-18828: --- Summary: Update share group metrics code in group coordinator Key: KAFKA-18828 URL: https://issues.apache.org/jira/browse/KAFKA-18828 Project: Kafka Is

Re: [PR] MINOR: Add a separate page for zk2kraft.html [kafka]

2025-02-18 Thread via GitHub
frankvicky commented on code in PR #18961: URL: https://github.com/apache/kafka/pull/18961#discussion_r1961026169 ## docs/upgrade.html: ## @@ -48,7 +48,6 @@ Notable changes in 4 Before updating your Kafka cluster which build on Zookeeper to Kafka 4.0, you must unde

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-18 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1960706340 ## metadata/src/test/java/org/apache/kafka/controller/ClusterControlManagerTest.java: ## @@ -718,30 +710,14 @@ public void testRegistrationWithUnsupportedMetadataVersion

Re: [PR] KAFKA-17544: Fix for loading big files while performing load tests [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on PR #18391: URL: https://github.com/apache/kafka/pull/18391#issuecomment-2667111606 @manoj-mathivanan could you please merge trunk to run CI again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[PR] MINOR: Add Append KRaft Version Record to BatchAccumulator [kafka]

2025-02-18 Thread via GitHub
nihyxx opened a new pull request, #18956: URL: https://github.com/apache/kafka/pull/18956 ### What This minor PR adds a function to append the KRaft Version Record in BatchAccumulator. This is needed to implement KRaft upgrade (https://issues.apache.org/jira/browse/KAFKA-16538). *

Re: [PR] KAFKA-18723; Better handle invalid records during replication [kafka]

2025-02-18 Thread via GitHub
jsancio commented on code in PR #18852: URL: https://github.com/apache/kafka/pull/18852#discussion_r1960725101 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1086,63 +1088,79 @@ class UnifiedLog(@volatile var logStartOffset: Long, var shallowOffsetOfMaxTimestamp

Re: [PR] Feb 18 test 2 [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah merged PR #56: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/56 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

Re: [PR] PR Title Test 1 [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah merged PR #55: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

Re: [PR] MINOR: cleanup top level class JavaDocs for main interfaces of Kafka Streams DSL (3/N) [kafka]

2025-02-18 Thread via GitHub
mjsax merged PR #18883: URL: https://github.com/apache/kafka/pull/18883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] Another default commit message test [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah merged PR #58: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

Re: [PR] MINOR: Update upgrade notes for 4.0.0 [kafka]

2025-02-18 Thread via GitHub
ijuma commented on PR #18960: URL: https://github.com/apache/kafka/pull/18960#issuecomment-2667401699 @chia7712 I didn't change the #include for kraft to zk, but cleaned up the page significantly. -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] KAFKA-18647: Clarify Windows support in Quick Start Guide [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on PR #18715: URL: https://github.com/apache/kafka/pull/18715#issuecomment-2667048506 > Is Kafka-site what im building or the main Kafka site. The changes you've made are difficult to review without seeing the rendered output. Our usual process is to build the site

Re: [PR] KAFKA-18641: AsyncKafkaConsumer could lose records with auto offset commit [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on PR #18737: URL: https://github.com/apache/kafka/pull/18737#issuecomment-2667067831 @frankvicky could you please fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] Touch asf yaml [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah opened a new pull request, #57: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/57 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-18 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1960678323 ## metadata/src/test/java/org/apache/kafka/image/writer/ImageWriterOptionsTest.java: ## @@ -48,40 +48,33 @@ public class ImageWriterOptionsTest { @Test public

Re: [PR] KAFKA-18601: Assume a baseline of 3.3 for server protocol versions [kafka]

2025-02-18 Thread via GitHub
ijuma commented on code in PR #18845: URL: https://github.com/apache/kafka/pull/18845#discussion_r1960679302 ## metadata/src/main/java/org/apache/kafka/image/writer/ImageWriterOptions.java: ## @@ -29,30 +29,22 @@ public final class ImageWriterOptions { public static class

Re: [PR] KAFKA-10409: Refactor Kakfa Streams RocksDB Iterators [kafka]

2025-02-18 Thread via GitHub
ableegoldman commented on PR #18610: URL: https://github.com/apache/kafka/pull/18610#issuecomment-2667093088 Yep! Will take a look in the next day or so 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Update asf.yaml [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah merged PR #54: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@

Re: [PR] KAFKA-10409: Refactor Kakfa Streams RocksDB Iterators [kafka]

2025-02-18 Thread via GitHub
agavra commented on code in PR #18610: URL: https://github.com/apache/kafka/pull/18610#discussion_r1960767233 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimestampedStore.java: ## @@ -277,197 +275,361 @@ public void close() { } } -

Re: [PR] KAFKA-18364 migrating from zk to kraft document [kafka]

2025-02-18 Thread via GitHub
ijuma commented on code in PR #18365: URL: https://github.com/apache/kafka/pull/18365#discussion_r1960797682 ## docs/upgrade.html: ## @@ -38,6 +38,12 @@ Notable changes in 4 taken when it comes to kafka clients that are not part of Apache Kafka, please see

[PR] PR Title Test 1 [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah opened a new pull request, #55: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/55 Here is the PR description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[PR] Feb 18 test 2 [kafka-merge-queue-sandbox]

2025-02-18 Thread via GitHub
mumrah opened a new pull request, #56: URL: https://github.com/apache/kafka-merge-queue-sandbox/pull/56 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] MINOR: fix Kafka Streams "smoke test" pass criteria [kafka]

2025-02-18 Thread via GitHub
mjsax commented on code in PR #18835: URL: https://github.com/apache/kafka/pull/18835#discussion_r1960802819 ## tests/kafkatest/tests/streams/streams_smoke_test.py: ## @@ -109,5 +109,7 @@ def test_streams(self, processing_guarantee, crash, metadata_quorum): if crash

Re: [PR] KAFKA-16890: Compute valid log-start-offset when deleting overlapping remote segments [kafka]

2025-02-18 Thread via GitHub
divijvaidya commented on code in PR #16237: URL: https://github.com/apache/kafka/pull/16237#discussion_r1960063268 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -972,7 +972,9 @@ private boolean isSegmentBreachedByRetentionSize(RemoteLogSegmentMetadata meta

[jira] [Comment Edited] (KAFKA-18033) ShareConsumerTest is flaky

2025-02-18 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928176#comment-17928176 ] Shivsundar R edited comment on KAFKA-18033 at 2/18/25 5:42 PM: ---

Re: [PR] KAFKA-12622: Automate LICENSE file validation [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on PR #17888: URL: https://github.com/apache/kafka/pull/17888#issuecomment-2665984323 @fonsdant I apologize, and while we typically prioritize the oldest PR, we are currently preparing for the 4.0.0 release, which may make us a little impolite :( If you have other

[jira] [Commented] (KAFKA-18033) ShareConsumerTest is flaky

2025-02-18 Thread Shivsundar R (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928176#comment-17928176 ] Shivsundar R commented on KAFKA-18033: -- Hey [~kangning] , do you mind if I take ove

[jira] [Resolved] (KAFKA-18524) Fix flaky RemoteIndexCacheTest#testCorrectnessForCacheAndIndexFilesWhenResizeCache

2025-02-18 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash resolved KAFKA-18524. -- Fix Version/s: 4.1.0 Resolution: Duplicate > Fix flaky > RemoteIndexCa

Re: [PR] KAFKA-18089: RemoteIndexCacheTest fails with caffeine > 3.1.1 [kafka]

2025-02-18 Thread via GitHub
TaiJuWu commented on PR #18004: URL: https://github.com/apache/kafka/pull/18004#issuecomment-2666227933 > The flaky tests are tracked under [KAFKA-18606](https://issues.apache.org/jira/browse/KAFKA-18606) and [KAFKA-18825](https://issues.apache.org/jira/browse/KAFKA-18825). Thanks fo

[jira] [Resolved] (KAFKA-18089) RemoteIndexCacheTest fails with caffeine > 3.1.1

2025-02-18 Thread Kamal Chandraprakash (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamal Chandraprakash resolved KAFKA-18089. -- Fix Version/s: 4.1.0 Resolution: Fixed > RemoteIndexCacheTest fails wit

Re: [PR] KAFKA-18773: Migrate the log4j1 config to log4j 2 for native image and README [kafka]

2025-02-18 Thread via GitHub
chia7712 merged PR #18872: URL: https://github.com/apache/kafka/pull/18872 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[PR] Add unit tests for GraphNode class [kafka]

2025-02-18 Thread via GitHub
lorcanj opened a new pull request, #18951: URL: https://github.com/apache/kafka/pull/18951 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

Re: [PR] KAFKA-18364 migrating from zk to kraft document [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on code in PR #18365: URL: https://github.com/apache/kafka/pull/18365#discussion_r1960141648 ## docs/upgrade.html: ## @@ -38,6 +38,12 @@ Notable changes in 4 taken when it comes to kafka clients that are not part of Apache Kafka, please see

[jira] [Commented] (KAFKA-4650) Improve test coverage org.apache.kafka.streams.kstream.internals

2025-02-18 Thread Lorcan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928166#comment-17928166 ] Lorcan commented on KAFKA-4650: --- Hi [~damianguy], [~mjsax], I have created a PR for some un

[jira] [Comment Edited] (KAFKA-18033) ShareConsumerTest is flaky

2025-02-18 Thread Ukpa Uchechi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928152#comment-17928152 ] Ukpa Uchechi edited comment on KAFKA-18033 at 2/18/25 4:49 PM: ---

Re: [PR] KAFKA-18198: Added check to prevent acknowledgements on initial ShareFetchRequest. [kafka]

2025-02-18 Thread via GitHub
AndrewJSchofield commented on code in PR #18944: URL: https://github.com/apache/kafka/pull/18944#discussion_r1960173095 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManagerTest.java: ## @@ -1344,6 +1344,31 @@ public void testFetchError(

Re: [PR] KAFKA-18773: Migrate the log4j1 config to log4j 2 for native image and README [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on code in PR #18872: URL: https://github.com/apache/kafka/pull/18872#discussion_r1960176376 ## build.gradle: ## @@ -1072,7 +1072,6 @@ project(':core') { implementation libs.argparse4j implementation libs.commonsValidator implementation libs.jac

Re: [PR] KAFKA-18089: RemoteIndexCacheTest fails with caffeine > 3.1.1 [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on code in PR #18004: URL: https://github.com/apache/kafka/pull/18004#discussion_r1960176557 ## gradle/dependencies.gradle: ## @@ -54,10 +54,7 @@ versions += [ apacheds: "2.0.0-M24", argparse4j: "0.7.0", bcpkix: "1.78.1", - // Version >=3.1.2 include

Re: [PR] MINOR: Fix the missing and updated licenses [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on PR #18950: URL: https://github.com/apache/kafka/pull/18950#issuecomment-2666354400 run the check locally. ``` All libs from ./libs are present in the LICENSE file. No extra dependencies in the LICENSE file. chia7712@chia7712-ubuntu:~/project/kafka$ python

Re: [PR] KAFKA-18089: RemoteIndexCacheTest fails with caffeine > 3.1.1 [kafka]

2025-02-18 Thread via GitHub
kamalcph commented on PR #18004: URL: https://github.com/apache/kafka/pull/18004#issuecomment-2666193968 There are 0 failed tests, 3 flaky tests. The tests are already flaky in trunk: ``` FLAKY ⚠️ EligibleLeaderReplicasIntegrationTest > "testLastKnownLeaderShouldBeElectedIfEmpty

Re: [PR] KAFKA-18089: RemoteIndexCacheTest fails with caffeine > 3.1.1 [kafka]

2025-02-18 Thread via GitHub
kamalcph merged PR #18004: URL: https://github.com/apache/kafka/pull/18004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-18825) Fix the flaky EligibleLeaderReplicasIntegrationTest

2025-02-18 Thread Kamal Chandraprakash (Jira)
Kamal Chandraprakash created KAFKA-18825: Summary: Fix the flaky EligibleLeaderReplicasIntegrationTest Key: KAFKA-18825 URL: https://issues.apache.org/jira/browse/KAFKA-18825 Project: Kafka

[jira] [Commented] (KAFKA-18033) ShareConsumerTest is flaky

2025-02-18 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17928172#comment-17928172 ] Andrew Schofield commented on KAFKA-18033: -- [~graceu] Not quite. The tests in q

Re: [PR] MINOR: Fix the missing and updated licenses [kafka]

2025-02-18 Thread via GitHub
chia7712 merged PR #18950: URL: https://github.com/apache/kafka/pull/18950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-18823) native docker don't honor the result of checking sign key

2025-02-18 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-18823: -- Summary: native docker don't honor the result of checking sign key Key: KAFKA-18823 URL: https://issues.apache.org/jira/browse/KAFKA-18823 Project: Kafka

Re: [PR] KAFKA-12622: Automate LICENSE file validation [kafka]

2025-02-18 Thread via GitHub
chia7712 closed pull request #17888: KAFKA-12622: Automate LICENSE file validation URL: https://github.com/apache/kafka/pull/17888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] KAFKA-12622: Automate LICENSE file validation [kafka]

2025-02-18 Thread via GitHub
chia7712 commented on PR #17888: URL: https://github.com/apache/kafka/pull/17888#issuecomment-2666055242 @fonsdant thanks for you. I'm going to close this PR/jira -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (KAFKA-18824) Update docs of docker hub to add dynamic voters description

2025-02-18 Thread TengYao Chi (Jira)
TengYao Chi created KAFKA-18824: --- Summary: Update docs of docker hub to add dynamic voters description Key: KAFKA-18824 URL: https://issues.apache.org/jira/browse/KAFKA-18824 Project: Kafka Is

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-18 Thread via GitHub
frankvicky commented on code in PR #18844: URL: https://github.com/apache/kafka/pull/18844#discussion_r1960055576 ## docker/server.properties: ## @@ -0,0 +1,129 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the N

Re: [PR] KAFKA-18767: Add client side config check for shareConsumer [kafka]

2025-02-18 Thread via GitHub
TaiJuWu commented on PR #18850: URL: https://github.com/apache/kafka/pull/18850#issuecomment-2666161624 @AndrewJSchofield Thanks for review! If any issues I can help, please assign to me, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] KAFKA-18737: KafkaDockerWrapper setup functions fails due to storage format command [kafka]

2025-02-18 Thread via GitHub
frankvicky commented on PR #18844: URL: https://github.com/apache/kafka/pull/18844#issuecomment-2666142357 Run the jvm container with the latest commit: ![Screenshot from 2025-02-18 23-38-22](https://github.com/user-attachments/assets/7e89970e-f043-4c4d-8a75-3b7eedfc7204) New argum

Re: [PR] KAFKA-18767: Add client side config check for shareConsumer [kafka]

2025-02-18 Thread via GitHub
AndrewJSchofield merged PR #18850: URL: https://github.com/apache/kafka/pull/18850 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafk

[jira] [Resolved] (KAFKA-18767) Add client side config check for shareConsumer

2025-02-18 Thread Andrew Schofield (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Schofield resolved KAFKA-18767. -- Fix Version/s: 4.1.0 Resolution: Fixed > Add client side config check for share

[jira] [Updated] (KAFKA-18818) Significant delay in Metadata Update After Admin Client Operations in KRaft Mode

2025-02-18 Thread Shubham Raj (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shubham Raj updated KAFKA-18818: Description: We have observed a significant delay in metadata updates after performing asynchrono

Re: [PR] KAFKA-18198: Added check to prevent acknowledgements on initial ShareFetchRequest. [kafka]

2025-02-18 Thread via GitHub
ShivsundarR commented on code in PR #18944: URL: https://github.com/apache/kafka/pull/18944#discussion_r1960241628 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java: ## @@ -177,8 +177,14 @@ public PollResult poll(long currentTim

Re: [PR] KAFKA-18089: RemoteIndexCacheTest fails with caffeine > 3.1.1 [kafka]

2025-02-18 Thread via GitHub
kamalcph commented on code in PR #18004: URL: https://github.com/apache/kafka/pull/18004#discussion_r1960245594 ## gradle/dependencies.gradle: ## @@ -54,10 +54,7 @@ versions += [ apacheds: "2.0.0-M24", argparse4j: "0.7.0", bcpkix: "1.78.1", - // Version >=3.1.2 include

Re: [PR] KAFKA-18667: Add ducktape tests for simultaneous broker + controller failure [kafka]

2025-02-18 Thread via GitHub
mumrah merged PR #18757: URL: https://github.com/apache/kafka/pull/18757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o

  1   2   3   >