mjsax commented on code in PR #18883:
URL: https://github.com/apache/kafka/pull/18883#discussion_r1960770603
##########
streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindowedKStream.java:
##########
@@ -18,38 +18,46 @@
import org.apache.kafka.common.utils.Bytes;
import org.apache.kafka.streams.KafkaStreams;
-import org.apache.kafka.streams.KeyValue;
import org.apache.kafka.streams.StoreQueryParameters;
import org.apache.kafka.streams.StreamsConfig;
import org.apache.kafka.streams.Topology;
+import org.apache.kafka.streams.processor.api.Record;
import org.apache.kafka.streams.state.ReadOnlyWindowStore;
import org.apache.kafka.streams.state.TimestampedWindowStore;
import org.apache.kafka.streams.state.WindowStore;
import java.time.Duration;
/**
- * {@code TimeWindowedKStream} is an abstraction of a <i>windowed</i> record
stream of {@link KeyValue} pairs.
- * It is an intermediate representation after a grouping and windowing of a
{@link KStream} before an aggregation is
- * applied to the new (partitioned) windows resulting in a windowed {@link
KTable} (a <emph>windowed</emph>
- * {@code KTable} is a {@link KTable} with key type {@link Windowed
Windowed<K>}).
- * <p>
- * The specified {@code windows} define either hopping time windows that can
be overlapping or tumbling (c.f.
- * {@link TimeWindows}) or they define landmark windows (c.f. {@link
UnlimitedWindows}).
- * <p>
- * The result is written into a local {@link WindowStore} (which is basically
an ever-updating
+ * {@code TimeWindowedKStream} is an abstraction of a <em>windowed</em> record
stream of {@link Record key-value} pairs.
+ * It is an intermediate representation of a {@link KStream}, that is
aggregated into a windowed {@link KTable}
+ * (a <em>windowed</em> {@link KTable} is a {@link KTable} with key type
{@link Windowed Windowed<K>}).
+ *
+ * <p>A {@code TimeWindowedKStream} can represent one of four different
windowed types:
Review Comment:
Yeah, I did count tumbling/hopping as two
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
