adixitconfluent commented on code in PR #18864:
URL: https://github.com/apache/kafka/pull/18864#discussion_r1960965421
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/SimpleAssignor.java:
##########
@@ -111,12 +258,26 @@ private Map<Uuid, Set<Integer>> computeTargetPartitions(
);
}
- Set<Integer> partitions = new HashSet<>();
for (int i = 0; i < numPartitions; i++) {
- partitions.add(i);
+ targetPartitions.add(new TargetPartition(topicId, i));
}
- targetPartitions.put(topicId, partitions);
});
return targetPartitions;
}
+
+ record TargetPartition(Uuid topicId, int partition) {
Review Comment:
you're right, we can use it. I was unable to find a class that did not
contain topic name. Thanks for pointing it out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
