chia7712 commented on code in PR #18845:
URL: https://github.com/apache/kafka/pull/18845#discussion_r1960696997
##########
metadata/src/test/java/org/apache/kafka/controller/ClusterControlManagerTest.java:
##########
@@ -718,30 +710,14 @@ public void
testRegistrationWithUnsupportedMetadataVersion() {
setFeatures(new
BrokerRegistrationRequestData.FeatureCollection(
Collections.singleton(new
BrokerRegistrationRequestData.Feature().
setName(MetadataVersion.FEATURE_NAME).
-
setMinSupportedVersion(MetadataVersion.IBP_3_3_IV3.featureLevel()).
-
setMaxSupportedVersion(MetadataVersion.IBP_3_3_IV3.featureLevel())).iterator())).
+
setMinSupportedVersion(MetadataVersion.IBP_3_4_IV0.featureLevel()).
+
setMaxSupportedVersion(MetadataVersion.IBP_3_4_IV0.featureLevel())).iterator())).
setIncarnationId(Uuid.fromString("0H4fUu1xQEKXFYwB1aBjhg")),
123L,
featureControl.finalizedFeatures(Long.MAX_VALUE),
false)).getMessage());
}
- @Test
- public void testRegisterControlWithOlderMetadataVersion() {
- FeatureControlManager featureControl = new
FeatureControlManager.Builder().
- setMetadataVersion(MetadataVersion.IBP_3_3_IV0).
Review Comment:
It appears that `testRegistrationWithUnsupportedMetadataVersion` is designed
to test broker registration, while
`testRegisterControlWithOlderMetadataVersion` is for controller registration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
