aliehsaeedii commented on code in PR #18652:
URL: https://github.com/apache/kafka/pull/18652#discussion_r1936905316
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/ProcessState.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Softw
frankvicky commented on code in PR #18763:
URL: https://github.com/apache/kafka/pull/18763#discussion_r1936975308
##
tests/kafkatest/sanity_checks/test_console_consumer.py:
##
@@ -44,8 +44,7 @@ def setUp(self):
@cluster(num_nodes=3)
@matrix(security_protocol=['PLAINTEX
loicgreffier commented on code in PR #18739:
URL: https://github.com/apache/kafka/pull/18739#discussion_r1936976194
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java:
##
@@ -259,6 +259,10 @@ public void send(final String topic,
[
https://issues.apache.org/jira/browse/KAFKA-18679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922646#comment-17922646
]
TaiJuWu commented on KAFKA-18679:
-
Hi [~kevinwu2412] , may I pick this up?
> KafkaRaftM
loicgreffier commented on code in PR #18739:
URL: https://github.com/apache/kafka/pull/18739#discussion_r1936995608
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StampedRecord.java:
##
@@ -55,8 +69,26 @@ public Headers headers() {
return value.he
dajac opened a new pull request, #18766:
URL: https://github.com/apache/kafka/pull/18766
This patch renames kraft_upgrade_test.py to upgrade_test.py. This is enough
to cover the old upgrade/downgrade tests.
### Committer Checklist (excluded from commit message)
- [ ] Verify design
mimaison merged PR #18519:
URL: https://github.com/apache/kafka/pull/18519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
chirag-wadhwa5 commented on code in PR #18696:
URL: https://github.com/apache/kafka/pull/18696#discussion_r1937022015
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -2160,6 +2234,43 @@ private long startOffsetDuringInitialization(long
partitionDataStartOffs
黃竣陽 created KAFKA-18685:
---
Summary: Refactor DynamicLogConfig constructor
Key: KAFKA-18685
URL: https://issues.apache.org/jira/browse/KAFKA-18685
Project: Kafka
Issue Type: Improvement
Repo
lucasbru commented on code in PR #18765:
URL: https://github.com/apache/kafka/pull/18765#discussion_r1936939161
##
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java:
##
@@ -1543,26 +1544,28 @@ private boolean close(final Optional timeout,
final boolean leaveGroup
dajac merged PR #18763:
URL: https://github.com/apache/kafka/pull/18763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
[
https://issues.apache.org/jira/browse/KAFKA-18677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-18677.
-
Resolution: Fixed
> Update ConsoleConsumerTest system test
> ---
dajac commented on PR #18763:
URL: https://github.com/apache/kafka/pull/18763#issuecomment-2626970633
Merged to trunk and 4.0. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/KAFKA-18686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 updated KAFKA-18686:
Description:
It seens this test flaky these days
[https://github.com/apache/kafka/actions/runs/13061784839/job/36
[
https://issues.apache.org/jira/browse/KAFKA-18685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
黃竣陽 updated KAFKA-18685:
Summary: Cleanup DynamicLogConfig constructor (was: Refactor
DynamicLogConfig constructor )
> Cleanup DynamicLo
dajac commented on code in PR #18763:
URL: https://github.com/apache/kafka/pull/18763#discussion_r1936943993
##
tests/kafkatest/sanity_checks/test_console_consumer.py:
##
@@ -44,8 +44,7 @@ def setUp(self):
@cluster(num_nodes=3)
@matrix(security_protocol=['PLAINTEXT', '
mimaison merged PR #17511:
URL: https://github.com/apache/kafka/pull/17511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
frankvicky commented on code in PR #18763:
URL: https://github.com/apache/kafka/pull/18763#discussion_r1936955157
##
tests/kafkatest/sanity_checks/test_console_consumer.py:
##
@@ -44,8 +44,7 @@ def setUp(self):
@cluster(num_nodes=3)
@matrix(security_protocol=['PLAINTEX
dajac commented on code in PR #18756:
URL: https://github.com/apache/kafka/pull/18756#discussion_r1936945456
##
docs/upgrade.html:
##
@@ -89,6 +89,27 @@ Notable changes in 4
Broker
+The new Consumer
apoorvmittal10 commented on code in PR #18696:
URL: https://github.com/apache/kafka/pull/18696#discussion_r1936961623
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -1791,10 +1875,24 @@ be removed once all the messages (0-99) are
acknowledged (ACCEPT or REJ
lucasbru opened a new pull request, #18765:
URL: https://github.com/apache/kafka/pull/18765
The exception stack trace shown in the ticket can happen when we are
concurrently closing the producer because of an error and doing a regular
close. This is not a bug in the test, but a real race co
[
https://issues.apache.org/jira/browse/KAFKA-16906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kaushik Raina reassigned KAFKA-16906:
-
Assignee: Kaushik Raina
> Add consistent error handling for Transactions
>
黃竣陽 created KAFKA-18686:
---
Summary: Flaky test
StandbyTaskEOSMultiRebalanceIntegrationTest#shouldHonorEOSWhenUsingCachingAndStandbyReplicas
Key: KAFKA-18686
URL: https://issues.apache.org/jira/browse/KAFKA-18686
aliehsaeedii commented on code in PR #18652:
URL: https://github.com/apache/kafka/pull/18652#discussion_r1936919748
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignor.java:
##
@@ -0,0 +1,440 @@
+/*
+ * Licensed to the Apache
chirag-wadhwa5 commented on code in PR #18696:
URL: https://github.com/apache/kafka/pull/18696#discussion_r1936922439
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -1791,10 +1875,23 @@ be removed once all the messages (0-99) are
acknowledged (ACCEPT or REJ
chirag-wadhwa5 commented on code in PR #18696:
URL: https://github.com/apache/kafka/pull/18696#discussion_r1936922439
##
core/src/main/java/kafka/server/share/SharePartition.java:
##
@@ -1791,10 +1875,23 @@ be removed once all the messages (0-99) are
acknowledged (ACCEPT or REJ
mimaison commented on PR #18762:
URL: https://github.com/apache/kafka/pull/18762#issuecomment-2626730476
Thanks for the PR.
I've not looked into this issue but if we're fixing some logic then I was
expecting some updates in the tests too. Why are the existing tests passing if
you say
[
https://issues.apache.org/jira/browse/KAFKA-16717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922688#comment-17922688
]
Jimmy Wang commented on KAFKA-16717:
[~schofielaj] Thanks for your reply.
I prefer
cadonna commented on code in PR #18676:
URL: https://github.com/apache/kafka/pull/18676#discussion_r1936879253
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/TopologyMetadata.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Foundat
sebastienviale commented on code in PR #18233:
URL: https://github.com/apache/kafka/pull/18233#discussion_r1937323264
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -592,6 +592,10 @@ public class StreamsConfig extends AbstractConfig {
public sta
sebastienviale commented on code in PR #18233:
URL: https://github.com/apache/kafka/pull/18233#discussion_r1937323668
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -592,6 +592,10 @@ public class StreamsConfig extends AbstractConfig {
public sta
sebastienviale commented on code in PR #18233:
URL: https://github.com/apache/kafka/pull/18233#discussion_r1937326984
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -2333,4 +2341,33 @@ public
WrappedProcessorSupplier w
sebastienviale commented on code in PR #18233:
URL: https://github.com/apache/kafka/pull/18233#discussion_r1937324922
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedStreamAggregateBuilder.java:
##
@@ -214,8 +215,7 @@ private void processRepartitions
sebastienviale commented on code in PR #18233:
URL: https://github.com/apache/kafka/pull/18233#discussion_r1937325997
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/InternalStreamsBuilder.java:
##
@@ -489,7 +492,8 @@ private void mergeRepartitionTopics() {
cadonna commented on PR #18739:
URL: https://github.com/apache/kafka/pull/18739#issuecomment-2627367592
> @cadonna Changes about buffers will be added to this PR. However, despite
my tests using `suppress()`, I did not manage to lose the `rawKey` and
`rawValue` for now. I'm always receiving
cadonna commented on code in PR #18551:
URL: https://github.com/apache/kafka/pull/18551#discussion_r1937345936
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java:
##
@@ -0,0 +1,1249 @@
+/*
+ * Licensed to the Apache Software Founda
dajac merged PR #18766:
URL: https://github.com/apache/kafka/pull/18766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
chia7712 commented on code in PR #18450:
URL: https://github.com/apache/kafka/pull/18450#discussion_r1937376383
##
core/src/main/scala/kafka/zookeeper/ZooKeeperClient.scala:
##
@@ -59,63 +50,9 @@ class ZooKeeperClient(connectString: String,
time: Time,
lianetm commented on PR #17700:
URL: https://github.com/apache/kafka/pull/17700#issuecomment-2627458022
Done, manually cherry-picked to 4.0 (clean)
https://github.com/apache/kafka/commit/9c02072c4fd8159087b7960872d6ee8271a308ab
Thanks @kirktrue !
cc. @junrao
--
This is an autom
[
https://issues.apache.org/jira/browse/KAFKA-18146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-18146.
-
Resolution: Fixed
> tests/kafkatest/tests/core/upgrade_test.py needs to be re-added as KRaft
> -
sebastienviale commented on code in PR #18233:
URL: https://github.com/apache/kafka/pull/18233#discussion_r1937384414
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilder.java:
##
@@ -192,6 +196,10 @@ public InternalTopologyBuilder(final
[
https://issues.apache.org/jira/browse/KAFKA-17182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922724#comment-17922724
]
Lianet Magrans commented on KAFKA-17182:
Cherry-picked to 4.0
[https://github.c
cadonna commented on code in PR #18551:
URL: https://github.com/apache/kafka/pull/18551#discussion_r1937615237
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java:
##
@@ -0,0 +1,1249 @@
+/*
+ * Licensed to the Apache Software Founda
cadonna commented on code in PR #18551:
URL: https://github.com/apache/kafka/pull/18551#discussion_r1937614089
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java:
##
@@ -0,0 +1,1249 @@
+/*
+ * Licensed to the Apache Software Founda
cadonna commented on code in PR #18551:
URL: https://github.com/apache/kafka/pull/18551#discussion_r1937615571
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java:
##
@@ -0,0 +1,1249 @@
+/*
+ * Licensed to the Apache Software Founda
cadonna commented on code in PR #18551:
URL: https://github.com/apache/kafka/pull/18551#discussion_r1937616145
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java:
##
@@ -0,0 +1,1249 @@
+/*
+ * Licensed to the Apache Software Founda
cadonna commented on code in PR #18551:
URL: https://github.com/apache/kafka/pull/18551#discussion_r1937616145
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java:
##
@@ -0,0 +1,1249 @@
+/*
+ * Licensed to the Apache Software Founda
chia7712 commented on code in PR #18641:
URL: https://github.com/apache/kafka/pull/18641#discussion_r1937287973
##
core/src/main/scala/kafka/server/ClientQuotaManager.scala:
##
@@ -451,10 +449,31 @@ class ClientQuotaManager(private val config:
ClientQuotaManagerConfig,
}
dajac commented on code in PR #18749:
URL: https://github.com/apache/kafka/pull/18749#discussion_r1937293367
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorRecordSerdeTest.java:
##
@@ -198,6 +198,34 @@ public void testDeserializeWithInvalid
dajac commented on PR #18766:
URL: https://github.com/apache/kafka/pull/18766#issuecomment-2627314076
I got a successful run:
https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2025-01-31--001.87ec847a-f18e-4d26-b85b-f8c53100a36f--17383290
Yunyung commented on code in PR #18450:
URL: https://github.com/apache/kafka/pull/18450#discussion_r1937409376
##
core/src/main/scala/kafka/zookeeper/ZooKeeperClient.scala:
##
@@ -59,63 +50,9 @@ class ZooKeeperClient(connectString: String,
time: Time,
cadonna commented on code in PR #18676:
URL: https://github.com/apache/kafka/pull/18676#discussion_r1937549560
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/TopologyMetadata.java:
##
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Founda
dajac merged PR #18750:
URL: https://github.com/apache/kafka/pull/18750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
cadonna commented on code in PR #18551:
URL: https://github.com/apache/kafka/pull/18551#discussion_r1937554379
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManager.java:
##
@@ -0,0 +1,1249 @@
+/*
+ * Licensed to the Apache Software Founda
FrankYang0529 opened a new pull request, #18768:
URL: https://github.com/apache/kafka/pull/18768
Test result:
```
>
TC_PATHS="tests/kafkatest/sanity_checks/test_verifiable_producer.py::TestVerifiableProducer"
/bin/bash tests/docker/run_tests.sh
ahuang98 commented on PR #17139:
URL: https://github.com/apache/kafka/pull/17139#issuecomment-2627732715
@srdo what did you think about the KIP? Your point about the multithreading
issue is valid, and since fixing TimeRatio would impact the metric reporting
for the existing idle ratio metri
ijuma commented on code in PR #18727:
URL: https://github.com/apache/kafka/pull/18727#discussion_r1937695933
##
clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java:
##
@@ -264,8 +273,11 @@ public boolean hasValidVersion() {
return oldestVersion() <= late
ijuma commented on code in PR #18727:
URL: https://github.com/apache/kafka/pull/18727#discussion_r1937699394
##
core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala:
##
@@ -283,6 +286,48 @@ class ProduceRequestTest extends BaseRequestTest {
assertEquals(-1, partit
ijuma commented on code in PR #18727:
URL: https://github.com/apache/kafka/pull/18727#discussion_r1937699394
##
core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala:
##
@@ -283,6 +286,48 @@ class ProduceRequestTest extends BaseRequestTest {
assertEquals(-1, partit
mumrah opened a new pull request, #18770:
URL: https://github.com/apache/kafka/pull/18770
WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-u
ijuma commented on code in PR #18727:
URL: https://github.com/apache/kafka/pull/18727#discussion_r1937734265
##
core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala:
##
@@ -283,6 +286,48 @@ class ProduceRequestTest extends BaseRequestTest {
assertEquals(-1, partit
[
https://issues.apache.org/jira/browse/KAFKA-18686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922813#comment-17922813
]
Matthias J. Sax commented on KAFKA-18686:
-
The test had 100% pass rate until yes
[
https://issues.apache.org/jira/browse/KAFKA-18686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-18686:
---
Assignee: Matthias J. Sax
> Flaky test
> StandbyTaskEOSMultiRebalanceIntegrationTe
[
https://issues.apache.org/jira/browse/KAFKA-18686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-18686:
Component/s: streams
unit tests
> Flaky test
> StandbyTaskEOSMultiRebala
loicgreffier commented on code in PR #18739:
URL: https://github.com/apache/kafka/pull/18739#discussion_r1937172436
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorRecordContext.java:
##
@@ -48,6 +50,24 @@ public ProcessorRecordContext(final long t
[
https://issues.apache.org/jira/browse/KAFKA-18687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Quah updated KAFKA-18687:
--
Description:
When a consumer protocol static member replaces an existing member in a classic
group, i
[
https://issues.apache.org/jira/browse/KAFKA-18688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sean Quah reassigned KAFKA-18688:
-
Assignee: Sean Quah
> Uniform homogeneous assignment is not always stable
> ---
[
https://issues.apache.org/jira/browse/KAFKA-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-18320.
-
Resolution: Fixed
> Ensure that assignors are at the right place
> -
lucasbru commented on code in PR #18676:
URL: https://github.com/apache/kafka/pull/18676#discussion_r1937040226
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/TopologyMetadata.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache Software Founda
Sean Quah created KAFKA-18688:
-
Summary: Uniform homogeneous assignment is not always stable
Key: KAFKA-18688
URL: https://issues.apache.org/jira/browse/KAFKA-18688
Project: Kafka
Issue Type: Bug
lucasbru commented on PR #18676:
URL: https://github.com/apache/kafka/pull/18676#issuecomment-2627695635
@cadonna @bbejeck Thanks for the comments! All comments addressed, ready for
re-review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
loicgreffier commented on PR #18739:
URL: https://github.com/apache/kafka/pull/18739#issuecomment-2627195210
@cadonna Changes about buffers will be added to this PR. However, despite my
tests using `suppress()`, I did not manage to lose the `rawKey` and `rawValue`
for now. I'm always receiv
chia7712 commented on code in PR #18641:
URL: https://github.com/apache/kafka/pull/18641#discussion_r1937322084
##
core/src/main/scala/kafka/server/ClientQuotaManager.scala:
##
@@ -451,10 +449,31 @@ class ClientQuotaManager(private val config:
ClientQuotaManagerConfig,
}
dajac commented on code in PR #18768:
URL: https://github.com/apache/kafka/pull/18768#discussion_r1937598836
##
tests/kafkatest/sanity_checks/test_verifiable_producer.py:
##
@@ -32,25 +31,21 @@ def __init__(self, test_context):
super(TestVerifiableProducer, self).__init
chia7712 commented on code in PR #18583:
URL: https://github.com/apache/kafka/pull/18583#discussion_r1937352489
##
core/src/test/scala/unit/kafka/log/LogConfigTest.scala:
##
@@ -447,21 +447,6 @@ class LogConfigTest {
LogConfig.validate(logProps)
}
- @ParameterizedTest
sebastienviale commented on code in PR #18233:
URL: https://github.com/apache/kafka/pull/18233#discussion_r1937350055
##
streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java:
##
@@ -384,7 +384,7 @@ public synchronized GlobalKTable
globalTable(final String topic,
mingyen066 opened a new pull request, #18767:
URL: https://github.com/apache/kafka/pull/18767
Based on the discussion
https://github.com/apache/kafka/pull/18741#issuecomment-2623740585
Add unit test to ensure user can provide space-separated broker list
This change need to be backp
sebastienviale commented on code in PR #18233:
URL: https://github.com/apache/kafka/pull/18233#discussion_r1937351094
##
streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java:
##
@@ -457,7 +457,7 @@ public synchronized GlobalKTable
globalTable(final String topic,
sebastienviale commented on code in PR #18233:
URL: https://github.com/apache/kafka/pull/18233#discussion_r1937350055
##
streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java:
##
@@ -384,7 +384,7 @@ public synchronized GlobalKTable
globalTable(final String topic,
ahuang98 commented on code in PR #16831:
URL: https://github.com/apache/kafka/pull/16831#discussion_r1937578663
##
raft/src/main/java/org/apache/kafka/raft/utils/DescribeQuorumRpc.java:
##
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
ahuang98 commented on code in PR #16831:
URL: https://github.com/apache/kafka/pull/16831#discussion_r1937578663
##
raft/src/main/java/org/apache/kafka/raft/utils/DescribeQuorumRpc.java:
##
@@ -0,0 +1,135 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mo
ahuang98 commented on PR #18600:
URL: https://github.com/apache/kafka/pull/18600#issuecomment-2627768820
@ijuma I believe @jsancio is okay with this change. I'll review first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chia7712 commented on code in PR #18165:
URL: https://github.com/apache/kafka/pull/18165#discussion_r1937733425
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4081,7 +4084,9 @@ void handleFailure(Throwable throwable) {
}
private
ijuma commented on code in PR #18727:
URL: https://github.com/apache/kafka/pull/18727#discussion_r1937734265
##
core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala:
##
@@ -283,6 +286,48 @@ class ProduceRequestTest extends BaseRequestTest {
assertEquals(-1, partit
chia7712 commented on code in PR #18727:
URL: https://github.com/apache/kafka/pull/18727#discussion_r1937752816
##
core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala:
##
@@ -283,6 +286,48 @@ class ProduceRequestTest extends BaseRequestTest {
assertEquals(-1, par
junrao commented on code in PR #18727:
URL: https://github.com/apache/kafka/pull/18727#discussion_r1937678804
##
core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala:
##
@@ -283,6 +286,48 @@ class ProduceRequestTest extends BaseRequestTest {
assertEquals(-1, parti
ahuang98 commented on code in PR #18680:
URL: https://github.com/apache/kafka/pull/18680#discussion_r1937681609
##
metadata/src/main/java/org/apache/kafka/image/writer/ImageWriterOptions.java:
##
@@ -30,6 +31,7 @@ public final class ImageWriterOptions {
public static class
chia7712 commented on code in PR #18727:
URL: https://github.com/apache/kafka/pull/18727#discussion_r1937725987
##
core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala:
##
@@ -283,6 +286,48 @@ class ProduceRequestTest extends BaseRequestTest {
assertEquals(-1, par
jolshan commented on PR #18165:
URL: https://github.com/apache/kafka/pull/18165#issuecomment-2628007305
Sorry, for some reason I only get tags when someone approves/merges the PR.
Thanks for taking a look @mimaison!
--
This is an automated message from the Apache Git Service.
To respond t
ijuma commented on code in PR #18727:
URL: https://github.com/apache/kafka/pull/18727#discussion_r1937803364
##
core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala:
##
@@ -283,6 +286,48 @@ class ProduceRequestTest extends BaseRequestTest {
assertEquals(-1, partit
stevenschlansker opened a new pull request, #18771:
URL: https://github.com/apache/kafka/pull/18771
I opened KAFKA-18689 because we see in our application:
```
java.util.NoSuchElementException: null
at
java.base/java.util.concurrent.ConcurrentSkipListMap.firstKey(Concurrent
stevenschlansker commented on PR #18771:
URL: https://github.com/apache/kafka/pull/18771#issuecomment-2628414500
If you do not like this improvement, it's totally OK by me to close the
issue and PR as duplicate.
--
This is an automated message from the Apache Git Service.
To respond to th
CalvinConfluent commented on code in PR #18277:
URL: https://github.com/apache/kafka/pull/18277#discussion_r1938125715
##
core/src/test/java/kafka/server/integration/EligibleLeaderReplicasIntegrationTest.java:
##
@@ -0,0 +1,450 @@
+/*
+ * Licensed to the Apache Software Foundati
mjsax commented on PR #18747:
URL: https://github.com/apache/kafka/pull/18747#issuecomment-2628633913
Looking into test failure history (especially for PRs),
`SmokeTestDriverIntegrationTest` has a high failure rate with
`processingThreadsEnabled=true` and 100% pass rate w/o processing threa
mjsax opened a new pull request, #18773:
URL: https://github.com/apache/kafka/pull/18773
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
ijuma commented on code in PR #18727:
URL: https://github.com/apache/kafka/pull/18727#discussion_r1938136154
##
clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java:
##
@@ -66,21 +67,10 @@ public Builder(short minVersion,
@Override
publi
ijuma commented on code in PR #18727:
URL: https://github.com/apache/kafka/pull/18727#discussion_r1938136022
##
clients/src/main/java/org/apache/kafka/common/protocol/ApiKeys.java:
##
@@ -264,8 +273,11 @@ public boolean hasValidVersion() {
return oldestVersion() <= late
ijuma commented on code in PR #18727:
URL: https://github.com/apache/kafka/pull/18727#discussion_r1938138397
##
core/src/test/scala/unit/kafka/server/ProduceRequestTest.scala:
##
@@ -283,6 +286,48 @@ class ProduceRequestTest extends BaseRequestTest {
assertEquals(-1, partit
ijuma commented on PR #18727:
URL: https://github.com/apache/kafka/pull/18727#issuecomment-2628657478
@junrao @chia7712 I realized that the test I wanted already existed in
`ProcessorTest` - I made a small adjustment so it tests V0-V2 (and not just
V0). I then went ahead and adjusted the pr
[
https://issues.apache.org/jira/browse/KAFKA-18320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17922891#comment-17922891
]
Ismael Juma edited comment on KAFKA-18320 at 2/1/25 2:35 AM:
-
1 - 100 of 178 matches
Mail list logo
