loicgreffier commented on code in PR #18739:
URL: https://github.com/apache/kafka/pull/18739#discussion_r1936995608
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StampedRecord.java:
##########
@@ -55,8 +69,26 @@ public Headers headers() {
return value.headers();
}
+ public byte[] rawKey() {
+ return rawKey;
+ }
+
+ public byte[] rawValue() {
+ return rawValue;
+ }
+
@Override
public String toString() {
return value.toString() + ", timestamp = " + timestamp;
}
+
+ @Override
+ public boolean equals(final Object other) {
+ return super.equals(other);
+ }
+
+ @Override
+ public int hashCode() {
+ return super.hashCode();
+ }
Review Comment:
Since we added new `rawKey` and `rawValue` attributes, SpotBugs requires to
define the `equals` function
(https://spotbugs.readthedocs.io/en/stable/bugDescriptions.html#eq-class-doesn-t-override-equals-in-superclass-eq-doesnt-override-equals)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
