dajac commented on code in PR #18768:
URL: https://github.com/apache/kafka/pull/18768#discussion_r1937598836
##########
tests/kafkatest/sanity_checks/test_verifiable_producer.py:
##########
@@ -32,25 +31,21 @@ def __init__(self, test_context):
super(TestVerifiableProducer, self).__init__(test_context)
self.topic = "topic"
- self.zk = ZookeeperService(test_context, num_nodes=1) if
quorum.for_test(test_context) == quorum.zk else None
- self.kafka = KafkaService(test_context, num_nodes=1, zk=self.zk,
+ self.kafka = KafkaService(test_context, num_nodes=1, zk=None,
topics={self.topic: {"partitions": 1,
"replication-factor": 1}})
self.num_messages = 1000
# This will produce to source kafka cluster
self.producer = VerifiableProducer(test_context, num_nodes=1,
kafka=self.kafka, topic=self.topic,
max_messages=self.num_messages,
throughput=self.num_messages // 10)
- def setUp(self):
- if self.zk:
- self.zk.start()
@cluster(num_nodes=3)
- @matrix(producer_version=[str(DEV_BRANCH)], acks=["0", "1", "-1"],
enable_idempotence=[False])
- @matrix(producer_version=[str(DEV_BRANCH)], acks=["-1"],
enable_idempotence=[True])
- @matrix(producer_version=[str(DEV_BRANCH)],
security_protocol=['PLAINTEXT', 'SSL'], metadata_quorum=quorum.all)
+ @matrix(producer_version=[str(DEV_BRANCH)], acks=["0", "1", "-1"],
enable_idempotence=[False], metadata_quorum=quorum.all_kraft)
+ @matrix(producer_version=[str(DEV_BRANCH)], acks=["-1"],
enable_idempotence=[True], metadata_quorum=quorum.all_kraft)
+ @matrix(producer_version=[str(DEV_BRANCH)],
security_protocol=['PLAINTEXT', 'SSL'], metadata_quorum=quorum.all_kraft)
@cluster(num_nodes=4)
Review Comment:
I wonder whether we could have 3 or 4 nodes for all tests. I am not sure why
there is a difference for the last one. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
