ahuang98 commented on code in PR #16831: URL: https://github.com/apache/kafka/pull/16831#discussion_r1937578663
########## raft/src/main/java/org/apache/kafka/raft/utils/DescribeQuorumRpc.java: ########## @@ -0,0 +1,135 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.raft.utils; + +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.common.message.DescribeQuorumRequestData; +import org.apache.kafka.common.message.DescribeQuorumResponseData; +import org.apache.kafka.common.protocol.Errors; +import org.apache.kafka.raft.LeaderState; +import org.apache.kafka.raft.LogOffsetMetadata; +import org.apache.kafka.raft.ReplicaKey; + +import java.util.Collection; +import java.util.Collections; +import java.util.List; +import java.util.stream.Collectors; + +public class DescribeQuorumRpc { + public static DescribeQuorumRequestData singletonDescribeQuorumRequest( + TopicPartition topicPartition + ) { + return new DescribeQuorumRequestData() + .setTopics( + Collections.singletonList( + new DescribeQuorumRequestData.TopicData() + .setTopicName(topicPartition.topic()) + .setPartitions( + Collections.singletonList( + new DescribeQuorumRequestData.PartitionData() + .setPartitionIndex(topicPartition.partition()) + ) + ) + ) + ); + } + + public static DescribeQuorumResponseData singletonDescribeQuorumResponse( + short apiVersion, + TopicPartition topicPartition, + int leaderId, + int leaderEpoch, + long highWatermark, + Collection<LeaderState.ReplicaState> voters, + Collection<LeaderState.ReplicaState> observers, + long currentTimeMs + ) { + DescribeQuorumResponseData response = new DescribeQuorumResponseData() + .setTopics( + Collections.singletonList( + new DescribeQuorumResponseData.TopicData() + .setTopicName(topicPartition.topic()) + .setPartitions( + Collections.singletonList( + new DescribeQuorumResponseData.PartitionData() + .setPartitionIndex(topicPartition.partition()) + .setErrorCode(Errors.NONE.code()) + .setLeaderId(leaderId) + .setLeaderEpoch(leaderEpoch) + .setHighWatermark(highWatermark) + .setCurrentVoters(toReplicaStates(apiVersion, leaderId, voters, currentTimeMs)) + .setObservers(toReplicaStates(apiVersion, leaderId, observers, currentTimeMs)))))); Review Comment: style nit: I know this was carried over from the old code, but maybe better to have each closing parenthesis on its own new line (there are a few other spots in the PR which could use this too) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
