ableegoldman merged PR #16331:
URL: https://github.com/apache/kafka/pull/16331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.ap
jlprat commented on PR #16310:
URL: https://github.com/apache/kafka/pull/16310#issuecomment-2167378623
Hi @kirktrue. Let's check again when the PR is approved :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
chia7712 commented on code in PR #16022:
URL: https://github.com/apache/kafka/pull/16022#discussion_r1639374094
##
clients/src/main/java/org/apache/kafka/common/requests/ShareFetchResponse.java:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Luke Chen created KAFKA-16956:
-
Summary: Broker-side ability to subscribe to record delete events
Key: KAFKA-16956
URL: https://issues.apache.org/jira/browse/KAFKA-16956
Project: Kafka
Issue Type
[
https://issues.apache.org/jira/browse/KAFKA-16956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16956:
--
Labels: need-kip (was: )
> Broker-side ability to subscribe to record delete events
> ---
mfvitale commented on PR #15756:
URL: https://github.com/apache/kafka/pull/15756#issuecomment-2167438478
> @mfvitale Merge-able, I don't know yet, but we can start reviewing it :)
;-)
> This is not a candidate for 3.8 as we're now past code freeze. Also the
KIP only got 3 bindi
FrankYang0529 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1639415070
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,834 +16,986 @@
*/
package org.apache.kafka.tools.consume
FrankYang0529 commented on code in PR #15908:
URL: https://github.com/apache/kafka/pull/15908#discussion_r1639418996
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -16,834 +16,986 @@
*/
package org.apache.kafka.tools.consume
ableegoldman commented on PR #16331:
URL: https://github.com/apache/kafka/pull/16331#issuecomment-2167453864
Test failures are unrelated
Merged to trunk and cherrypicked to 3.8 cc @jlprat
--
This is an automated message from the Apache Git Service.
To respond to the message, please
edoardocomar commented on PR #16326:
URL: https://github.com/apache/kafka/pull/16326#issuecomment-2167486809
@C0urante it was only not to make noise on the release(s). Quite happy to
cherry-pick
--
This is an automated message from the Apache Git Service.
To respond to the message,
edoardocomar commented on PR #16326:
URL: https://github.com/apache/kafka/pull/16326#issuecomment-2167489841
I just thought we're past the deadline and making noise for such a small
change was not worth it. Of course I'd prefer to have consistent code for this
test class
--
This is an au
chia7712 commented on code in PR #16280:
URL: https://github.com/apache/kafka/pull/16280#discussion_r1639460364
##
core/src/main/scala/kafka/server/ConfigHandler.scala:
##
@@ -239,19 +239,24 @@ class BrokerConfigHandler(private val brokerConfig:
KafkaConfig,
def processCon
chia7712 commented on PR #16305:
URL: https://github.com/apache/kafka/pull/16305#issuecomment-2167528614
> Test with writePercentage 0.01 (100 times of computeIfAbsent) and 0.0001
(10 times of computeIfAbsent), though there is not much difference under
0.0001, ConcurrentHashMap still perfor
brandboat closed pull request #16305: KAFKA-16942 Use ConcurrentHashMap in
RecordAccumulator#nodeStats
URL: https://github.com/apache/kafka/pull/16305
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
brandboat commented on PR #16305:
URL: https://github.com/apache/kafka/pull/16305#issuecomment-2167536819
> If there is no much benefit to use ConcurrentHashMap, maybe we should keep
using CopyOnWriteMap for consistency
I'm fine with this one, indeed it is a bit weird to keep both Cop
[
https://issues.apache.org/jira/browse/KAFKA-16942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kuan Po Tseng resolved KAFKA-16942.
---
Resolution: Won't Do
The performance in get method is not obvious between ConcurrentHashMap
chia7712 merged PR #16231:
URL: https://github.com/apache/kafka/pull/16231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-12708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-12708.
Fix Version/s: 3.9.0
Resolution: Fixed
> Rewrite org.apache.kafka.test.Microbenchma
dajac commented on code in PR #16309:
URL: https://github.com/apache/kafka/pull/16309#discussion_r1639492866
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1648,9 +1650,11 @@ private CoordinatorResult
classicGroupJoinToCo
[
https://issues.apache.org/jira/browse/KAFKA-16673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-16673.
-
Fix Version/s: 3.8.0
Resolution: Duplicate
This was done as part of https://github.com/ap
[
https://issues.apache.org/jira/browse/KAFKA-16673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reopened KAFKA-16673:
-
> Optimize toTopicPartitions with ConsumerProtocolSubscription
> ---
[
https://issues.apache.org/jira/browse/KAFKA-16673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot updated KAFKA-16673:
Fix Version/s: (was: 3.8.0)
> Optimize toTopicPartitions with ConsumerProtocolSubscription
> -
[ https://issues.apache.org/jira/browse/KAFKA-16673 ]
David Jacot deleted comment on KAFKA-16673:
-
was (Author: dajac):
This was done as part of https://github.com/apache/kafka/pull/15785.
> Optimize toTopicPartitions with ConsumerProtocolSubsc
[
https://issues.apache.org/jira/browse/KAFKA-16674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-16674.
-
Resolution: Fixed
This was done in https://github.com/apache/kafka/pull/15785.
> Adjust classic
[
https://issues.apache.org/jira/browse/KAFKA-16317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-16317.
-
Resolution: Won't Do
> Add event rate in GroupCoordinatorRuntimeMetrics
> --
chia7712 commented on PR #16309:
URL: https://github.com/apache/kafka/pull/16309#issuecomment-2167576802
It seems we can apply this simplification to following code, since the
protocol data can offer all required info
https://github.com/apache/kafka/blob/888a17760347223614da9243dc375
showuon commented on code in PR #16284:
URL: https://github.com/apache/kafka/pull/16284#discussion_r1636434931
##
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##
@@ -495,8 +496,19 @@ void deleteTopicConfigs(String name) {
configDa
showuon commented on code in PR #16284:
URL: https://github.com/apache/kafka/pull/16284#discussion_r1636432727
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -2093,6 +2116,50 @@ Optional
changePartitionReassignment(TopicIdPartition t
dajac commented on code in PR #16183:
URL: https://github.com/apache/kafka/pull/16183#discussion_r1639511150
##
core/src/main/scala/kafka/coordinator/transaction/TransactionStateManager.scala:
##
@@ -618,7 +624,7 @@ class TransactionStateManager(brokerId: Int,
// generate
showuon commented on PR #16229:
URL: https://github.com/apache/kafka/pull/16229#issuecomment-2167585352
@edoardocomar , this PR causes compilation error in 3.7 CI. Could you help
take a look?
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka/detail/3.7/177/pipeline
dajac commented on PR #16309:
URL: https://github.com/apache/kafka/pull/16309#issuecomment-2167587707
> It seems we can apply this simplification to following code, since the
protocol data can offer all required info
>
>
https://github.com/apache/kafka/blob/888a17760347223614da9243dc
Chia-Ping Tsai created KAFKA-16957:
--
Summary: Enable
KafkaConsumerTest#configurableObjectsShouldSeeGeneratedClientId to work with
CLASSIC and CONSUMER
Key: KAFKA-16957
URL: https://issues.apache.org/jira/browse
[
https://issues.apache.org/jira/browse/KAFKA-16957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855001#comment-17855001
]
Chia Chuan Yu commented on KAFKA-16957:
---
Hi, [~chia7712]
Can I have this? thanks
[
https://issues.apache.org/jira/browse/KAFKA-16957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16957:
--
Assignee: Chia Chuan Yu (was: Chia-Ping Tsai)
> Enable KafkaConsumerTest#configurabl
cadonna commented on code in PR #16310:
URL: https://github.com/apache/kafka/pull/16310#discussion_r1639493007
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1666,23 +1668,68 @@ private boolean initWithCommittedOffsetsIfNeede
philipnee commented on code in PR #16272:
URL: https://github.com/apache/kafka/pull/16272#discussion_r1639205859
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1512,7 +1513,9 @@ public void unsubscribe() {
}
chia7712 commented on PR #15924:
URL: https://github.com/apache/kafka/pull/15924#issuecomment-2167621969
@chiacyu any update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
muralibasani commented on code in PR #16324:
URL: https://github.com/apache/kafka/pull/16324#discussion_r1639541717
##
gradle/dependencies.gradle:
##
@@ -237,14 +237,14 @@ libs += [
pcollections: "org.pcollections:pcollections:$versions.pcollections",
opentelemetryProto:
[
https://issues.apache.org/jira/browse/KAFKA-16550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855004#comment-17855004
]
PoAn Yang commented on KAFKA-16550:
---
Hi [~targetoee], are you working on this? If not,
muralibasani commented on code in PR #16324:
URL: https://github.com/apache/kafka/pull/16324#discussion_r1639543009
##
bin/kafka-run-class.sh:
##
@@ -243,6 +243,14 @@ fi
(( WINDOWS_OS_FORMAT )) && LOG_DIR=$(cygpath --path --mixed "${LOG_DIR}")
KAFKA_LOG4J_CMD_OPTS="-Dkafka.log
[
https://issues.apache.org/jira/browse/KAFKA-16550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16550:
--
Assignee: PoAn Yang (was: JiaChi Wang)
> add integration test for LogDirsCommand
> -
chia7712 commented on PR #16289:
URL: https://github.com/apache/kafka/pull/16289#issuecomment-2167630992
@EricLuGHub could you please fix the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Chia-Ping Tsai created KAFKA-16958:
--
Summary: add `STRICT_STUBS` to `EndToEndLatencyTest`,
`OffsetCommitCallbackInvokerTest`, `ProducerPerformanceTest`, and `TopologyTest`
Key: KAFKA-16958
URL: https://issues.apa
[
https://issues.apache.org/jira/browse/KAFKA-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16958:
---
Description: They all need `@MockitoSettings(strictness =
Strictness.STRICT_STUBS)` (was: a
[
https://issues.apache.org/jira/browse/KAFKA-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855012#comment-17855012
]
dujian0068 commented on KAFKA-16958:
Hello:
Can you assign this task to me?
> add
OmniaGM commented on code in PR #16116:
URL: https://github.com/apache/kafka/pull/16116#discussion_r1639569549
##
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfigs.java:
##
@@ -51,4 +60,16 @@ public final class TransactionLogCon
OmniaGM commented on code in PR #16116:
URL: https://github.com/apache/kafka/pull/16116#discussion_r1639570221
##
transaction-coordinator/src/main/java/org/apache/kafka/coordinator/transaction/TransactionLogConfigs.java:
##
@@ -51,4 +60,16 @@ public final class TransactionLogCon
aliehsaeedii commented on code in PR #16332:
URL: https://github.com/apache/kafka/pull/16332#discussion_r1639578562
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1220,6 +1223,7 @@ private void ensureValidRecordSize(int size) {
* of f
aliehsaeedii commented on PR #16332:
URL: https://github.com/apache/kafka/pull/16332#issuecomment-2167688944
@C0urante It would be nice if you took a look.
Instead of implementing a custom handler for Producer (as suggested in
KIP-1038), we came up with the idea of allowing the user to st
aliehsaeedii commented on code in PR #16332:
URL: https://github.com/apache/kafka/pull/16332#discussion_r1639578562
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1220,6 +1223,7 @@ private void ensureValidRecordSize(int size) {
* of f
[
https://issues.apache.org/jira/browse/KAFKA-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16958:
--
Assignee: dujian0068 (was: Chia-Ping Tsai)
> add `STRICT_STUBS` to `EndToEndLatencyT
[
https://issues.apache.org/jira/browse/KAFKA-16958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855017#comment-17855017
]
Chia-Ping Tsai commented on KAFKA-16958:
sure
> add `STRICT_STUBS` to `EndToEn
C0urante commented on PR #16326:
URL: https://github.com/apache/kafka/pull/16326#issuecomment-2167702484
👍 I think it makes sense to cherry-pick
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
jlprat commented on PR #16326:
URL: https://github.com/apache/kafka/pull/16326#issuecomment-2167708048
It makes sense to cherry pick this one to 3.8 for sure.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
jlprat commented on PR #16321:
URL: https://github.com/apache/kafka/pull/16321#issuecomment-2167758040
Yes it is fine to add to the 3.8 branch. Can you cherry pick this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chia7712 commented on PR #16259:
URL: https://github.com/apache/kafka/pull/16259#issuecomment-2167760107
@ardada2468 As you have filed a jira, please add jira number to the title.
for example: `KAFKA-16923 New Unit Test for stripDotPathComponents method`
--
This is an automated message fr
FrankYang0529 commented on PR #15908:
URL: https://github.com/apache/kafka/pull/15908#issuecomment-2167763518
Hi @chia7712 and @TaiJuWu, I addressed all comments. May you take a look
again? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
[
https://issues.apache.org/jira/browse/KAFKA-16900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855032#comment-17855032
]
Chia-Ping Tsai commented on KAFKA-16900:
Maybe we should enable transaction if e
satishd commented on PR #16321:
URL: https://github.com/apache/kafka/pull/16321#issuecomment-2167776223
Merged to 3.8 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
FrankYang0529 commented on PR #16328:
URL: https://github.com/apache/kafka/pull/16328#issuecomment-216113
Hi @chia7712, thanks for your review. I addressed all comments. May you take
a look? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the mess
apoorvmittal10 commented on code in PR #16022:
URL: https://github.com/apache/kafka/pull/16022#discussion_r1639658963
##
clients/src/main/java/org/apache/kafka/common/requests/ShareFetchResponse.java:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
lucasbru merged PR #16272:
URL: https://github.com/apache/kafka/pull/16272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
AndrewJSchofield commented on code in PR #16022:
URL: https://github.com/apache/kafka/pull/16022#discussion_r1639666418
##
clients/src/main/java/org/apache/kafka/common/requests/ShareFetchResponse.java:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
lucasbru commented on PR #16272:
URL: https://github.com/apache/kafka/pull/16272#issuecomment-2167800843
Test failures are unrelated
Merged to trunk and cherrypicked to 3.8 cc @jlprat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
harryfallows commented on code in PR #16280:
URL: https://github.com/apache/kafka/pull/16280#discussion_r1639672823
##
core/src/main/scala/kafka/server/ConfigHandler.scala:
##
@@ -239,19 +239,24 @@ class BrokerConfigHandler(private val brokerConfig:
KafkaConfig,
def proces
harryfallows commented on code in PR #16280:
URL: https://github.com/apache/kafka/pull/16280#discussion_r1639672823
##
core/src/main/scala/kafka/server/ConfigHandler.scala:
##
@@ -239,19 +239,24 @@ class BrokerConfigHandler(private val brokerConfig:
KafkaConfig,
def proces
harryfallows commented on code in PR #16280:
URL: https://github.com/apache/kafka/pull/16280#discussion_r1639672823
##
core/src/main/scala/kafka/server/ConfigHandler.scala:
##
@@ -239,19 +239,24 @@ class BrokerConfigHandler(private val brokerConfig:
KafkaConfig,
def proces
harryfallows commented on code in PR #16280:
URL: https://github.com/apache/kafka/pull/16280#discussion_r1639672823
##
core/src/main/scala/kafka/server/ConfigHandler.scala:
##
@@ -239,19 +239,24 @@ class BrokerConfigHandler(private val brokerConfig:
KafkaConfig,
def proces
lucasbru commented on code in PR #16265:
URL: https://github.com/apache/kafka/pull/16265#discussion_r1639679771
##
docs/streams/upgrade-guide.html:
##
@@ -134,11 +134,38 @@ <
Streams API changes in 3.8.0
+
+
+Kafka Streams now supports customizable task
omkreddy merged PR #16263:
URL: https://github.com/apache/kafka/pull/16263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
Chia-Ping Tsai created KAFKA-16959:
--
Summary: ConfigCommand should not allow to define both
`entity-default` and `entity-name`
Key: KAFKA-16959
URL: https://issues.apache.org/jira/browse/KAFKA-16959
[
https://issues.apache.org/jira/browse/KAFKA-16747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Abhinav Dixit resolved KAFKA-16747.
---
Resolution: Fixed
> Implement share sessions and context
> -
[
https://issues.apache.org/jira/browse/KAFKA-16954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans reassigned KAFKA-16954:
--
Assignee: Lianet Magrans
> Move consumer leave operations on close to background thre
[
https://issues.apache.org/jira/browse/KAFKA-16954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-16954:
---
Priority: Blocker (was: Major)
> Move consumer leave operations on close to background thre
[
https://issues.apache.org/jira/browse/KAFKA-16954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-16954:
---
Fix Version/s: 3.8.0
> Move consumer leave operations on close to background thread
> --
lianetm commented on PR #16272:
URL: https://github.com/apache/kafka/pull/16272#issuecomment-2167847254
Hey @philipnee, agreed there is still an issue with the Interrupt discovered
with the stress tests, it's just that as discussed offline that will come in a
separate PR (just to not keep s
apoorvmittal10 opened a new pull request, #16339:
URL: https://github.com/apache/kafka/pull/16339
The share-partition leader keeps track of the state and delivery attempts
for in-flight records. However, delivery attempts tracking follows atleast-once
semantics.
The consumer process
apoorvmittal10 commented on PR #16339:
URL: https://github.com/apache/kafka/pull/16339#issuecomment-2167881836
@AndrewJSchofield The PR build will fail untill we have APIs defined for
Persister interface, I ll update the code once dependent PR is merged.
--
This is an automated messag
[
https://issues.apache.org/jira/browse/KAFKA-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17855040#comment-17855040
]
黃竣陽 commented on KAFKA-16959:
-
Im interesting in this issue, I want handle it.
> ConfigComm
[
https://issues.apache.org/jira/browse/KAFKA-16959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16959:
--
Assignee: 黃竣陽 (was: Chia-Ping Tsai)
> ConfigCommand should not allow to define both
chia7712 commented on code in PR #16022:
URL: https://github.com/apache/kafka/pull/16022#discussion_r1639747343
##
clients/src/main/java/org/apache/kafka/common/requests/ShareFetchResponse.java:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
chia7712 commented on code in PR #16280:
URL: https://github.com/apache/kafka/pull/16280#discussion_r1639750736
##
core/src/main/scala/kafka/server/ConfigHandler.scala:
##
@@ -239,19 +239,24 @@ class BrokerConfigHandler(private val brokerConfig:
KafkaConfig,
def processCon
chia7712 commented on PR #16330:
URL: https://github.com/apache/kafka/pull/16330#issuecomment-2167934579
@m1a2st could you please take a look at failed tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
apoorvmittal10 commented on code in PR #16335:
URL: https://github.com/apache/kafka/pull/16335#discussion_r1639739009
##
server-common/src/main/java/org/apache/kafka/server/group/share/GroupTopicPartitionData.java:
##
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foun
[
https://issues.apache.org/jira/browse/KAFKA-16752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apoorv Mittal resolved KAFKA-16752.
---
Resolution: Done
> Implement acquire functionality in SharePartition
> -
Luke Chen created KAFKA-16960:
-
Summary: StreamsUpgradeTest system tests fail in v3.7.1 RC1
Key: KAFKA-16960
URL: https://issues.apache.org/jira/browse/KAFKA-16960
Project: Kafka
Issue Type: Impr
Luke Chen created KAFKA-16961:
-
Summary: TestKRaftUpgrade system tests fail in v3.7.1 RC1
Key: KAFKA-16961
URL: https://issues.apache.org/jira/browse/KAFKA-16961
Project: Kafka
Issue Type: Test
Luke Chen created KAFKA-16962:
-
Summary: kafkatest.tests.core.upgrade_test system tests failed in
v3.7.1 RC1
Key: KAFKA-16962
URL: https://issues.apache.org/jira/browse/KAFKA-16962
Project: Kafka
AndrewJSchofield commented on code in PR #16335:
URL: https://github.com/apache/kafka/pull/16335#discussion_r1639795031
##
server-common/src/main/java/org/apache/kafka/server/group/share/PartitionAllData.java:
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundatio
AndrewJSchofield commented on code in PR #16335:
URL: https://github.com/apache/kafka/pull/16335#discussion_r1639797544
##
server-common/src/main/java/org/apache/kafka/server/group/share/ReadShareGroupStateParameters.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Softw
AndrewJSchofield commented on code in PR #16335:
URL: https://github.com/apache/kafka/pull/16335#discussion_r1639801028
##
server-common/src/main/java/org/apache/kafka/server/group/share/Persister.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
showuon commented on code in PR #16284:
URL: https://github.com/apache/kafka/pull/16284#discussion_r1636432727
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -2093,6 +2116,50 @@ Optional
changePartitionReassignment(TopicIdPartition t
AndrewJSchofield commented on PR #16335:
URL: https://github.com/apache/kafka/pull/16335#issuecomment-2168022748
@apoorvmittal10 Thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
showuon commented on code in PR #16284:
URL: https://github.com/apache/kafka/pull/16284#discussion_r1636434931
##
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##
@@ -495,8 +496,19 @@ void deleteTopicConfigs(String name) {
configDa
AyoubOm commented on code in PR #16218:
URL: https://github.com/apache/kafka/pull/16218#discussion_r1639815011
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/foreignkeyjoin/CombinedKeySchema.java:
##
@@ -94,7 +94,7 @@ public CombinedKey fromBytes(final Bytes
harryfallows commented on code in PR #16280:
URL: https://github.com/apache/kafka/pull/16280#discussion_r1639845590
##
core/src/main/scala/kafka/server/ConfigHandler.scala:
##
@@ -239,19 +239,24 @@ class BrokerConfigHandler(private val brokerConfig:
KafkaConfig,
def proces
chickenchickenlove commented on PR #15926:
URL: https://github.com/apache/kafka/pull/15926#issuecomment-2168090694
> I started a new build here
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15926/6/
Thanks for your comments.
If there is something to be fixed, please le
apoorvmittal10 opened a new pull request, #16340:
URL: https://github.com/apache/kafka/pull/16340
Added additional APIs for SharePartition which shall be used by
SharePartitionManager.
The lock API on SharePartition helps not issuing concurrent fetch request on
replica manager for sa
mimaison commented on code in PR #15999:
URL: https://github.com/apache/kafka/pull/15999#discussion_r1639833636
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConfig.java:
##
@@ -166,6 +169,34 @@ Duration consumerPollTimeout() {
return D
FrankYang0529 opened a new pull request, #16341:
URL: https://github.com/apache/kafka/pull/16341
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
1 - 100 of 234 matches
Mail list logo
